- 14 Aug, 2018 8 commits
-
-
Benedikt Meurer authored
This reverts commit 6c7c81e0. Reason for revert: Dependent CL was reverted. Original change's description: > [turbofan] Properly zero-extend indices on 64-bit architectures. > > This was an oversight from the previous CL. It doesn't really matter > with the current code generation pattern, since the upper bits of the > index will always be zero, but that might change in the future. > > Bug: chromium:225811 > Change-Id: I568a0824cad9ce9b73a56decc15d146c7dc675a1 > Reviewed-on: https://chromium-review.googlesource.com/1174111 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55104} TBR=jarin@chromium.org,bmeurer@chromium.org Change-Id: Ib344609b0c4734c6512e6be287a5b7f80bc3f603 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811 Reviewed-on: https://chromium-review.googlesource.com/1174232Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55109}
-
jgruber authored
Follow-up to 17ad3ae4. Another try at exposing embedded builtin symbols on chromecrash. Bug: v8:6666, v8:7722 Change-Id: Ie715251797134be0618c0bc496ec10958f7545c3 Reviewed-on: https://chromium-review.googlesource.com/1174112Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55108}
-
Leszek Swirski authored
This reverts commit c46915b9. Reason for revert: Disasm failures https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/21727 Original change's description: > [turbofan] Further optimize DataView accesses. > > This adds support for unaligned load/store access to the DataView > backing store and uses byteswap operations to fix up the endianess > when necessary. This changes the Word32ReverseBytes operator to be > a required operator and adds the missing support on the Intel and > ARM platforms (on 64-bit platforms the Word64ReverseBytes operator > is also mandatory now). > > This further improves the performance on the dataviewperf.js test > mentioned in the tracking bug by up to 40%, and at the same time > reduces the code complexity in the EffectControlLinearizer. > > Bug: chromium:225811 > Change-Id: I296170b828c2ccc1c317ed37840b564aa14cdec2 > Reviewed-on: https://chromium-review.googlesource.com/1172777 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55099} TBR=sigurds@chromium.org,bmeurer@chromium.org Change-Id: If7a62e3a1a4ad26823fcbd2ab6eb4c053ad11c49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811 Reviewed-on: https://chromium-review.googlesource.com/1174171Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#55107}
-
Andreas Haas authored
The problem was that in AsyncCompileJob::FinishModule we allocate a handle, but when this function is called from streaming compilation, then there was no HandleScope around AsyncCompileJob::FinishModule. This issue was fixed in another CL, https://crrev.com/c/1172357. This CL is just a rebase of the original CL. Original change's description: > [wasm] Implement the new API for WebAssembly.instantiateStreaming > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to > make it spec compliant again. The design doc where the whole change is > discussed is available in the tracking bug. The tracking bug also > references prototype implementations of the whole change, which includes > the changes in this CL. R=starzinger@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib0cb25488654d2b325b4f529d33b76b846c64436 Reviewed-on: https://chromium-review.googlesource.com/1172429Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55106}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I310d9453be8b90a82856c0d394442aad5527a3ae Reviewed-on: https://chromium-review.googlesource.com/1169167 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55105}
-
Benedikt Meurer authored
This was an oversight from the previous CL. It doesn't really matter with the current code generation pattern, since the upper bits of the index will always be zero, but that might change in the future. Bug: chromium:225811 Change-Id: I568a0824cad9ce9b73a56decc15d146c7dc675a1 Reviewed-on: https://chromium-review.googlesource.com/1174111 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55104}
-
Hai Dang authored
This affects map, filter, every, some, indexOf and includes. Tests for those cases and more are also added. Bug: v8:8049 Change-Id: I196abd8e7e2419a2bb465f44caf4de52990ffced Reviewed-on: https://chromium-review.googlesource.com/1172346Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Hai Dang <dhai@google.com> Cr-Commit-Position: refs/heads/master@{#55103}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6705895..016397a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/21cd5a3..501bed8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6fa51528cc992f2656812baec91089543cb62e50 Reviewed-on: https://chromium-review.googlesource.com/1173758Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55102}
-
- 13 Aug, 2018 29 commits
-
-
Camillo Bruni authored
Drive-by-fix: - Remove obsolete mark_shared_functions_for_tier_up flag Bug: chromium:873728 Change-Id: I6c18b2e55068be913a3fc16932a9be0f9f02b635 Reviewed-on: https://chromium-review.googlesource.com/1173232 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55101}
-
Creddy authored
Word32Not was used instead of Word32BinaryNot which caused unecssary runtime lookup. This CL fixed the performance regression https://crrev.com/c/1145438. Bug: chromium:868799 Change-Id: I9e070de6155797e52dd9b461a9660cb003509a57 Reviewed-on: https://chromium-review.googlesource.com/1169808 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55100}
-
Benedikt Meurer authored
This adds support for unaligned load/store access to the DataView backing store and uses byteswap operations to fix up the endianess when necessary. This changes the Word32ReverseBytes operator to be a required operator and adds the missing support on the Intel and ARM platforms (on 64-bit platforms the Word64ReverseBytes operator is also mandatory now). This further improves the performance on the dataviewperf.js test mentioned in the tracking bug by up to 40%, and at the same time reduces the code complexity in the EffectControlLinearizer. Bug: chromium:225811 Change-Id: I296170b828c2ccc1c317ed37840b564aa14cdec2 Reviewed-on: https://chromium-review.googlesource.com/1172777 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:6922 Change-Id: I641f654f0548c2da24cdea3ffd275461ae8ce9b0 Reviewed-on: https://chromium-review.googlesource.com/1172776Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55098}
-
Benedikt Meurer authored
The DataView access methods can use the neutering protector to avoid introducing an explicit check into the optimized code to see if the backing store was neutered. Instead the optimized code has an implicit dependency on the global neutering protector which gets invalidated when the first array buffer is neutered (globally). We use the same trick for typed arrays already. Bug: chromium:225811 Change-Id: I9b3c95b3113b8fa00dcbba216ef29c84c0056951 Reviewed-on: https://chromium-review.googlesource.com/1172779 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
[scanner] Explicitly add one-byte characters to a one-byte literal buffer when scanning ascii identifiers Change-Id: Ia8337506d9f442d6887b6fa3c2ed17210ffd3c28 Reviewed-on: https://chromium-review.googlesource.com/1172789Reviewed-by:
-
Toon Verwaest authored
Change-Id: I0d23484d9a48a73575ca158b07b7ed1b83d4029e Reviewed-on: https://chromium-review.googlesource.com/1172774Reviewed-by:
-
Bogdan Lazarescu authored
Change-Id: I4a6d57903016323eba439cd7f959f263d6605c84 Reviewed-on: https://chromium-review.googlesource.com/1169165Reviewed-by:
-
Tobias Tebbi authored
drive-by change: fix wrong typing in CSA. Change-Id: I9234306e8568a64157b44a86a58f09e65116b298 Reviewed-on: https://chromium-review.googlesource.com/1172583 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55093}
-
Clemens Hammacher authored
After https://crrev.com/c/1172285, abortion and deletion of an {AsyncCompileJob} is the same. Hence, remove the {AbortCompileJobsOnIsolate} method and replace all uses by {DeleteCompileJobsOnIsolate}. R=ahaas@chromium.org CC=mstarzinger@chromium.org Bug: chromium:869420 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I053dc47395a257066bbca55069d53445dc28eeb9 Reviewed-on: https://chromium-review.googlesource.com/1172288Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55092}
-
Camillo Bruni authored
This should make the uses of binary vs. bitwise not very clear: - Word32BinaryNot for logical negation - Word32BitwiseNot for bitwise negation Change-Id: I3345913111da0dbdae6fdf285f090b67eb3f3afc Reviewed-on: https://chromium-review.googlesource.com/1169205 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: If008d618d3cb27c38cf814b1858244578d0c4e84 Reviewed-on: https://chromium-review.googlesource.com/1169213Reviewed-by:
-
Bret Sepulveda authored
This patch also includes some CSS tweaks and other minor cleanup. Bug: v8:6240 Change-Id: I86e26fe53465dff6f9a706f58e565b1f1ee559da Reviewed-on: https://chromium-review.googlesource.com/1172360 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:840785 Change-Id: I043df7aa5203dec27b84636c64286d68a56fba31 Reviewed-on: https://chromium-review.googlesource.com/1172428Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55088}
-
jgruber authored
Bug: v8:8015 Change-Id: Ie8265458ace8c0d12ca9d3f58afd981f1f30cd1e Reviewed-on: https://chromium-review.googlesource.com/1170826 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andreas Haas authored
{AsyncCompileJob::FinishCompile} assumes that it is called within a {HandleScope}. This was not the case when it was called at the end of streaming compilation. R=clemensh@chromium.org Bug: chromium:860637 Change-Id: I74508e6cdfc145efb9adc76176abce1ca5713515 Reviewed-on: https://chromium-review.googlesource.com/1172357Reviewed-by: -
Predrag Rudic authored
By using NAL for reading PC instead of BAL, we are acctualy not taking branch. Thus optimizing code for instruction pipeline and address predictor. Change-Id: I574dc98390dc850443de06c928022292e2b50747 Reviewed-on: https://chromium-review.googlesource.com/1170777Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55085}
-
Yang Guo authored
This simplifies a bit. R=jgruber@chromium.org Change-Id: If7a433c9d2b13edf4fe4485816ac5ab06435773e Reviewed-on: https://chromium-review.googlesource.com/1172299Reviewed-by:
-
Clemens Hammacher authored
In {WasmEngine::DeleteCompileJobsOnIsolate} (triggered on isolate teardown), we are deleting the {AsyncCompileJob} with the expectation that this cancels all background compilation. Since the introduction of the CompilationState, this is not true any more. The call to {CompilationState::Abort} is missing. This CL fixes this by moving the logic from {AsyncCompileJob::Abort} to {~AsyncCompileJob}, since the former calls the latter anyway. R=ahaas@chromium.org Bug: chromium:869420 Change-Id: I4644d161270def0fe3a94d09cde0135ee420a383 Reviewed-on: https://chromium-review.googlesource.com/1172285Reviewed-by: -
Camillo Bruni authored
Bug: chromium:840785 Change-Id: I93f417084cc3ad3d1b906bdbef5dda14ead208c6 Reviewed-on: https://chromium-review.googlesource.com/1169044Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I7c55b81a21ef4bafd9ed9b1e6c68bd9110850b11 Reviewed-on: https://chromium-review.googlesource.com/1172135Reviewed-by:
-
Ross McIlroy authored
Decodes SFI::Flags on construction and sets properties in ParseInfo::flags_ directly, as well as adding a FunctionKind field, instead of keeping the encoded SFI flags in the ParseInfo. BUG=v8:8041 Change-Id: I9bd9345b29a8b0e9ffb3e2e73aac11ae6ef69322 Reviewed-on: https://chromium-review.googlesource.com/1169181Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55080}
-
Clemens Hammacher authored
All these methods did was executing DCHECKs. This CL just writes out the DCHECKs directly. R=mstarzinger@chromium.org Bug: v8:8015 Change-Id: I01d4c536ea354d158da5f628aeab35fb13b80a58 Reviewed-on: https://chromium-review.googlesource.com/1170822 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55079}
-
Bret Sepulveda authored
This patch reshuffles the colors used for the various tick categories in the visualization. Category rows are now light gray. The new colors are taken from the Material palette. See screenshots on the associated bug. This patch also labels the GC bucket as such, instead of having the same label as uncategorized C++. Bug: v8:6240 Change-Id: I3909a177148b98e99d63f5ec9ae02e3c6f63eb24 Reviewed-on: https://chromium-review.googlesource.com/1172139 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Bug: chromium:873555 Change-Id: I6268bedf47a89194875d1179e603bcfe972c9d68 Reviewed-on: https://chromium-review.googlesource.com/1172282Reviewed-by:
-
Andreas Haas authored
With the origin trial for WebAssembly threads, threads can be turned on and off by the embedder depending on the context we are currently in. With this CL we call the embedder callback stored on the isolate to determine whether threads are enabled in the current context or not. Design decision: I decided to extend the {WasmFeaturesFromIsolate} function to ask the embedder if WebAssembly threads are enabled. This is the function which defines dynamically which features are turned on. It would be awkward to have two such functions, one which calls the embedder and one which does not. A downside is that in WasmJs::Install the embedder does not seem to be ready to be called. That's why I changed the code there to call {WasmFeaturesFromFlags} instead. R=titzer@chromium.org, mstarzinger@chromium.org Bug: chromium:868844 Change-Id: I6bfa89960a54cec71992756e3717bbb3a9fe195e Reviewed-on: https://chromium-review.googlesource.com/1169180 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55076}
-
Ivica Bogosavljevic authored
This CL implements several things needed for full SIMD BE support in WASM: * Global variables are now kept in little-endian order as per specification * Added support for SIMD on BE in wasm interpreter * Fixed several tests that didn't work on BE because input or output data were not using LE in-memory layout Change-Id: I4542d13d09fd276e15b0fc39f02e4a58831f65e4 Reviewed-on: https://chromium-review.googlesource.com/1160484 Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#55075}
-
Yang Guo authored
The break id is no longer used. Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib07046d66497cbd5e01a8a1248afd890180200bf Reviewed-on: https://chromium-review.googlesource.com/1172136Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/68bf4b8..6705895 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id30b10fbbbe7d29edb71f08d02e9641ae777f52a Reviewed-on: https://chromium-review.googlesource.com/1172151 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 12 Aug, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5c13474..68bf4b8 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/1da4e38..74c827a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia676fa56d262206c40bcabfe479a3f74159a1eec Reviewed-on: https://chromium-review.googlesource.com/1172077 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 11 Aug, 2018 2 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:826280 Change-Id: I8225cd481835470235496d38023794068980dc3d Reviewed-on: https://chromium-review.googlesource.com/1171240Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55071}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:826280 Change-Id: Ica0061605b76c699516a0bc83e14cb7ed744346e Reviewed-on: https://chromium-review.googlesource.com/1171236Reviewed-by:
-
