- 26 Jul, 2017 1 commit
-
-
Sathya Gunasekaran authored
- No need for multiple assertAsyncRan() calls, just do t.plan(count) - Previously, if you forget to call assertAsyncRan(), the test will still pass, which is no longer true. - No longer hold global state (with asyncAssertsExpected). Previously if one assert wasn't hit then there's no way to find out which test failed. You'd have to comment each test and try again. - Each test runs independently in the microtask queue. - Better failure reporting by printing the entire function. Example error : === mjsunit/harmony/promise-prototype-finally === abort: Expected asserts: 2, Actual asserts: 1 in test: reject/finally/then assert => { assert.plan(2); Promise.reject(3).finally().then( assert.unreachable, x => { assert.equals(3, x); }); } Change-Id: Ic3f6272e1e87b8b0121b8c8c7cce19cf90d1f1be Reviewed-on: https://chromium-review.googlesource.com/455555 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#46910}
-
- 10 May, 2017 3 commits
-
-
Mircea Trofin authored
This reverts commit 619dfed4. Original CL: https://chromium-review.googlesource.com/c/494968/ Bug: Change-Id: Ib4a1f481e46f1972420cc8f8d2192bb6c470e08d Reviewed-on: https://chromium-review.googlesource.com/501650 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#45240}
-
Mircea Trofin authored
This reverts commit 45bbf804. Reason for revert: Still some flakes. Original change's description: > Reland "Introducing an event loop mechanism for d8." > > This reverts commit 02595c60. > > Original CL: https://chromium-review.googlesource.com/c/494968/ > > Bug: > Change-Id: I7441ed91ebb4a087cdf437ae3239f9b021110a11 > Reviewed-on: https://chromium-review.googlesource.com/500947 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Mircea Trofin <mtrofin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45212} TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: Change-Id: Idf2ea0431865104042a68bd2dac944a9725bf3f9 Reviewed-on: https://chromium-review.googlesource.com/501370Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#45215}
-
Mircea Trofin authored
This reverts commit 02595c60. Original CL: https://chromium-review.googlesource.com/c/494968/ Bug: Change-Id: I7441ed91ebb4a087cdf437ae3239f9b021110a11 Reviewed-on: https://chromium-review.googlesource.com/500947Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#45212}
-
- 09 May, 2017 1 commit
-
-
Michael Achenbach authored
This reverts commit 7dcc8eff. Reason for revert: Some flakes still (see comments) and breaks predictable testing: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20predictable/builds/11452 Original change's description: > Revert "Revert "Introducing an event loop mechanism for d8."" > > This reverts commit f7c25da6. > > Reason for revert: Fixed > > Original change's description: > > Revert "Introducing an event loop mechanism for d8." > > > > This reverts commit de964dbe. > > > > Reason for revert: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/17958 > > > > Original change's description: > > > Introducing an event loop mechanism for d8. > > > > > > This mechanism ensures APIs like wasm async complete their work, > > > without requiring use of natives (%APIs). > > > > > > The mechanism is similar to the one used in content_shell, > > > which should allow us to easily port tests in that environment. > > > > > > Review-Url: https://codereview.chromium.org/2842843005 > > > Cr-Original-Commit-Position: refs/heads/master@{#44908} > > > Bug: > > > Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 > > > Reviewed-on: https://chromium-review.googlesource.com/494968 > > > Commit-Queue: Mircea Trofin <mtrofin@google.com> > > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45165} > > > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Change-Id: Iafec2615d705d1990c57229cab3a988c00b5e12f > > Reviewed-on: https://chromium-review.googlesource.com/498630 > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45166} > > TBR=bradnelson@chromium.org,machenbach@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Ic3c782e918326e291a6cb9bb349c609e9a340b09 > Reviewed-on: https://chromium-review.googlesource.com/498430 > Reviewed-by: Mircea Trofin <mtrofin@chromium.org> > Commit-Queue: Mircea Trofin <mtrofin@google.com> > Cr-Commit-Position: refs/heads/master@{#45172} TBR=bradnelson@chromium.org,machenbach@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I21ffba7141db0bfb4a3275b6e1bf4fb399800ed2 Reviewed-on: https://chromium-review.googlesource.com/500128Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45177}
-
- 08 May, 2017 3 commits
-
-
Mircea Trofin authored
This reverts commit f7c25da6. Reason for revert: Fixed Original change's description: > Revert "Introducing an event loop mechanism for d8." > > This reverts commit de964dbe. > > Reason for revert: > https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/17958 > > Original change's description: > > Introducing an event loop mechanism for d8. > > > > This mechanism ensures APIs like wasm async complete their work, > > without requiring use of natives (%APIs). > > > > The mechanism is similar to the one used in content_shell, > > which should allow us to easily port tests in that environment. > > > > Review-Url: https://codereview.chromium.org/2842843005 > > Cr-Original-Commit-Position: refs/heads/master@{#44908} > > Bug: > > Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 > > Reviewed-on: https://chromium-review.googlesource.com/494968 > > Commit-Queue: Mircea Trofin <mtrofin@google.com> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45165} > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Iafec2615d705d1990c57229cab3a988c00b5e12f > Reviewed-on: https://chromium-review.googlesource.com/498630 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45166} TBR=bradnelson@chromium.org,machenbach@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ic3c782e918326e291a6cb9bb349c609e9a340b09 Reviewed-on: https://chromium-review.googlesource.com/498430Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@google.com> Cr-Commit-Position: refs/heads/master@{#45172}
-
Michael Achenbach authored
This reverts commit de964dbe. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/17958 Original change's description: > Introducing an event loop mechanism for d8. > > This mechanism ensures APIs like wasm async complete their work, > without requiring use of natives (%APIs). > > The mechanism is similar to the one used in content_shell, > which should allow us to easily port tests in that environment. > > Review-Url: https://codereview.chromium.org/2842843005 > Cr-Original-Commit-Position: refs/heads/master@{#44908} > Bug: > Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 > Reviewed-on: https://chromium-review.googlesource.com/494968 > Commit-Queue: Mircea Trofin <mtrofin@google.com> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45165} TBR=bradnelson@chromium.org,mtrofin@chromium.org,mtrofin@google.com,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Iafec2615d705d1990c57229cab3a988c00b5e12f Reviewed-on: https://chromium-review.googlesource.com/498630Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45166}
-
Mircea Trofin authored
This mechanism ensures APIs like wasm async complete their work, without requiring use of natives (%APIs). The mechanism is similar to the one used in content_shell, which should allow us to easily port tests in that environment. Review-Url: https://codereview.chromium.org/2842843005 Cr-Original-Commit-Position: refs/heads/master@{#44908} Bug: Change-Id: I9deee0d256a600c60b42902fc8ef8478e5546344 Reviewed-on: https://chromium-review.googlesource.com/494968 Commit-Queue: Mircea Trofin <mtrofin@google.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#45165}
-
- 07 Nov, 2016 1 commit
-
-
jgruber authored
This CL adds further support to the test wrapper. We are now able to run almost all mjsunit/debug-step-* tests using the inspector backend. debug-stepframe-* tests are not yet supported since inspector does not know a 'frame' step type. The interface has also been improved to be able to move these tests to inspector mostly without modification. BUG=v8:5330 Review-Url: https://codereview.chromium.org/2466273005 Cr-Commit-Position: refs/heads/master@{#40800}
-
- 04 Mar, 2016 1 commit
-
-
adamk authored
BUG=v8:3699, chromium:588803 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1749353004 Cr-Commit-Position: refs/heads/master@{#34474}
-
- 16 Dec, 2015 1 commit
-
-
yangguo authored
And tons of changes to debugger tests. R=bmeurer@chromium.org BUG=chromium:569835 LOG=N Review URL: https://codereview.chromium.org/1525173003 Cr-Commit-Position: refs/heads/master@{#32885}
-
- 08 Mar, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG=102153 TEST=regress-102153.js Review URL: https://chromiumcodereview.appspot.com/9625011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10963 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Aug, 2010 1 commit
-
-
ricow@chromium.org authored
Review URL: http://codereview.chromium.org/3072031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Apr, 2010 1 commit
-
-
sgjesse@chromium.org authored
Generate inlined named property load for in-object properties. This uses the same mechanism as on the Intel platforms with the map check and load instruction of the inlined code being patched by the inline cache code. The map check is patched through the normal constant pool patching and the load instruction is patched in place. Review URL: http://codereview.chromium.org/1715003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jul, 2009 1 commit
-
-
http://codereview.chromium.org/149542yurys@chromium.org authored
Reapply http://codereview.chromium.org/149542 now that issue with Mac builder is fixed(http://codereview.chromium.org/155591) Review URL: http://codereview.chromium.org/149746 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2479 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Jul, 2009 1 commit
-
-
yurys@chromium.org authored
Review URL: http://codereview.chromium.org/149672 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2009 1 commit
-
-
yurys@chromium.org authored
Related Chromium bug: http://code.google.com/p/chromium/issues/detail?id=16427 Review URL: http://codereview.chromium.org/149542 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-