- 07 May, 2019 19 commits
-
-
Dan Elphick authored
This reverts commit 758700a7. Reason for revert: Broken Original change's description: > [compiler] Don't collect source positions for the top frame > > While most source positions were not collected even throwing exceptions, > the top frame still was always collected as it was used to initialize > the JSMessageObject. This skips even that frame, by storing the > SharedFunctionInfo and bytecode offset in the JSMessageObject allowing > it to lazily evaluate the actual source position. > > Also adds tests to test-api.cc that test each of the source position > functions in isolation to ensure that they don't rely on previous > invocations to call the source collection function. > > Since no source positions are now collected at the point when an > exception is thrown, the mjsunit/stack-traces-overflow now passes again > with the flag enabled. (cctest/test-cpu-profiler/Inlining2 is now the > only failure). > > Bug: v8:8510 > Change-Id: Ic5382bdbab65cd8838f0c84b544fabb1a9109d13 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587385 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61271} TBR=ulan@chromium.org,rmcilroy@chromium.org,delphick@chromium.org Change-Id: I3ee0b5db5f8a1b3255f68070dc10d27d0e013048 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598758Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#61273}
-
Santiago Aboy Solanes authored
This CL is the final one for the access-builder.cc's changes. There are still Tagged loads and stores (e.g in wasm) which will be tackled on following CLs. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I2667eaacbada0846fe5f128bb17a1a305862c64d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590077 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61272}
-
Dan Elphick authored
While most source positions were not collected even throwing exceptions, the top frame still was always collected as it was used to initialize the JSMessageObject. This skips even that frame, by storing the SharedFunctionInfo and bytecode offset in the JSMessageObject allowing it to lazily evaluate the actual source position. Also adds tests to test-api.cc that test each of the source position functions in isolation to ensure that they don't rely on previous invocations to call the source collection function. Since no source positions are now collected at the point when an exception is thrown, the mjsunit/stack-traces-overflow now passes again with the flag enabled. (cctest/test-cpu-profiler/Inlining2 is now the only failure). Bug: v8:8510 Change-Id: Ic5382bdbab65cd8838f0c84b544fabb1a9109d13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587385 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61271}
-
Santiago Aboy Solanes authored
Follow -up CL that aims to eliminate the straggler tagged loads and stores. It includes a lot of access builder changes. There are 8 access (2 Any and 6 Pointer) that are still remaining as tagged since changing those to compressed make some tests fail. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Iad305fd3a2da257764d22bad30b25489f727e676 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588431Reviewed-by:
-
Santiago Aboy Solanes authored
GraphBuilderTester was introduced at a time where RawMachineAssembler was going to be deprecated (https://codereview.chromium.org/1423923003/). Now we know that it's not going to happen any time soon. Since GraphBuilderTester it's only used in one test which can use RawMachineAssembler, I updated it and removed the class. Now the .h file had another class, which is now the only class in the file. Therefore, I renamed it and updated the include calls to it. Also updated the include commands: some were not necessary, and some others could be moved to more aptly places. Bug: v8:9183 Change-Id: I44bf16090c0515b1b9ff6cbded1bdb0adb4e44e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594563Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61269}
-
Simon Zünd authored
R=sigurds@chromium.org Bug: v8:8880 Change-Id: Ib862842f3624689d004b1b7750f260be79fc9c36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598693 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61268}
-
Mythri A authored
This is a reland of d14ed12e with fix for test failures in lite mode. When handling load named properties (without feedback vectors) we used to miss to runtimes if the prototypes aren't set. This was because we wanted to give the prototype a chance to become fast, since most prototypes start in slow mode but move to fast after the initial setup. Though this check is not really useful when we don't have feedback vectors, and once feedback vectors are allocated we will turn the prototypes fast anyway. Bug: v8:8394, v8:8860 Change-Id: I5c7b5061e1d9068c72d6f0eea47517880940a054 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591772Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61267}
-
Michael Achenbach authored
This ports: https://crrev.com/c/1576022 Bug: chromium:958870 Change-Id: Id187f5af80823fe58e38f1365baebabfc6587316 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594556Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61266}
-
Peter Marshall authored
The TraceObject passed to AppendTraceEvent can be completely uninitialized (set to all 0s) in some situations where a flush happens between creation and initialization of the TraceObject. Fix the MockTraceWriter in test-tracing to expect nullptr strings for the name of the object so that it does not try to construct an std::string from a null char*. Bug: v8:9214 Change-Id: Ib4f3b039ab98d5d786991134cb71ecc62f127179 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598751 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61265}
-
Sigurd Schneider authored
Torque semantic analysis is now a four-stage process: 1. The TypeDeclarationVisitor introduces a TypeAlias for every TypeDeclaration* (or derived) in the Torque source, but does not process the TypeDeclaration* itself. 2. All aliases are resolved in a dependency respecting manner. This CL also changes struct member resolution to happen at this point already. Types for classes are created, but their members are not resolved to allow classes to mutually reference each other in their field types. 3. 'value' declarations (macros, etc.) are processed. 4. Members of classes are processed. Bug: v8:7793 Change-Id: I46108555a5cdf30df03c5d4399ec786ee6cc6df4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61264}
-
Simon Zünd authored
To obtain SourcePositions for unary and binary operators, this CL changes the "OneOf" parser rule to produce an Identifier*. Forwarding this new identifier as callee for a CallExpression enables "goto Definition" support for operators in the Language Server. Side note: VSCode won't highlight operators with an underlined font when hovering with Ctrl pressed. "goto Definition" will work nonetheless using default F12 or Ctrl-Click. R=tebbi@chromium.org Bug: v8:7793 Change-Id: Iada06009e324a3de8c453ec058427049e921a70d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598690 Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Bug: v8:9145 Change-Id: Idb1a838666ea21cb260a141929fd80b400913836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596731Reviewed-by:
-
Simon Zünd authored
The Torque compiler generates macros for accessing fields in classes. These are currently indistiguishable from user defined macros. To improve the upcoming symbol search in the Torque Language Server, this CL introduces a flag on macros to differentiate user defined and auto generated macros. R=sigurds@chromium.org Bug: v8:7793 Change-Id: I84a8ab14535ec779494b5b2e887fda8fc4edf3e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598688Reviewed-by:
-
Maya Lekova authored
The call to EnsureSourcePositionsAvailable for a given SharedFunctionInfo is now done in the serializer for each SFI that is marked as serialized for compilation. This will enable brokerization of the JSInliner class. Change-Id: I7821a50fcac8a3e19386e98758f2b0dea3023bb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582400 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61260}
-
Jakob Gruber authored
This reverts commit efd8c2d9. Reason for revert: Performance regressions (chromium:958035) Original change's description: > Remove --win64-unwinding-info flag and always generate unwind info on Win/x64 > > The generation of unwind info to enable stack walking on Windows/x64 > (https://chromium-review.googlesource.com/c/v8/v8/+/1469329) was implemented > behind a temporary flag, in order to coordinate these changes with the > corresponding changes in Chromium. > > The required changes to Chromium > (https://chromium-review.googlesource.com/c/chromium/src/+/1474703) have also > been merged, so we can now remove the flag and enable the generation of stack > unwinding info by default on Windows/x64. > > Bug: v8:3598 > Change-Id: I88814aaeabecc007f5262227aa0681a1d16156d5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573138 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Paolo Severini <paolosev@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#61020} TBR=ulan@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,paolosev@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Tbr: ulan@chromium.org,mstarzinger@chromium.org,paolosev@microsoft.com Bug: v8:3598, chromium:958035 Change-Id: Ia86a230ee83080ed8ace43e4641c8c1013043df4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598748 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61259}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/6281d0d..27799cd Fix bikeshed build (#1014) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/27799cd [spec] Fix typo (#1011) (Galaxtone) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/6172038 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I65c6da974440bc368993d221824372489cdc787a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598528Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61258}
-
Milad Farazmand authored
This reverts commit b51404a8. Reason for revert: Need to revert this change due to a revert on this commit: 18100666 Original change's description: > PPC/S390: [typedarray] Make JSTypedArray::length authoritative. > > Removing NumberToSize on PPC and S390. > > Port ad44c258 > > Change-Id: Ic5d3132f1bb396f07a26399d2e3f6aca4689aa3f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554227 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60691} TBR=jarin@chromium.org,titzer@chromium.org,petermarshall@chromium.org,bmeurer@chromium.org,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idd6cf715ce25ed35f9cb55c70e20183072c660d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598308Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61257}
-
Yu Yin authored
Change-Id: I98ebc42a7dc343abc471d04c606b6746f6cae18a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596047Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61256}
-
Yu Yin authored
mips load/store instructions can only handle when the memory offset is in range [int16_min, int16_max], when beyond this range, we can use macro instructions which will adjust base and offset first. Change-Id: I84319b7fef9de8d0b8f507374654e38827503bdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596046Reviewed-by:
-
- 06 May, 2019 21 commits
-
-
Alexander Neville authored
Change-Id: If464c03c16e322fa4268a511fa984bb143b65a50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594290 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Johannes Henkel authored
New revision: 2039736177ee11d96a096cdab9c58cc1d78faa43 This modifies roll.py to update namespaces and header guards. Also I'm removing --reverse, to avoid making this more complicated. third_party/encoding/encoding{.h,cc} are already up to date, since I manually propaged them earlier. So this is why this change is only updating the template. Change-Id: I5ddb075c9d6dad28b5665348023860683e964841 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596392Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61253}
-
Z Duong Nguyen-Huu authored
Bug: v8:8996 Change-Id: Ie4b17928fcb9d426bade5afc1238d24bc75ec13e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594275 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#61252}
-
Georg Schmid authored
R=tebbi@chromium.org Change-Id: I1003a4f4a0e9227618e685a2fb56ead2083709a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594731 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
-
Toon Verwaest authored
It's not necessarily helpful, and can actually cause pretty bad performance and memory usage. I moved up the next_ field to where allocation_ used to be since apparently the alignment caused by it has huge impact on perf (>10% diff...) at least on my machine. Change-Id: I1026a2e954d061b1a178f6a733d8ef81ae6d0cab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594432 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61250}
-
Michael Achenbach authored
Error messages are unspecified in JavaScript and occasional small differences in the compared configurations lead to an unjustified maintenance burden of correctness-fuzzing issues. This CL replaces most error messages with a fixed suppression message during correctness fuzzing (behind a flag). The flag covering all extra behavior for correctness fuzzing is now renamed to --correctness-fuzzer-suppressions. Bug: chromium:958668,chromium:946476 Change-Id: Iba1197f765138a962d5bbb176730322e5a411707 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594730 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Original change's description: > [runtime] Inline SeqOneByteSubStringKey IsMatch and AsHandle > > The performance actually matters to JSON parsing and this improves it by a % or > 2. > > In the longer run we should probably share the IsMatch implementation in > StringTableKey directly and call a virtual GetBytes on the key implementation. > > Change-Id: I838a106f9c8c52f0385057a52a8c0b9141ae025b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1589977 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Auto-Submit: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61183} Change-Id: I3fc73b4d123f193f7c2ce3078b0b030a652efc17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596735 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This is a reland of b0c4a876 Original change's description: > [json] Speed up json parsing > > - scan using raw data pointers + GC callback > - scan using scanner tables > - cap internalizing large string values > - inline fast transitioning logic > > Fixes previous CL by moving AllowHeapAllocation to callers of > ReportUnexpectedCharacter where needed to make it clear we need to exit. > > Tbr: ulan@chromium.org > Change-Id: Icfbb7cd536e0fbe153f34acca5d0fab6b5453d71 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591778 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61159} Change-Id: I0d713e02d243723df2d2a7c252eae44a6648b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596444Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I513c3ba048eafb7ca5bfa2fb63e35143f49643ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596736 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Until this CL, the Memory benchmark was the only one to be based on a cctest runner; all others use d8. Besides being a tedious exception to the rule, this caused issues such as described in the linked bug (summary: refbuilds are built with v8_static_library, and neither cctests nor unittests support this configuration). Here, we move the Memory benchmark into a d8 runner. Bug: v8:9189, chromium:957029 Change-Id: I9b45ff36f4842cb0bdef2c1c4b0184c5509d3385 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588464 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#61245}
-
Clemens Hammacher authored
To reduce physical memory consumption, discard code pages that are fully freed. To determine pages which only become fully free after several freed wasm code objects, this CL adds a {DisjointAllocationPool} to track all freed code ({freed_code_space_} in {NativeModule}). R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I22ad92d2c0bd4469e92f0dfd5aec05c03b5a47d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594728 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This deprecates the variant taking an int argument. Chromium was switched to the size_t variant in https://crrev.com/c/1583747 and https://crrev.com/c/1587597. Pdfium was switched here: https://pdfium-review.googlesource.com/c/pdfium/+/53996 R=ulan@chromium.org Change-Id: I0f4e007b2edc7a176bd8865600bfd5e70b838c3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581640Reviewed-by:
-
Ben L. Titzer authored
R=jarin@chromium.org Change-Id: I47b506599ae338e8323ef0def63db3b2004ac798 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594562Reviewed-by:
-
Georg Neis authored
This fixes a performance regression. Bug: v8:9197, chromium:958730 Change-Id: I70a59dd85d74275b967a196e9ab4623293b92756 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596446Reviewed-by:
-
Frederik Gossen authored
The interpreter accesses code directly from the code manager. With lazy validation, however, this code is not guaranteed to exist. The interpreter now checks for this and compiles it lazily if needed. It also handles exceptions that may arise from lazy validation. Bug: v8:9003 Change-Id: I37c365f0a4d755ed55630d01c8526f2a3efa9a9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594567Reviewed-by:
-
Michael Starzinger authored
This fixes the source position printed in the stack trace for exceptions thrown from within Wasm code. Specifically this affects the stack trace attached to the exception object, as well as the message propagated to the console. Both are tested by the new message test. R=clemensh@chromium.org TEST=message/fail/wasm-exception-throw BUG=v8:8091 Change-Id: I5b2f76191cf47457ac113dce9d9601a8a810ee19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591603Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7793 Change-Id: If419ec5659e98ebeba454417d097a7981ac3da65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596729Reviewed-by:
-
Yang Guo authored
R=petermarshall@chromium.org Change-Id: Ib0cfb056ed328a4c6cb0851921f913613b3f1a51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591611Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61237}
-
Clemens Hammacher authored
Use the existing move assignment operator instead. R=ulan@chromium.org Bug: v8:9183 Change-Id: Id7a4427da2bbf92d2954faba06e24afe64cb9818 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594729Reviewed-by:
-
Clemens Hammacher authored
It was a std::list for no obvious reason. This CL turns it into a vector, which is the standard data structure we use if we don't have any special requirements. R=mstarzinger@chromium.org Change-Id: Iefc321db9327e0743772dd804e2325266a9bff64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594727Reviewed-by:
-
Simon Zünd authored
This CL improves SourcePosition support inside the Torque compiler. It starts with the parser, where the SourcePosition of the MatchedInput now encompasses all tokens, not just the first one. Second, AST nodes can now be created with an explicit source position. This can be used to forward the "all encompassing" source position via MatchedInput -> ParseResultIterator to AST nodes. Third, declarables are extended to hold two different SourcePositions: - One represents the whole declarable. For a macro this would inlcude the body as well as the signature. - The other is the SourcePosition of the identifying part of a declarable. In most cases this is the name. For the rest this will stay invalid. R=sigurds@chromium.org, tebbi@chromium.org Bug: v8:7793 Change-Id: I509f83aeef7a040d0ea6363b5b7c31ff1b11f47b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591600 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
