- 27 May, 2019 24 commits
-
-
Benedikt Meurer authored
As the next step in supporting huge typed arrays in V8, this moves the external/data pointer from the FixedTypedArrayBase backing store to the JSTypedArray instance itself, and replaces the special backing stores with a plain ByteArray (removing all the code for the FixedTypedArrayBase class hierarchy). By doing so, we can drastically simplify the system around typed arrays. Note: Several places in the code base used to check the instance type of the elements backing store of a JSTypedArray instead of checking the elements kind on the JSTypedArray map directly. Those had to be fixed, since the backing store is now always a ByteArray. Drive-by-fix: Move all the typed elements access related code into the elements.cc file to properly encapsulate the accesses. Doc: http://doc/1Z-wM2qwvAuxH46e9ivtkYvKzzwYZg8ymm0x0wJaomow Bug: chromium:951196, chromium:965583, v8:4153, v8:7881, v8:9183 Change-Id: I8cc06b190c53e34155000b4560f5f3ef40621646 Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627535 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61855}
-
Peter Marshall authored
Add a new abstract class TraceEventListener which is just an interface for consuming trace events. This separates the V8-specific stuff that an actual perfetto consumer needs to do e.g. handling the has_more flag and signalling back to the controller with a semaphore. This is a change from the previous plan of making the PerfettoConsumer class sub-classable to implement custom consumption of trace events. This will be difficult when the consumer is created outside of the PerfettoTracingController as we can't hook up the consumer_finished_semaphore_ that belongs to the controller. Now the PerfettoTracingController is responsible for the Consumer life- cycle and hides it entirely from callers. We add the AddTraceEventListener() method to allow callers to register a listener either for testing or a JSON listener for real tracing. This lets us write tests that can store all the trace events in memory without first converting them to JSON, letting us write test more easily. There's an example test add to test-tracing - more tests using this style will follow. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: I2d2b0f408b1c7bed954144163e1968f40d772c1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1628789 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61854}
-
Jakob Gruber authored
Bug: v8:9103 Change-Id: I7ff6bb0032fd5d81339401bbf8276baf19af8489 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631417 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This moves the platform-specific WriteByteChunk (& friends) into platform-specific embedded file writers. Bug: v8:9103 Change-Id: I0113c90dbf661a39dabe62b420cf6a160ee1be1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631412 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds a reflective function to retrieve the function type of an exported or constructed WebAssembly function object. Note that this first implementation only supports exported functions for now, the support for constructed functions will be done as a follow-up. R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I38a16972d8437521993992ca20887c47c7c6b99b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627989Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61851}
-
Jakob Gruber authored
The win64-specific unwinding info writer should not be part of the generic EmbeddedFileWriter class. Let's hide it in the platform-specific writer. Bug: v8:9103 Change-Id: Ifc4f8b326f07e037b6876e0592cb70b8281edb9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627536 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This replaces all typedefs that define types and not functions by the equivalent "using" declaration. This was done mostly automatically using this command: ag -l '\btypedef\b' src test | xargs -L1 \ perl -i -p0e 's/typedef ([^*;{}]+) (\w+);/using \2 = \1;/sg' Patchset 2 then adds some manual changes for typedefs for pointer types, where the regular expression did not match. R=mstarzinger@chromium.org TBR=yangguo@chromium.org, jarin@chromium.org Bug: v8:9183 Change-Id: I6f6ee28d1793b7ac34a58f980b94babc21874b78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631409 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61849}
-
Joyee Cheung authored
The `->` operator should be changed to `.` after https://chromium-review.googlesource.com/c/v8/v8/+/1624209 Change-Id: Ie16adaa17bfc7caaa589ed3881a8716e98ea36b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1628793Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#61848}
-
Ulan Degenbaev authored
Bug: chromium:966832 Change-Id: Ie89dbbc1d92f746547aecf4752b6b3189bc251aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627987 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61847}
-
Toon Verwaest authored
Bug: chromium:967151 Change-Id: I54a856cfcc4b4b17bd282dd3eabe5a915e617ca5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630683 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Simon Zünd authored
When allocating large arrays on 32-bit systems, the length conversion caused the work array capacity to become negative. As the sort range is currently clamped at kSmiMaxValue anyway, the fix is to also clamp the work capacity to that value. R=jgruber@chromium.org Bug: chromium:967065 Change-Id: I9ea60464c5b7f3796c5389cbaf668b990eddecf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630672 Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Georg Schmid authored
R=jarin@google.com, tebbi@google.com Change-Id: Ic64ca132178f189a6d78a73ed18150ae503dd9a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617936 Auto-Submit: Georg Schmid <gsps@google.com> Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61844}
-
Jakob Gruber authored
Bug: v8:9103 Change-Id: I9a11bd99eb3f2b082749cf6a497ffe759216ad22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627347 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit 384a51da. This hack is both broken (builtins now have individual symbols and no longer resolve to v8_Default_embedded_blob_) and useless (profview seems to detect builtins just fine without it). Bug: v8:6666 Change-Id: I264b4de31124f1657f4dc570590eb73e53aa08d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627344Reviewed-by:
-
Clemens Hammacher authored
Currently, all background compile tasks run for 50ms, then they all publish their results and restart. This results in significant contention during the publish phase. This CL introduces an atomic counter on the {CompilationStateImpl} to distribute the deadline more evenly: Each task executes between 50ms and 200ms, and tries to pick a deadline 5ms after the previously assigned deadline, if this lies within these boundaries. This speeds up publishing significantly and saves several percent compilation time overall. R=mstarzinger@chromium.org Bug: v8:8916 Change-Id: Id32a5a72c1dd44d30df2ea09643b2a6e4f436944 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627984 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
The category for wasm trace events is "disabled-by-default-v8.wasm", generated by {TRACE_DISABLED_BY_DEFAULT("v8.wasm")}. This CL fixes two events that used the category without the "disabled-by-default-" prefix, and adds two more trace events to make code GC more visible in the trace. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: Ib20d9caec9e55013acbeb604f91a63e8a557f30c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627982 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Thibaud Michaud authored
R=ahaas@chromium.org CC=titzer@chromium.org Bug: v8:9231 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Change-Id: I3de9c839ad43ab37c69b622ccf221dfc429c2e2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1605732 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61839}
-
Georg Schmid authored
This is a reland of e588ff10 The only change over the original CL is found in JSCreateLowering::AllocateFastLiteral. We now guard against boilerplate values for unboxed double fields that *look* like legitimate initial values, but should really be kHoleNanInt64 instead. The underlying problem certainly existed before, but an invariant added to LoadElimination in this CL caused a Chromium layout test to fail. The change in this reland is therefore a workaround, the root cause remains to be fixed. Specifically, we find that a pointer to the undefined value oddball is sometimes reinterpreted as a double and assigned as a boilerplate value. @jarin suspects that this stems from in-place map updates. Original change's description: > Make LoadElimination aware of const fields (Part 2; stores) > > Adds const information to store field accesses and uses it in load elimination > > Change-Id: I00765c854c95c955dabd78557463267b95f75eef > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611543 > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Georg Schmid <gsps@google.com> > Cr-Commit-Position: refs/heads/master@{#61796} Change-Id: Ie388754890024a3ca7d10c9d4d7391442655b426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630676Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Drive-by: fix an #include that the gcov bot is missing Bug: v8:9183 Change-Id: I35d1b4e346a56799a5f49b7059a658d5ccfe75ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627548Reviewed-by:
-
Yang Guo authored
R=sigurds@chromium.org Bug: v8:9247 Change-Id: I25743f048e3e6cd22a18e003e77c8b78f147b630 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630680Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61836}
-
Simon Zünd authored
COW arrays were previously handled in the C++ pre-processing runtime function. The Torque version forgot a "EnsureWritableFastElements". This CL fixes that. Bug: chromium:967254 Change-Id: Ifbf89e57cfe724e61316b8abc226f7e8a262fce2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630675Reviewed-by:
-
Maya Lekova authored
This CL removes the await-optimization-flag, that is no longer needed, since the feature is considered web compatible. Bug: v8:8267, chromium:893469 Change-Id: I046f003f9ed6853d713b825c436fe5f0a1e5a0a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630677Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:9183 Change-Id: Id2ae3ee0a53133eaf41e28fcadc681edf5ffb382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630673Reviewed-by:
-
Z Nguyen-Huu authored
Pass test262 change in Proxy: defineProperty, deleteProperty, getOwnPropertyDescriptor. Bug: v8:9228 Change-Id: Id9a2c8dcbfcf68ed2837eb6d5042abcbce7ab0ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1626474 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#61832}
-
- 25 May, 2019 1 commit
-
-
Sergiy Belozorov authored
TBR=tmrts@chromium.org No-Try: true Change-Id: I9a7a7bd623399575f8c31b9566744f7510648775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630147 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#61831}
-
- 24 May, 2019 15 commits
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Frank Tang authored
Consider the case that uloc_toLegacyType may return nullptr while the specified keyword value cannot be mapped to a well-formed legacy type. Bug: chromium:966285 Change-Id: I40511c54e4835599c002f1c678121341276a4e58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627902 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7793 Change-Id: Ic485dc953c80d055ff190b8be2a5434e5cdbeb5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624214 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Simon Zünd authored
This is a reland of 2b0ac2fb The layout test that caused this revert was fixed with: https://crrev.com/c/1627386 Original change's description: > [array] Move Array#sort pre-processing to Torque > > This CL removes the "PrepareElementsForSort" runtime function, and > replaces it with a simpler version in Torque. The biggest difference > is that certain sparse configurations no longer have a fast-path. > > The Torque pre-processing step replaces the existing Torque mechanism that > copied already pre-processed elements into the "work" FixedArray. The Torque > compacting works as follows: > - Iterate all elements from 0 to {length} > - If the element is the hole: Do nothing. > - If the element is "undefined": Increment undefined counter. > - In all other cases, push the element into the "work" FixedArray. > > Then the "work" FixedArray is sorted as before. Writing the elements from > the "work" array back into the receiver, after sorting, has three steps: > 1. Copy the sorted elements from the "work" FixedArray to the receiver. > 2. Add previously counted number of "undefined" to the receiver. > 3. Depending on the backing store either delete properties or > set them to the Hole up to {length}. > > Bug: v8:8714 > Change-Id: I14eccb7cfd2e4618bce2a85cba0689d7e0380ad2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619756 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61812} TBR: jgruber@chromium.org Bug: v8:8714 Change-Id: If7613f6e5f37c5e0d649e8192195594bc6c32100 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627977 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL fixes a crash when "constexpr" is infered from the intializer expression of a variable declaration. R=sigurds@chromium.org Bug: v8:7793 Change-Id: I0ec51280fa145d874424e885905bbf79c93b3904 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627983 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Torque only supports TFS linkage, which requires all arguments to be tagged. This CL issues a warning if a Torque-defined builtin tries to declare untagged arguments. Change-Id: Ibc186b4fce05541e768f4bb673e9ea64a45b0e01 Bug: v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627971Reviewed-by:
-
Andreas Haas authored
Deleting this comment addresses feedback of https://crrev.com/c/1627348. I changed the comment in gerrit but forgot to publish the change. NOTRY=true TBR=mstarzinger@chromium.org Change-Id: Ia76a1fa6dc6c593e559626c9bf9a564f3f09f777 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627986Reviewed-by:
-
Andreas Haas authored
New spec changes allow anyref tables to be initialized with function references. R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: I59596e1e383408114b974fa10529ae15b8cf7a15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627348Reviewed-by:
-
Andreas Haas authored
R=clemensh@chromium.org Also-By: clemensh@chromium.org Bug: v8:9288, v8:8217 Change-Id: I1b4b7b5f06c49a6047d98a3a5db8bfa0c277be09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627981 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9290, v8:7490, v8:9183 Change-Id: Iac5cdf0d96c1fdbb7e6461ea435c1ff32c6a701e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627543 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This reduction replaces the Phi's input decompressions with their parent node, if and only if all of the Phi's inputs are Decompress nodes. Also, if we have different Decompress nodes as inputs, we need to use a conservative decompression after the Phi. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I8cc0264f9d08fe5ad25364f18c9f305afc54529c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624785Reviewed-by:
-
Tobias Tebbi authored
This is a reland of c33a1ef2 It seems the revert was based on a flake. Original change's description: > Reland "[torque] move class tests to unittests" > > This is a reland of f589d561 > > Now with an ASAN-container-overflow false positive workaround: > Somehow ASAN was unhappy about a simple > std::vector<std::string>::push_back. > Increasing the std::vector capacity before doing the push_back > strangely fixes the problem. > > Original change's description: > > [torque] move class tests to unittests > > > > This avoids the generation of fake external classes. > > > > Bug: v8:7793 > > Change-Id: I9744b299d3ec474d72b298b4f6143f95e345d1d9 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625991 > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#61778} > > TBR: szuend@chromium.org, sigurds@chromium.org > Bug: v8:7793 > Change-Id: Ifa1958e4d6e850ba27632aa95c7efaf5ca4bfefa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627970 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61807} Bug: v8:7793 Change-Id: Ia403f1b784500c0903172f13e74c0b325e82599f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627980Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:958717 Change-Id: Ib0f12cc7ec9cca12c7859bf838e536fb330c5e9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627537 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This adds optimizations that apply the reductions (x + Int32Constant(a)) + Int32Constant(b)) => x + Int32Constant(a + b) (x + Int64Constant(a)) + Int64Constant(b)) => x + Int64Constant(a + b) to the TurboFan graph. This helps reducing awkward sequences like leaq r12,[r9*8+0x8] movq r12,[rbx+r12*1-0x1] to movq r12,[rax+r9*8+0x7] Change-Id: Iaa3a1cb9136a3f905ba33c62e16c3cb3c117605c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627544 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Also adding a pair of valid compress/decompress that was missing. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, chromium:963759 Change-Id: I668c26e636996e1c7621a23743df33b73e18ae89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624787 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
