- 01 Jun, 2022 26 commits
-
-
Seth Brenith authored
This is a partial reland of https://crrev.com/c/3597106 including fixes from https://crrev.com/c/3654413 Before this change, a script cache key is the same format as an eval cache key, which is a FixedArray containing: - The SharedFunctionInfo of the containing function - The source text - The language mode in which the code was parsed - The position in the source where eval was called After this change, a script cache key is a WeakFixedArray containing: - A weak pointer to the Script - The hash value of the source text This sets up for a subsequent change which can cause these keys to outlive their corresponding values (top-level SharedFunctionInfos) without leaking any memory beyond the key itself. Bug: v8:12808 Change-Id: Ibdfe5d10eafe5b7392e554c500af47975baf45c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668304Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#80899}
-
Marja Hölttä authored
The OOB check belongs in ValidateIntegerTypedArray according to the spec. This also fixes the error types for OOB TypedArrays when doing Atomics: OOB TypedArrays should get a TypeError, not RangeError. Bug: v8:11111 Change-Id: Ice2e5695d69d84b2c20a4cf8f06880673d901a91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676859 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80898}
-
Maya Lekova authored
This CL addresses a TODO left from implementing Wasm entry to fast C calls in https://chromium-review.googlesource.com/c/v8/v8/+/3440694/ and avoids generating a branch in case it's not needed (either because the embedder isn't providing an options object, which is the case for Wasm, or because we're not generating overloads). Bug: chromium:1052746 Change-Id: I7323f85801c034f0c47877ea15f677a53d3acea3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650923 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80897}
-
Shu-yu Guo authored
IsCompiledScope retains code to protect against code flushing. The current API is easily misused by forgetting to initialize IsCompiledScope with a SFI's current state. Change-Id: Ie8ab60acc4fb85c4b8b76c52040976e2e34f9d5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3674117Reviewed-by:
-
Leszek Swirski authored
Some parses are actually re-parses of an already parsed function; things like source position collection, CallPrinter AST walks, debugger, etc. These may want slightly different parse behaviour -- in particular, we likely don't want to post parallel compile tasks for them. So, keep track externally of which parses are reparses, and suppress parallel compile tasks for them. Change-Id: I8b38caad1a385e08231bd247774e9804a409de0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291317Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80895}
-
Omer Katz authored
MinorMC only used a single color (grey) while the full MC used 2 colors (grey and black). Update MinorMC to use black as well. This aligns and brings full MC and MinorMC closer, and allows to reuse more of the existing sweeping infrastructure for the non-moving MinorMC. Bug: v8:12612 Change-Id: Ifa740537c4587dc197196e41829ea74a312b79d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683320Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80894}
-
Clemens Backes authored
The fuzzers sometimes fail to instantiate a module that we already instantiated before. This is nondetermistic and hard to reproduce (maybe an out-of-memory situation). Make the fuzzers print the error message so we learn more about those failures. R=ahaas@chromium.org Bug: chromium:1330572 Change-Id: I0db103bdb113b1c1cedf662e02fb7a7f9d34ebd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3680298 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80893}
-
Marja Hölttä authored
This time without stray changes. Previous version: https://chromium-review.googlesource.com/c/v8/v8/+/3657431 Bug: v8:11111 Change-Id: I365224040c2d1b490a8d92513b9e73027bf8bb0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683609Reviewed-by:
-
Leszek Swirski authored
Bug: v8:12781 Change-Id: I1cf929e1d817ba81d25ba5095872b975c13f40d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683319 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80891}
-
Clemens Backes authored
The last line of output (which is not terminated by a newline) was not showing for me when running the merge script. We can either fix it by specifying `flush=True` at the `print` statement, or flushing before reading user input. The latter seems more future-proof. R=machenbach@chromium.org Change-Id: I61cb929d2f7cdd20b3e32b9beb1653fe2d5c5791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676857Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80890}
-
jameslahm authored
... flag-definitions-unittest. Bug: v8:12781 Change-Id: I11cd6acc4d7c548773f013fcaf5a2de5b47d730b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3682879Reviewed-by:
-
Marja Hölttä authored
This reverts commit df73fd60. Reason for revert: Reverting before branch Original change's description: > Reland "[rab/gsab] Temporarily stage --harmony-rab-gsab to enable fuzzing" > > This reverts commit 24286b8e. > > Reason for revert: Re-staging the experimental flag for fuzzing > > Original change's description: > > Revert "[rab/gsab] Temporarily stage --harmony-rab-gsab to enable fuzzing" > > > > This reverts commit b8f88be0. > > > > Reason: disabling an experimental feature in release branch > > > > Bug: v8:11111,v8:12870 > > Change-Id: I6fbd6bdb318c0d25e69c04db208a0d5f2b9ebbd7 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647357 > > Auto-Submit: Marja Hölttä <marja@chromium.org> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80520} > > Bug: v8:11111,v8:12870 > Change-Id: I0a45ed5ce53010196949dda23773d152aa605846 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647836 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#80576} Bug: v8:11111,v8:12870 Change-Id: Ib32c1ba464dde7a5c8cc16f32680bad144bb4304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683358Reviewed-by:
Lutz Vahl <vahl@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80888}
-
Liviu Rau authored
Bringing test closer together Bug: v8:12785 Change-Id: I2eed79fd3b1bda210b1f58b341422fc0c6435bfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3678210Reviewed-by:
-
Pan, Tao authored
The removing the optimized OSR code logic depends on collecting the reference of the optimized OSR code in ic. Bug: chromium:1330405, chromium:1330452, chromium:1330454, chromium:1330486, chromium:1330545 Change-Id: I0981a6b2f41bd7f90b74a1866c91d6eb35c5c591 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679846Reviewed-by:
-
Danil Somsikov authored
Bug: chromium:1290236 Change-Id: Ie8cda6fd6260d30d3107d3b0288e01960b0e2d3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677293 Auto-Submit: Danil Somsikov <dsv@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#80885}
-
Camillo Bruni authored
List all variants for the --variant help text Change-Id: I249d8140b19e13dc3eceedaade2b856b1fdb1567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663088Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80884}
-
Liviu Rau authored
Unused imports and some deprecation related updates. Bug: v8:12785 Change-Id: Ia3998a75f0c3b83eef4134741c1bda5f3d49c6f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3678840Reviewed-by:
-
jameslahm authored
... managed-unittest. Bug: v8:12781 Change-Id: Ic9dea14ffd0f8ca944c39d791c2b66aa1f76bcfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3682881Reviewed-by:
-
jameslahm authored
... threads-unittest. Bug: v8:12781 Change-Id: I1294d0bf9f47c158532a489657bc1e5349afce79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3682882Reviewed-by:
-
jameslahm authored
... hashmap-unittest. Bug: v8:12781 Change-Id: Id2d4c1d41540791e4c32919d4da4648565ac9faf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3682880Reviewed-by:
-
Leszek Swirski authored
When injecting locations for block-end gap moves into Phis, make sure to maintain register frame state too, so that the subsequent MergeRegisterValues call sees the result of these moves. Bug: v8:7700 Change-Id: I4f68e386c5a6cc578d26904306cb9b0c2f7a90d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676861 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Add a method which optionally merges dead fallthrough paths, in case the iteration in EmitUnconditionalDeopt reaches a merge point that is live from another jump but dead on the fallthrough. Bug: v8:7700 Change-Id: Ie505cd5356fcf70208f2f6d3e52b805956485f74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663086 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Unlike other spaces we didn't update external bytes counters when adding or removing pages from large spaces. Bug: chromium:1329766 Change-Id: I5fbc8703964f9e4e846d986c32c5d57ed4f0c0c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3681118 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80877}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b2f1ec8..fb6ee35 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/a5fa465..8b16338 Rolling v8/buildtools/linux64: git_revision:c547ca1497e3ff0dcbc0b2cb036b3d40380cbeeb..git_revision:37baefb026b199605affa7bcb24810d1724ce373 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/79a2e92..b126981 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4ad92ec..c30c515 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/d03f56b..5e737be Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a1cf7a2..fba169d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4e6aa25..e1197f0 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220522.3.1..version:8.20220531.3.1 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/80b28c9..64bbf98 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6df1876..393c871 Rolling v8/tools/luci-go: git_revision:0ef9351a5b73943d547fb27d463d5f4a1572727f..git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7 Rolling v8/tools/luci-go: git_revision:0ef9351a5b73943d547fb27d463d5f4a1572727f..git_revision:de014227dd270df7c61bfab740eb4ae4b52ac2a7 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I350575968cfc4adfe6d6785146735d83debfa0a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3682481 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80876}
-
Shu-yu Guo authored
This is a reland of commit ea9a1f1c Changes since revert: - Make the state field uintptr-aligned since arm64 faults on atomic accesses to non-naturally aligned addresses. Original change's description: > [shared-struct] Add Atomics.Mutex > > This CL adds a moving GC-safe, JS-exposed mutex behind the > --harmony-struct flag. It uses a ParkingLot-inspired algorithm and > each mutex manages its own waiter queue. > > For more details, please see the design doc: https://docs.google.com/document/d/1QHkmiTF770GKxtoP-VQ1eKF42MpedLUeqiQPfCqus0Y/edit?usp=sharing > > Bug: v8:12547 > Change-Id: Ic58f8750d2e14ecd573173d17d5235a136bedef9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595460 > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80789} Bug: v8:12547 Change-Id: I776cbf6ea860dcc6cb0ac51694a9b584b53d255c Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673354Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80875}
-
Shu-yu Guo authored
Bug: v8:12764 Change-Id: I67b9b0e4f3c7ca6a2719c234b7f7605f07f86b28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671760Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
- 31 May, 2022 14 commits
-
-
Milad Fa authored
Port: a77dd89e Bug: v8:5210, chromium:1269989, chromium:1313647 Change-Id: I91cb97d7d807c70939a8da4b80386d5aed5f3c8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677453 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80873}
-
Andreas Haas authored
When async compilation finishes for WebAssembly, the promise returned by `WebAssembly.compile()` gets resolved. Resolving the promise creates a microtask that should get executed automatically when the call stack empties up when MicrotasksPolicy::kAuto is used. However, this policy requires a CallDepthScope to work, but there is no CallDepthScope when WebAssembly compilation finishes. This CL adds this CallDepthScope. R=jkummerow@chromium.org Bug: chromium:1297672 Change-Id: I1bd607dec9daf08b3dbb1294393a8af255d222ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679579 Auto-Submit: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Milad Fa authored
Modification is needed since after this CL: https://crrev.com/c/3676642 Bug: v8:12781 Change-Id: Icb2644c9cd6f20e37c4b0ba0c4b861417c84b7f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679980Reviewed-by:
-
Joyee Cheung authored
This reverts commit 07e11a64. Reason for revert: caused regressions and heap verification failures Bug: chromium:1330410, chromium:1330408, chromium:1330413 Original change's description: > [heap] pre-populate the single_character_string_cache > > This simplifies the code and removes the runtime overhead of > spontaneously adding strings to the cache. > > Bug: v8:12718 > Change-Id: I2ed49bd82e3baf2563eeb8f463be72c0308c52c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616553 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Cr-Commit-Position: refs/heads/main@{#80803} Bug: v8:12718 Change-Id: I569fea9e34effd57c9e7c65190cf5b4ec0b0623b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679680 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Nikolaos Papaspyrou authored
This CL introduces the following changes to the experimental implementation of the object start bitmap, that is evaluated as a mechanism for resolving inner pointers (behind the flag v8_enable_conservative_stack_scanning): - Manually iterate through page objects, instead of using the PagedSpaceObjectIterator, for performance (avoid calling MakeHeapIterable all the time) and to simplify the handling of filler objects. - Clear bits when reusing evacuated pages of the new space. - Use the cage base to iterate correctly through code objects. - Introduce a method for verifying the validity of the object start bitmap. - Minor fixes, additional checks and cleanup. Bug: v8:12851 Change-Id: I245937ffe6f4b53c4c2dcf5126e8836aec4dc79e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675099Reviewed-by:
-
Leszek Swirski authored
Fixed: chromium:1330584 Change-Id: I8ae7942226350e52419e42fc46cb157bd480d102 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3680301 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80868}
-
Clemens Backes authored
Remove code size and compilation time sampling for the "top tier finished" event. With dynamic tiering, this event will never be reached. R=ahaas@chromium.org Bug: v8:12899 Change-Id: I1b0d053e31fe8cd1f8ba3b23bfff4c5879569b45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647691Reviewed-by:
-
Leszek Swirski authored
This is a reland of commit 3b251deb Annotates the perfetto proto include with nogncheck, because gn's header checker doesn't understand preprocessor directives. See https://gn.googlesource.com/gn/+/main/docs/reference.md#advice-on-fixing-problems Original change's description: > Reland "[test] Move tracing cctest to unittests" > > This is a reland of a7d6bf96 > > Added perfetto to unittests include_rules. > > Bug: v8:12781 > Change-Id: Iabf0e62abb1de879de21ba06fbd38f5432ee4f76 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652295 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80847} Bug: v8:12781 Change-Id: I886df9254d8fecd56f64110f04b1447937605b58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3680299 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Backes authored
The macro list makes it difficult to impossible to deprecate individual methods (like the one receiving a {WasmModuleTieredUp} struct). Hence avoid the macro list and instead call the macro explicitly for each definition. R=cbruni@chromium.org Bug: v8:12899 Change-Id: I4139de7721c4a1450920c5be312e91e7478e6fa7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667076Reviewed-by: -
Danil Somsikov authored
Bug: chromium:1240663 Change-Id: I133e3de012b08666c767478b8ad6fd7bf7c0fa35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679098Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Danil Somsikov <dsv@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#80864}
-
Clark DuVall authored
This will be useful for implementing crbug.com/1328448. Bug: v8:12916 Change-Id: Id22ae96f6c1f9b72ab09508dd1f6dc2d70f8b5d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677654 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Patrick Thier authored
Add a new late escape analysis pass to JS late optimizations. The new pass simply removes allocations that are not used (besides initializing stores to the object). Bug: v8:12200 Change-Id: I01fc6233cca2f369c77ff2116ed7c4da1a232d95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677298 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: Ia6f542104887624d80eebd309f16b7da94159fc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679978Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80861}
-
Dominik Inführ authored
After AssertNoTypedSlotsInFreeMemory being a CHECK for some time now to get more test coverage, turn this into a DCHECK again. This CL also renames the methods used by the sweeper to clear typed slots in free memory. It was previously called "invalid slots" but IMHO that could be a bit misleading, since this isn't about object slot invalidation (where we also filter slots) but only really about slots in free memory. Bug: v8:12760 Change-Id: I8f414be06207460531fa54189b9ef1be85f4ecb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679578Reviewed-by:
-
