- 04 Jan, 2018 7 commits
-
-
Clemens Hammacher authored
This adds support for get_local and set_local to the wasm compile fuzzer. Each function will have between 0 and 32 locals of random type. For set_local, we generate a value of the respective type and store it in the local. For get_local, we load any local and convert it to the wanted type. Note that with get_local, we now also check that parameters are passed correctly between functions. Drive-by: Fix parameters passed to the main function (was [1,2,3] for the interpreter, but [1,1,1] for compiled code). R=ahaas@chromium.org, eholk@chromium.org Change-Id: I38e85fe25b1fb4ac298fa81ec8e33711294e78bb Reviewed-on: https://chromium-review.googlesource.com/847535Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50355}
-
Sigurd Schneider authored
These checks seem to be redundant, since the relevant information of both Array.prototype and Object.prototype is already guarded by the NoElements protector, which guarantees no indexed data and accessor properties. Bug: v8:7127, v8:7205 Change-Id: I0785c31670c04a3db29eefdc2f75cc63971fed3b Reviewed-on: https://chromium-review.googlesource.com/848780 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50354}
-
Sigurd Schneider authored
This removes a stability check from CanInlineArrayResizeOperation. This is safe, since all prototype maps are either stable or in dictionary mode, where the latter is ruled out separately. Bug: v8:7127, v8:7205 Change-Id: I3a07805cb89f41adf031c6c2a6dd5b2defcb87a8 Reviewed-on: https://chromium-review.googlesource.com/848778 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7127, v8:7205 Change-Id: I9c4af8b604845861f4e29b872cc516fdeb89b519 Reviewed-on: https://chromium-review.googlesource.com/848999Reviewed-by:
-
Mostyn Bramley-Moore authored
Bug: v8:7127, v8:7204, v8:7205 Change-Id: Iedea388590991e4d0edcf59e02c767b6c04460e7 Reviewed-on: https://chromium-review.googlesource.com/849216Reviewed-by:
-
Michael Achenbach authored
This reverts commit 1685b5d2. Reason for revert: Was probably caused by infra change: https://crrev.com/c/845781 Original change's description: > Revert "[test] Move has unexpected output to outproc." > > This reverts commit 71605b3e. > > Reason for revert: Seems to break static-initializers step: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156 > > Original change's description: > > [test] Move has unexpected output to outproc. > > > > Expected outcomes optimized to serialize [PASS] as None. > > > > Keeping expected outcomes inside output processors should be > > optimized in the future. Few possible optimizations: > > - separate classes for tests that are expected to PASS - done as > > an example in mozilla test suite. > > - cache output processors inside testcase. > > - share output processors between copies of the same test - needs > > some updates to the create_variant to update outproc only if > > expected outcomes changed. > > > > Bug: v8:6917 > > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9 > > Reviewed-on: https://chromium-review.googlesource.com/843025 > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#50347} > > TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com > > Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:6917 > Reviewed-on: https://chromium-review.googlesource.com/849572 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50348} TBR=bbudge@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: I7a522b6487de6e96985d223524533493eb9171f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/848975Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50350}
-
Tobias Tebbi authored
The missing regression test for https://chromium-review.googlesource.com/c/v8/v8/+/847011 Bug: chromium:796041 Change-Id: I3d791d6485221d2fa68def2c7be96c48822aa651 Reviewed-on: https://chromium-review.googlesource.com/848995Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#50349}
-
- 03 Jan, 2018 16 commits
-
-
Bill Budge authored
This reverts commit 71605b3e. Reason for revert: Seems to break static-initializers step: https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156 Original change's description: > [test] Move has unexpected output to outproc. > > Expected outcomes optimized to serialize [PASS] as None. > > Keeping expected outcomes inside output processors should be > optimized in the future. Few possible optimizations: > - separate classes for tests that are expected to PASS - done as > an example in mozilla test suite. > - cache output processors inside testcase. > - share output processors between copies of the same test - needs > some updates to the create_variant to update outproc only if > expected outcomes changed. > > Bug: v8:6917 > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9 > Reviewed-on: https://chromium-review.googlesource.com/843025 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50347} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/849572Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#50348}
-
Michal Majewski authored
Expected outcomes optimized to serialize [PASS] as None. Keeping expected outcomes inside output processors should be optimized in the future. Few possible optimizations: - separate classes for tests that are expected to PASS - done as an example in mozilla test suite. - cache output processors inside testcase. - share output processors between copies of the same test - needs some updates to the create_variant to update outproc only if expected outcomes changed. Bug: v8:6917 Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9 Reviewed-on: https://chromium-review.googlesource.com/843025 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This seperates OS-specific code of the Command class into a Posix and a WindowsCommand to simplify scattered OS checks. This also removes some temporary mac debug output that's obsolete after https://crbug.com/v8/6927 got resolved. TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: Iaab3b527ce556dfba797a164ae58e8dd358eb56f Reviewed-on: https://chromium-review.googlesource.com/847000Reviewed-by:
-
Michael Achenbach authored
This reverts commit ce8f5141. Reason for revert: Changes a layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/20693 Original change's description: > Skip Execution::Call in CompileFunctionInContext. > > We execute the top-level function only to get to the wrapped function. > We could do the same by simply instantiating it. > > Other approaches would change the parser so that the top-level function > is the wrapped function. However, that change violates existing scoping > invariants and fixing it would add a lot more complexity to the parser. > > R=adamk@chromium.org, marja@chromium.org > > Bug: v8:7172 > Change-Id: I7272b8b58fc739d47a44da3a9d4a914af3e8cf3d > Reviewed-on: https://chromium-review.googlesource.com/836367 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50333} TBR=adamk@chromium.org,marja@chromium.org,yangguo@chromium.org Change-Id: I922fdd2410512d837705263e092a09e041b9d28f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7172 Reviewed-on: https://chromium-review.googlesource.com/849215Reviewed-by:
-
Michael Achenbach authored
This replaces multiprocessing with threading in tests to make python coverage work. TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: Idff763dfefa4a7fc782133d94089b3a5b00a194d Reviewed-on: https://chromium-review.googlesource.com/844735Reviewed-by:
-
Michael Achenbach authored
The tests already run on upload and commit. This makes them run on the corresponding continuous tester. NOTRY=true TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: I7dedd482ea54f0879854055c97b27f825f06d6e2 Reviewed-on: https://chromium-review.googlesource.com/846807Reviewed-by:
-
Sigurd Schneider authored
This should improve performance in cases where receiver or argument types are unknown. Bug: v8:7127, v8:7092 Change-Id: I72f1fcdc088bc817c1cc42bf27ecee91965b7680 Reviewed-on: https://chromium-review.googlesource.com/846761Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7127, v8:7204, v8:7205 Change-Id: I05d6bc2e20e29eaa683ad3aa94af24a4309bcdc7 Reviewed-on: https://chromium-review.googlesource.com/847484Reviewed-by:
-
Tobias Tebbi authored
DeadValue was a constant node of type None. This is unsound in the presence of re-scheduling. This CL adds a value input to DeadValue, which preserves the dependency on the original node of type None. Bug: chromium:796041 Change-Id: I3ac459bf661fb78c56552e8201aa18a7dbc4d182 Reviewed-on: https://chromium-review.googlesource.com/847011 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Franziska Hinkelmann authored
Use the script name from the shared function info to create an inline entry. Otherwise functions are attributed to the wrong file in the CpuProfileNode. See https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs/issues/89 Bug: v8:7203, v8:7241 Change-Id: I8ea31943741770e6611275a9c93375922b934547 Reviewed-on: https://chromium-review.googlesource.com/848093Reviewed-by:
-
Mike Stanton authored
This code is highly repetitive, and while we've held off on large refactorings (using "Builder" classes, templates or macros), it's useful to find a few common points that don't change very much. Bug: Change-Id: Ib0880558cf667f5d07c8343328461609ccb1e6b1 Reviewed-on: https://chromium-review.googlesource.com/848913Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50338}
-
Sigurd Schneider authored
Bug: v8:7127, v8:7204, v8:7205 Change-Id: Idd3c11dc92fbd2c7ccab3aece7b2ad189619fc2c Reviewed-on: https://chromium-review.googlesource.com/833916Reviewed-by:
-
Mythri authored
Now that we have an API to request code cache, we want to decouple compilation from serialization. As a first step, we will add CompileEager option (used when we want to produce full code cache) and DeferredProduceCodeOption to NoCacheReason. This is so that we can properly bucket the compilation time and collect statistics about the cache behaviour. Once, blink and node start using the new API, we can remove the code to produce code cache from the compilation. Bug: chromium:783124 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I35dbb6b0af39940450d412ff75b769603398b2f6 Reviewed-on: https://chromium-review.googlesource.com/828977 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50336}
-
Benedikt Meurer authored
This allows TurboFan to inline API function calls with more than 7 parameters. It's now possible to inline API function calls with up to 127 parameters, which should be sufficiently large. Bug: chromium:794865 Change-Id: I974fed740cd3506d0b8d75ed922227364c51a1fb Reviewed-on: https://chromium-review.googlesource.com/848712Reviewed-by:
-
Sigurd Schneider authored
Rename FastArray{Push,Pop,Shift,Slice} to ArrayPrototype{Push,Pop,Shift,Slice}. Bug: v8:7127, v8:7204, v8:7205 Change-Id: I409fcb4b088f1acece7c6520690f419cad36e78c Reviewed-on: https://chromium-review.googlesource.com/846982Reviewed-by: -
Yang Guo authored
We execute the top-level function only to get to the wrapped function. We could do the same by simply instantiating it. Other approaches would change the parser so that the top-level function is the wrapped function. However, that change violates existing scoping invariants and fixing it would add a lot more complexity to the parser. R=adamk@chromium.org, marja@chromium.org Bug: v8:7172 Change-Id: I7272b8b58fc739d47a44da3a9d4a914af3e8cf3d Reviewed-on: https://chromium-review.googlesource.com/836367Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50333}
-
- 02 Jan, 2018 10 commits
-
-
Bill Budge authored
This reverts commit 2a8e1e4a. Reason for revert: Time outs were caused by infra issues. Original change's description: > Revert "[debugger] do not try to find saved context before DebugEvaluate::Local" > > This reverts commit ea7499df. > > Reason for revert: Speculative, but this CL seems correlated with a bunch of timeouts on Linux: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/19540 > > Original change's description: > > [debugger] do not try to find saved context before DebugEvaluate::Local > > > > Current implementation produces crashes since sometimes saved context > > is empty. It looks like we do not need to restore saved context since > > we do not set debug context as current, at least all tests are passed. > > > > R=yangguo@chromium.org > > > > Bug: chromium:797573,chromium:792838 > > Change-Id: I1271640f6a18cbaaecfa1e99ed9ac28e0dbbb1da > > Reviewed-on: https://chromium-review.googlesource.com/844979 > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#50327} > > TBR=yangguo@chromium.org,kozyatinskiy@chromium.org > > Change-Id: I543201698c96c9762c481c1f6012cc13cb712842 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:797573, chromium:792838 > Reviewed-on: https://chromium-review.googlesource.com/846205 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50331} TBR=bbudge@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I44e916c796b935c372ce418a3fad44aa25d6f863 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:797573, chromium:792838 Reviewed-on: https://chromium-review.googlesource.com/848132Reviewed-by:
-
Bill Budge authored
This reverts commit ea7499df. Reason for revert: Speculative, but this CL seems correlated with a bunch of timeouts on Linux: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/19540 Original change's description: > [debugger] do not try to find saved context before DebugEvaluate::Local > > Current implementation produces crashes since sometimes saved context > is empty. It looks like we do not need to restore saved context since > we do not set debug context as current, at least all tests are passed. > > R=yangguo@chromium.org > > Bug: chromium:797573,chromium:792838 > Change-Id: I1271640f6a18cbaaecfa1e99ed9ac28e0dbbb1da > Reviewed-on: https://chromium-review.googlesource.com/844979 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50327} TBR=yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I543201698c96c9762c481c1f6012cc13cb712842 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:797573, chromium:792838 Reviewed-on: https://chromium-review.googlesource.com/846205Reviewed-by:
-
Bill Budge authored
- Implements GetPageAllocator and OnCriticalMemoryPressure methods, delegating to the default platform, in preparation for switching over to these for handling memory management. Bug: chromium:756050 Change-Id: I66edb35ce2669ee9ffd53e82a63b598cc5b7f40c Reviewed-on: https://chromium-review.googlesource.com/845035 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Pierre Langlois authored
Bug: Change-Id: Ibd094c5f0fddba4932d3b87f4c27d6af4636217b Reviewed-on: https://chromium-review.googlesource.com/847374Reviewed-by:
-
Pierre Langlois authored
These classes were only used to implement checked loads. Bug: Change-Id: Icd3aa6f22ffe7a48e5bea98b0a44a58905788c80 Reviewed-on: https://chromium-review.googlesource.com/847578Reviewed-by:
-
Alexey Kozyatinskiy authored
Current implementation produces crashes since sometimes saved context is empty. It looks like we do not need to restore saved context since we do not set debug context as current, at least all tests are passed. R=yangguo@chromium.org Bug: chromium:797573,chromium:792838 Change-Id: I1271640f6a18cbaaecfa1e99ed9ac28e0dbbb1da Reviewed-on: https://chromium-review.googlesource.com/844979Reviewed-by:
-
Pierre Langlois authored
Extend the code-generator tests to cover AssembleMove and AssembleSwap with Simd128 registers and stack slots, for targets that support them. For this to work however, we need support for passing Simd128 stack parameters in TurboFan which this patch implements for Arm and x86. PPC and S390 both do not support the Simd128 representation and it appears MIPS and MIPS64's implementation of AssembleMove and AssembleSwap do not support it either. As per the design of the tests, the set of values to perform moves on are represented in a FixedArray of Smis (for kTagged) and HeapNumbers (for kFloat32 and kFloat64). They are converted to raw values for the moves to be performed on, to be then converted back into a FixedArray. For the kSimd128 representation, we represent values as a FixedArray of 4 Smis, each representing a lane. They are converted to a raw Simd128 vector using the `I32x4ReplaceLane` and `I32x4ExtractLane` operations. Finally, these tests need Simd128 variables mixed with the CodeStubAssembler which is not a use-case officially supported. And as a result, the `RecordWrite` stub does not guarantee to preserve Simd128 registers. To get around this, we have to be careful to skip write barriers when dealing with Simd128 parameters inside the "teardown" function, and we've had to move all allocations to the "setup" function. Thanks to this, we are able to catch bugs such as this one https://bugs.chromium.org/p/v8/issues/detail?id=6843. Bug: v8:6848 Change-Id: I8787d6339cdbfcd9356c5e8995925f0b45c562fa Reviewed-on: https://chromium-review.googlesource.com/728599 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
-
Franziska Hinkelmann authored
This reverts commit c500aa9f. Reason for revert: Breaks V8 Linux64 - gyp Original change's description: > [cpu-profiler] Fix script name when recording inlining info > > Use the script name from the shared function info to create an > inline entry. Otherwise functions are attributed to the wrong file > in the CpuProfileNode. > > See https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs/issues/89 > > > Bug: v8:7203, v8:7241 > Change-Id: I7a7524ad68a295efd35ef94295cd48f823376e07 > Reviewed-on: https://chromium-review.googlesource.com/845624 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50324} TBR=jarin@chromium.org,franzih@chromium.org Change-Id: I5876d24723bb6bd20854db91a579485b07313a69 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7203, v8:7241 Reviewed-on: https://chromium-review.googlesource.com/846771Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#50325}
-
Franziska Hinkelmann authored
Use the script name from the shared function info to create an inline entry. Otherwise functions are attributed to the wrong file in the CpuProfileNode. See https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs/issues/89 Bug: v8:7203, v8:7241 Change-Id: I7a7524ad68a295efd35ef94295cd48f823376e07 Reviewed-on: https://chromium-review.googlesource.com/845624Reviewed-by:
-
Clemens Hammacher authored
After https://crrev.com/c/832457, CheckedLoad is not being used any more. Thus, remove it from the TurboFan backend and from all tests. CheckedStore was already removed in https://crrev.com/c/822570. R=jarin@chromium.org CC=titzer@chromium.org, mstarzinger@chromium.org Change-Id: I2eeec2f4a9d0a10067db5cc25ec41366ae85e917 Reviewed-on: https://chromium-review.googlesource.com/832459 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
- 29 Dec, 2017 7 commits
-
-
Sigurd Schneider authored
Bug: v8:7127, v8:7092 Change-Id: Ib79c1cf5e65632b8701528799fe7df1d5407ad59 Reviewed-on: https://chromium-review.googlesource.com/846766 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50322}
-
Sigurd Schneider authored
Change-Id: I56dfa2a0ee6d953002ba9a86f25c142bc2262106 Reviewed-on: https://chromium-review.googlesource.com/846740 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by:
-
Mike Stanton authored
Bug: v8:1956 Change-Id: Iee1c6245832b786993ebd71b615cf4257c6bd0bb Reviewed-on: https://chromium-review.googlesource.com/758769 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Franziska Hinkelmann authored
Cleanup, delete unused struct. Bug: Change-Id: I4ea5e81d6d0711d7cf3fdd279f8b0d136bcd6db3 Reviewed-on: https://chromium-review.googlesource.com/846760 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Update notion of compatibility used in redundancy elimination to determine whether one check subsumes another check to ignore the feedback on the operator. Bug: v8:7127 Change-Id: I77ab8a64adcd2b36ee7eafbe6cc148ddbc430b11 Reviewed-on: https://chromium-review.googlesource.com/839441 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Mike Stanton authored
Bug: v8:1956 Change-Id: Iae150730eb230dd7c90c66941d4d6aa8f0f0a423 Reviewed-on: https://chromium-review.googlesource.com/845685Reviewed-by:
-
Sigurd Schneider authored
This also fixes benchmark scores for String.prototype.indexOf Bug: v8:7127, v8:7092 Change-Id: Iee0f9689feb5923b300e253c267a6f32ffd4da20 Reviewed-on: https://chromium-review.googlesource.com/846739Reviewed-by:
-
