- 10 Oct, 2016 1 commit
-
-
petermarshall authored
Also add a test for when the first argument is null or undefined, as there are no tests that cover this currently. BUG=v8:5364 Review-Url: https://codereview.chromium.org/2399423003 Cr-Commit-Position: refs/heads/master@{#40127}
-
- 07 Mar, 2016 1 commit
-
-
littledan authored
The ES2015 specification requires that String.prototype.startsWith, String.prototype.endsWith and String.prototype.includes use the IsRegExp internal algorithm to determine whether to throw a TypeError to prevent a RegExp from being accidentally cast to a String for those methods. That internal algorithm checks the presence/truthiness of Symbol.match to make its determination. This patch switches the builtins to use this correct test, rather than checking for the [[RegExpMatcher]] internal slot as the builtins previously did. R=yangguo Review URL: https://codereview.chromium.org/1762183002 Cr-Commit-Position: refs/heads/master@{#34547}
-
- 20 Mar, 2015 1 commit
-
-
dslomov authored
String functions are shipping since 4.1/Chrome M41, it is time to unflag. R=yanngguo@chromium.org,rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1024813002 Cr-Commit-Position: refs/heads/master@{#27337}
-
- 20 Nov, 2014 3 commits
-
-
dslomov authored
Per TC39 Nov 2014 decison. R=arv@chromium.org,yangguo@chromium.org LOG=Y Committed: https://chromium.googlesource.com/v8/v8/+/b5379216e23ff0ec734e70361dd07057c2421c96 Review URL: https://codereview.chromium.org/742963002 Cr-Commit-Position: refs/heads/master@{#25448}
-
machenbach authored
Revert of Rename String.prototype.contains to 'includes'. (patchset #1 id:1 of https://codereview.chromium.org/742963002/) Reason for revert: Breaks test262-es6: http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/1289 Original issue's description: > Rename String.prototype.contains to 'includes'. > > Per TC39 Nov 2014 decison. > > R=arv@chromium.org,yangguo@chromium.org > LOG=Y > > Committed: https://chromium.googlesource.com/v8/v8/+/b5379216e23ff0ec734e70361dd07057c2421c96 TBR=arv@chromium.org,yangguo@chromium.org,dslomov@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/745543002 Cr-Commit-Position: refs/heads/master@{#25432}
-
dslomov authored
Per TC39 Nov 2014 decison. R=arv@chromium.org,yangguo@chromium.org LOG=Y Review URL: https://codereview.chromium.org/742963002 Cr-Commit-Position: refs/heads/master@{#25430}
-