- 20 Jan, 2017 2 commits
-
-
mtrofin authored
BUG= Review-Url: https://codereview.chromium.org/2644643009 Cr-Commit-Position: refs/heads/master@{#42528}
-
caitp authored
Flag is used by followup patches split apart from https://codereview.chromium.org/2622833002/, and tests for each split out CL ends up using Symbol.asyncIterator, so it makes sense to land it first (behind a flag). BUG=v8:5855 R=littledan@chromium.org, adamk@chromium.org Review-Url: https://codereview.chromium.org/2645923003 Cr-Commit-Position: refs/heads/master@{#42527}
-
- 19 Jan, 2017 38 commits
-
-
adamk authored
It's crashing in TurboFan after c70ec473 (a change to turn on some Intl features, which aren't possible TF-related). BUG=v8:5873 TBR=machenbach@chromium.org NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2638333006 Cr-Commit-Position: refs/heads/master@{#42526}
-
mlippautz authored
BUG=v8:5865 Review-Url: https://codereview.chromium.org/2640363003 Cr-Commit-Position: refs/heads/master@{#42525}
-
jshin authored
Update string-capitalize expected result because now it passes all the tests in the file. Mark fast/js/string-capitalization as failing with no_i18n. Relanding after revert because the failure was taken care of by Adam's CL at https://codereview.chromium.org/2597543002 . 3rd langing after a crash is taken care of in https://codereview.chromium.org/2621393002 In addition to the previous version of this CL (PS #4) that landed and reverted, drop String.prototype.to(Locale){Upper,Lower}Case from the whitelist of built-in functions for side-effect-free-debugging. BUG=v8:4477, v8:4476 TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case, intl/general/case* Cr-Original-Original-Commit-Position: refs/heads/master@{#41834} Committed: https://chromium.googlesource.com/v8/v8/+/7c79e23c34ea971947eedc6e42d8a882617c0e47 Review-Url: https://codereview.chromium.org/2588963002 Cr-Original-Commit-Position: refs/heads/master@{#41883} Committed: https://chromium.googlesource.com/v8/v8/+/a42c8c67dece5328896b13d37c5c846a2a0f5b0b Review-Url: https://codereview.chromium.org/2588963002 Cr-Commit-Position: refs/heads/master@{#42524}
-
krasin authored
Clang just got more strict about unused lambda captures, and that requires us to clean all places with this issue across all the Chromium code base. This CL fixes all such cases in V8. BUG=chromium:681136 Review-Url: https://codereview.chromium.org/2646553002 Cr-Commit-Position: refs/heads/master@{#42523}
-
bmeurer authored
The %ClassOf runtime function and %_ClassOf intrinsics always produce an internalized string, or Null for primitive inputs. BUG=v8:5267 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2646523004 Cr-Commit-Position: refs/heads/master@{#42522}
-
bmeurer authored
Right now running the Map and Set builtins with I+TF would tank seriously because these builtins are still built on top of a couple of classic intrinsics that TurboFan doesn't understand. Middle-term the idea is to replace the Map and Set builtins with a CodeStubAssembler based solution, but for that might not be ready in time, so adding support for a couple of the critical intrinsics to mitigate the tankage a bit, namely - %_JSCollectionGetTable, - %_TheHole, and - %_StringGetRawHashField. Together these double the score on most of the existing performance tests for collections. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2647733002 Cr-Commit-Position: refs/heads/master@{#42521}
-
jkummerow authored
- builtins-ic.cc takes the place of the AccessorAssembler shim - AccessorAssemblerImpl can then be renamed - some cleanup in code-factory.cc - drop old _TF name suffixes - fix Generate##Name##Impl in TF_BUILTIN macro Review-Url: https://codereview.chromium.org/2647493002 Cr-Commit-Position: refs/heads/master@{#42520}
-
mtrofin authored
Make wasm code generation (including deserialization) aware of allow_codegen_callback - if one were set by the host - akin to what we do for `eval`. This allows web pages that opt out of unsafe-eval to also opt out of wasm scenarios. BUG=v8:5869 Review-Url: https://codereview.chromium.org/2646713002 Cr-Commit-Position: refs/heads/master@{#42519}
-
cbruni authored
Review-Url: https://codereview.chromium.org/2645673004 Cr-Commit-Position: refs/heads/master@{#42518}
-
mvstanton authored
GC performance issues need to be addressed first. TBR=bmeurer@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org BUG=v8:5456 Review-Url: https://codereview.chromium.org/2642743002 Cr-Original-Commit-Position: refs/heads/master@{#42495} Committed: https://chromium.googlesource.com/v8/v8/+/7803aa1ffb2f835c5f317ed2a097390d53e52567 Review-Url: https://codereview.chromium.org/2642743002 Cr-Commit-Position: refs/heads/master@{#42517}
-
mstarzinger authored
This uses the aforementioned helper within the {FastAccessorAssembler}. It was made available as a helper function now that several users create code objects following {kCallJSFunction} linkage via the {CodeAssembler}. R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2644033003 Cr-Commit-Position: refs/heads/master@{#42516}
-
rmcilroy authored
Review-Url: https://codereview.chromium.org/2644743003 Cr-Commit-Position: refs/heads/master@{#42515}
-
ahaas authored
Revert of [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32. (patchset #3 id:40001 of https://codereview.chromium.org/2639353002/ ) Reason for revert: compilation problems on mips Original issue's description: > [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32. > > On ia32 return statements in C++ automatically convert signalling NaNs > to quiet NaNs, even when bit_cast is used. This CL removes all uses of > bit_cast<float> and bit_cast<double> in the wasm compiler and wasm > interpreter. > > R=titzer@chromium.org, clemensh@chromium.org > > Review-Url: https://codereview.chromium.org/2639353002 > Cr-Commit-Position: refs/heads/master@{#42512} > Committed: https://chromium.googlesource.com/v8/v8/+/7739affa5b57e0d28674d476f63de60d71728fb6 TBR=clemensh@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2645693003 Cr-Commit-Position: refs/heads/master@{#42514}
-
jbroman authored
Also update a call in cctest to check the result. BUG=chromium:681843 Review-Url: https://codereview.chromium.org/2647573003 Cr-Commit-Position: refs/heads/master@{#42513}
-
ahaas authored
On ia32 return statements in C++ automatically convert signalling NaNs to quiet NaNs, even when bit_cast is used. This CL removes all uses of bit_cast<float> and bit_cast<double> in the wasm compiler and wasm interpreter. R=titzer@chromium.org, clemensh@chromium.org Review-Url: https://codereview.chromium.org/2639353002 Cr-Commit-Position: refs/heads/master@{#42512}
-
jbroman authored
This API does not allow reporting failure, but we should crash rather than have the caller get an ArrayBuffer that isn't properly set up. BUG=chromium:681843 Review-Url: https://codereview.chromium.org/2641953002 Cr-Commit-Position: refs/heads/master@{#42511}
-
jbroman authored
BUG=chromium:681843 Review-Url: https://codereview.chromium.org/2645673002 Cr-Commit-Position: refs/heads/master@{#42510}
-
machenbach authored
Broke after https://codereview.chromium.org/2621983002 BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2644113002 Cr-Commit-Position: refs/heads/master@{#42509}
-
jgruber authored
BUG=v8:5639 Review-Url: https://codereview.chromium.org/2638073002 Cr-Commit-Position: refs/heads/master@{#42508}
-
jkummerow authored
Issue was fixed in 38088853, re-enabling test. BUG=v8:5829 NOTRY=true Review-Url: https://codereview.chromium.org/2643043002 Cr-Commit-Position: refs/heads/master@{#42507}
-
mlippautz authored
BUG=679724 Review-Url: https://codereview.chromium.org/2631063003 Cr-Commit-Position: refs/heads/master@{#42506}
-
clemensh authored
Document that frame summaries are bottom-to-top, i.e. caller before callee, rename FrameSummary::GetFirst to FrameSummary::GetBottom and introduce FrameSummary::GetTop. For debugged JavaScript frames, it does not really matter which of the functions we call, so I replaced a few GetFirst by GetTop instead of GetBottom because it matches the semantics more closely. This CL also reverts part of http://crrev.com/2621953002 by changing BreakLocation::FromFrame back to accept a DebugInfo and a JavaScriptFrame. We don't plan to create BreakLocations for wasm. R=yangguo@chromium.org BUG=v8:5822 Review-Url: https://codereview.chromium.org/2647433002 Cr-Commit-Position: refs/heads/master@{#42505}
-
Michael Hablich authored
TBR=machenbach@chromium.org, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2641003003 . Cr-Commit-Position: refs/heads/master@{#42504}
-
jkummerow authored
using newly introduced ThinStrings, which store a pointer to the actual, internalized string they represent. BUG=v8:4520 (Previously landed as #42168 / af51befe) (Previously landed as #42193 / 4c699e34) (Previously landed as #42235 / ec45e6ed) Review-Url: https://codereview.chromium.org/2549773002 Cr-Commit-Position: refs/heads/master@{#42503}
-
titzer authored
R=rossberg@chromium.org BUG=chromium:682659 Review-Url: https://codereview.chromium.org/2638383004 Cr-Commit-Position: refs/heads/master@{#42502}
-
bmeurer authored
Properly recognize and optimize typeof in a strict/abstract equality comparison with the string literal "object" to a check for Null or a check of the map for Receiver instance type and non-callable. Drive-by-fix: Also optimize typeof o === "function" somewhat, now that we have the new types for Callable and NonCallable. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2646763003 Cr-Commit-Position: refs/heads/master@{#42501}
-
bmeurer authored
Instead of doing the dance via JSStrictEqual for comparisons with null, undefined or the hole, we can just go to ReferenceEqual directly. Also avoid the Select(x, false, true) dance for negation and use BooleanNot directly. R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2646763004 Cr-Commit-Position: refs/heads/master@{#42500}
-
titzer authored
R=rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2640953002 Cr-Commit-Position: refs/heads/master@{#42499}
-
ishell authored
BUG= Review-Url: https://codereview.chromium.org/2644843002 Cr-Commit-Position: refs/heads/master@{#42498}
-
ishell authored
Currently PropertyConstness is still in sync with PropertyLocation. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2591233002 Cr-Commit-Position: refs/heads/master@{#42497}
-
machenbach authored
Revert of Revert [TypeFeedbackVector] Root literal arrays in function literal slots (patchset #2 id:20001 of https://codereview.chromium.org/2642743002/ ) Reason for revert: Breaks nosnap: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/13802 Original issue's description: > Revert [TypeFeedbackVector] Root literal arrays in function literal slots > > GC performance issues need to be addressed first. > > TBR=bmeurer@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org > BUG=v8:5456 > > Review-Url: https://codereview.chromium.org/2642743002 > Cr-Commit-Position: refs/heads/master@{#42495} > Committed: https://chromium.googlesource.com/v8/v8/+/7803aa1ffb2f835c5f317ed2a097390d53e52567 TBR=mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5456 Review-Url: https://codereview.chromium.org/2642933003 Cr-Commit-Position: refs/heads/master@{#42496}
-
mvstanton authored
GC performance issues need to be addressed first. TBR=bmeurer@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org BUG=v8:5456 Review-Url: https://codereview.chromium.org/2642743002 Cr-Commit-Position: refs/heads/master@{#42495}
-
bmeurer authored
Especially support constant-folding typeof for detectable and undetectable receivers. BUG=v8:5267,v8:5270 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2646743002 Cr-Commit-Position: refs/heads/master@{#42494}
-
mstarzinger authored
This makes sure 32-bit constants that are used as {MachineType::Uint32} by the deoptimization translation are also interpreted as such when the literals are collected. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-681983 BUG=chromium:681983 Review-Url: https://codereview.chromium.org/2646463002 Cr-Commit-Position: refs/heads/master@{#42493}
-
jgruber authored
Just desugar directly into the runtime call instead. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2633353002 Cr-Commit-Position: refs/heads/master@{#42492}
-
machenbach authored
Revert of [test] Speculatively remove local-tests from archive (patchset #2 id:20001 of https://codereview.chromium.org/2643983002/ ) Reason for revert: Breaks all windows bots: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6811 Original issue's description: > [test] Remove local-tests from test262 archive and add to .isolate > > This might help fix the bots, which are broken in e.g., > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011 > > The archive was added in order to transmit test262 tests more rapidly. > It doesn't serve much of a purpose for local-tests. I naively added > local-tests there out of symmetry. However, the BUILD.gn file does not > regenerate an archive when files are only deleted and not added or > changed. Since the performance concern is not present for the small > volume of local-tests, this patch reverts to the more normal mechanism > for sending over dependencies, with test262.isolate. > > R=adamk > > Review-Url: https://codereview.chromium.org/2643983002 > Cr-Commit-Position: refs/heads/master@{#42485} > Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c3686a TBR=adamk@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2640223003 Cr-Commit-Position: refs/heads/master@{#42491}
-
neis authored
Since the script origin is part of the key used in the compilation cache, this ensures that the cache never confuses a module with a non-module script. BUG=v8:1569,v8:5685 Review-Url: https://codereview.chromium.org/2611643002 Cr-Commit-Position: refs/heads/master@{#42490}
-
bmeurer authored
When StringAdd builtin is used to concatenate two primitive values, we know that the operation might throw, but cannot trigger any other observable side effect, so it shouldn't flush the LoadElimination state. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2645523002 Cr-Commit-Position: refs/heads/master@{#42489}
-