Commits · 48a4780e9d6121b55924ace851c86ffee0c2a386 · Linshizhi / V8

05 Nov, 2020 16 commits

Reland "[wasm] Fix code offset after module cache hit" · 48a4780e

Thibaud Michaud authored Nov 05, 2020

This is a reland of c6c86944
The code offset is allowed to be null if there is no function in the module.

Original change's description:
> [wasm] Fix code offset after module cache hit
>
> If the module cache was hit, we didn't set the code offset in the
> decoded module. Hence it was reported as 0 to the DevTools frontend,
> leading to subsequent errors.
> Note that this error can only happen if multiple isolates share the same
> module, which we cannot easily test in v8. Sharing within a single
> isolate is implemented via the script cache, so we won't report another
> script via CDP.
>
> R=thibaudm@chromium.org
>
> Bug: chromium:1114143
> Change-Id: I3218a3b12cf5be09d685e3f371f858ab799cef80
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519560
> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
> Commit-Queue: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70967}

Bug: chromium:1114143
Change-Id: I4609cfc61fbd8b5092781dc9308f5651bcc76c42
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517695
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70991}

48a4780e

[log] Fix shared-library logging · 3fbc94f6

Camillo Bruni authored Nov 05, 2020

The setup order in the logger was slightly off and we skipped on writing
the log entries for the loaded shared-library. This causes a lot of unaccounted
ticks with the ticks-processor.

Bug: v8:11108
Change-Id: I260eb846da4cce0ead7cdb6e90fd0b02d3cd8eaa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517697Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70990}

3fbc94f6

[torque] allow exported classes with custom C++ class · 26f10ecd

Tobias Tebbi authored Nov 04, 2020

Introduce a new annotation @customCppClass that can be used for
non-extern @export classes, that is, generate everything, remove
boilerplate from all the internal lists and switches, but allow
a custom C++ class, which in turn also allows overwriting the generated
print and verify functions.

Port DescriptorArray and StrongDescriptorArray as an example.

Bug: v8:7793
Change-Id: I744e52fb4102ac49c0097f1c95bb17d301975bf0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2489687Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Seth Brenith <seth.brenith@microsoft.com>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70989}

26f10ecd

[super] Optimize super property access in JSNativeContextSpecialization · 0147db5a

Marja Hölttä authored Nov 05, 2020

Generalize the existing property lookup machinery
(JSNCS::ReduceNamedAccess) to handle the case where the
lookup_start_object and the receiver are different objects.

Design doc: https://docs.google.com/document/d/1b_wgtExmJDLb8206jpJol-g4vJAxPs1XjEx95hwRboI/edit#heading=h.xqthbgih7l2l

Bug: v8:9237
Change-Id: I28b6d87ce6537acd8cf972bbe7dc6d63d581aadc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487122
Commit-Queue: Marja Hölttä <marja@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70988}

0147db5a

[wasm-simd][arm64] Skip top 64-bit write in MOVI if identical. · 6ee68916

Pierre Langlois authored Oct 29, 2020

The MOVI instruction writes an immediate into every lane of a vector. In
order to support all immediates, we split it into two 64-bit
writes. However if the top and bottom 64 bits are identical, we can skip
the second write.

Bug: v8:11033
Change-Id: Idfb74471de815d278a84c78d204d534d19214b2c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507691Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
Cr-Commit-Position: refs/heads/master@{#70987}

6ee68916

[mac-arm64] Fix missing #include · 1d0f4263

Jakob Kummerow authored Nov 05, 2020

For an "#if defined(MAP_JIT)" test to work as expected, <sys/mman.h>
must be included in the compilation unit.

Bug: chromium:1144200
Change-Id: Ia0bf35ec1872c02457f1fbc0ee6689c7f7d27d4a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517689Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70986}

1d0f4263

[arm] Comply with hardfloat calling convention for double arguments. · 70c05ce8

Pierre Langlois authored Oct 29, 2020

The hardfloat calling convention reserves registers d0 to d7 for passing
double parameters, any parameters after that will be passed on the
stack.

We do not pass more than a couple of double parameters at a time when
calling C functions from generated code in V8, so this hasn't been an
issue but it could be in the future.

Change-Id: I44971ef0943894c201ddb908031ba9cf6fc0bc8e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507692Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
Cr-Commit-Position: refs/heads/master@{#70985}

70c05ce8

[inspector][test] Exit properly on internal errors · ff2993bb

Clemens Backes authored Nov 04, 2020

Calling {Exit} does not stop execution in the current thread (or
process), it just tells the two task runners to stop. Hence following
code would still be executed.
This CL replaces the calls to {Exit} to {FATAL} for internal errors
where we want to stop immediately.

R=szuend@chromium.org

Bug: chromium:1142437
Change-Id: I70c1c39da28a3cd040214d46eddf61f05a12bce7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519568Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70984}

ff2993bb

[compiler] Introduce --trace-code-dependencies · 77a77f05

Georg Neis authored Nov 04, 2020

This is helpful for debugging. At the moment it reports any
installations of code dependencies and, by implying
--trace-deopt-verbose, any deopts due to dependency changes.

Change-Id: I910a6dc165cc3586eaf7e5f322c90924359ae6ba
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519566
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70983}

77a77f05

Revert "[nci] Enable --turbo-nci behind --future to gather perf data" · 2dc17995

Jakob Gruber authored Nov 05, 2020

This reverts commit c3b2b64b.

Reason for revert: Scheduled revert.

The flag flip is in 88.0.4315.0. Group report links:

https://chromeperf.appspot.com/group_report?rev=70949
https://chromeperf.appspot.com/group_report?rev=823663

Original change's description:
> [nci] Enable --turbo-nci behind --future to gather perf data
>
> .. to be reverted in a day or two.
>
> Bug: v8:8888
> Change-Id: Iee156da614b50c351ca9a07cc497177c92de865d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512907
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Lutz Vahl <vahl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70949}

TBR=machenbach@chromium.org,jgruber@chromium.org,vahl@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:8888,v8:11087
Change-Id: I57411474d885dd69613a85f5fa3a801a573fcd08
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517690Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70982}

2dc17995

[turboprop] Refactor minimorphic-polymorphic dynamic map checks · 5f1a742e

Sathya Gunasekaran authored Nov 03, 2020

For minimorphic-polymorphic checks, instead of loading the feedback
vector in an inlined unrolled loop, just inline the maps present in
the feedback vector at compile time and call out to the builtin if
these map checks fail.

Change-Id: I4672bc2c774027935aa245382625b9aa64be1d10
Bug: v8:10582
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2460812Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70981}

5f1a742e

Revert "[mips] Remove arguments adaptor frame" · 4adc7c7f

Liu yu authored Nov 05, 2020

This reverts commit 7257dc93.

Reason for revert:
- New test fail on mips64el: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8864502401132417824/+/steps/Check/0/logs/modules-import-large/0

Original change's description:
> [mips] Remove arguments adaptor frame
>
> Port: 958d8e9f
>
> Bug: v8:10201
>
> Change-Id: I27d29f2a1f1d5f659d558b5fd776b88474d9b140
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2513867
> Auto-Submit: Liu yu <liuyu@loongson.cn>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70964}

TBR=jgruber@chromium.org,liuyu@loongson.cn

Change-Id: Iddca9684995409fb9a1f3340b3a1931b1b5b472b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:10201
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519189Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70980}

4adc7c7f

Revert "Update V8 DEPS." · 8ca481ed

Michael Achenbach authored Nov 05, 2020

This reverts commit 689fbbc2.

Reason for revert:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20builder/49553

Original change's description:
> Update V8 DEPS.
>
> Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/92c40db..01b3fe4
>
> Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/98881a1..b6526d9
>
> Rolling v8/buildtools/linux64: git_revision:f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc..git_revision:e002e68a48d1c82648eadde2f6aafa20d08c36f2
>
> Rolling v8/third_party/aemu-linux-x64: uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC..GcTt9uPsoI1ThLZlKalBAGZLijn8zwDw_BQtJwWpS08C
>
> Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/888c272..b8b4d61
>
> Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/655afeb..8ca189d
>
> Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1..e84c9a3
>
> Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4c43492..952382f
>
> Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
>
> Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
>
> Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
>
> TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
>
> Change-Id: If1d65d05063942b39f6986df8472d5ae6fd241c5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520379
> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#70978}

TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8cdb3536acd7757108c5ab2113a4afcbf027ef01
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517691Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70979}

8ca481ed

Update V8 DEPS. · 689fbbc2

v8-ci-autoroll-builder authored Nov 05, 2020

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/92c40db..01b3fe4

Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/98881a1..b6526d9

Rolling v8/buildtools/linux64: git_revision:f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc..git_revision:e002e68a48d1c82648eadde2f6aafa20d08c36f2

Rolling v8/third_party/aemu-linux-x64: uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC..GcTt9uPsoI1ThLZlKalBAGZLijn8zwDw_BQtJwWpS08C

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/888c272..b8b4d61

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/655afeb..8ca189d

Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1..e84c9a3

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4c43492..952382f

Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb

TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If1d65d05063942b39f6986df8472d5ae6fd241c5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520379Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#70978}

689fbbc2

[wasm-simd][x64] Optimize integer splats of constant 0 · 7d7b25d9

Zhi An Ng authored Nov 03, 2020

Integer splats (especially for sizes < 32-bits) does not directly
translate to a single instruction on x64. We can do better for special
values, like 0, which can be lowered to `xor dst dst`. We do this check
in the instruction selector, and emit a special opcode kX64S128Zero.

Also change the xor operation for kX64S128Zero from xorps to pxor. This
can help reduce any potential data bypass delay (search for this on
agner's microarchitecture manual for more details.). Since integer
splats are likely to be followed by integer ops, we should remain in the
integer domain, thus use pxor.

For i64x2.splat the codegen goes from:

  xorl rdi,rdi
  vmovq xmm0,rdi
  vmovddup xmm0,xmm0

to:

  vpxor xmm0,xmm0,xmm0

Also add a unittest to verify this optimization, and necessary
raw-assembler methods for the test.

Bug: v8:11093
Change-Id: I26b092032b6e672f1d5d26e35d79578ebe591cfe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516299Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70977}

7d7b25d9

Introduce Function::FunctionProtoToString() · 2ccd4dc5

Devlin Cronin authored Nov 02, 2020

Add a new function on the public API to allow serializing a function to
a string using the built-in toString() implementation, allowing
serialization without worrying about untrusted author script overriding
the toString() implementation. This is similar in nature to
Object::ObjectProtoToString() (but that only returns "[object Function]"
for any passed function).

Add tests for the same.

Bug: chromium:1144841
Change-Id: Ie4c29b870034c0817c23bf91f9424f956098823d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2514768Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70976}

2ccd4dc5

04 Nov, 2020 18 commits

PPC: [wasm-simd] Use P9 vector insert to implement ReplaceLane · a3e67fea

Milad Fa authored Nov 04, 2020

Power 9 offers new Vector Insert instructions which now can be used
to implement Replace Lane opcodes. Also changed the input
register to be the same as output.

Change-Id: Ie71b4d44bf715d2f619ee55144ef18e9e727ed9a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2518617Reviewed-by: Junliang Yan <junyan@redhat.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#70975}

a3e67fea

Revert "[wasm] Fix code offset after module cache hit" · d0c6deb4

Michael Achenbach authored Nov 04, 2020

This reverts commit c6c86944.

Reason for revert:
https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux%20Debug/6762
https://test-results.appspot.com/data/layout_results/V8_Blink_Linux_Debug/6762/blink_web_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html

Original change's description:
> [wasm] Fix code offset after module cache hit
>
> If the module cache was hit, we didn't set the code offset in the
> decoded module. Hence it was reported as 0 to the DevTools frontend,
> leading to subsequent errors.
> Note that this error can only happen if multiple isolates share the same
> module, which we cannot easily test in v8. Sharing within a single
> isolate is implemented via the script cache, so we won't report another
> script via CDP.
>
> R=thibaudm@chromium.org
>
> Bug: chromium:1114143
> Change-Id: I3218a3b12cf5be09d685e3f371f858ab799cef80
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519560
> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
> Commit-Queue: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70967}

TBR=clemensb@chromium.org,thibaudm@chromium.org

Change-Id: I61528d5000d703ce36ad2ba88cae043220f5f9f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1114143
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519569Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70974}

d0c6deb4

Reland "[x64][ia32] Add stack overflow check in InvokePrologue" · f383a923

Victor Gomes authored Nov 04, 2020

This is a reland of adceb459
Redesign test to not be OS dependent.

Original change's description:
> [x64][ia32] Add stack overflow check in InvokePrologue
>
> In case of no arguments adaptor frame, we massage the arguments in InvokePrologue pushing undefined objects if the actual argument count is below the parameter count. This CL adds a stack overflow check before pushing these undefined objects to the stack.
>
> Change-Id: I2a88bf6fdfd17958f6f6884143a67d50ea842fd2
> Bug: v8:10201
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2491039
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Commit-Queue: Victor Gomes <victorgomes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70927}

Bug: v8:10201
Change-Id: Ifab3413b748cdf3bb998a5080cd1fcb3b67a737b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517921Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70973}

f383a923

Update to ICU68-1 · b0a7f569

Frank Tang authored Nov 04, 2020

ICU68-1 change the output skeleton format. So we need to change
resolvedOptions code for 68 migration.

Chromium roll
https://chromium-review.googlesource.com/c/chromium/src/+/2474093

Bug: v8:10945
Change-Id: I3b2c7fbe8abb22df8fa51287c498ca3245b8c55b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477431
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70972}

b0a7f569

[deoptimizer] Fix define typo and inlined frame base · 18d79f90

Victor Gomes authored Nov 03, 2020

Change-Id: I81ace5b6abf883c80bea1fada94a66888b16745a
Bug: chromium:1144672, v8:10201
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512923Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70971}

18d79f90

[api] TC39 Dynamic Code Brand checks - rename for consistency. · 543e5633

Daniel Vogelheim authored Oct 30, 2020

Rename-only CL: Rename "code kind" to "code like".

The reason is CL feedback when using this feature, and a desire for
consistency across V8 + Blink. An additional benefit would be to
disambiguate from the v8::internal::CodeKind type, which is unrelated to
any of this.

Original CL: crrev.com/c/v8/v8/+/2339618
CL whose review prompted this change: crrev.com/c/2340905

Bug: chromium:1096017
Change-Id: Id59016fc2906ab6cd1414e598338b3963811b92f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509598Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70970}

543e5633

[tools] Port more tools to ES6 classes · a8eea879

Camillo Bruni authored Nov 03, 2020

Convert Profile, CodeMap and their helpers to ES6 classes.
Code cleanup will happen in a separate step.

Bug: v8:10667
Change-Id: Icfb28f6d9ef7f00efba93b347fdf210a9af36a49
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509591
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70969}

a8eea879

Disassociate runtime_deps from the stamp file · 73ed5430

Almothana Athamneh authored Nov 04, 2020

Bug: v8:11102
Change-Id: I40ce923a42097bf76a4b53c61bab1ef983523f64
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519557Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70968}

73ed5430

[wasm] Fix code offset after module cache hit · c6c86944

Clemens Backes authored Nov 04, 2020

If the module cache was hit, we didn't set the code offset in the
decoded module. Hence it was reported as 0 to the DevTools frontend,
leading to subsequent errors.
Note that this error can only happen if multiple isolates share the same
module, which we cannot easily test in v8. Sharing within a single
isolate is implemented via the script cache, so we won't report another
script via CDP.

R=thibaudm@chromium.org

Bug: chromium:1114143
Change-Id: I3218a3b12cf5be09d685e3f371f858ab799cef80
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519560Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70967}

c6c86944

[objects] Documentation, minor refactors in compilation cache · 93a8c4c9

Jakob Gruber authored Nov 04, 2020

The various compilation caches are tricky to understand. Hopefully
some addtl. documentation helps.

Bug: v8:8888
Change-Id: I20f2778b5548fcc38724aca600ccf770c240758d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516476
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70966}

93a8c4c9

[api] Add updated ScriptCompiler::StartStreaming API · 5ce10a0b

Camillo Bruni authored Oct 26, 2020

The new api removes the unused CompileOptions argument.

Change-Id: Ie3c48cda5247da9ce87d70a90b7ab9c43d5e8e37
Bug: chromium:1061857
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498698Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70965}

5ce10a0b

[mips] Remove arguments adaptor frame · 7257dc93

Liu Yu authored Nov 03, 2020

Port: 958d8e9f

Bug: v8:10201

Change-Id: I27d29f2a1f1d5f659d558b5fd776b88474d9b140
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2513867
Auto-Submit: Liu yu <liuyu@loongson.cn>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70964}

7257dc93

[regexp] Don't recognize the 'l' flag unless enabled · 0593cb72

Jakob Gruber authored Nov 03, 2020

.. by the runtime flag --enable-experimental-regexp-engine.

Introduced in https://chromium-review.googlesource.com/c/v8/v8/+/2461244

Tbr: neis@chromium.org
Bug: v8:10765
Change-Id: Ic32464ced7e5ddb4c31fe165eddb6b9d19260efc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516920
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70963}

0593cb72

[TurboFan] Concurrency test needs to accept that worker thread exits · 1ef2936a

Mike Stanton authored Nov 04, 2020

Timeouts occurred in test-concurrent-feedback-vector/CheckLoadICStates
because the main thread could enter "handshaking" mode precisely at
the moment when the worker thread successfully saw all states.
The main thread would miss this, and end up waiting forever on
a signal from the worker thread.

Bug: v8:11082
Change-Id: I0441785d908c5e27562a3620bb2195483727f118
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519553
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70962}

1ef2936a

Revert "[wasm-simd][x64] Optimize pmin/pmax and add horiz for AVX" · 4f4dda3f

Clemens Backes authored Nov 04, 2020

This reverts commit 3c4e434f.

Reason for revert: Fails noavx tests: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug/34613

Original change's description:
> [wasm-simd][x64] Optimize pmin/pmax and add horiz for AVX
>
> The AVX versions of these instructions can take 3 operands, so we don't
> need to force dst == src.
>
> Bug: v8:9561
> Change-Id: If346a05f7d599bf0d636263cafc3bc823c3b8452
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2515337
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Commit-Queue: Zhi An Ng <zhin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70958}

TBR=clemensb@chromium.org,zhin@chromium.org

Change-Id: I5fcdd2e51d418cb32a1b1e2bec7c0dff19f29154
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9561
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519558Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70961}

4f4dda3f

Revert "Update V8 DEPS." · ccce6f2a

Maya Lekova authored Nov 04, 2020

This reverts commit 6e780005.

Reason for revert: GN roll in v8/buildtools is causing an MB error - https://bugs.chromium.org/p/v8/issues/detail?id=11102

Original change's description:
> Update V8 DEPS.
>
> Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/92c40db..ef5fe70
>
> Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/98881a1..95fa84e
>
> Rolling v8/buildtools/linux64: git_revision:e002e68a48d1c82648eadde2f6aafa20d08c36f2..git_revision:f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc
>
> Rolling v8/third_party/aemu-linux-x64: uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC..QCu1udNpe84cj5K2ZaTcAwnDUyjm45HgGJgtnoFkp7gC
>
> Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/888c272..c5bd411
>
> Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/655afeb..5bdfcd8
>
> Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1..e84c9a3
>
> Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4c43492..c37ae57
>
> Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
>
> Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
>
> Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
>
> TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
>
> Change-Id: I2395c6577e023d2aa48cf15b1f88e0207bd3f381
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2518492
> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#70959}

TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2f86e73d2991a2d4617b67c6646d2e7b5a83b50b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2518672Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70960}

ccce6f2a

Update V8 DEPS. · 6e780005

v8-ci-autoroll-builder authored Nov 04, 2020

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/92c40db..ef5fe70

Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/98881a1..95fa84e

Rolling v8/buildtools/linux64: git_revision:e002e68a48d1c82648eadde2f6aafa20d08c36f2..git_revision:f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc

Rolling v8/third_party/aemu-linux-x64: uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC..QCu1udNpe84cj5K2ZaTcAwnDUyjm45HgGJgtnoFkp7gC

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/888c272..c5bd411

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/655afeb..5bdfcd8

Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1..e84c9a3

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4c43492..c37ae57

Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb

TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2395c6577e023d2aa48cf15b1f88e0207bd3f381
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2518492Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#70959}

6e780005

[wasm-simd][x64] Optimize pmin/pmax and add horiz for AVX · 3c4e434f

Zhi An Ng authored Nov 03, 2020

The AVX versions of these instructions can take 3 operands, so we don't
need to force dst == src.

Bug: v8:9561
Change-Id: If346a05f7d599bf0d636263cafc3bc823c3b8452
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2515337Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70958}

3c4e434f

03 Nov, 2020 6 commits

PPC: [wasm-simd] Saturate swizzle indices to 5 bits · 35ecf0cd

Milad Fa authored Nov 03, 2020

`vperm` indices are taken from the five least significant bits
of the input byte. We need to make sure bigger values
are saturated to 31 to make vperm select 0 as the output.

Change-Id: I27ad77684b99f32a7fd7f690dec0b127be3ad9e7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2518343Reviewed-by: Junliang Yan <junyan@redhat.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#70957}

35ecf0cd

[flags] Remove --harmony-promise-all-settled · e1fd3f69

Shu-yu Guo authored Nov 03, 2020

It's shipped since M76.

Bug: v8:9060
Change-Id: Ifb107f3ef77ab803d5c0ce34f0a31ac33088c41a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2510610
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70956}

e1fd3f69

[flags] Remove --harmony-namespace-exports · 5a03fbeb

Shu-yu Guo authored Oct 30, 2020

It's shipped since M72.

Bug: v8:8101
Change-Id: I80856b9e1acfb6e434f20b6174e864f8c4e2896a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509945
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70955}

5a03fbeb

[flags] Remove --harmony-import-meta · a5e33a57

Shu-yu Guo authored Nov 03, 2020

It's shipped since M64.

Bug: v8:6693
Change-Id: Ifc547c0036dd7e5f7bab9bcb169abee0157f73b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509943
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70954}

a5e33a57

[flags] Remove --harmony-dynamic-import · 49dc0e31

Shu-yu Guo authored Oct 30, 2020

It's shipped since M63.

Bug: v8:5785
Change-Id: Iaa591890edc560bc58b7a6b18ad5787d747f1ba4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509942Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70953}

49dc0e31

[dict-proto] Add support for ordered property dicts, pt.1 · 4b6455aa

Frank Emrich authored Nov 03, 2020

This CL adds partial support for objects whose slow mode dictionaries
are OrderedNameDictionaries. This is the case for all slow mode objects
if V8_DICT_MODE_PROTOTYPES is enabled.

Bug: v8:7569
Change-Id: I0b5a0d751e6551e78121569ddefd9e00c164cc5a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2489692Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Frank Emrich <emrich@google.com>
Cr-Commit-Position: refs/heads/master@{#70952}

4b6455aa