- 21 Oct, 2019 19 commits
-
-
Jakob Gruber authored
V8 uses a backtracking regexp engine, which has the caveat that some regexp patterns can have exponential runtime behavior when excessive backtracking is involved. Especially when regexp patterns are user-controlled, it would be useful to be able to set an upper limit for a single regexp execution. This CL takes an initial step in that direction by adding a backtracking limit (intended to approximate execution time): - The limit is stored in the JSRegExp's data array. - A limit can currently only be set through the %NewRegExpWithLimit runtime function. - The limit is applied during interpreter execution. When exceeded, the interpreter stops execution and returns FAILURE (even if continued execution would at some later point have resulted in SUCCESS). In follow-up CLs, this mechanism will be extended to work in jitted regexp code, and exposed through the V8 API. Bug: v8:9695 Change-Id: Iadb5c100052f4a63b26f1ec49cf97c6713a66b9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864934 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#64417}
-
Milad Farazmand authored
Port afbbfcbe R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I5c2dc6f4ae185259f7b6fc23265c9eff495a599d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869452Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64416}
-
Leszek Swirski authored
This reverts commit ad9bd3a0. Reason for revert: Speculative revert for TSAN failures (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/28816) Original change's description: > [ptr-compr][CSA] Enable the DecompressionOptimizer phase in CSA > > Also update the MachineGraphVerifier to take into account the > possibility of the Store receiving a Compressed representation as well. > > Bug: v8:7703 > Change-Id: I6d6e28b980151af6296000cfe6f67a3a037b029c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859627 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64410} TBR=jgruber@chromium.org,tebbi@chromium.org,solanes@chromium.org Change-Id: I805593d9b49503a20348a4b059049ed24345cf8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7703 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871914Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#64415}
-
Leszek Swirski authored
This reverts commit 0347f00a. Reason for revert: MSAN failures (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/29288) Original change's description: > Refactor platform tests to avoid deprecated API > > The old tasks API is deprecated and we want to remove it in 8.0. > Thus, this CL refactors the platform tests to use the new > TaskRunner-based API, and removes redundant tests. > > R=ahaas@chromium.org > > Bug: v8:9810 > Change-Id: Ie53c90184639e77b3247228059fd88290b233e0c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868619 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64412} TBR=ahaas@chromium.org,clemensb@chromium.org Change-Id: I1b240df992425f25a2a4a9d33d27f6262d91c004 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9810 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871913Reviewed-by:
-
Clemens Backes authored
We still set a lot of macros depending on specific gcc versions. All these old versions are unsupported by now anyways, so we can also just define these macros as 1. If this CL sticks for a while, we can start actually cleaning up all code relying on these macros, as most of them should be 1 now on all platforms. R=ulan@chromium.org Bug: v8:9810 Change-Id: I2f9c55170091f8c263deeddfb7ff89e5b2a0bb12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862564Reviewed-by:
-
Clemens Backes authored
The old tasks API is deprecated and we want to remove it in 8.0. Thus, this CL refactors the platform tests to use the new TaskRunner-based API, and removes redundant tests. R=ahaas@chromium.org Bug: v8:9810 Change-Id: Ie53c90184639e77b3247228059fd88290b233e0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868619Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64412}
-
Santiago Aboy Solanes authored
It was unused and the last commit was a long time ago. NOPRESUBMIT=true Change-Id: I5c4992cbc2e9977549787e21e4f5dac284291c58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863938Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64411}
-
Santiago Aboy Solanes authored
Also update the MachineGraphVerifier to take into account the possibility of the Store receiving a Compressed representation as well. Bug: v8:7703 Change-Id: I6d6e28b980151af6296000cfe6f67a3a037b029c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859627 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64410}
-
Mike Stanton authored
TurboFan can normally inline an arrow function closure callback like: [1, 2, 3].map(x => x * x); The serializer has information to support this in the form of FunctionBlueprint Hints, though it's not exploiting them. This CL remedies that. Bug: v8:7790 Change-Id: I8fc10f04ffc9bd2ea03cd761e8a5a41258000c76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863939Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#64409}
-
Michael Achenbach authored
Bug: v8:9871 Change-Id: Ib2042002c1eba72b81fcd15811a627b13e7e3281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866770Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64408}
-
Jakob Gruber authored
This reverts commit dfd9ceb9. Reason for revert: Regressions https://chromeperf.appspot.com/group_report?rev=64356 https://crbug.com/1015749 Original change's description: > [regexp] Clone match info for match indices. > > The current behavior for generating match indices simply stashes a > pointer to the match info and then constructs the indices lazily. > However, it turns out the match info object used to create the result > object is the regexp_last_match_info living on native context, and thus > it can change between the creation of the result object and the generation > of indices. This cl clones the match info which will be safer. > > Bug: v8:9548 > Change-Id: Ia6f26f88fbc22fd09671bf4c579d39a1510b552d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864585 > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64356} TBR=jgruber@chromium.org,joshualitt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9548, chromium:1015749 Change-Id: I9c30b8fb459cf2aa89d920bf061614441250844d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870236 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mu Tao authored
Port 7d09b270 Original Commit Message: It turns out that because we are *subtracting* from fp, we need to *subtract less* to get a higher address. Who knew. R=xwafish@gmail.com, clemensb@chromium.org Change-Id: I1ddb5e15ef7fab2f198aebf07a5ce607add4c3c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868559 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64406}
-
Yang Guo authored
R=bmeurer@chromium.org Change-Id: Ia76369623c767fbbc249d1d77643d63062f99487 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870231Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64405}
-
Liviu Rau authored
Bug: v8:9856 Change-Id: Ia7dd11c3e603b7880a90fb89087d3118409b432f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864650Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#64404}
-
Benedikt Meurer authored
When using promise hooks we can actually end up in capturing stack trace with an async generator on the stack whose queue is empty, and we need to gracefully handle that case as well. Fixed: chromium:1015945 Change-Id: Ia459e7444b373ecab01ca6900a781fd8b4021d1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870230 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Gus Caplan authored
Change-Id: Ia450876e085b8d4aec5df6be6d17a9cfa557980a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866884Reviewed-by:
-
Jakob Gruber authored
This is a reland of 97ed8b27 Original change's description: > [regexp] Guarantee an allocated regexp stack > > The regexp stack is used during execution of jitted regexp matcher > code. Previously, the stack was initially not present / nullptr, and > we had to explicitly check for this condition and bail out in builtin > code. > > This CL changes behavior to guarantee a present stack by adding a > statically-allocated area that is used whenever no > dynamically-allocated stack exists. > > Change-Id: I52934425ae72cf0e5d13fab2b9d63d37ca76fcf3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1852126 > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64326} Change-Id: If345c09bdbfc8dc6b63f016c3f10ffda811bbb6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866771 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=tmrts@chromium.org Change-Id: I44bff77691130b39b4033127dc837ef9d27a740c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870232 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8823f36..7136ae1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Iababa920839bb6578233ad5079dc4ebed0bfeabd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869859Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64399}
-
- 20 Oct, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/193283f..8823f36 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I76142e9c0d9ed62e641c4c7ec00377646cefca3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869857Reviewed-by:
-
- 19 Oct, 2019 4 commits
-
-
Clemens Backes authored
Local testing shows that this switch for small counts (up to size 16) is significantly faster than the default {std::copy_n} (by up to 20%, e.g. for the "join-int" js perf test). It's also faster than just a loop covering all sizes up to 16. R=leszeks@chromium.org CC=jkummerow@chromium.org Bug: chromium:1006157 Change-Id: I4d179f064704261fa18f453c23c04ee0b351e942 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864831Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6924ab4..193283f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c98b1ee..a5c8651 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fcde3ba..acf922c TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Iaae325a8d6058921c80093f3c9cf5d3cbe551b44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869854Reviewed-by:
-
Deepti Gandluri authored
Change-Id: I335b31d07445d6e6f3739481ac8928b38793e233 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869923Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#64395}
-
Ng Zhi An authored
Change-Id: I1c430a2f57578767c216121384cd4e1873a80e86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869919Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64394}
-
- 18 Oct, 2019 16 commits
-
-
Milad Farazmand authored
Port a0b95232 R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I41e950820d526f1471505ec06c223459a5adf2ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1867972Reviewed-by:
-
Johannes Henkel authored
New Revision: bbc72612409377752c8fd2e7a63a1a5947b7dc4b Change-Id: I625c056b35ffa0658a9063da52ec17178db213a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866967Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64392}
-
Ng Zhi An authored
It was using "data", should be using "current". Was: 0x16e1493c294c 90c 660f3a0fe905 palignr xmm5,[rdi],0x1 0x16e1493c2952 912 660f3a0f6a04 palignr xmm5,[rdi],0x0 Now: 0x2faab74294c 90c 660f3a0fe905 palignr xmm5,xmm1,0x1 0x2faab742952 912 660f3a0f6a0405 palignr xmm5,[rdx+0x4],0x1 Change-Id: I061096889bb26982b27656bd27ac3c9fb6402368 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869079Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: Ic17e0861cee5b1613370f6d2a1801a0e1744a3f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868823Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Iff69b35ec7ea96f0e63610a93c01557429792c59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866883Reviewed-by:
-
Michael Lippautz authored
- Move foward deprecations in EmbedderHeapTracer - Deprecate SetFinalizationCallback in v8::TraceReference Change-Id: Ic68402096ce8f5fe08521253836d3b19d73326ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863941 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/d49777de..21195de94 21195de Inital commit for Intl.DisplayNames tests (#2404) 4b6efea Add more tests for DateTimeFormat.hourCycle/hour12. (#2385) 146ef7d add features: [Intl.DateTimeFormat-formatRange] (#2403) 98883a5 Use canonical format for the description in the metatags (#2401) f25ae22 Add cases for matching paren covered logical expressions f0f4cd6 Improve metadata c7a158e Add feature ec41c1a Add tests for Nullish Coalesce Expression 6b66b82 Cleanup compareArray and deepEqual assertions, remove assert._formatValue 4182972 Merge pull request #2396 from leobalter/2381/yaml 59d1af9 [matchAll] pass a global regex (#2399) 2b48ec7 More yaml and whitespace fixes 917e6f7 Yaml consistency Bug: v8:7834, v8:9875, v8:8703 Change-Id: I03fdce94d524ec0ffc270512fe920acf9b86e781 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1867791Reviewed-by:
-
Clemens Backes authored
The missing include causes compilation failures for node.js, see https://github.com/nodejs/node/pull/30020. It's not great to have includes in a file called "macros.h", but we define several functions there that make use of type traits. Fixing that is a separate project. R=mlippautz@chromium.org Change-Id: Idb067679e597521230f94eb8c99f1347ed3808cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868622Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64386}
-
Dan Elphick authored
Adds function name, script name/url and start (character) position to the error message on a bytecode mismatch. Bug: v8:8510 Change-Id: I8505d744eb4bbf5f0bab35e2db7f2867d2df49de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869197Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64385}
-
Toon Verwaest authored
At certain points in time we learn that we have to drop certain errors in the ExpressionScope. If an AccumulationScope appears between where we learn about the error and where we drop the error, we previously stopped accumulating, assuming that we're already going to fail anyway. Since we might drop the earlier error later; we can't early on this. Instead the accumulator should simply keep on accumulating, keeping the earlier error alive across accumulation. Bug: chromium:1015567 Change-Id: I4d70643d02233fe82582b568a0a946eacf883880 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869198 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
This reverts commit 83f8464f. Reason for revert: speculative revert for blink linux failure https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/1272 Original change's description: > [builtins] Move non-JS linkage builtins code objects into RO_SPACE > > Creates an allow-list of builtins that can still go in code_space > including all TFJ builtins and a small manual list that should be pared > down in the future. > > For builtins that go in RO_SPACE a Code object is created that contains > no code at all (shrinking its size from 96 bytes to 64 bytes on x64), > but is there to allow the runtime to continue to work since it expects > a Code object. > > This reduces code_space from ~152k to ~40k (-112k) and increases > read_only_space from 33k to 108k (+75k) in the snapshot. > > Bug: v8:7464, v8:9821, v8:9338, v8:8127 > Change-Id: Icc8bfc722bb267a2bcc17e2f1e27bef7f02f2376 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795358 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64377} TBR=mstarzinger@chromium.org,jgruber@chromium.org,delphick@chromium.org Change-Id: I4cf38e9370280acdd2de718ca527776ebc509003 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464, v8:9821, v8:9338, v8:8127 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868621Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#64383}
-
Dan Elphick authored
Combines several individual pushes/pops into a single call to Push in GenerateTailCallToReturnedCode. This saves a single instruction since pushes in descending register order can be be merged into a single instruction. The pop merge doesn't save anything but is done for consistency. Bug: v8:9771 Change-Id: I67084985ef5b7b2ed2fc73faedbb0bd9c50e6df6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868612 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64382}
-
Vadim Gorbachev authored
There are now less that 100 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 Related tasks: 1. https://github.com/nodejs/node/issues/24512 2. https://github.com/v8/v8/pull/35 Bug: v8:8594 Change-Id: Ia081a158a2b41cd880a5d47bb340f21858340d42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864942 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Victor Gomes authored
This is a reland of c07c02e1 Original change's description: > [runtime] Remove extension slots from context objects > > Context objects have an extension slot, which contains further > additional data that depends on the type of the context. > > This CL removes the extension slot from contexts that don't need > them, hence reducing memory. > > The following contexts will still have an extension slot: native, > module, await, block and with contexts. See objects/contexts.h for > what the slot is used for. > The following contexts will not have an extension slot anymore (they > were not used before): script, catch and builtin contexts. > Eval and function contexts only have the extension slot if they > contain a sloppy eval. > > Bug: v8:9744 > Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191 > Commit-Queue: Victor Gomes <victorgomes@google.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Cr-Commit-Position: refs/heads/master@{#64372} TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org Bug: v8:9744 Change-Id: I0749cc2d8f59940c25841736634a70047116d647 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869192Reviewed-by:
-
Mythri A authored
We could use StorePropertyInLiteral builtin to handle StaInArrayLiteral when there is no feedback vector. Change-Id: I38cae322cc1901582e570f996c6ffd270501245f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862559Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#64379}
-
Georg Neis authored
In inlining heuristics, we used to warn about a missing bytecode array when the actual reason for not inlining the function might have been a different one (and was printed earlier already). Bug: v8:7790 Change-Id: I3a44fd793d9b1edc80cd215a8110aa47eee731d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863934Reviewed-by:
-
