- 17 Apr, 2019 14 commits
-
-
Clemens Hammacher authored
This is a reland of 067ba2a0. Unchanged reland, hence TBR. Original change's description: > [wasm] Add stack guard for logging code > > Benchmarks or worker threads might never return to the event queue, > hence they will never execute the scheduled foreground task to log > compiled and published wasm code. > This CL adds a stack guard to log the code, to ensure that we also log > it for wasm code that never returns to the event queue. > > R=mstarzinger@chromium.org > > Bug: v8:9104 > Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60879} TBR=mstarzinger@chromium.org Bug: v8:9104 Change-Id: I105b37ef8429d16ef5b983919ba8bca615e347c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570017Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60899}
-
Jakob Gruber authored
This adds support for iOS builds in libsampler. Both iOS simulator builds (target architecture x64) and iOS device builds (arm64) are supported. Note that this is mostly untested since we neither have iOS bots nor an iOS test runner. This CL was thus only tested by compiling V8 for both iOS simulator & device targets. Bug: v8:9140 Change-Id: Ib618bf793771f4be84d1979a968d2b3ef9f6ff86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569436Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60898}
-
Jakob Gruber authored
Add OS detection for iOS builds. If we are building for an iOS target, the following V8 OS defines will be set: V8_OS_BSD V8_OS_MACOSX V8_OS_POSIX V8_OS_IOS // This one is new. The detection code is taken from Chromium's build_config.h file. Bug: v8:9140 Change-Id: I435a8931dc0ae0eefdb893bc838a04470bcc57db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569435Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60897}
-
tzik authored
Realm.navigate hits a UAF when it's called after Realm.detachGlobal, and that's hit a clusterfuzz test. Bug: chromium:952749 Change-Id: Icf0f0d0b845bc5a2d1ddd80ab52756dae97b982f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1567583Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#60896}
-
Clemens Hammacher authored
For some unknown reasons, the profiler starts seeing illegal source positions (see referenced bug). This CL quick-fixes that by just ignoring them for now. This might regress profiling, and should be fixed mid-term. R=mstarzinger@chromium.org Bug: chromium:953309 Change-Id: I10db7e5ad24e8470e319fc9418cd3a684f614c26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569845 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60895}
-
Peter Marshall authored
Add no_chromium_code config - this is required when removing the chromium_code config. Fix a warning that occurs when compiling protobuf_full by suppressing warnings for not marking overriding functions with override. Change-Id: I7f71a24b95dc3ef7d327481581aaa217407ee2cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569441Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60894}
-
Ross McIlroy authored
Avoids allocating a frame for the fast-path in IncHandler by marking some calling branches as Deferred. Also avoid loading feedback slot and vector until it's needed to reduce live range. This reduces the time needed for a tight loop in Ignition (e.g., while (i < 1000000000) ++i;) from 15.5s to 12.8s. BUG=v8:9133 Change-Id: I0a62efdaefca7f3024b3ae05c61631a63cb01390 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570005 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#60893}
-
Z Duong Nguyen-Huu authored
Spec: https://tc39.github.io/ecma262/#sec-proxy-constructor Bug: v8:6664 Change-Id: Ia8b5ed75841d813babd1db4743c3bb9d25658b51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1553007Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60892}
-
Jakob Gruber authored
OS X has been a UNIX 03 registered product since version 10.5, released in October 2007. Bug: v8:8834 Change-Id: I64ca5512a9999b6eb7b4003a6758081a06eb6529 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569437 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#60891}
-
Michael Hablich authored
This reverts commit 067ba2a0. Reason for revert: blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/1570208 21:26:22.251 27507 # Fatal error in ../../v8/src/profiler/profile-generator.cc, line 19 21:26:22.251 27507 # Debug check failed: line > 0 (0 vs. 0). 21:26:22.251 27507 # 21:26:22.251 27507 # 21:26:22.251 27507 # 21:26:22.252 27507 #FailureMessage Object: 0x7ffe851046a0#0 0x56532cb371f9 base::debug::CollectStackTrace() 21:26:22.252 27507 #1 0x56532ca70863 base::debug::StackTrace::StackTrace() 21:26:22.252 27507 #2 0x56532e99610b gin::(anonymous namespace)::PrintStackTrace() 21:26:22.252 27507 #3 0x56532e989468 V8_Fatal() 21:26:22.252 27507 #4 0x56532e9891c5 v8::base::(anonymous namespace)::DefaultDcheckHandler() 21:26:22.252 27507 #5 0x56532b2bb876 v8::internal::SourcePositionTable::SetPosition() 21:26:22.252 27507 #6 0x56532b2c2268 v8::internal::ProfilerListener::CodeCreateEvent() 21:26:22.252 27507 #7 0x56532ae25275 v8::internal::(anonymous namespace)::LogFunctionCompilation() 21:26:22.252 27507 #8 0x56532ae26008 v8::internal::OptimizedCompilationJob::RecordFunctionCompilation() 21:26:22.252 27507 #9 0x56532ae32a08 v8::internal::Compiler::FinalizeOptimizedCompilationJob() 21:26:22.252 27507 #10 0x56532ae228eb v8::internal::OptimizingCompileDispatcher::InstallOptimizedFunctions() 21:26:22.252 27507 #11 0x56532af14e4a v8::internal::StackGuard::HandleInterrupts() 21:26:22.252 27507 #12 0x56532b35f2ec v8::internal::__RT_impl_Runtime_StackGuard() 21:26:22.252 27507 #13 0x56532bba6720 <unknown> Original change's description: > [wasm] Add stack guard for logging code > > Benchmarks or worker threads might never return to the event queue, > hence they will never execute the scheduled foreground task to log > compiled and published wasm code. > This CL adds a stack guard to log the code, to ensure that we also log > it for wasm code that never returns to the event queue. > > R=mstarzinger@chromium.org > > Bug: v8:9104 > Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60879} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I63dc56a41747caf683b14869a2d62017fd0301c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9104 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570012Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#60890}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/2a28a92..d14d538 [spec] More precise Unicode terminology (#1002) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/d14d538 [test] Alignment and offset with overlong leb128 (#998) (Wanming Lin) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/4dce956 [spec] Add paragraph break for more emphasis (#1001) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/3099a7b TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Ifc803d75840ee8389f5634ed090992f4d6934837 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571126Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60889}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f202325..a0b2e3b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2f423f7..acbf095 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4b79c38..7e7523b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iee7a9a297113146826638a1674a9c29e8e06c176 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570584Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60888}
-
Paolo Severini authored
Converted WeakFixedArray, PromiseReactionJobTask, PromiseResolveThenableJobTask, PropertyCell, RegExpMatchInfo, WasmModuleObject, WasmTableObject, WasmMemoryObject, WasmGlobalObject, WasmExceptionObject, AsmWasmData to torque. Bug: v8:8952 Change-Id: Iddc8b7bc50f93f1a75b4a96667237eed57de236b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536991 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60887}
-
Yu Yin authored
This is port for https://crrev.com/c/1524482 Original commit message: This allows immediates to be encoded directly into instructions, rather than mov-ing constants to registers first. This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once this approach has been approved. Bug: v8:9038 Change-Id: I4f35498ccf89306f12601df5ce91e1748975b11b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568710Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#60886}
-
- 16 Apr, 2019 26 commits
-
-
Ben Smith authored
The bulk memory proposal changed behavior of segment initialization during instantiation. Previously, all segments would be bounds-checked, after which the segments would be initialized. The bulk memory proposal removes the up-front check, and always initializes active segments in order, starting with element segments and then continuing with data segments. Each active segment is initialized as-if they were being initialized with the `memory.init` and `table.init` instructions, so an out-of-bounds initialization may still modify the memory or table partially. Bug: v8:8892 Change-Id: I472fca2401e07d60b288f0cc745629a451b31088 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565033 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60885}
-
Z Duong Nguyen-Huu authored
Increase length of packed sealed array will create holes in packed array so transition to dictionary elements for now. Later we can consider transitioning to holey sealed array. Bug: chromium:952382 Change-Id: Ibe26ce56918859a114fccc1933f9c966c47c4112 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566968 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#60884}
-
Johannes Henkel authored
To Revision 16b370abe6f4b59efea00377473b5dddb438defb. Also make roll.py executable (chmod u+x roll.py). Change-Id: Ib3b3767f7fc9c3eef044779c142f62f3d6923242 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568651Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#60883}
-
Joshua Litt authored
Currently v8 ignores class instance fields when determining how many properties to preallocate for a given function. This cl changes v8's behavior to start preallocating for instance fields in addition to properties. Bug: v8:8774 Change-Id: If598c2ba8a1b14bd0293f36bae7d35e2d85f7898 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1560216 Commit-Queue: Joshua Litt <joshualitt@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60882}
-
Z Duong Nguyen-Huu authored
Just update merge conflict. The reverted CL is https://chromium-review.googlesource.com/c/v8/v8/+/1565470. Treat packed sealed, frozen element as packed element. Also rename to IsPackedFrozenOrSealedElementsKind. Bug: chromium:951988 Change-Id: I4e7cc0a0d43e1e1c109fa08231dd5396901f9614 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566235 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#60881}
-
Sathya Gunasekaran authored
Change-Id: Ic771d1981fcf382697d15b3d8b288861b982484c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569799Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60880}
-
Clemens Hammacher authored
Benchmarks or worker threads might never return to the event queue, hence they will never execute the scheduled foreground task to log compiled and published wasm code. This CL adds a stack guard to log the code, to ensure that we also log it for wasm code that never returns to the event queue. R=mstarzinger@chromium.org Bug: v8:9104 Change-Id: I176959cadb4ab3a60153d0717530c032272ad3e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561073 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60879}
-
Paolo Severini authored
Converted InterpreterData, JSDataView, StackTraceFrame, WasmDebugInfo, WasmExportedFunctionData to torque. Bug: v8:8952 Change-Id: I424edc04fd3f7a62d72f546dee898919d7a726df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542504Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60878}
-
Dan Elphick authored
Bug: v8:8834 Change-Id: Ief3c02a05252d3e234e524e9fa3582280f70ae22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569439 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#60877}
-
Frederik Gossen authored
Extend test coverage for Wasm compilation with compilation hints. Tests cover, in particular, error handling in streaming compilation and asynchronous compilation. Bug: v8:9003 Change-Id: Id46e02904a3a5df60c2617b11445bdc04c8b3b1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566520 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60876}
-
Sergiy Belozorov authored
We've originally added them in https://crrev.com/c/1159361 and then removed again in https://crrev.com/c/1291370 since they were implemented in LogDog Viewer. However, looks like logs from the swarming tasks are all dumped into step stdout at the same time and thus logdog assigns idential timestamp to all lines making it fairly useless. TBR=machenbach@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: I49bfb23f8007e4a0facdfea6a09cde911f8e5a51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569432Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60875}
-
Santiago Aboy Solanes authored
This is a cleanup CL that stemmed from the CompressedSigned one https://chromium-review.googlesource.com/c/v8/v8/+/1547859 Bug: v8:8977, v8:7703 Change-Id: Icd217c43cc3430579dd79387d680205ef4440962 Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569428 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#60874}
-
Santiago Aboy Solanes authored
We translate loads with TaggedXXX (XXX in {"", "Signed", "Pointer"}) representation in CSA into loads of CompressedXXX + ChangeCompressedXXXToTaggedXXX in the raw-machine-assembler. This way, CSA doesn't need to know about Compressed values since we are introducing an explicit "decompress" node. Also updating tests that were checking for the load nodes. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ie22ca8123a25ef005c1ff7383776f9355020fa42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565897Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#60873}
-
Georg Neis authored
We'll eventually map each relevant map to a PropertyAccessInfo at serialization time. Bug: v8:7790 Change-Id: I739075af3629359f43acfdeb609112f355f1bd38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565899 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60872}
-
Jakob Gruber authored
Builds for an iOS target were left unhandled in the v8_libbase component inside BUILD.gn. This adds the appropriate source files to the build for iOS targets. Tbr: machenbach@chromium.org Bug: v8:9140 Change-Id: I853e9a39727d80f0f281c8ac2da4eeb465e188e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569430Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60871}
-
Jakob Gruber authored
The arm64 ABI defines x18 as a platform register, and as such platforms may reserve it for their own purposes. This CL unconditionally removes x18 from the allocatable register list (previously it was only excluded from arm64 Windows). If, for some reason, we want to keep x18 allocatable on some platforms, we can explicitly enable it for specific platforms in the future. Bug: v8:8940,v8:9140 Change-Id: I28c4f6aad714e21a0a54bab6041c13a1b28fd467 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564194Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60870}
-
Clemens Hammacher authored
This moves the vector of {WasmCode} to log (per isolate) from the {LogCodesTask} to the {WasmEngine}, where lifetime is more clear. This makes it harder to mess up the ref count of the stored {WasmCode} objects. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I07131f95391bfabee3c376378179d8bcdc1555b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566518 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60869}
-
Sergiy Belozorov authored
The test is currently passing at over 90% of its timeout both on desktop and Android devices and already occasionally failing due to timeouts on Android. R=jarin@chromium.org, mvstanton@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: Id1ba078d6a730d304935407426bdbfd0588a138b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569429Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60868}
-
Simon Zünd authored
The Torque compiler makes heavy use of scoped globals (contextuals). This created a problem for the design of the compiler interface: - Either the compiler provides all the necessary scopes itself, disallowing callers any access to the contextuals, which might contain data the caller is interested in (such as the compilation result). - Or the caller provides all the necessary scopes. This design was fine when the compiler executable was the only user. With the recent addition of unit tests and the language server, this interface became brittle, as missing scopes are only detected at runtime. This CL refactors the compiler interface to not leak contextual scopes past the interface boundary. Content of contextuals is collected and returned, providing access for the caller and freedom to either use the data directly or move it into the callers own scopes. R=sigurds@chromium.org Bug: v8:7793 Change-Id: Ieb988522d08fc6026b3fb74d976008e566146770 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529000 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60867}
-
Andrew Comminos authored
Adds CpuProfiler::SetUsePreciseSampling, which provides a hint whether to sacrifice CPU cycles to reduce the level of sampling interval variance. On Windows, this controls whether or not busy waiting is performed for sample rates < 100ms. Defaults to enabled (old behaviour). Bug: v8:3967 Change-Id: Iee84c3ae8132541c78b1f78bf294ec7c718bb19b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510577 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60866}
-
Simon Zünd authored
When a stack trace is captured, it is stored in a private symbol on the respective Error object. The first access to "Error.stack" will then format the stack trace, with a possible call into user JS via the Error.prepareStackTrace callback. Until now, the accessor converted ".stack" to a normal data property containing the formatted stack trace. This causes a new Map with a new DescriptorArray to be created, which will not be shared with anything else (also not other error objects with formated stack traces). This CL changes the accessor to store the formatted stack trace in the same symbol (stack_trace_symbol) as the structured data. The result is that an error object will have the same Map before and after "Error.stack" is accessed. Bug: v8:9115 Change-Id: I7d6bf49be76d63b57fbbaf904cc6ed7dbdbfb96b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564061 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60865}
-
tzik authored
After this CL, MicrotasksScope allows null MicrotaskQueue parameter, so that the user can migrate one-by-one from the default microtask queue to the finer grained one. Change-Id: Id519920a9d57e80e279026ad05a14422fb72b050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559678Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#60864}
-
Joyee Cheung authored
Previously when an unresolved private name is not found in the current scope but found in an outer class scope, we forget to push it to the outer class scope so the name would never get bound. This patch simplifies ClassScope::ResolvePrivateNamesPartially() and removes the search in outer class scopes since they are incomplete at this point. Instead just push any private name that can't be resolved in the current scope to the outer class scope so that it gets handled later when the outer class scope is complete. Bug: chromium:952722 Change-Id: Ia0dda74cac57a0a1e25a9a09575f55633c6093b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1567709Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#60863}
-
tzik authored
Blink used to use v8::MicrotasksScope::GetCurrentDepth() to get the number of nested MicrotasksScope for the default microtask queue. However, there was no corresponding one for non-default queues. Change-Id: I1c2472ba19b1a11cb968f02119d91d92867c6e02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1567705Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#60862}
-
peterwmwong authored
Bug: v8:8976 Change-Id: I2d5131c2a1d96e5d5e0114efac3b1b2c3497351d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566249Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#60861}
-
Simon Zünd authored
This is a reland of ffe6940f The UBSan issue is fixed with https://crrev.com/c/1566511 TBR=tebbi@chromium.org Original change's description: > Reland^2 "[torque] Throw exception instead of aborting if something goes wrong" > > This is a reland of 251d1623 > > The reland fixes ASAN component builds by adding RTTI build config to both > torque executables. Big thanks to sigurds for finding the fix. > > Original change's description: > > Reland "[torque] Throw exception instead of aborting if something goes wrong" > > > > This is a reland of 3bd49f9b > > > > The issue on the windows bot is apparently a compiler bug in MSVC related to > > move construction. The fix seems to be to change the order of the fields in > > "JsonParseResult" (go figure). > > > > Drive-by-change: Fix LS on windows by emitting correct line endings and > > enabling exceptions for the LS executable as well. > > > > Original change's description: > > > [torque] Throw exception instead of aborting if something goes wrong > > > > > > This CL enables exceptions for the Torque compiler and Torque language > > > server. Instead of aborting when something goes wrong during > > > compilation, a TorqueError is thrown, containing the error message > > > and a source position. The compiler executable still prints the error > > > and aborts, while the language server will pass this information > > > along to the client (not included in this CL). > > > > > > R=danno@chromium.org > > > > > > Bug: v8:8880 > > > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003 > > > Reviewed-by: Daniel Clifford <danno@chromium.org> > > > Commit-Queue: Simon Zünd <szuend@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#60512} > > > > Bug: v8:8880 > > Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995 > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Commit-Queue: Simon Zünd <szuend@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#60736} > > Bug: v8:8880 > Change-Id: Iba198d771169283e83e74324f27aa9e90b8d8975 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1563770 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60804} Bug: v8:8880 Change-Id: I5b7e40ad27bff8f7bfa22240954c2cb75083ad82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564065Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60860}
-