- 18 Mar, 2016 1 commit
-
-
littledan authored
Revert of Restore per-TypedArray-class length accessors as a perf workaround (patchset #2 id:20001 of https://codereview.chromium.org/1624383003/ ) Reason for revert: This patch actually seemed to cause a further GameBoy regression! Reverting it seems to address the regression. Original issue's description: > Restore per-TypedArray-class length accessors as a perf workaround > > This patch is a workaround to the performance regression caused by > implementing the ES2015 TypedArray prototype chain: Include a > per-TypedArray-subclass length getter so that the superclass getter does > not become polymorphic. The patch appears to fix a regression in the > Gameboy Octane benchmark. > > BUG=chromium:579905 > R=adamk > LOG=Y > > Committed: https://crrev.com/03ce7711e474a0ef74f723b30ae1527c89dec010 > Cr-Commit-Position: refs/heads/master@{#33501} R=adamk@chromium.org BUG=chromium:579905,chromium:593634 LOG=Y Review URL: https://codereview.chromium.org/1812143004 Cr-Commit-Position: refs/heads/master@{#34906}
-
- 25 Jan, 2016 1 commit
-
-
littledan authored
This patch is a workaround to the performance regression caused by implementing the ES2015 TypedArray prototype chain: Include a per-TypedArray-subclass length getter so that the superclass getter does not become polymorphic. The patch appears to fix a regression in the Gameboy Octane benchmark. BUG=chromium:579905 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1624383003 Cr-Commit-Position: refs/heads/master@{#33501}
-
- 30 Dec, 2015 1 commit
-
-
littledan authored
Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of https://codereview.chromium.org/1554523002/ ) Reason for revert: Should be fixed again with this Blink change to add NeedsManualRebaseline Original issue's description: > Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ ) > > Reason for revert: > [Sheriff] Changes layout tests. Please fix upstream first if intended. > > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 > > Original issue's description: > > Use ES2015-style TypedArray prototype chain > > > > This patch switches TypedArrays to use the prototype chain described > > in the ES2015 specification, which adds a %TypedArray% superclass above > > all individual TypedArray types. Most methods are defined on the > > superclass rather than the subclasses. > > > > In order to prevent a performance regression, a few methods are > > marked as inline. Inlining might prevent code which was previously > > monomorphic from becoming polymorphic, and it was specifically > > applied in places where methods became more polymorphic than before. > > Tests with realistic workloads would be nice to do before this > > ships in stable. > > > > This patch does not bring TypedArrays up to full spec compliance. In > > particular, @@species is not yet supported. > > > > R=cbruni > > BUG=v8:4085 > > LOG=Y > > > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > > Cr-Commit-Position: refs/heads/master@{#33050} > > TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4085 > > Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c > Cr-Commit-Position: refs/heads/master@{#33053} TBR=caitpotter88@gmail.com,cbruni@chromium.org,machenbach@chromium.org BUG=v8:4085 LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1558663002 Cr-Commit-Position: refs/heads/master@{#33067}
-
- 29 Dec, 2015 1 commit
-
-
machenbach authored
Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first if intended. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 Original issue's description: > Use ES2015-style TypedArray prototype chain > > This patch switches TypedArrays to use the prototype chain described > in the ES2015 specification, which adds a %TypedArray% superclass above > all individual TypedArray types. Most methods are defined on the > superclass rather than the subclasses. > > In order to prevent a performance regression, a few methods are > marked as inline. Inlining might prevent code which was previously > monomorphic from becoming polymorphic, and it was specifically > applied in places where methods became more polymorphic than before. > Tests with realistic workloads would be nice to do before this > ships in stable. > > This patch does not bring TypedArrays up to full spec compliance. In > particular, @@species is not yet supported. > > R=cbruni > BUG=v8:4085 > LOG=Y > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > Cr-Commit-Position: refs/heads/master@{#33050} TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Review URL: https://codereview.chromium.org/1554523002 Cr-Commit-Position: refs/heads/master@{#33053}
-
- 28 Dec, 2015 1 commit
-
-
littledan authored
This patch switches TypedArrays to use the prototype chain described in the ES2015 specification, which adds a %TypedArray% superclass above all individual TypedArray types. Most methods are defined on the superclass rather than the subclasses. In order to prevent a performance regression, a few methods are marked as inline. Inlining might prevent code which was previously monomorphic from becoming polymorphic, and it was specifically applied in places where methods became more polymorphic than before. Tests with realistic workloads would be nice to do before this ships in stable. This patch does not bring TypedArrays up to full spec compliance. In particular, @@species is not yet supported. R=cbruni BUG=v8:4085 LOG=Y Review URL: https://codereview.chromium.org/1541233002 Cr-Commit-Position: refs/heads/master@{#33050}
-
- 01 Jul, 2015 1 commit
-
-
littledan authored
Conditionally including Array and TypedArray methods seems to cause a slowdown in V8 context creation, possibly due to the new code added. BUG=chromium:504629 R=adamk@chromium.org LOG=Y Review URL: https://codereview.chromium.org/1215863003 Cr-Commit-Position: refs/heads/master@{#29430}
-
- 09 May, 2015 1 commit
-
-
dehrenberg authored
This is the first step of converting TypedArrays to the proper proto chain. There is one copy for each of the Harmony TypedArray methods, rather than a version for each TypedArray type. This form prevents accidentally baking in knowledge about a particular array type into the method definition. R=adamk@chromium.org, arv@chromium.org, caitpotter88@gmail.com, dslomov@chromium.org, jochen@chromium.org BUG=v8:4085 LOG=Y Review URL: https://codereview.chromium.org/1126313003 Cr-Commit-Position: refs/heads/master@{#28325}
-