- 11 Nov, 2020 17 commits
-
-
Igor Sheludko authored
This CL * renames Name::hash_field field to raw_hash_field. * all local variables that store raw_hash_field value are also renamed to raw_hash_field where possible. Bug: chromium:1133527, v8:11074 Change-Id: I17313f386110b33a64f629cc2b9d4afd1e06c6c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2471999Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71114}
-
Clemens Backes authored
After https://crrev.com/c/2529140, the actual data race should already be fixed. This CL updates documentation (by moving the field to the fields protected by {mutex_}), and updates {SetHighPriority} to also take the mutex. This change is not strictly necessary, because this method is only called right after creating the object, so no other threads have access to it yet. But relying on that seems brittle, and moving the initialization to the constructor is a bigger refactoring that I don't consider worth it at the moment. The whole priority management will probably be refactored again soon anyway. R=ahaas@chromium.org Bug: v8:11141 Change-Id: I496b619d551aeb584bd6e777c04ed4df076c3ae9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529143Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71113}
-
Frank Emrich authored
This contains more changes to ordered hash tables towards using them as property dictionaries. Most notably, this CL makes the type of the used isolates a template parameter for certain operations. This is already the case for unordered hash tables, and necessary in follow-up CLs where ordered name dictionaries are used with LocalIsolate as the isolate type. Bug: v8:7569 Change-Id: I5c938425a2c196ccd0866b66318a350ebeac8be2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523319 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71112}
-
Clemens Backes authored
The message on the DCHECK says that no compilation should have started when adding js-to-wasm units, but the check itself then also allows for situations where the job was created but is already done. This is unnecessarily permissive. This CL fixes the DCHECK to check what the comment says. R=ahaas@chromium.org Change-Id: I6de8af33869fd11ae91ce2009c360b8d4ed54e9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529142Reviewed-by:
-
Ross McIlroy authored
Introduces an AtomicUint64 type and a seperate AtomicLoad64 due to the different types returned by loading 64-bit atomic values on 32-bit vs 64-bit architectures. BUG=v8:6949,v8:11074 Change-Id: I95de994df9639847cd6b5fd56ea2a6585189ed3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529455 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#71110}
-
Milad Fa authored
Port 366d30c9 Original Commit Message: - don't restore the context register after InvokeFunction unless we need to for throwing exceptions. - manually manage the frame to improve code layout for the fast path R=verwaest@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I2db3ccd8948c21bc7c5be34237f016be305d7e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2530873Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Clemens Backes authored
Replace by explicitly deleting the copy constructor and copy assignment operator. R=zhin@chromium.org Bug: v8:11074 Change-Id: I5accd5d3d4ecfd20d497d16a3cfd189d17314479 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523315Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71108}
-
Jakob Gruber authored
.. in which the given map already matched the default map provided by SharedFunctionInfo::function_map_index(). Bug: v8:8888,v8:11147 Change-Id: I43f51219e1c9534760c653049ac64bc6021c6a75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2530876 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Mythri Alle authored
This reverts commit b5823ea7. Reason for revert: This was meant to be temporary to measure impact. Original change's description: > [turboprop] Disable dynamic map checks for measuring impact > > Bug: v8:10582 > Change-Id: I1ee996ff4490136a2f97ed0ebf56da074663230e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523311 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Auto-Submit: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71028} TBR=rmcilroy@chromium.org,mythria@chromium.org,gsathya@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10582 Change-Id: Ief903f57942e3351ea297fd3ab9e028ea51a3d32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2531777Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#71106}
-
Liu Yu authored
Port: 366d30c9 Change-Id: I8cb720b7de38344627818c578efc36f42c33bbcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2531367Reviewed-by:
-
Clemens Backes authored
Replace by explicitly deleting the copy constructor and copy assignment operator. R=zhin@chromium.org Bug: v8:11074 Change-Id: If312e920b1ef42f8ef667f3b81066ff2aad054e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523316Reviewed-by:
-
Vicky Kontoura authored
This CL aims at avoiding compilation of the same js-to-wasm wrapper multiple times by iterating over all exported functions in the export table and replacing the wrapper for all functions that share the same signature with the function that tiered up. Bug: v8:10982 Change-Id: I721de2f48844349de8a5d12f512a74957c66a0e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527082 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Gruber authored
They've been replaced by JSFunctionBuilder. Bug: v8:8888 Change-Id: Ie37e37befaf313fd58da3ecb02ab7c040e696f8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529134 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
* Replace deprecated Factory::NewFunction* calls with JSFunctionBuilder. * Drive-by: rename Factory::NewFunctionForTest to ..ForTesting (this is the correct suffix recognized by our tooling to ensure it's only called from tests). Tbr: clemensb@chromium.org Bug: v8:8888 Change-Id: I110063803e5b467bd91b75fe8fea2ca4174f2bcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529129Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2101eff..1a0a9f8 Rolling v8/third_party/aemu-linux-x64: xP4TXh9wWGTG0qr4y6eFcUO_0HOBmt3vorgtVmpwBJsC..DVv5pUl-M5J693D1Gl5WWXRACYvP3V3wzNASbl_CU4wC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/982b2a7..b4f4226 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I735b3a54045818b42862a583ef07af7baca919a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2530417Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71100}
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: Iab3ae7fc16f759e6c6d70234b558ecb0c465cce8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2525541Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71099}
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I11632ad59ec3826b71e901e0eb34ef6dc1295637 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2524419Reviewed-by:
-
- 10 Nov, 2020 23 commits
-
-
Junliang Yan authored
Change-Id: I275b15d2b37a4043c3cdb8815fab5e93c1b5e728 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2530214Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#71097}
-
Camillo Bruni authored
By keeping the SharedFunctionInfo around for modules with the kErrored status, we don't need the additional script field anymore. The script can thus be always accessed indirectly through the code object. Removing the script field fixes context serialization of modules. Bug: v8:11073 Change-Id: I9bb3c6b129a41e9d708547ceeb35e6d921c8eea0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504256 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Victor Gomes authored
Change-Id: I117b48b5c2e0f233d6c7223e0d3e9f75e5bd60cf Bug: v8:11118 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527084 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#71095}
-
Toon Verwaest authored
- don't restore the context register after InvokeFunction unless we need to for throwing exceptions. - manually manage the frame to improve code layout for the fast path Change-Id: Ibccb3bf604085bd470c4279d0348edcf6f18d796 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523196 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Drive-by-fix: - Remove duplicated LazyTable - Introduce more pseudo private _* fields - Remove MapPanel.mapDetails getter - Rename MapDetails.setSelectedMap to .map Bug: v8:10644 Change-Id: I0f976ab86f24de2677e024e386e7d4169c9abbb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523192 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I5cc99ac457d6d9e6317b5a910ad11c0543130e45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528900 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Manos Koukoutos authored
When comparing a decoded i33 value (v) to an expected value (ex) given as a 7-bit unsigned byte, we first truncated (v) to 7 bits. This resulted in values which coincide with (ex) only in the last 7 digits to erroneously be accepted. Bug: v8:7748 Change-Id: Iaf40d5be7bbfa80535cec9109c7dd19a9d96edaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2526387 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Victor Gomes authored
- It also fixes padding issues in the deoptimizer Change-Id: Icac62892657830d067b7c21ff45b43ba58e350d9 Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498694 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#71090}
-
Clemens Backes authored
A new compile job can be scheduled from any thread, and {current_compile_job_} is documented to be protected by {mutex_}. Hence take the mutex before writing that field. R=thibaudm@chromium.org, ahaas@chromium.org Bug: v8:11089 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: I2d3b2c51a7d24c7e827bb7ddc9c76b718c2ccb4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529140Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71089}
-
Michael Achenbach authored
This reverts commit df156ffc. Reason for revert: experiment over Original change's description: > Reland "Temporary compilation failure to test tree closing" > > This is a reland of e3ec228c > > Original change's description: > > Temporary compilation failure to test tree closing > > > > This will be reverted after testing the new tree closer. > > > > No-Try: true > > Bug: v8:10661 > > Change-Id: I1b47976ee38cda447e2960ca4b6bd274f16425fe > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529131 > > Reviewed-by: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Liviu Rau <liviurau@chromium.org> > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#71081} > > No-Try: true > Bug: v8:10661 > Change-Id: Ia628c5eb7609b57c9ad7ebe042e63d056e0ff85f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529144 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71085} TBR=machenbach@chromium.org,clemensb@chromium.org,mslekova@chromium.org,liviurau@chromium.org Change-Id: I11d7c3de64ef26c7d53210463d5477d15fa925b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10661 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529146Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71088}
-
Marja Hölttä authored
The tests assert that funcs are optimized / deoptimized a certain way. Bug: v8:9237, v8:11138 Change-Id: Ia4879e722e442be52de0bf93919eb03fecb88147 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529136Reviewed-by:
-
Ross McIlroy authored
Also moves CallStubN to be a private member of code-assembler. BUG=v8:6949,v8:11074 Change-Id: I88a36819aead919cc4f4deff201925562fc9f74f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527061Reviewed-by:
-
Michael Achenbach authored
This is a reland of e3ec228c Original change's description: > Temporary compilation failure to test tree closing > > This will be reverted after testing the new tree closer. > > No-Try: true > Bug: v8:10661 > Change-Id: I1b47976ee38cda447e2960ca4b6bd274f16425fe > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529131 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71081} No-Try: true Bug: v8:10661 Change-Id: Ia628c5eb7609b57c9ad7ebe042e63d056e0ff85f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529144 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#71085}
-
Jakob Gruber authored
Construction of JSFunction objects is complex, mostly due to the existence of multiple functions kinds (JS, wasm, builtin, test, ...) that are all created slightly differently. For example, JS functions may come with an existing FeedbackCell (and FeedbackVector), while builtins and wasm functions always use the many_closures_cell (without a vector). Prior to this CL, construction logic was scattered over a family of 7 functions, without a clearly defined chokepoint for header initialization. This was hard to understand, hard to modify, and needlessly inefficient (by setting some fields twice). This CL fixes all that by introducing JSFunctionBuilder. The BuildRaw method is the chokepoint for allocation and initialization, and Build performs common pre- and post-work. Future work: - Remove now-deprecated functions. - Untangle SFI/Map/JSFunction construction and remove Factory::NewFunction and NewFunctionArgs. Bug: v8:8888 Change-Id: I709a2a44ee02e10593a4c9afe43d4d2c6d6351c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527098Reviewed-by:
-
Michael Achenbach authored
This reverts commit a9252d70. Reason for revert: experiment done Original change's description: > Temporary failure for tree-closer test > > CL to test tree-closure. This CL will be reverted afterwards. > > No-Try: true > Bug: v8:10661 > Change-Id: I07cdedc530dd3718a9537bca51fbb40b83a3e8b9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527100 > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71075} TBR=machenbach@chromium.org,mslekova@chromium.org,liviurau@chromium.org Change-Id: I830daa57a10f284d96e8532b6117d627817f1da8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10661 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529138Reviewed-by:
-
Michael Achenbach authored
This reverts commit e3ec228c. Reason for revert: experiment done Original change's description: > Temporary compilation failure to test tree closing > > This will be reverted after testing the new tree closer. > > No-Try: true > Bug: v8:10661 > Change-Id: I1b47976ee38cda447e2960ca4b6bd274f16425fe > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529131 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71081} TBR=machenbach@chromium.org,clemensb@chromium.org,mslekova@chromium.org,liviurau@chromium.org Change-Id: I16b03d0e86b23cbf55fcd3e7f40976897e138229 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10661 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529137Reviewed-by:
-
Michael Achenbach authored
This will be reverted after testing the new tree closer. No-Try: true Bug: v8:10661 Change-Id: I1b47976ee38cda447e2960ca4b6bd274f16425fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529131Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Camillo Bruni authored
This is mostly an auto-conversion done by several tools. - use let / const - use arrow functions - use template strings There are some additional manual rewrite required to modernize the code further. Change-Id: I63a7a43b05b14b33ad9941350d3d5f26aab10ba0 Bug: v8:10667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519564Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 TBR=hpayer@chromium.org Change-Id: I88644c9476b74f57d3cf7a3056a9b70f1467b96d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2489689 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#71079}
-
Clemens Backes authored
This reverts commit a74f9eb6. Reason for revert: Data race: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/34121 Original change's description: > [wasm]: Use CancelAndDetach and barrier on BackgroundCompileJob. > > To avoid keeping around a list of job handles, CancelAndDetach() is > used in CancelCompilation. Dependency on WasmEngine is handled by a > barrier that waits on all jobs to finish. > > > Change-Id: I685a1737354b2fb3d1f4b98580926a93da38be5b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498659 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71074} TBR=ulan@chromium.org,jkummerow@chromium.org,clemensb@chromium.org,etiennep@chromium.org Change-Id: I9288abd03b572059ac5278d2e5b84bd418b4d69d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529132Reviewed-by:
-
Marja Hölttä authored
This is the second reland of https://chromium-review.googlesource.com/c/v8/v8/+/2487122 , this time without RuntimeCallStats in the tests. Generalize the existing property lookup machinery (JSNCS::ReduceNamedAccess) to handle the case where the lookup_start_object and the receiver are different objects. Design doc: https://docs.google.com/document/d/1b_wgtExmJDLb8206jpJol-g4vJAxPs1XjEx95hwRboI/edit#heading=h.xqthbgih7l2l Bug: v8:9237 Change-Id: I782df6e032ff8191082b425e68d68b69cef0a560 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527092 Auto-Submit: Marja Hölttä <marja@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Instead of just warning, let's try to format the files as well Bug: v8:10670 Change-Id: I0dfbdc0ed4a96af7f2a2a472f1d0d3d332d39c90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523193 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Achenbach authored
CL to test tree-closure. This CL will be reverted afterwards. No-Try: true Bug: v8:10661 Change-Id: I07cdedc530dd3718a9537bca51fbb40b83a3e8b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527100 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
