- 20 Dec, 2019 8 commits
-
-
Tobias Tebbi authored
This reverts commit 91e3243d. Reason for revert: This deopts to the wrong point. Original change's description: > Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]() > > Current GetIterator bytecode loads and calls @@iterator property on a > given object. This change extends the bytecode functionality to check > whether the value returned after calling @@iterator property is a valid > JSReceiver. The bytecode throws SymbolIteratorInvalid exception if the > returned value is not a valid JSReceiver. This change absorbs the > functionality of additional two bytecodes - JumpIfJSReceiver and > CallRuntime, that are part of the iterator protocol in the GetIterator > bytecode. > > Bug: v8:9489 > Change-Id: I9e84cfe85eeb9a1b8a97ca0595375ac26ba1bbfd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792905 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com> > Cr-Commit-Position: refs/heads/master@{#63704} TBR=rmcilroy@chromium.org,leszeks@chromium.org,tebbi@chromium.org,swapnilgaikwad@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9489 Change-Id: I9324b5b01ead29912ad793a1e7b4d009643d7901 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960288Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65541}
-
Clemens Backes authored
This adds a respective test, even though Liftoff frames currently do not show scope information. The output will change with future CLs. R=jkummerow@chromium.org Bug: v8:10019 Change-Id: I015863768c02678e97404f2edb538e3b4320d134 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975754 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65540}
-
Clemens Backes authored
This uses the Smi-fast-path that was added for i32 values also for f32 and f64. The code was generalized to do the smi-to-wasm-type and float64-to-wasm-type conversion dependent on the type, and keep the rest generic. R=jkummerow@chromium.org Bug: v8:10070 Change-Id: I42b021dcc99755883cf003579c730675e6d93ff6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965577Reviewed-by:
-
Tobias Tebbi authored
This allows the definition of classes with several arrays and ports SmallOrderedHashTable subclasses to Torque as an example, including the existing CSA allocation functions for them. Overview of changes: - Introduce ResidueClass to encapsulate the modulo-arithmetic necessary to do alignment checks. - Add MachineOperatorReducer to the CSA pipeline to address now missing CSA ad-hoc constant folding that got blocked by a temporary phi. - Allow assignments to references to structs. This is needed to initialize the data_table part of SmallOrderedHashMap. - Make the NumberLiteralExpression AST-node store a double instead of a string. This is necessary to detect arrays with constant size used for padding. - Turn offsets into base::Optional<size_t> to ensure we don't use an invalid or statically unknown offset. - Remove CreateFieldReferenceInstruction since it doesn't work for complex offset computations and the logic can be expressed better in ImplementationVisitor. - Validate alignment of structs embedded in classes. Bug: v8:10004 v8:7793 Change-Id: Ifa414b42278e572a0c577bf9da3d37f80771a258 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958011 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65538}
-
Tobias Tebbi authored
This is a reland of 53308bf7 Original change's description: > [csa] use JSGraph to create constants in CodeAssembler > > Now that CodeAssembler uses optimizing TurboFan passes, creating > constants without using the caching implemented in JSGraph leads to > problems, since value numbering only works properly if all constants > in the graph were introduced through the cache. > To mitigate this, this CL creates the JSGraph earlier so that > CodeAssembler can already use the same JSGraph used by later TurboFan > optimizations. > For other uses of RawMachineAssembler, everything stays as before. > > This issue is creating bot failures in > https://chromium-review.googlesource.com/c/v8/v8/+/1958011 > > Change-Id: Ife017876b19cb2602694279ef1da75f23e18a031 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967329 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65477} TBR=mslekova@chromium.org Change-Id: I5c8218ce22470b3efa06d872176c910a4c5325a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977858Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:10077 Change-Id: I4b76d62462658dfa54f351ba10e52e57f63f3493 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977857 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65536}
-
Maya Lekova authored
This CL limits the total number of hints of each type (constants, maps, etc.) to 50. It also adds a limit to the number of seen functions with the same SFI and feedback vector to 200. Octane already hits those limits in DeltaBlue and TypeScript, but that doesn't affect the scores. Bug: v8:7790 Change-Id: I644519955115c09bfb8ba6d98cf21087b153668d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975757Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65535}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/09a0189..032b1bd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a892219..0593495 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie331cda9ed6a4a4634274e51e601920c53a488cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1978056Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65534}
-
- 19 Dec, 2019 25 commits
-
-
Ng Zhi An authored
The instruction selector for these two operations use VisitRROFloat which uses and operand for the second input (operand1). The codegen assumes it is a register, which is wrong. This fixes it to be an operand. Change-Id: Ic27ba2c0520ba6e15963b01af7593411ec2a34e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958052Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65533}
-
Shu-yu Guo authored
Change unregister tokens to be held weakly instead of strongly. This enables the use case for an object to be used as its own unregister token. To avoid using an ephemeron table, FinalizationGroup's key_map is changed to key off unregister tokens' identity hashes. Because hashes may collide, a single key list may rarely contain multiple tokens. When a FinalizationGroup WeakCell's token becomes unreachable, during GC, it is removed from the the doubly linked key list and removed from the key map if it had a unique key. Bug: v8:8179 Change-Id: If88fd2ab196e3f9a287990ae345117a0abb2f04d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970493 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65532}
-
Ng Zhi An authored
This change includes templatization of the test helper to allow the same function to be reused for both signed and unsigned data types. We implement a new function RoundingAverageUnsigned in overflowing-math, rather than in base/utils, since the addition could overflow. SIMD scalar lowering and implementation for other backends will follow in future patches. Bug: v8:10039 Change-Id: I70735f7b6536f197869ef1afbccaf5649e7e8448 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958007Reviewed-by:
-
Frank Tang authored
To sync with https://github.com/tc39/proposal-intl-displaynames/pull/63 Bug: v8:10069 Change-Id: I64921c348a69ca7b265d498cac9e7da9f3e3f755 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975038Reviewed-by:
-
Z Nguyen-Huu authored
This is the first part of switching between Liftoff and Turbofan in debugging Wasm. In this CL, we implemented the logic to tier down/up all functions in module. Bug: v8:9654 Change-Id: Ia25103ca29963afa103c124ff5f159f197c2b2b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970470 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Richard Townsend authored
Bug: v8:10012 Change-Id: Id94276d8ab10835758b9c63029ac3c35d35e903b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962853Reviewed-by:
-
Clemens Backes authored
It would be nice if unused {RegClass}es just equal {kNoReg} on all platforms. This CL adds the static asserts for that, and slightly modifies the definition of the {RegClass} enum to fulfil that. Interestingly, this only changes the values for the one configuration that is currently unused :) R=zhin@chromium.org Change-Id: Ib1b2a663183ad34822f514d6168c65450c1d7f2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975753Reviewed-by:Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65527}
-
Ng Zhi An authored
For functions which check if a register pair is used, change them from is_gp_pair to is_pair, since they do not care if the pair of register is a gp pair or a fp pair. Bug: v8:9909 Change-Id: I262108caadd616c64019b39ebbf6972a548112df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1974833Reviewed-by:
-
Clemens Backes authored
For Smi, we can avoid calling the ToNumber builtin, and also the conversion to float and back. This adds some complexity, but greatly improves performance for parameters that fit in a Smi. R=jkummerow@chromium.org Bug: v8:10070 Change-Id: Ic55f17e42ce52811296293f3cd218c850af42961 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965576 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Peter Marshall authored
Bug: chromium:1033407 Change-Id: I59642d64fd111884547605f7a010d40e974d2762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975752Reviewed-by:
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Ibf0c0b0f55a3728810de026c0132ff89e2c9861f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1961943Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65523}
-
Ulan Degenbaev authored
This is a reland of ff7acbd6 Original change's description: > Reland "Delay setting up deserialized JSArrayBuffer" > > This is a reland of 83786cb4 > > Original change's description: > > Delay setting up deserialized JSArrayBuffer > > > > Setting up JSArrayBuffer may trigger GC. Delay this until we > > are done with deserialization. > > > > R=ulan@chromium.org > > > > Bug: chromium:1033395 > > Change-Id: I6c79bc47421bc2662dc1906534fc8e820c351ced > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965580 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Yang Guo <yangguo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65441} > > Tbr: yangguo@chromium.org > Bug: chromium:1033395, chromium:1034059 > Change-Id: I89d05768f52a480400d9c6f5aaaa233c5d5ba126 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969896 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65484} Tbr: yangguo@chromium.org Bug: chromium:1033395, chromium:1034059 Change-Id: I1cc47fa742bd7c5ce602b1eb9a0a78cb479a86f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975756Reviewed-by:
-
Peter Marshall authored
This new API uses the code pages rather than code ranges approach. It's supported on arm32, as well as the previous two supported platforms, x64 and arm64. Deprecate the old API which only works on x64 and arm64 to reduce the maintenance overhead of keeping both. Users of the old API should migrate to the new one as it can be used all on supported platforms. We keep the tests for the old API by ignoring deprecation warnings so that we don't accidentally break it while it is still in the codebase. Design doc: https://docs.google.com/document/d/1VGwUult5AHLRk658VetwEHMOmDDxA2eDQs9lDFMZTE0 Bug: v8:8116 Change-Id: I1de8246a48fc1b4991603501ea6087db6b43fdd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969900 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Backes authored
After calling the ToNumber builtin, we are guaranteed to get either a Smi or a HeapNumber. Thus we can skip the check for undefined, which removes quite some unneeded code from wasm-to-js and js-to-wasm wrappers. R=ahaas@chromium.org Bug: v8:10070 Change-Id: I0e2ad19f1575fb6979222e324fbdb71aaf85e6fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962279 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65520}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d854784..09a0189 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aa39e6f..104d957 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I152d09c71e965fec6e0b4cfafce4a0a8ae858941 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975950Reviewed-by:
-
Daniel Clifford authored
Bug: v8:7793 Change-Id: Ib950ce398f101779a4654353d08ce947b8e05a66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526016Reviewed-by:
-
Shu-yu Guo authored
The spec was normatively changed to simplify var scopes for parameter expressions. Previously there was a per-parameter var scope in sloppy mode so direct evals could introduce vars that did not escape the parameter position. That semantics is complex both for the programmer and implementation and has resulted in bugs in the past. Furthermore, it has never been fully interoperable (with Safari in particular). The spec was instead changed to be simpler: to have a single var scope for sloppy evals in parameters that encloses the parameter scope and body scope. This simplification lets us remove expression-scope-reparenter. Drive-by removal of stale reference to PatternRewriter. Bug: v8:7532 Change-Id: Iade5594abe0009f7f3f6a1adad18628b17e1e779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962471Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#65517}
-
Nico Hartmann authored
This reverts commit ff7acbd6. Reason for revert: https://ci.chromium.org/p/chromium/builders/try/win_optional_gpu_tests_rel/34257 Original change's description: > Reland "Delay setting up deserialized JSArrayBuffer" > > This is a reland of 83786cb4 > > Original change's description: > > Delay setting up deserialized JSArrayBuffer > > > > Setting up JSArrayBuffer may trigger GC. Delay this until we > > are done with deserialization. > > > > R=ulan@chromium.org > > > > Bug: chromium:1033395 > > Change-Id: I6c79bc47421bc2662dc1906534fc8e820c351ced > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965580 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Yang Guo <yangguo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65441} > > Tbr: yangguo@chromium.org > Bug: chromium:1033395, chromium:1034059 > Change-Id: I89d05768f52a480400d9c6f5aaaa233c5d5ba126 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969896 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65484} TBR=ulan@chromium.org,yangguo@chromium.org,petermarshall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1033395, chromium:1034059 Change-Id: I3ad17293bfeba8a817346f57f885c7ba95739d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975751Reviewed-by:
-
Igor Sheludko authored
... in object literals. Bug: chromium:1034973 Change-Id: Ie357eef4c46f87486f2c3756ba1c288ad25a93df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1974070Reviewed-by:
-
Frank Tang authored
Bug: chromium:1014272 Change-Id: I5707dbfcff4ac52f7f27b0f9feb2edfe1c7775ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972425Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
-
Zhang, Shiyu authored
Contributed by fanchen.kong@intel.com Change-Id: I99f2360ba1b064577c6891a161fd62114cce7a3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975341Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65513}
-
Zhang, Shiyu authored
Change-Id: I3c83a3e9b0a9aa58d31968dbcb5bcb483eb47926 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965927 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/471c567..d854784 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0124932..aa39e6f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5e2debe..a892219 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I44762690b171d49e5d744dc01748b0f480ab70da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975192Reviewed-by:
-
Joshua Litt authored
Also port a few smaller functions. Bug: v8:9838 Change-Id: I2245abe648378970a89331baa19af49f7f49359b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1961942 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Johannes Henkel authored
New revision: 3b0551d3904f7fc067e78905ce697002187fa7a5 Upstream reviews: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1972474 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1967550 Change-Id: Ie9cec5faf410cc80ddb178da30cda66d801196f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972404Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65509}
-
- 18 Dec, 2019 7 commits
-
-
Ng Zhi An authored
This introduces a new constant kNeedS128RegPair, which is set for architecture where a pair of FP registers (DoubleRegister) is mapped to single Simd128Register (ARM). In this case, a new RegClass, kFpRegPair, is defined to represent LiftoffRegister of this type. kFpRegPair will be kNoReg on all other architectures. We add 1 more bit to the encoding on ARM, so now the top bit is set for kFpRegPair, the second most top bit is set for kGpRegPair. When the top bit is set, we encode the FP register code into the bottom bits of code_. Note that this is directly encoded, i.e. not added to kMaxGpRegCode, so we can save an add/subtract when converting to/from DoubleRegister. We only need to store 1 FP register, the low register, since the high other register is implicity the next register. Note that the stored register is *always* an even-numbered register. Bug: v8:9909 Change-Id: I78d603c9938c3d0add9bd3ca77ddebbfa7abbc05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973276 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Frank Tang authored
Implement the ECMA402 localeMatcher: "best fit" option by using ICU LocaleMatcher API. Bug: v8:7051 Change-Id: I3d7c1ee39a5c649a5f500429f2b41329346a1a78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943050Reviewed-by:
-
Joshua Litt authored
Change-Id: I9fa2276b9e27fe51d15be3c1afb34633b53d1230 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973969Reviewed-by:
-
Z Nguyen-Huu authored
In setting breakpoint in wasm, we can find wasm script from location but in removing a breakpoint, only breakpoint id is provided. For wasm, we have a list of all BreakPointInfo objects attached to the Script. From breakpoint id, we iterates all scripts to find the targeted breakpoint and remove it. Bug: chromium:837572 Change-Id: Ia5d0fb7d804fb98270b2103232bc10eb5d4f93a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1959749 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65505}
-
Liviu Rau authored
Bug: v8:9633 Change-Id: I44e8e2d036552f47c82441cd0484807ca34d0e14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973739 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This CL implements enums in Torque in three steps: 1.) It implements necessary changes to Torque's type system. In particular, the constraints on constexpr types are relaxed such that constexpr types can exist without a corresponding non-constexpr version. Furthermore, constexpr and their non-constexpr counterpart need not be of the same kind of type. This allows an AbstractType to have a UnionType as its non-constexpr counterpart. 2.) The enum feature itself is realized as a pure desugaring in the parser, where all required types, constants and macro specializations (like FromConstexpr<>) are generated from a simple enum declaration, such that enum entries are not just constants, but are namespace scoped and have distinct types so that they can be used within typeswitch constructs. 3.) Almost all of the existing constants defined in torque (.tq files) are ported to new enum definitions. Bug: v8:10053 Change-Id: I72426d3b1434f301fd690847e15603de0dc1021b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1964392 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Maya Lekova authored
Fixed: chromium:1035331 Change-Id: I6ef31910b2e22e4687412c45cc14c98669c6bd3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973733Reviewed-by:
-
