- 18 Nov, 2019 22 commits
-
-
Ng Zhi An authored
This implements the rest of the load extend instructions: - i32x4.load16x4_s - i32x4.load16x4_u - i64x2.load32x2_s - i64x2.load32x2_u Bug: v8:9886 Change-Id: I4649f77bae5224042a1628d9f0498c050b1e599d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903812Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65017}
-
Seth Brenith authored
As one of several steps involved in supporting struct-valued fields within classes, this CL generates type verification code for the data contained in those structs. In order to generate verification code, Torque needs to know about struct field offsets and the total size of structs. Those calculations are added to StructType itself and the function TypeVisitor::ComputeType which initializes the StructType. I repurposed the Field::offset value to behave in structs more like it does in classes (it had previously indicated the index of a field within a struct, but nobody used that value). Overall this works okay, and I think it's less confusing to have Field::offset mean the same thing everywhere. However, some struct fields have types with unknown size (Field::GetFieldSizeInformation fails), so those fields are now marked with offset Field::kInvalidOffset to indicate that the structs containing them should not be used within class fields or anywhere else that requires packed layout. Bug: v8:7793 Change-Id: If2677c8c81efc85e63b4bfb831d818a748427e18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897247 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65016}
-
Anna Henningsen authored
Having had these would have saved me quite a bit of time :) Change-Id: I36a04cc89db9ceaa786a146d01a6b0f4444f5729 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914214Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65015}
-
Anna Henningsen authored
At least under some circumstances (GCC 6 with x64 Linux for me), the code in `serializer-for-background-compilation.cc` guarded by `ENABLE_SLOW_DCHECKS` attempts to use `std::iterator_traits` on the `FunctionalList`, which previously failed compilation because the standard iterator member types were unavailable. This adds these members. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1800578 Change-Id: Ifece423fce31d98777c6a65ef442623c321ecba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921800Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65014}
-
Tobias Tebbi authored
For many subclasses of JSObject, we used kSize instead of kHeaderSize even though they can contain in-object properties. In fact, kSize was very much used as the header size, as can be seen in many examples in this CL. This change is a preparation for a for a cleanup of how Torque generates field offsets. TBR=hpayer@chromium.org Change-Id: I350e996057cd66c427381334080f8ac93de88597 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917141 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#65013}
-
Simon Zünd authored
R=bmeurer@chromium.org Change-Id: I7338c4a5a259b7f81e8f7719d29c41e721ec1b00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921795 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65012}
-
Georg Neis authored
The serialization of Construct was accidentally using the wrong hints for the receiver. Also, the recursion in ProcessCallOrConstruct was not quite right: for example, it overwrote the accumulator hints in each recursion. With this CL the Octane raytrace score for --concurrent-inlining is back to the default configuration's score. Bug: v8:7790 Change-Id: I501c9cc0b0c8de04520742b9c6b392a4a732bf78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921789 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65011}
-
Georg Neis authored
That warning about missing data was sometimes printed even when nothing was missing. (Also drop an outdated TODO.) Bug: v8:7790 Change-Id: I9550b3237c87b7b0e59f740c34b13d3e38d8d36e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917153 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65010}
-
Simon Zünd authored
This CL adds one undeclared "torque_base" header, as well as two headers that are generated by the Torque compiler itself. R=tebbi@chromium.org Bug: v8:9810 Change-Id: I76c552d897da08b47c03efba959b348f0c2e5843 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918256 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65009}
-
Maya Lekova authored
Bug: v8:9810 Change-Id: I239a624541a4132092c8be9e20da6d49dd5506ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918252 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65008}
-
Mike Stanton authored
Bug: v8:9810 Change-Id: If793739dd24ff6249bbec6e2ffddaf9111995e34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918254 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65007}
-
Andreas Haas authored
R=mstarzinger@chromium.org Change-Id: I1eefd4cbb2a00535a8d6a9c830aadf3620011ea9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921788Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65006}
-
Dan Elphick authored
Converts Node*s to TNode<>s in the following functions: GotoIfNotNumber GotoIfNumber BitwiseOp InitializePropertyArrayLength LoadFixedDoubleArrayElement GotoIfContextElementEqual LoadJSFunctionPrototype AllocateCellWithValue AllocateSmiCell LoadCellValue StoreCellValue AllocateOrderedHashTable AllocateJSObjectFromMap InitializeJSObjectFromMap Bug: v8:9810 Change-Id: I323da8d72a0e164c70bd6026b32fa46010c7c256 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910109Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#65005}
-
Dan Elphick authored
Since WASM can generate direct calls to any function that it knows the arity of and these can be any JS linkage builtin, we need to ensure that CPP builtins also go into CODE_SPACE. This moves 276 builtins (~25KiB) from RO_SPACE back to CODE_SPACE. Bug: chromium:1022695, v8:7464 Change-Id: I4cda8b68ddf6a5ddad09c6e7d4e6a08c8e6c2ccb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916600 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65004}
-
Deepti Gandluri authored
The DCHECK in the lookup method compares the stashed length of the backing store and the byte_length queried on lookup. These two are not guaranteed to be equal as there can be grow calls that update the lenght of the buffer between the length being stashed and the equality check. Bug: chromium:1010272 Change-Id: I754fa0a9ab676cd838e893d12ef6b13fc7d335e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1911490Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65003}
-
Michael Starzinger authored
This makes sure that the {WasmGraphBuilder} properly detects the presence of Simd128 global.get and global.set opcodes and triggers scalar lowering on architectures without Simd128 support. R=clemensb@chromium.org TEST=cctest/test-run-wasm-simd/RunWasm_S128Globals BUG=v8:9973 Change-Id: I1538bd1d3fea40cc78e82b125d4f113842faf68a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917148Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65002}
-
Michael Achenbach authored
This reverts commit 80caf2cf. Reason for revert: Breaks gpu tests: https://ci.chromium.org/p/v8/builders/ci/Win%20V8%20FYI%20Release%20(NVIDIA)/5570 # Debug check failed: !possibly_empty_buckets->Contains(bucket_index). Original change's description: > [heap] Reduce size of possibly empty buckets > > Before this CL a byte was used per bucket to store whether the bucket > is possibly empty or not. This CL changes this such that each bucket > only needs a single bit. > > PossiblyEmptyBuckets is now a word in the page header. If more bits > are needed than fit into a single word, an external bitmap is > allocated using AlignedAlloc. Storing this on the page header, allows > to remove initial_buckets from the SlotSet. The SlotSet allocation is > then again a power-of-2 in release mode. > > Change-Id: If61fd5cfa153f98757beeb444a530f6e2803fdb6 > Bug: chromium:1023139 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906376 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64991} TBR=ulan@chromium.org,dinfuehr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1023139 Change-Id: Ia90b07b9562af934dacba012da31e4f172f2922d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918258Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65001}
-
Michael Achenbach authored
This reverts commit 0e31eb9e. Reason for revert: Need to land: https://chromium-review.googlesource.com/c/v8/v8/+/1918258 Original change's description: > [ptr-compr][x64] Temporarily enable pointer compression on x64 > > Bug: v8:7703 > Change-Id: I50bb3d336d48f0fe176d2bae3536f049e2bf5cf8 > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > Cq-Include-Trybots: luci.v8.try:v8_linux64_cfi_rel_ng > Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918253 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64994} TBR=machenbach@chromium.org,ishell@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703 Change-Id: If80aeee94844f0d855f9d6d02cabf9d9f979779d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921787 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65000}
-
Michael Achenbach authored
TBR=tmrts@chromium.org No-Try: true Bug: chromium:1021522 Change-Id: I54574e451487c497b478bc084e97f3ec450b2fa8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910105Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64999}
-
Jakob Gruber authored
This reverts commit a9ea67d4. Reason for revert: Regressions https://crbug.com/1025160. Original change's description: > Reland "[regalloc] Use an adaptive data structure for live sets" > > This is a reland of b3d748a2 > > Original change's description: > > [regalloc] Use an adaptive data structure for live sets > > > > Live sets represent sets of live virtual registers at block entry and > > exit points. They are usually sparsely populated; for example, a sample > > taken from Octane2 shows 80% of sampled live sets with a fill ratio of > > 10% or less. > > > > Prior to this CL, live sets were implemented as a statically-sized bit > > vector. This is fine for low-ish virtual register counts, but becomes > > wasteful at higher numbers. > > > > This CL attempts to address this issue through an adaptive > > implementation. Small live sets remain bit vectors, while larger sets > > switch to a PersistentMap-based implementation. PersistentMap has very > > memory-efficient add/remove/copy operations. > > > > Of course, with adaptive data structures we enter the territory of > > parameter fiddling. In this case, two parameters are used: > > kMaxSmallSetSize controls when to switch implementations, and > > kMaxDeletionsBeforePrune controls when pruning (= managing the # of > > deleted entries in the map) sets in. > > > > On the (degenerate) test case from the linked bug, the register > > allocation zone shrinks from 1008MB to 475MB. For more realistic cases > > I expect savings on the order of 10s of KB. > > > > Bug: v8:9574 > > Change-Id: Id903bbe23f030b418e8d887ef4839c8d65126c52 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1891693 > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#64872} > > Bug: v8:9574 > Change-Id: I5a95d56c33a98cc5c6c58ff9308314e2eefa462c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910953 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64950} TBR=jgruber@chromium.org,tebbi@chromium.org,thibaudm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9574,chromium:1025160 Change-Id: I177d64eed588cd09c999e15b04d37630c2c6538b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918255 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64998}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a4ee526..253c17c TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I80448ebe9b366d3d71a501682847b3a3808df90e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921165Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64997}
-
jiepan authored
Switch the parameter name src and dst. Change-Id: I4bd07959dd9e9da3a32ebb8d4b61dd6b92e90592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918094Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/master@{#64996}
-
- 17 Nov, 2019 3 commits
-
-
Milad Farazmand authored
This reverts commit 0c3906f4. Reason for revert: <broken compatibility with Python 3> Original change's description: > Fix an error caused by a bug in Python < 2.7.9 > > There seems to be a bug in Python versions prior > to 2.7.9 where running exec could produce the following error: > > SyntaxError: unqualified exec is not allowed in function > '_ParsePythonTestTemplates' it contains a nested function > with free variables (testcfg.py, line 71) > > https://bugs.python.org/issue21591 > > It's causing an issue on all Ubuntu 14 and RHEL 7 machines. > > The proposed change is an equivalent syntax which doesn't > produce an error: > https://docs.python.org/2/reference/simple_stmts.html#the-exec-statement > > > Change-Id: I159cc1be58ff375f313ae5c4fb814763704b880e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1893647 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#64736} TBR=machenbach@chromium.org,bmsdave@gmail.com,tmrts@chromium.org,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib62143645184d768f54272b7c2d7745f6b700369 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921171Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64995}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I50bb3d336d48f0fe176d2bae3536f049e2bf5cf8 Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_cfi_rel_ng Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918253 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64994}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6613a83..a4ee526 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I7b2ff3c4afa602b7d5ab13ea93dac9f8bb1d63df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917057Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64993}
-
- 16 Nov, 2019 4 commits
-
-
Mike Stanton authored
Bug: v8:9810 Change-Id: I29bb3db071c1957cc2a94fa7a47109cc0bab56f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916599 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64992}
-
Dominik Inführ authored
Before this CL a byte was used per bucket to store whether the bucket is possibly empty or not. This CL changes this such that each bucket only needs a single bit. PossiblyEmptyBuckets is now a word in the page header. If more bits are needed than fit into a single word, an external bitmap is allocated using AlignedAlloc. Storing this on the page header, allows to remove initial_buckets from the SlotSet. The SlotSet allocation is then again a power-of-2 in release mode. Change-Id: If61fd5cfa153f98757beeb444a530f6e2803fdb6 Bug: chromium:1023139 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906376 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64991}
-
Igor Sheludko authored
This reverts commit 1ec2ca26. Reason for revert: Preparing for re-enabling pointer compression. Original change's description: > [ptr-compr] Temporarily enable double fields unboxing > > We are not shipping ptr-compr in M79 on x64 because chromium:1009439 > blocks 31-bit Smis on 64-bit architectures, so these's no point in > disabling double fields unboxing. > > This CL will be reverted after the M79 branch point. > > Bug: v8:9799, chromium:1009439 > Change-Id: I28d0013d3ab06ce41d5028ba4f66c9b249de52d7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862556 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64288} Bug: v8:9799, chromium:1009439 Change-Id: I18e22422725777ad8bfbb19243158228f3559c32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1919320Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64990}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ad957be..6613a83 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9413ab0..a6bbfb9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/90c88f0..1f392b8 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ebea19a..fdd6048 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I755fed9b869a0d21b4b7a559fa88a72a41a838d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918930Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64989}
-
- 15 Nov, 2019 11 commits
-
-
Dan Elphick authored
It was perhaps incorrectly not declared inline while still appearing in the main header file and then appearing in the -inl.h. MSVC doesn't like it being declared inline however, so just inline it directly into the main header. Bug: v8:8510 Change-Id: I16106b91b3b4dff31e70382f2e66aa4f42fb290b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918249 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64988}
-
Seth Brenith authored
Currently it's pretty easy to write Torque code that generates an error in some common generic function such as Convert<To: type, From: type>, and unless your change is very small, it can be hard to figure out what part of it caused that macro specialization. This CL updates the Torque compiler to emit some extra information about the stack of code positions that caused a specialization of a macro or builtin, similar to what Clang does for C++ templates. Obviously there might be multiple places that require a particular specialization, but we only report the first one that caused the specialization to be created. Bug: v8:7793 Change-Id: I4c0fbf1fd437d0eb0d7d5002baef7a5361aea5ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1911019 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64987}
-
Dan Elphick authored
The constructor taking an Isolate and HeapObject never uses the HeapObject value and just calls through to the Isolate constructor. Bug: v8:9810 Change-Id: Ia2553b4d1f31cf24549980dbb5c2bfa38fe91f8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918247 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64986}
-
Benedikt Meurer authored
Still trying to find the culprit for https://crbug.com/893973, which seems to be some internal inconsistency in the debug stack trace iterator. Bug: chromium:893973 Tbr: yangguo@chromium.org Change-Id: Id8d62a371cb957d3e78f4919e1ed8b9f54c5738b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918246Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#64985}
-
Georg Neis authored
Bug: v8:7790 Change-Id: Ibfc83828c8677901caa4e04e2b88915ddabeed49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918245 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64984}
-
Dan Elphick authored
utils.h itself is fairly large and contains lots of unrelated functions as well as having a fair number of dependencies itself, so this splits bounds checking and bit field operations into their own headers in base and replaces uses of utils.h with the more appropriate header where possible. (Also fixes some cases where other headers were previously brought in transitively). Bug: v8:9810, v8:8912 Change-Id: I76c53f953848a57e2c5bfad6ce45abcd6d2a4f1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916604Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64983}
-
Milad Farazmand authored
Changes introduced in a5376b7e "Convert" the Smi values to int64 and back to Smi. This behaviour fails as the 64-bit overflow check will not work due to the conversion making Smi to the lower 32-bit. Change-Id: Ida57baed13d8ad048cf2484e6984b4d26eb3fda5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917421Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64982}
-
Maya Lekova authored
This helps reduce the number of false positives encountered by the dead variable analysis in gcmole. TBR=jgruber@chromium.org, verwaest@chromium.org, yangguo@chromium.org Bug: v8:9810 Change-Id: I1a34ccaab340e6abc37832b4ce1a0cabc56fa438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917146 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64981}
-
Eric Leese authored
Currently the inspector reports Wasm in one of two ways: - If there is a source map, report one script per Wasm script, with bytecode but no source. - If there is no source map, report one script per Wasm function, with source (Wasm disassembly) but no bytecode. With this change, behavior with source map is same, but without source map it will report both ways. This will allow us to change the frontend to do its own disassembly, allowing us to remove the per-function scripts in a future change. Bug: chromium:1013527 Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#64980}
-
Michael Achenbach authored
This adds an abstraction for command-line arguments for each of the two comparison runs done in correctness fuzzing. No functional changes intended. No-Try: true Bug: chromium:1023091 Change-Id: I9421715c4904416b9aaf53848954a5248c79ffd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906372 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#64979}
-
Igor Sheludko authored
Bug: v8:9708 Change-Id: I8ae79b0a5ec43497b43fa6c98c9d33ba91fc7e59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917145 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#64978}
-