- 09 Jul, 2018 28 commits
-
-
Dan Elphick authored
Add <root>_handle getters to ReadOnlyRoots, so an Isolate isn't required to get a handle of a root. Also convert one GetIsolate()->factory()->accessor() to GetReadOnlyRoots().accessor_handle() in FixedArray. Bug: v8:7786 Change-Id: I1b72c58f90eacf64be95abb65df91cf993178a93 Reviewed-on: https://chromium-review.googlesource.com/1129225 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54334}
-
Michael Starzinger authored
Now that we no longer use code specialization to patch WasmCode after it was generated, we no longer need to flush the instruction cache after instance building finishes. R=clemensh@chromium.org Change-Id: I4ce31876dde9c6dcc4ad945e024641b72330fe4f Reviewed-on: https://chromium-review.googlesource.com/1128975Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54333}
-
Clemens Hammacher authored
1) Refactor code using the {Diamond} helper. 2) Fix the effect chain to include the loads in that method. R=mstarzinger@chromium.org Change-Id: I8583b46c1c56b226842248f3c1763c7565ef3797 Reviewed-on: https://chromium-review.googlesource.com/1128864 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Théotime Grohens authored
This CL completes the implementation of DataView prototype methods in TurboFan, by implementing the Uint8, Int8, Uint16, Int16, Uint32, Int32, Float32 and Float64 setters. DataView performance is now ahead of the equivalent TypedArray wrapper, and is now expected to at least match TypedArray performance in the general case as well. This CL also adds a test file in the compiler directory, to make sure that the setters actually behave correctly. Change-Id: I4ad4341c6b9b9d461348b62216f37a73abe321e8 Reviewed-on: https://chromium-review.googlesource.com/1128867Reviewed-by:
-
Sigurd Schneider authored
This script averages numbers output from another script. It is useful to average over a benchmark that outputs one or more results of the form <key> <number> <unit> key and unit are optional. For example, if $ bch --allow-natives-syntax toNumber.js outputs Number('undefined'): 155763 Kps (+'undefined'): 193050 Kps parseFloat('undefined'): 23736 Kps then $ avg.py 10 bch --allow-natives-syntax toNumber.js will output [10/10] (+'undefined') : avg 192,240.40 stddev 6,486.24 (185,529.00 - 206,186.00) Kps [10/10] Number('undefined') : avg 156,990.10 stddev 16,327.56 (144,718.00 - 202,840.00) Kps [10/10] parseFloat('undefined'): avg 22,885.80 stddev 1,941.80 ( 17,584.00 - 24,266.00) Kps Change-Id: I237706da8ade1b152e04084e0189007460d359c5 Reviewed-on: https://chromium-review.googlesource.com/1128747 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54330}
-
Clemens Hammacher authored
1) Define all commands in one file. 2) Add logic to make 'jco' print current pc by default. 3) Add a comment to explain how to load the lldb_commands.py file. 4) Minor refactorings. R=ahaas@chromium.org No-Try: true Bug: v8:7754 Change-Id: I553f2ce4cefedad05466c692a8665a570372b76a Reviewed-on: https://chromium-review.googlesource.com/1127892Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54329}
-
Dominik Inführ authored
Updating refs to new space in internal data structures could take some time, so also measure this. Bug: chromium:844008 Change-Id: I9f5af4d09f8ef580ca0ad0019cfc78a994d62ffd Reviewed-on: https://chromium-review.googlesource.com/1128889Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@google.com> Cr-Commit-Position: refs/heads/master@{#54328}
-
Sigurd Schneider authored
Bug: v8:6666 Change-Id: I5940e957452d47edac243898fa7cddf772b54e72 Reviewed-on: https://chromium-review.googlesource.com/1127057 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54327}
-
Michael Starzinger authored
This reverts commit 231b3e15. Reason for revert: Flakes in inspector/debugger/wasm-stack Original change's description: > [wasm] Move code generation fully to background task. > > This moves the entire code generation phase (including code emission > into the native module) into the background task. The code manager is > fully thread safe by now and there are no Isolate-bound steps anymore. > > R=clemensh@chromium.org > BUG=v8:7921 > > Change-Id: Ie3e8565e126bfdb58bf472291a1f9fbebe7b5431 > Reviewed-on: https://chromium-review.googlesource.com/1128743 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54324} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: Ice5d80425cebd3921d9683d06f70d5173f663e42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7921 Reviewed-on: https://chromium-review.googlesource.com/1129059Reviewed-by:
-
Clemens Hammacher authored
It took me a while to understand what this code is doing. This CL just renames a few local variables and documents the checks that are done. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I4072c4b1969f8b88d4454c8f3022c9b9de825197 Reviewed-on: https://chromium-review.googlesource.com/1128862 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This moves the entire code generation phase (including code emission into the native module) into the background task. The code manager is fully thread safe by now and there are no Isolate-bound steps anymore. R=clemensh@chromium.org BUG=v8:7921 Change-Id: Ie3e8565e126bfdb58bf472291a1f9fbebe7b5431 Reviewed-on: https://chromium-review.googlesource.com/1128743Reviewed-by:
-
Théotime Grohens authored
This CL correctly updates the JSTests.json file in test/mjsunit/ to reflect the new DataView Float32/64 performance tests from commit e14699c5. Change-Id: I9cbb05ac0cbd37f8d8a0bc66ebb59c1e05298776 Reviewed-on: https://chromium-review.googlesource.com/1128880Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54323}
-
Georg Neis authored
Bug: v8:7790 Change-Id: Ia9526c507769f8a7f973a9ed7aedd7cc56d169d0 Reviewed-on: https://chromium-review.googlesource.com/1128756 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54322}
-
Leszek Swirski authored
When live edit patches a script, it distinguishes between 'changed' and 'unchanged' functions, and unchanged functions have their position and source script patched to the new script instead of being replaced by a new SFI. However, if a 'changed' function has an inner 'unchanged' function, it also holds a pointer to the inner function in its bytecode constant pool. This constant pool entry was not being updated for changed functions (it was for unchanged), and therefore the outer changed function would compile the redundant new function instead of the old, patched, unchanged function. This patch fixes this by patching 'changed' functions' bytecode constant pools. This is done by swapping the script and script function list position of the old new and old 'unchanged' function, rather than just setting the script (and position) on the old one, and using the new function (now pointing at the old script) to read off the old function literal id. This could also be done by reading the function_literal_id off the new function, but we are soon removing that field anyway. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib22078c06539c795b418d29a493d8224ecea182e Reviewed-on: https://chromium-review.googlesource.com/1127941Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54321}
-
Sigurd Schneider authored
This CL uses pc-relative jumps and calls (B/BL) for calls from embedded builtins to embedded builtins. To make this work, the code range size is limited to 32MB on arm during mksnapshot, which ensures that all builtin to builtin offsets for jumps/calls fit into the B/BL immediate. At code generation time, we put a placeholder into the instruction offset which we resolve to the right code object when the code is copied to the heap. We use a new relocation mode RELATIVE_CODE_TARGET for these relative jumps. The relocation mode RELATIVE_CODE_TARGET should never appear after generating the snapshot. We modify the target_address/set_target_address methods of RelocInfo such that they return the absolute target addresses for pc-relative B/BL instructions. This ensures that the GC can treat RELATIVE_CODE_TARGET in the same way as code targets. This, however, only matters during snapshot creation time, and production code never contains RELATIVE_CODE_TARGET relocations. Bug: v8:6666 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If7eab83ad588859ca87c654a5ddc3e37caea884c Reviewed-on: https://chromium-review.googlesource.com/1117181Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Add new types for function data for SharedFunctionInfo, for uncompiled functions. UncompiledData holds start/end positions, allowing us to remove these fields from SFI. Uncompiled functions with pre-parsed scope data now hold an UncompiledDataWithScope that has a pointer to PreParsedScopeData -- this allows us to also remove the start/end pos from PreParsedScopeData. Bug: chromium:818642 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I56f3c4e62cbf38929babac734a332709f12a8202 Reviewed-on: https://chromium-review.googlesource.com/1126381 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54319}
-
Andreas Haas authored
With this CL we now also support the decoding of the AnyFunc type. I will add the type more deeply in subsequent CLs. R=titzer@chromium.org Bug: v8:7581 Change-Id: I9f30706a442462f915adfd8f720eb65168b80bb8 Reviewed-on: https://chromium-review.googlesource.com/1014111 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54318}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I918af0461e86ce8eacb9155de18954d8b6270ecc Reviewed-on: https://chromium-review.googlesource.com/1123831 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds an {AccountingAllocator} to the {WasmEngine}, separate from the allocator used per Isolate. It is in preparation of being able to share engines across multiple Isolates. For now we just add up the stats from both allocators until a public API for the engine becomes available. R=ahaas@chromium.org TEST=cctest/test-wasm-shared-engine/SharedEngineRunImported BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia915a1ae4aa7ebed27073b7b6bd067e31717a6ea Reviewed-on: https://chromium-review.googlesource.com/1127788 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Georg Neis authored
No changes were necessary. R=jarin@chromium.org Bug: v8:7790 Change-Id: I8a5c308b9534ee1fb669a901b6626c338883fbf8 Reviewed-on: https://chromium-review.googlesource.com/1128741Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:7790 Change-Id: I42c1208f3555a7e5a3a241860d0a1609b8530b79 Reviewed-on: https://chromium-review.googlesource.com/1128740Reviewed-by:
-
Georg Neis authored
No changes were necessary. R=jarin@chromium.org Bug: v8:7790 Change-Id: I70efc56dd07f778dffda3b38f28b9b94d634361e Reviewed-on: https://chromium-review.googlesource.com/1128739Reviewed-by:
-
Clemens Hammacher authored
This reduces the critical section in {NativeModule::AddOwnedCode} to not include the memcpy. It also contains small drive-by fixes. R=mstarzinger@chromium.org Bug: v8:7921 Change-Id: Idbed5d1ab5627fe2ab3f60887ec2b31c5525e36c Reviewed-on: https://chromium-review.googlesource.com/1127025 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Lippautz authored
Deprecates EmbedderHeapTracer::NumberOfWrappersToTrace and replaces it with EmbedderHeapTracer::IsTracingDone. V8 only really cares about the final state (emptiness) here and embedders may choose implementations that have a hard time determinining exact size for their work queues. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1e141c47771ef08aab7dbe204e8175cfee99cf92 Reviewed-on: https://chromium-review.googlesource.com/1127599 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Change-Id: I755f2426d4f0e34115ff0c73e487e47db5290df1 Reviewed-on: https://chromium-review.googlesource.com/1127916Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54310}
-
Benedikt Meurer authored
This extends the current Promise Rejection Hook with two new events kPromiseRejectAfterResolved kPromiseResolveAfterResolved which are used to detect (and signal) misuse of the Promise constructor. Specifically the common bug like new Promise((res, rej) => { res(1); throw new Error("something") }); where the error is silently swallowed by the Promise constructor without the user ever noticing can be caught via this hook. Doc: https://goo.gl/2stLUY Bug: v8:7919 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I890a7e766cdd1be88db94844fb744f72823dba33 Reviewed-on: https://chromium-review.googlesource.com/1126099Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ec3bd1b..84b1e58 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ebf0d4a..230416c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib8c27d83cb9a23a6e1a2ad747ee95a2bd4142e34 Reviewed-on: https://chromium-review.googlesource.com/1128620 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54308}
-
jing.bao authored
Change-Id: Ic2c4f02d5e451c4a3a6612ae91e5cc8231d62448 Reviewed-on: https://chromium-review.googlesource.com/1119773 Commit-Queue: Jing Bao <jing.bao@intel.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54307}
-
- 08 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d0011aa..ec3bd1b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8a075d7..9eaedb7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d8cde7f..ebf0d4a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icfa0b58d4e4ece3a60401ef40a517005ecdbcf98 Reviewed-on: https://chromium-review.googlesource.com/1128542Reviewed-by:
-
- 07 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/911a0c5..d0011aa Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5715e98..8a075d7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5484b86..92745a5 Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/45571de..b41863e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I03d4d4235e8b767e210565891e91ef4bdc2ca2d2 Reviewed-on: https://chromium-review.googlesource.com/1128467Reviewed-by:
-
- 06 Jul, 2018 10 commits
-
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: Iff4f0561901c454fc3facfeb152727d3994b4f98 Reviewed-on: https://chromium-review.googlesource.com/1127947 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Bill Budge authored
- Refactors most of the logic into a helper CanonicalizeShuffle overload that is more easily tested. - Reorders these methods to be in the order they're used. - Adds unit tests for this helper. Bug: v8:6020 Change-Id: Ia7e08bd2ff3ae62b13c9283c6de04e0e1e85086b Reviewed-on: https://chromium-review.googlesource.com/1118706Reviewed-by:
-
Bill Budge authored
- Adds opcodes for 2x8, 4x4, and 8x2 byte reversing swizzles on ia32. Bug: v8:6020 Change-Id: I2c5d4ba88b42a17fc75ac0307e80d8c11d1838ba Reviewed-on: https://chromium-review.googlesource.com/1121956 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#54302}
-
Dan Elphick authored
Change GetHeap() in set methods to Heap::FromWritableHeapObject() since the object can't be read-only if set is being called on it. Also use the non-isolate form of set_the_hole to remove one GetIsolate(). Bug: v8:7786 Change-Id: I85cb95c8c7eb3baa9316b4a39eecf21bb13e5958 Reviewed-on: https://chromium-review.googlesource.com/1128081 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Bill Budge authored
- Eliminates I8x16SPLAT macro. This generates: push eax mov eax, #imm32 movd xmmDest, eax pxor xmmScratch, xmmScratch pshufb xmmDest, xmmScratch pop eax - Uses smaller sequence for I8x16Shl and I8x16ShrU that doesn't require a temp register. - Uses punpckbw, psraw, packsswb sequence for I8x16ShrS. Bug: v8:6020 Change-Id: I1dc4ecaba43b150a3412e9083fe930868d9e5d5d Reviewed-on: https://chromium-review.googlesource.com/1121045Reviewed-by:
-
Clemens Hammacher authored
Instead of creating a separate code object per exported function, we can share the code per signature, and load the function index from the {WasmExportedFunction} object which is being passed as an argument anyway. This greatly reduces instantiation time for modules with a lot of exports. As a next step, we could even share the code across instances, or (with more work) across isolates. R=mstarzinger@chromium.org Bug: chromium:860491 Change-Id: I6438065b2de0df59dce980fb52408a0f475144b3 Reviewed-on: https://chromium-review.googlesource.com/1127660 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Georg Neis authored
R=jarin@chromium.org Bug: v8:7902 Change-Id: I402b2711b8a5a820b8c95285dc929f2a10c55f98 Reviewed-on: https://chromium-review.googlesource.com/1127883 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54298}
-
Dan Elphick authored
This is a clean-up to completely remove the Heap accessors for roots accessible via ReadOnlyRoots. Where previously ReadOnlyRoots called the Heap accessor, now it accesses the roots array directly using the root index (since ReadOnlyRoots is a friend of Heap). Also clean up several cases where private Heap accessors were still being used by Heap and its friends. Bug: v8:7786 Change-Id: Iaca2e17b22822b30d395dec6250a4d5ae496c983 Reviewed-on: https://chromium-review.googlesource.com/1127172 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: Ibb8cd735036368c5bda83fe60b12b427e8e7ce7f Reviewed-on: https://chromium-review.googlesource.com/1127887Reviewed-by:
-
Georg Neis authored
- Move the CompilationDependencies member of OptimizedCompilationInfo to Turbofan's PipelineData (and thus into the compiler namespace). - Move compilation-dependencies.{cc,h} to the compiler directory. Bug: v8:7902 Change-Id: I5471d0923daf83abe975357325db5bc5ad0a8571 Reviewed-on: https://chromium-review.googlesource.com/1127793 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
