- 02 Jan, 2019 4 commits
-
-
Clemens Hammacher authored
And use it in several places in wasm. R=tebbi@chromium.org Bug: v8:8562 Change-Id: I1e857baf33e99849eb32ac2c94e39d7f27b180c8 Reviewed-on: https://chromium-review.googlesource.com/c/1391757 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58495}
-
Clemens Hammacher authored
Introduce a LeakyObject template and use that to implement static lazily initialized objects that never get destructed. This was done in a hand-crafted and complex way before via LazyInstance and LazyStaticInstance. R=tebbi@chromium.org Bug: v8:8600, v8:8562 Change-Id: Id160996753b2cb1baf0f4b2cec9e1727f1d01512 Reviewed-on: https://chromium-review.googlesource.com/c/1388539 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
In the description of the `v8_use_snapshot` gn arg, we had a link to the old location of our blog. R=mathias@chromium.org No-Try: true Change-Id: Ib7d0ae21f3e109b4fae9ca51a1c69d07d42f9017 Reviewed-on: https://chromium-review.googlesource.com/c/1392191Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58493}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff33f8c..67f9fae Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ecf56e8..16717a6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ieadefe1fbbe9660eb3eb29e106cbcfee186b399d Reviewed-on: https://chromium-review.googlesource.com/c/1392246Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58492}
-
- 01 Jan, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d305f3..ff33f8c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I24f35fc87d77ab782fde87b73ef1f51fedb022d7 Reviewed-on: https://chromium-review.googlesource.com/c/1392242Reviewed-by:
-
- 31 Dec, 2018 2 commits
-
-
peterwmwong authored
Bug: chromium:917980 Change-Id: Ia9b68f492bb9f0769dc6ee1706baf8b09de49968 Reviewed-on: https://chromium-review.googlesource.com/c/1392070 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58490}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/554d385..2d305f3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ief238bdb2d76a8975191d0a156c7b86689eaf9a4 Reviewed-on: https://chromium-review.googlesource.com/c/1392238Reviewed-by:
-
- 30 Dec, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/be5ac65..554d385 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I14a3264b66a0edfb1bc3ecb43d9926dcb8ae2d57 Reviewed-on: https://chromium-review.googlesource.com/c/1392236Reviewed-by:
-
- 29 Dec, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/70cbac6..be5ac65 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a923c2a..ecf56e8 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/106695b..50670f1 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I1f811941fe26b898ca2ca2ab5330c5d48c052953 Reviewed-on: https://chromium-review.googlesource.com/c/1392234Reviewed-by:
-
- 28 Dec, 2018 4 commits
-
-
Clemens Hammacher authored
This improves validation time by 7-8% and Liftoff compilation time by 2-3% while increasing binary size by ~12kB. R=mvstanton@chromium.org Bug: v8:8423 Change-Id: I08961097fb61f4a218522138efe51a9165a7c62b Reviewed-on: https://chromium-review.googlesource.com/c/1391748Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58486}
-
Deepti Gandluri authored
Identify validation fails to read the index of prefixed opcodes, and not continue to decode the next bytes. Change-Id: I2c737af55615ba69ba0c5f5adf18a06c6cdb951a Bug: chromium:905815 Reviewed-on: https://chromium-review.googlesource.com/c/1390927 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#58485}
-
Ulan Degenbaev authored
Currently the concurrent marker visits any fixed array in one go ignoring the progress bar and does not expect seeing black arrays in the worklist. For this reason, if the main thread marker starts visiting a large array with the progress bar, then it has to re-push the array in the bailout worklist. So all subsequent visitations of the array happen on the main thread. This patch makes the progress bar thread-safe and allows the concurrent marker to visit arrays in chunks. Change-Id: I5e8867077ed2908b7f9c5d8bde34d0401f7fe446 Reviewed-on: https://chromium-review.googlesource.com/c/1385164 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58484}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7f37dc1..70cbac6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I977ef05a0473602d831afd15de9a298bff9fb0de Reviewed-on: https://chromium-review.googlesource.com/c/1390931Reviewed-by:
-
- 27 Dec, 2018 12 commits
-
-
Alexei Filippov authored
BUG=chromium:917136 Change-Id: I02696a3315c22b34705bbc48cddaeb9e6c59fa9f Reviewed-on: https://chromium-review.googlesource.com/c/1391749Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#58482}
-
Alexei Filippov authored
This reverts commit 0fbe2717. Reason for revert: Debug data has been collected. Removing debug code. Original change's description: > [inspector] Add extra debug code to investigate crbug/897816 > > BUG=chromium:897816 > > Change-Id: Ie28efcab73ccbcb6d8b1a7508b99aec59f3a3ae3 > Reviewed-on: https://chromium-review.googlesource.com/c/1384795 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58383} TBR=dgozman@chromium.org,alph@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:897816 Change-Id: I6b2b5dae2b7e42843d72573ba598e5acfec3514b Reviewed-on: https://chromium-review.googlesource.com/c/1390926Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#58481}
-
Clemens Hammacher authored
Prevent aliasing between problematic registers for shift operations with int64 values in the arm port of Liftoff. Bug: v8:6600, chromium:912592 Change-Id: I905f0a657626fdfac3e41fe2878e918e3c779a8f Reviewed-on: https://chromium-review.googlesource.com/c/1388564 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58480}
-
Clemens Hammacher authored
They will later be detected as redundant again, but we can save memory and performance by just not adding them in the first place. R=mvstanton@chromium.org Bug: v8:8423 Change-Id: I11d88642333681612e2f8f4eaee7ba700cbf64d5 Reviewed-on: https://chromium-review.googlesource.com/c/1390132Reviewed-by:
-
Clemens Hammacher authored
This silences the new presubmit check for all base classes. R=tebbi@chromium.org Bug: v8:8616 Change-Id: I389fedde1b44d9c583dd2fb75e6c8af138c4feb0 Reviewed-on: https://chromium-review.googlesource.com/c/1387491 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58478}
-
Ulan Degenbaev authored
Bug: v8:8616 Change-Id: I2774bf86b3446afddb7cf269e88ba128e53ae7f6 Reviewed-on: https://chromium-review.googlesource.com/c/1390130Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I2cc5ceb7b70a9b53d5bcc90b32276c011f89ffbe Reviewed-on: https://chromium-review.googlesource.com/c/1388530 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58476}
-
Ulan Degenbaev authored
This reverts commit 2d2c1374. Reason for revert: layout test timeout - crbug.com/917714 Original change's description: > Reland^2 "[turbofan] Use feedback when reducing global loads/stores." > > This reverts commit ac85ab0a. A > chromium test caused trouble and was taken care of in > https://chromium-review.googlesource.com/c/1384064. > > Original change's description: > > [turbofan] Use feedback when reducing global loads/stores. > > > > We already record the script context location or the property cell > > as feedback of the global load/store IC, so Turbofan doesn't need > > to do the lookups again. > > TBR=sigurds@chromium.org > > Change-Id: I58bcd9bceec2f9cf401f7b0fc4460a6da6cd0abc > Reviewed-on: https://chromium-review.googlesource.com/c/1386404 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58393} TBR=neis@chromium.org,sigurds@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9003135cfc5cc3ffb8bbf06ca35c9773adac93e7 Reviewed-on: https://chromium-review.googlesource.com/c/1390129Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: Id97f5b53fe6e6a696d8955acc1ab1bc5ac2f4052 Reviewed-on: https://chromium-review.googlesource.com/c/1388527 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58474}
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I54b857cdacf9360b95d64147a486a0d5fa1ffe10 Reviewed-on: https://chromium-review.googlesource.com/c/1388526 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b71c9cc..7f37dc1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2cf76f5..106695b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I661f882c0add60d4e667577a99c92b3f068b6756 Reviewed-on: https://chromium-review.googlesource.com/c/1390919Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I6ef4291ebd6c2bb6acc4b525014ec02a88d45281 Reviewed-on: https://chromium-review.googlesource.com/c/1388525 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
- 26 Dec, 2018 4 commits
-
-
Jakob Kummerow authored
Tbr: ahaas@chromium.org,leszeks@chromium.org,verwaest@chromium.org Bug: v8:3770 Change-Id: Ia6530fbb70dac05e9972283781c3550d8b50e1eb Reviewed-on: https://chromium-review.googlesource.com/c/1390116 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58470}
-
Jakob Kummerow authored
This reverts commit 97628eee. Reason for revert: breaks compilation in Lite mode, which does not allow overriding of certain flags. See https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8926078411629093216/+/steps/build/0/steps/compile/0/stdout. Original change's description: > [error] extend error stack w/ function parameters > > Extend FrameArray to hold weak references to parameters for functions in > the call stack. The goal here is to provide more metadata for postmortem > tools (such as llnode), especially in cases of rethrowing (this will be > particularly useful when using postmortem with promises on Node.js). > > Besides postmortem, these changes allow us to print a more detailed > stack trace for errors with parameters types (or even values), which can > be useful since JavaScript functions can receive any number of > parameters of any type, and having a function behave differently > according to the number of parameters received as well as their types is > a common pattern on JS libraries and frameworks. > > R=bmeurer@google.com, yangguo@google.com > > Change-Id: Idf0984d0dbac16041f11d738d4b1c095a8eecd61 > Reviewed-on: https://chromium-review.googlesource.com/c/1289489 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58468} TBR=yangguo@chromium.org,bmeurer@google.com,bmeurer@chromium.org,mat@mmarchini.me Change-Id: Ide0a434c1521ab2bbeca6821397ff63ba7d40fe5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1390128Reviewed-by:
-
Matheus Marchini authored
Extend FrameArray to hold weak references to parameters for functions in the call stack. The goal here is to provide more metadata for postmortem tools (such as llnode), especially in cases of rethrowing (this will be particularly useful when using postmortem with promises on Node.js). Besides postmortem, these changes allow us to print a more detailed stack trace for errors with parameters types (or even values), which can be useful since JavaScript functions can receive any number of parameters of any type, and having a function behave differently according to the number of parameters received as well as their types is a common pattern on JS libraries and frameworks. R=bmeurer@google.com, yangguo@google.com Change-Id: Idf0984d0dbac16041f11d738d4b1c095a8eecd61 Reviewed-on: https://chromium-review.googlesource.com/c/1289489 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58468}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7c1d51b..a923c2a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia5e0c5e98c1d3086a5d5b461fe3e9d0b86842def Reviewed-on: https://chromium-review.googlesource.com/c/1390915Reviewed-by:
-
- 24 Dec, 2018 10 commits
-
-
Ulan Degenbaev authored
The concurrent marker can now visit maps and mark the subset of descriptors that a map requires. Bug: v8:8486 Change-Id: I184442ec90a8f60c73cfe16d6e9d66f4efa92a01 Reviewed-on: https://chromium-review.googlesource.com/c/1384320 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#58466}
-
Ulan Degenbaev authored
Factory::NewRawOneByteString initializes the string length without atomic accessor. This leads to data race if the string is pretenured and black allocated because the concurrent marker loads the string length before checking the string markbits. This patch changes the order to check the markbits first. Bug: v8:8579 Change-Id: Ic434f7dde9baa6264fe133499d2394c0d4cc5394 Reviewed-on: https://chromium-review.googlesource.com/c/1388542 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: v8:8521 Change-Id: I6e02930108ba90adf6d54aca319d2d2680964860 Reviewed-on: https://chromium-review.googlesource.com/c/1388543 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58464}
-
Aleksandar Rikalo authored
Logic is added to InterpreterEntryTrampoline to detect flushed functions, and enter CompileLazy instead. Get the bytecode array from the function object and load it. The bytecode array could have been flushed from the shared function info, if so, call into CompileLazy. This fixes: cctest/test-heap/TestBytecodeFlushing cctest/test-heap/TestOptimizeAfterBytecodeFlushingCandidate debugger/debug/lazy-deopt-then-flush-bytecode [mips] Macro-assembler fix Fix massive failing of tests after fa3cbf60. Change-Id: Ic1978b5233eefc743fd7b020f65153630ffa281f Reviewed-on: https://chromium-review.googlesource.com/c/1388528Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#58463}
-
Aleksandar Rikalo authored
Change-Id: Ic156eefa7ee2de568a368c44eca0ba80ab8828b0 Reviewed-on: https://chromium-review.googlesource.com/c/1388567Reviewed-by:
-
Jakob Gruber authored
These test off-heap builtin call sequences and don't make sense in noembed builds. Tbr: sigurds@chromium.org Bug: v8:7777 Change-Id: I2795257e33b6ad87958d08f0845b75a7e88988f2 Reviewed-on: https://chromium-review.googlesource.com/c/1390120Reviewed-by:
-
Jakob Gruber authored
This reverts commit 28275cd4. Reason for revert: Ho ho.. oh :{ Original change's description: > Seasonal greetings > > Ho ho ho. > > Tbr: santa@chromium.org > No-presubmit: true > Change-Id: Ida950937a352f32ccf8127907f623e92332f4806 > Reviewed-on: https://chromium-review.googlesource.com/c/1390119 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58459} TBR=jgruber@chromium.org Change-Id: I2f7d0a92d0af95e814a2d6cb04ceaf445d57023a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1390121Reviewed-by:
-
Jakob Gruber authored
Ho ho ho. Tbr: santa@chromium.org No-presubmit: true Change-Id: Ida950937a352f32ccf8127907f623e92332f4806 Reviewed-on: https://chromium-review.googlesource.com/c/1390119Reviewed-by:
-
Jakob Gruber authored
noembed bots have started failing since https://crrev.com/c/1382461. The reason was that inline_offheap_trampolines option was set to true even in noembed builds, and the assembler tried to inline trampolines to non-existent embedded builtins. Tbr: sigurds@chromium.org Bug: v8:7777 Change-Id: I483dd8b77269b8684e57f8da6e659a9648b1657b Reviewed-on: https://chromium-review.googlesource.com/c/1390117 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ce4fbca..b71c9cc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2c256e47641ea1e5cd1b4496329ecb4f5842076e Reviewed-on: https://chromium-review.googlesource.com/c/1390200Reviewed-by:
-
- 23 Dec, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b360239..ce4fbca Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d7d7892..7c1d51b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2e63407..2cf76f5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7e89de601758ee51241e6266f4f8b25437026337 Reviewed-on: https://chromium-review.googlesource.com/c/1390197Reviewed-by:
-
