- 07 Jun, 2021 9 commits
-
-
Clemens Backes authored
Since there is only a single thread in predictable mode, we should never wait for more work. That would be an immediate deadlock. This CL adds code to never wait, and instead checks after processing all messages that we would not need to wait (i.e. that all work was completed). This turns deadlocks into FATAL errors. R=ahaas@chromium.org Bug: v8:11848 Change-Id: If61305d634803fc43678238dc6e9d3a2f35793c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940886Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74966}
-
Jakob Kummerow authored
Strict equality checking of ValueTypes only made sense before reference types came along. Change-Id: I632f541328cb27ae87a5e3daccd4ffb9cfc8a502 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928513 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74965}
-
Andreas Haas authored
Bug: chromium:1213097 Change-Id: If768725a5645b7d21f59845692ca5491e8674bfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940896Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74964}
-
Dominik Inführ authored
Prepare method by taking an object as argument. In the future we can optimize this method by only sweeping the object's page. Bug: v8:11837 Change-Id: Ife1ee7949bfaf590dcc305cc4d03aa1813c07b76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940888Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74963}
-
Clemens Backes authored
This fixes a little mistake from https://crrev.com/c/2182453. In predictable mode (where we do not have any threads for executing background work) we are executing everything on the main thread, but we should never wait for background work to be spawned. Otherwise we can deadlock if the last background task spawned new foreground work, but we keep waiting for more background work to arrive. Generally, any blocking in predictable mode will block forever, because there is no one to spawn any work concurrently (foreground or background). But the blocking for foreground work has to be there for non-predictable mode, thus keep it for now, and only remove waiting for background work. R=ahaas@chromium.org Bug: v8:11848 Change-Id: I51c976f6858db8120baa4c47d28840a1041d7fea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940885Reviewed-by:
-
Michael Achenbach authored
This reverts commit d1e1f1be. Reason for revert: Main bug was fixed. Original change's description: > [infra] Switch back to Xenial on a slow variant > > This is to mitigate flaky timeouts due to memory problems on some > Bionic bots. > > Bug: v8:11818 > Change-Id: I4758f0f167b94d81f43e183a5599a39d8545b4e1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922245 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Auto-Submit: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74824} Bug: v8:11818 Change-Id: I9719cbcd074de44cd5fb981c40f46bf4e10adee0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940895 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#74961}
-
Michael Lippautz authored
This aids debugging as it gives the root set a name. Bug: chromium:1164553, chromium:1186901 Change-Id: I2c2aed369823b059629b35bb170b4966b47156d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933661 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74960}
-
Paolo Severini authored
The tests are not compatible with the --stress-background-compile flag. Bug: v8:11821 Change-Id: Iecef6a2838109fddc9f0ecc145a9f8971bc9bc3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2918214Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#74959}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/092e09c..8bf7a0b TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ib98bf84acfa7c1c13305dcf2dfcb9a32bf1a66a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2942625Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74958}
-
- 06 Jun, 2021 2 commits
-
-
Dominik Inführ authored
This is a reland of b0c70710 The first CL got reverted because of build errors. This CL replaces the remaining usage of is_local_space() with is_compaction_space(). Supposedly this was a leftover because https://crrev.com/c/2928189 landed at roughly the same time. Original change's description: > [heap] Remove unused LocalSpace class > > LocalSpace was introduced for off-heap spaces with concurrent bytecode > compilation finalization. However, finalization ended up using > LocalHeap for concurrent allocations. LocalSpace is therefore unused > and can be removed. > > This CL removes LocalSpace and renames all mentions of local space to > compaction space. Compaction space was the only local space left. > > Change-Id: I12a8a2724f777a77ddb9957fe2d8e89febfebbaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930169 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74914} Change-Id: I993c47fe85f4140f5d6137afde2653a48047cafb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939983Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/74cfeda..e353b02 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I2488e4e16cf75067122d61652303d6fad2b5cd25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2942922Reviewed-by:
-
- 05 Jun, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1da98aa..74cfeda Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/712eb08..092e09c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9705687..a5b6b2f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/af7a363..30cbc5c Rolling v8/tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 Rolling v8/tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 Rolling v8/tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I202053812c034c82bfd70aa9821685eb981d6335 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939053Reviewed-by:
-
- 04 Jun, 2021 13 commits
-
-
Milad Fa authored
ReadLittleEndianValue needs to be used to make sure value is returned correctly on BE machines. Change-Id: I02a64cded4f5dcccd39f1109c4179bebf9231a70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2941038Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74954}
-
Manos Koukoutos authored
Replacing existing values leads to type errors and printing wrong pcs in errors. Change-Id: I513eae0a7e0cb5764d307eb172a378d328ca3660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936596Reviewed-by:
-
Daan de Graaf authored
The two instructions are fused into a single Sadalp instruction, improving performance of quantized neural network operator implementations such as XNNPACK. This change also includes some formatting changes to the unit tests that were made automatically by clang-format, which I am happy to revert if preferred. Bug: v8:11546 Change-Id: I2afc8940a52186617cffd276c82733ad3020b728 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878742 Commit-Queue: Daan de Graaf <daagra@google.com> Reviewed-by:
-
Milad Fa authored
ReadLittleEndianValue needs to be used to assure ptrs are dereferenced correctly on BE machines. Change-Id: I420f863de1b98d5d68688614ead4847258779c9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2941022Reviewed-by:
-
Lu Yahan authored
Change-Id: Icfef3e722d8d01f023677090dca6b899c51a46e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931580Reviewed-by:
Brice Dobry <brice.dobry@futurewei.com> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74950}
-
Manos Koukoutos authored
So far, initializer-expression evaluation was tied to setting global values. We now need it to operate independently of globals, so that we can implement new constant expressions like struct.new, which need their arguments to be computed before they can be initialized. Changes: - Move type computation of WasmInitExpr into WasmInitExpr::type. - Fix WasmInitExpr::type kRttSub case for rtts without depth. - Introduce InstanceBuilder::EvaluateInitExpression(). - Rename InstanceBuilder::GetRawGlobalPointer() -> GetRawUntaggedGlobalPointer(). - Simplify InstanceBuilder::InitGlobals using EvaluateInitExpression(). - Introduce ValueType::is_numeric. - Add Simd128(byte*) constructor. - Introduce WasmValue::CopyTo() for numeric types. Change-Id: Ic502b611f3998187abd9fc6ec377c2954c27abdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939982 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Changes: - Merge all immediates which read a u32_v index into IndexImmediate. Refactor overloaded Validate(const byte*, [Type]Immediate) functions to Validate[Type](const byte*, IndexImmediate). - Move MemoryIndexImmediate/MemoryAccessImmediate validation into their own Validate functions. Remove CheckHasMemory(), move its functionality into these Validate() functions. - Refactor MemoryInitImmediate, TableInitImmediate and CallIndirectImmediate as composite immediates. - Change field initializations for some Immediates to constructor initializers. This helps us drop some useless default constructors. - Use the correct pc in StackEffect for struct.new_default. Bug: v8:11831 Change-Id: I878f69a33f8473dc275184995b3b7b88fe0dfc8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928498Reviewed-by:
-
Andreas Haas authored
R=thibaudm@chromium.org Change-Id: I6fcd78ffb2683ed92e056d67ec4ef792c0d2ec0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939986Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74947}
-
Vicky Kontoura authored
This CL introduces an ExplicitRealmScope in d8 for entering an existing Realm on demand. Bug: v8:11525, v8:11706 Change-Id: I3b556aed85fc615bb5efbd4a072e075534617258 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936602 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74946}
-
Georg Neis authored
Tbr: nicohartmann@chromium.org Bug: chromium:1198705, chromium:1199345, chromium:1200490 Change-Id: I4a486df636e084279423e6cd3b867137bfe3fd6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939984Reviewed-by:
-
Sigurd Schneider authored
The V8 roll is stuck due to a compile error: https://chromium-review.googlesource.com/c/chromium/src/+/2933917 This CL adds the defined() to a preprocessor guard to make it compile Change-Id: I744c6b9c3b92380a80fd50393e86f48392042b9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939985 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: I9a3c43418b17447741b5886d4706ccd1db9b38e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933662 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/20ee3d5..1da98aa Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/cd7b8c0..eb65cc3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ec690bb..712eb08 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c8f63d3..9705687 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/f022e29..a0718d4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/19eadef..af7a363 Rolling v8/tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 Rolling v8/tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 Rolling v8/tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I09959737175560509e13ec3060dd0b6dc5feb108 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939065Reviewed-by:
-
- 03 Jun, 2021 8 commits
-
-
Milad Fa authored
Change-Id: Ie16a4542179a9661991a4e1696d1b7a952b0e305 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936605Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74941}
-
Junliang Yan authored
Change-Id: I57e46d779e8336b4a456b2a0932a0a6126fcb873 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2937256 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74940}
-
Milad Fa authored
vcgd/vcdg with 32-bit FP inputs are only supported on z15 and above. For older machines we need to use scalar instructions. This is a partial revert of this CL: https://crrev.com/c/2697389 Change-Id: I61deb9357efd424c3b94dddc8be37e7e4c42d334 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936640Reviewed-by:
-
Lu Yahan authored
Port 97def807 Change-Id: If4f135be03e7ab719e091f02bdace49f9bcafcfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928143 Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by:
-
Lu Yahan authored
Port 2b77ca20 Change-Id: Ie953a1d54f5529423ae35d1b1cd3ca25e8101c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931577 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by:
-
Vicky Kontoura authored
This CL updates WebSnapshotSerializer::TakeSnapshot() to accept exports as a Local<PrimitiveArray>. Bug: v8:11525, v8:11706 Change-Id: Ie3a752ac7dbcc51fc4fb258eb44ce42d0cfc6a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930173Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/315c86c..20ee3d5 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/da3e6cb..7e3b768 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/c0776fc..950faee Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/053e386..ec690bb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cd3696c..c8f63d3 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/a3460d1..53495a2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d663c27..19eadef Rolling v8/tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e Rolling v8/tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e Rolling v8/tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I6bc8406c512b4dd51654874d785827b77820ef3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936147Reviewed-by:
-
Liu Yu authored
Port 2b77ca20 Bug: v8:11809 Change-Id: Idbbbc10d1339d6c8463686b6e701fb601a217cab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931557Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74934}
-
- 02 Jun, 2021 7 commits
-
-
Frank Tang authored
R4T: https://groups.google.com/a/chromium.org/g/blink-dev/c/e4Ict1TT9FE/m/aq69ne3rBAAJ Spec: https://tc39.es/proposal-intl-extend-timezonename/ https://chromestatus.com/guide/edit/4506375298220032 Bug: v8:11661 Change-Id: Ifa7571f4bb23c1852ada6c0f13e27611f7e5791d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2924525Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#74933}
-
Stephan Hartmann authored
LiftoffRegister::gp() and LiftoffRegister::fp() are constexpr. Therefore, VRegister::from_code() needs to be constexpr as well. Bug: chromium:819294 Change-Id: I5a75d6ae0dc79fce0a42a45c5f7928aa61ac5520 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922887Reviewed-by:
-
Vicky Kontoura authored
No-Try: true Change-Id: I8ba97cd2fe3ba0b7fa23960aa2ed9880454996a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933660Reviewed-by:
-
Deepti Gandluri authored
Bug: chromium:1190951 Change-Id: I2c314a143c77a9fee288f7822fea84f900c3059b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2921033Reviewed-by:
-
Georg Neis authored
Bug: chromium:1215514, chromium:1211215 Change-Id: I6ebc1d4138d6bee66c3fd9a8369741b8df960807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933663 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I33a6f165b36eb0a948712d0de2b3a926efcd3cb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931808 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Junliang Yan authored
Clean up 32 bit Load/Store Change-Id: I5bab0d33830039d3c4a501eba6e7cf95f4b9559e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933597Reviewed-by:
-
