- 20 Sep, 2018 21 commits
-
-
Benedikt Meurer authored
The following runtime functions (and their intrinsic counter parts) are completely unused/obsolete by now - %ToInteger - %GeneratorGetInputOrDebugPos and in addition the intrinsics for %_ToNumber and %_IsJSProxy are also dead (according to code coverage and manual verification), so drop them as well (their runtime function counterparts are still somewhat used). Bug: v8:8015 Change-Id: I60d53762dd9717fb43de38cb490b46676c467212 Reviewed-on: https://chromium-review.googlesource.com/1235923Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56076}
-
Sigurd Schneider authored
Bug: v8:6666 Change-Id: I5c75eda044312bba6be1ce6bf71afbfe94534afc Reviewed-on: https://chromium-review.googlesource.com/1233674Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56075}
-
Maya Lekova authored
This change introduces an initial size of 1000 for the refs map (obtained by observing the typical size for compiling an empty function), which reduces the time taken by "serialize standard objects" on TypeScript benchmark from ~100ms to ~75ms (25% improvement). Bug: v8:7790 Change-Id: I5e2d9036ad14ee0eafcd161ca913e770c468ef86 Reviewed-on: https://chromium-review.googlesource.com/1235918 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56074}
-
Benedikt Meurer authored
This is not used at all anymore and can thus be removed. Bug: v8:8015 Change-Id: Ifebe576dd84cbdbd77bf9ca54d479050e3174d2b Reviewed-on: https://chromium-review.googlesource.com/1235920Reviewed-by:
-
Benedikt Meurer authored
Remove the NumberConstant right hand side limitation for the speculative number operation optimization, and extend the logic to also deal with SpeculativeToNumber, which is common when dealing with postfix increment and array operations. Also add appropriate tests for all the relevant cases, specifically we mjsunit tests to increase the general coverage for the various cases here (in addition to dedicated unittests). Bug: v8:8015 Change-Id: I8c92f98490c63b07eb19686efd404322979e57c4 Reviewed-on: https://chromium-review.googlesource.com/1235919Reviewed-by:
-
Sigurd Schneider authored
This CL ensures the kRootRegister (ebx) is preserved in Call_ReceiverIsNullOrUndefined Call_ReceiverIsNotNullOrUndefined Call_ReceiverIsAny Bug: v8:6666 Change-Id: Ifef8ba544110c45810a8f895869acdd5b61d1d5d Reviewed-on: https://chromium-review.googlesource.com/1233597Reviewed-by:
-
Michael Achenbach authored
This is for fixing: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20N5X/871 TBR=sbc@chromium.org NOTRY=true Bug: v8:8020 Change-Id: I48180f3e24fbabfbc673890252a1067ef63d82a2 Reviewed-on: https://chromium-review.googlesource.com/1235578Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56070}
-
Sigurd Schneider authored
Bug: v8:6666 Change-Id: Ifffca8d91c482026e9e7eee09bb5d6ce3e87e212 Reviewed-on: https://chromium-review.googlesource.com/1233598Reviewed-by:
-
Yang Guo authored
We now clearly differentiate between: - unseeded hash for 32-bit integers - unseeded hash for 64-bit integers - seeded hash for 32-bit integers - seeded hash for strings R=bmeurer@chromium.org Bug: chromium:680662 Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce Reviewed-on: https://chromium-review.googlesource.com/1235973 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56068}
-
Igor Sheludko authored
and introduce RootsTable - a V8 heap roots storage. So, the renaming part looks like this: Heap::RootListIndex -> RootIndex Heap::kBlahBlahRootIndex -> RootIndex::kBlahBlah Bug: v8:8015, v8:8182 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I38e1f3e3f6813ef35e37b0bed35e9ae14a62134f Reviewed-on: https://chromium-review.googlesource.com/1234613Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56067}
-
Maya Lekova authored
To make code consistent with fef047a4 JSHeapBroker and CompilationDependencies are now being allocated and are using OptimizedCompilationInfo's zone, which is shared between compiler stages. Bug: v8:7790 Change-Id: If622ce8b39587ff1c87700ab70e9bd4bc1acc68f Reviewed-on: https://chromium-review.googlesource.com/1233616Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ibc5124e06f5774e7695029e2d21084a7efb965e6 Reviewed-on: https://chromium-review.googlesource.com/1224412 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org CC=machenbach@chromium.org Bug: v8:8201 Change-Id: I50f38a3c0f6c8d52cf6913557f26e38cd3cfd1c7 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1235914 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Dan Elphick authored
This always creates the bytecode handlers as part of the builtins table regardless of the V8_EMBEDDED_BYTECODE_HANDLERS definition. Lazy deserialization of bytecode handlers is enabled for this flow by moving the three lazy bytecode deserializers from the strong roots into the builtins table (ensuring that they not marked lazy themselves). To simplify lazy deserialization, the illegal bytecode handler is made non-lazy so that GetAndMaybeDeserializeBytecodeHandler doesn't to know about it. Since the bytecode handlers are now always part of the builtins table, many bytecode specific methods are removed, including logging and in BuiltinsSerializer and BuiltinsDeserializer. Removes setup-interpreter.h, setup-interpreter-internal.cc and builtin-snapshot-utils.*. Change-Id: Ie421aa897a04f7b3bcb964c476eb7ab149388d53 Reviewed-on: https://chromium-review.googlesource.com/1220046Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I5686fa0c1ed73b17f592a012b00c08c575ae5387 Reviewed-on: https://chromium-review.googlesource.com/1234234Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Introduces visitor methods for - JSDataView - JSTypedArray Bug: chromium:885125, chromium:843903 Change-Id: I812eaf0619034641c6998f9d164bee84bc4c6ca2 Reviewed-on: https://chromium-review.googlesource.com/1235693Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I0ba7bd3bf3665d4fb43f89b4cc9ab403d974930f Reviewed-on: https://chromium-review.googlesource.com/1228067Reviewed-by:
-
Michael Achenbach authored
This reverts commit 46573e51. Reason for revert: Speculative revert for breaking chromium integration. Might break gpu tests and linux debug: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20(Intel)/2554 Also blocks the roll: https://chromium-review.googlesource.com/c/chromium/src/+/1234328 Original change's description: > [es2015] Introduce JSDataView::external_pointer. > > This adds a new external_pointer field to every JSDataView instance > which points directly into the backing store at the given view's > byte_offset. This was the DataView performance is now almost on > par with the TypedArray performance for accessing aligned memory > (with appropriate endianess). This also serves as prepatory work > to enable full 64-bit addressing of DataView backing stores in > optimized code (soonish). > > This change optimizes the bounds checking sequence in TurboFan in > such a way that it further improves the DataView set/get performance > by around 10%, almost closing the remaining gap between DataViews > and TypedArrays. > > Drive-by-fix: Get rid of the code duplication around DataView inlining > in the JSCallReducer and have only a single bottleneck method now. > > Bug: chromium:225811, v8:4153, v8:7881, v8:8171 > Change-Id: I9118efd4d19e93f0e51c931a9bec1a56a0f4593e > Reviewed-on: https://chromium-review.googlesource.com/1231994 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56042} TBR=yangguo@chromium.org,mlippautz@chromium.org,tebbi@chromium.org,bmeurer@chromium.org Change-Id: I614a90043b1574b19936c37987db94806cac3bd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811, v8:4153, v8:7881, v8:8171 Reviewed-on: https://chromium-review.googlesource.com/1234417Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I864a7541b7ff37b750fc73cd6614feca98e57c77 Reviewed-on: https://chromium-review.googlesource.com/1233758Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/786a3d9..64006c6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c968ea0..582a06e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/79c6513..f837545 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b170cc8..35ffce8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I9a7f15b78303a1ec31250f21306e090b7b58ab19 Reviewed-on: https://chromium-review.googlesource.com/1235377 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56057}
-
Sam Clegg authored
Previously we only supported strings and not filenames. This changes the default to filename and adds a new `type: string` which can be passed `options` to allow for strings to be passed in test code. See: https://developer.mozilla.org/en-US/docs/Web/API/Worker/Worker Bug: v8:8020 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie8818885c5c5c071b6614852322cb45aeb01a647 Reviewed-on: https://chromium-review.googlesource.com/1185980 Commit-Queue: Sam Clegg <sbc@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#56056}
-
- 19 Sep, 2018 19 commits
-
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: Id88187906f82cc9956ffbc9c70e4a1fdd8b20b30 Reviewed-on: https://chromium-review.googlesource.com/1234974Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56055}
-
Junliang Yan authored
Port fef047a4 Original Commit Message: This CL implements the following design doc: https://docs.google.com/document/d/1h5kdfemMQMpUd15PSKW1lqikJW5hsGwrmOvoqhGFRts/edit?ts=5b978756#heading=h.urs7r34mx9p R=mslekova@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iac369feb7a0bfb1d878a3c0fb4a6efbee6371128 Reviewed-on: https://chromium-review.googlesource.com/1234973Reviewed-by:
-
Creddy authored
The LogAll test is flaky on windows build, disable one-shot optimization to check if the issue is related to one-shot or not. Change-Id: Ia963faf4158277d8d5e8bcbd3cf6ce99b69a4d39 Reviewed-on: https://chromium-review.googlesource.com/1234416Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Chandan Reddy <chandanreddy@google.com> Cr-Commit-Position: refs/heads/master@{#56053}
-
Hannes Payer authored
Change-Id: I039bf7e25884dd2c7c22f22e458048b75c0ca904 Reviewed-on: https://chromium-review.googlesource.com/1233833 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#56052}
-
Bill Budge authored
- Uses a temp register to hold esp so we can align it to a 8-byte boundary. Bug: v8:8015 Change-Id: I487789250aca89c360a70614d7b0bd382705febf Reviewed-on: https://chromium-review.googlesource.com/1229614Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I829fe79b95a0275ccc94e32fea2cdc74affef714 Reviewed-on: https://chromium-review.googlesource.com/1228066Reviewed-by:
-
Sam Clegg authored
This prevents the contents of these files showing up in the output of `git grep`. This makes git grep much more useful as these files are minified into a single line which is not human readable. Change-Id: I54047fe32d090570fa70935ce108455a47e4d888 Reviewed-on: https://chromium-review.googlesource.com/1232674Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#56049}
-
Clemens Hammacher authored
Those two methods are spread over the code base, and their purpose is often not clear. Historically, they were used to turn pointers into integers in order to do computations on them. Today we have {Address} which is uintptr_t, so we can compute directly on that. This also makes the {RoundUp} and {RoundDown} macros only work on integral values (including {Address}). R=mlippautz@chromium.org Bug: v8:8015 Change-Id: Ia98fb826793ee5d3a2a5b18c09c329d088443772 Reviewed-on: https://chromium-review.googlesource.com/1233914Reviewed-by: -
Sigurd Schneider authored
This CL ensures that the InterpreterEntryTrampoline, as well as InterpreterPushArgsThenCall and InterpreterPushArgs preserve the kRootRegister (ebx). Bug: v8:6666 Change-Id: I1e5b63f1002ffbe4dac84f039f373b6b77e67d8a Reviewed-on: https://chromium-review.googlesource.com/1233793Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I5645a85ca7d85ca9abf2cde9ed4191b1ae06ca73 Reviewed-on: https://chromium-review.googlesource.com/1224170Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:6666 Change-Id: I51db8fdf5e649884aa94cb6c9e5cc733250b7ce9 Reviewed-on: https://chromium-review.googlesource.com/1233757 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 3bb5cb63 Original change's description: > [wasm] Introduce a soft limit on reserved memory > > Currently, wasm memory and wasm code use a shared limit for the total > size of reservations. This can cause wasm code reservations to fail > because wasm memories used all available reservation space. > This CL introduces a soft limit which is used when allocating wasm > memory with full guards. If this limit is reached and the respective > flag is set, we fall back to allocation without full guards and check > against the hard limit. Code reservations always check against the hard > limit. > > R=ahaas@chromium.org > > Bug: v8:8196 > Change-Id: I3fcbaeaa6f72c972d408d291af5d6b788d43151d > Reviewed-on: https://chromium-review.googlesource.com/1233614 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56028} Bug: v8:8196 Change-Id: If8baf429b02e23b344346f7335bc911b99ae5579 Reviewed-on: https://chromium-review.googlesource.com/1233756Reviewed-by:
-
Michael Lippautz authored
Concurrently process objects and only read embedder fields on the main thread. Also prepares the concurrent marking infrastructure to plug this processing into different types. Bug: chromium:885125, chromium:843903 Change-Id: I23b7f778c16cff118dec93e11e2bbd02aaf11a78 Reviewed-on: https://chromium-review.googlesource.com/1231175Reviewed-by:
-
Benedikt Meurer authored
This adds a new external_pointer field to every JSDataView instance which points directly into the backing store at the given view's byte_offset. This was the DataView performance is now almost on par with the TypedArray performance for accessing aligned memory (with appropriate endianess). This also serves as prepatory work to enable full 64-bit addressing of DataView backing stores in optimized code (soonish). This change optimizes the bounds checking sequence in TurboFan in such a way that it further improves the DataView set/get performance by around 10%, almost closing the remaining gap between DataViews and TypedArrays. Drive-by-fix: Get rid of the code duplication around DataView inlining in the JSCallReducer and have only a single bottleneck method now. Bug: chromium:225811, v8:4153, v8:7881, v8:8171 Change-Id: I9118efd4d19e93f0e51c931a9bec1a56a0f4593e Reviewed-on: https://chromium-review.googlesource.com/1231994 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:878303, chromium:877964 Change-Id: I9f0de35780861f3f121daa9952af70b332c11e98 Reviewed-on: https://chromium-review.googlesource.com/1231176Reviewed-by:
-
Jakob Gruber authored
As part of this, we also update all InvokeFunctionCode callers to pass ecx as the expected-argc register. Drive-by: Inline InvokeFunction overload into its single use. Bug: v8:6666 Change-Id: I67590ecc3f4981d014642c9e18d3ed6db9831e54 Reviewed-on: https://chromium-review.googlesource.com/1233653 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56040}
-
Jakob Gruber authored
OnStackReplacement itself was dead code. Bug: v8:6666 Change-Id: I72df335f23fb749e652899a170bb3dc800992ba7 Reviewed-on: https://chromium-review.googlesource.com/1232635 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Not much to do here. This CL bakes in incompatibility between poisoning and embedded builtins, since we cannot unconditionally reset the poison register (which we reused as kRootRegister) as we used to. It also exposes a bug introduced in [0] where we set Isolate::c_function to a garbage value. [0] https://chromium-review.googlesource.com/1185011 Bug: v8:6666 Change-Id: Ia606f5d0e86c7ff68aa2af22acb89c2844519bf5 Reviewed-on: https://chromium-review.googlesource.com/1233255 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This also adds checks that ebx contains the root pointer during indirect load. And we work around a few spots where we create an ebx Register but do not actually reference it (e.g. when emitting xmm3, which has the same code as ebx). Bug: v8:6666 Change-Id: I7ec9e644c2e9c59d6395a71c6c5f479fac711d8d Reviewed-on: https://chromium-review.googlesource.com/1231093 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
