Commits · 443e645a2d4e4d7ffa8d4229f0fe5b2e449c75bb · Linshizhi / V8

04 Feb, 2014 16 commits

Tests and fixes for (pre)parse errors related to strict reserved words. · 443e645a

marja@chromium.org authored Feb 04, 2014

This contains the following fixes:

- We had strict_reserved_word and unexpected_strict_reserved, which one to use
was totally mixed in Parser and PreParser. Removed strict_reserved_word.
- When we saw a strict future reserved word when expecting something completely
different (such as "(" in "function foo interface"), Parser reports unexpected
identifier, whereas PreParser used to report unexpected strict reserved
word. Fixed PreParser to report unexpected identifier too.
- Unified parser and preparser error locations when the name of a function is a
strict reserved word. Now both point to the name.

BUG=3126
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/149253010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

443e645a

Added a test which installs a poisonous memento right after the new space top pointer. · e5c7f4ef

hpayer@chromium.org authored Feb 04, 2014

BUG=
R=bmeurer@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/152813003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19066 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5c7f4ef

Add Box object to heap profiler. · efee3b86

alph@chromium.org authored Feb 04, 2014

LOG=Y
R=ulan@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/143343006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19063 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

efee3b86

Tests for (pre)parse errors when "eval" and "arguments" are found in inappropriate places. · 27949558

marja@chromium.org authored Feb 04, 2014

In addition:
- Fix a bug in parser discovered by the tests (prefix and postfix confused in an
error message); the preparser had it right.
- Unify the parser and preparser error locations when the name of a function is
"eval" or "arguments. Now both point to the name.

BUG=3126
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/153693002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19062 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

27949558

Fix in array instance type initialization. · 0f89c8b9

ishell@chromium.org authored Feb 04, 2014

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/134713004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19058 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f89c8b9

Remake of the load elimination fix made earlier (r18884). · 05270212

ishell@chromium.org authored Feb 04, 2014

R=titzer@chromium.org, verwaest@chromium.org

Review URL: https://codereview.chromium.org/149063010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19057 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

05270212

Just initialize elements pointer in fast literal when pre-tenuring. · 8d1504b2

hpayer@chromium.org authored Feb 04, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/148253004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19056 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8d1504b2

Remove unused AllocationSpace paramenter from CollectGarbage. · 2afcfc0b

hpayer@chromium.org authored Feb 04, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/148943004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19054 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2afcfc0b

Revert "Tests for (pre)parse errors when "eval" and "arguments" are found in inappropriate places." · f62ef25c

marja@chromium.org authored Feb 04, 2014

Reason: The fixed error message broke some tests.

This reverts r19050.

BUG=
TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/153673002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19053 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f62ef25c

Add per-file OWNERS for MIPS-specific cctests · a550a188

jkummerow@chromium.org authored Feb 04, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/148923003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19052 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a550a188

Check the offset argument of TypedArray.set for fitting into Smi. · a03d3139

dslomov@chromium.org authored Feb 04, 2014

R=jkummerow@chromium.org
BUG=340125
LOG=Y

Review URL: https://codereview.chromium.org/145623009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19051 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a03d3139

Tests for (pre)parse errors when "eval" and "arguments" are found in inappropriate places. · 9aa05b09

marja@chromium.org authored Feb 04, 2014

In addition:
- Fix a bug in parser discovered by the tests (prefix and postfix confused in an
  error message); the preparser had it right.
- Unify the parser and preparser error locations when the name of a function is
  "eval" or "arguments. Now both point to the name.

BUG=3126
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/140543003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19050 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9aa05b09

Revert "Dispose Isolate at end of cctest." · 681289e0

svenpanne@chromium.org authored Feb 04, 2014

Things work locally, only the waterfall is unhappy for some arcane reason.
Investigating...

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/133193006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19049 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

681289e0

Dispose Isolate at end of cctest. · 4a4e64d6

svenpanne@chromium.org authored Feb 04, 2014

No measurable change in test running time, we clean up only trivial
known things at disposal time and do not walk the heap, run real
finalizers, etc.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/135153007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19047 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4a4e64d6

Prepare push to trunk. Now working on version 3.24.32. · 110ff9a2

machenbach@chromium.org authored Feb 04, 2014

R=bmeurer@chromium.org
TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/138303004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19044 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

110ff9a2

MIPS: Unroll push loop in r19040 and other push optimizations. · 69d8678b

palfia@homejinni.com authored Feb 04, 2014

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/145973015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19042 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

69d8678b

03 Feb, 2014 10 commits

MIPS: let load and store api callbacks use global proxy as receiver. · 4ac8778b

plind44@gmail.com authored Feb 03, 2014

Port r19033 (c31b3e7)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/152943002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19040 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4ac8778b

let load and store api callbacks use global proxy as receiver · ef2ca4ac

dcarney@chromium.org authored Feb 03, 2014

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/151063003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19033 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ef2ca4ac

Fix short-circuiting logical and/or in HOptimizedGraphBuilder. · 9e70f6a4

yangguo@chromium.org authored Feb 03, 2014

R=jkummerow@chromium.org
BUG=336148
LOG=Y

Review URL: https://codereview.chromium.org/143263022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19031 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9e70f6a4

Elements field of newly allocated JSArray could be left uninitialized in some... · b98637ce

ishell@chromium.org authored Feb 03, 2014

Elements field of newly allocated JSArray could be left uninitialized in some cases (fast literal case).

BUG=340124
LOG=Y
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/152673004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19026 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b98637ce

Make memento checks more stable. Add filler at the end of new space and check... · 559826f6

hpayer@chromium.org authored Feb 03, 2014

Make memento checks more stable. Add filler at the end of new space and check if object and memento are on the same new space page.

BUG=
R=bmeurer@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/152613002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19024 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

559826f6

Return a valid map for PropertyAccessInfos with Boolean type. · db7124dc

verwaest@chromium.org authored Feb 03, 2014

BUG=340064
LOG=N
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/152603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19023 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

db7124dc

[x64] add disasm for two fp instructions · 6f95c0b1

yangguo@chromium.org authored Feb 03, 2014

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/146583002

Patch from Weiliang Lin <weiliang.lin@intel.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6f95c0b1

Re-enable escape analysis. · b6625976

jarin@chromium.org authored Feb 03, 2014

R=danno@chromium.org, mstarzinger@chromium.org
LOG=Y
BUG=

Review URL: https://codereview.chromium.org/142843004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19021 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b6625976

More cctest fixes regarding lifetime/ownership. · 16bcd431

svenpanne@chromium.org authored Feb 03, 2014

   * Avoid double-free in cctest/test-api/RegExpInterruption.

   * Avoid incorrect zone fiddling in cctest/test-strings.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/144533005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19020 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

16bcd431

Prepare push to trunk. Now working on version 3.24.31. · 3cbe565f

machenbach@chromium.org authored Feb 03, 2014

R=bmeurer@chromium.org
TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/152523002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3cbe565f

01 Feb, 2014 6 commits

Replace nonexistent a4 by t0 on mips. · ea8e42c6

verwaest@chromium.org authored Feb 01, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/136093010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19016 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea8e42c6

Ensure we don't clobber the cell on ARM and MIPS · 77ccf369

verwaest@chromium.org authored Feb 01, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/151543003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19015 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77ccf369

Ensure the word after top is cleared in newspace if top < high. · 9e995fdd

verwaest@chromium.org authored Feb 01, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/151783002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19014 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9e995fdd

Fix expectations for new regression test. · d34938fe

machenbach@chromium.org authored Feb 01, 2014

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/150853004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19013 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d34938fe

Prepare push to trunk. Now working on version 3.24.30. · 0b791c5f

machenbach@chromium.org authored Feb 01, 2014

R=verwaest@chromium.org
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/137893030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19010 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0b791c5f

MIPS: Remove CallICs · 1142dcc8

palfia@homejinni.com authored Feb 01, 2014

Port r19001 (4b5aa649)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/151903003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19009 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1142dcc8

31 Jan, 2014 8 commits

MIPS: Fix zlib critical performance regression. · 40fb3bb0

plind44@gmail.com authored Jan 31, 2014

The very low score on zlib benchmark is caused by
huge number of deoptimizations inside BinaryOpIC stubs
when arguments are boolean.

TEST=
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/136193011

Patch from Dusan Milosavljevic <Dusan.Milosavljevic@rt-rk.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19006 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

40fb3bb0

Adjust test expectations to new error on method not found · eab6854f

verwaest@chromium.org authored Jan 31, 2014

BUG=
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/151483004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19005 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eab6854f

Remove CallICs · ae7a209e

verwaest@chromium.org authored Jan 31, 2014

BUG=
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/148223002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19001 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ae7a209e

[Sheriff] Mark new regression test flaky on linux 32. · 30fb7b83

machenbach@chromium.org authored Jan 31, 2014

BUG=
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/148483004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19000 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

30fb7b83

Simpler repro for bug 2989. · 3c2363f4

jarin@chromium.org authored Jan 31, 2014

We do not correctly handle accesses to f.arguments after one
of the argument has changed (where f is crankshafted).

R=machenbach@chromium.org
BUG=v8:2989
LOG=n

Review URL: https://codereview.chromium.org/151403003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18999 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3c2363f4

Migrate crashing tests from blink repository. · 5d146395

machenbach@chromium.org authored Jan 31, 2014

TBR=bmeurer@chromium.org
BUG=237872
LOG=n

Review URL: https://codereview.chromium.org/144533006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18996 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5d146395

Remove IsRegExpEquivalent. · 253edf24

jochen@chromium.org authored Jan 31, 2014

It's not used anywhere.

BUG=none
R=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/141563013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18995 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

253edf24

Prepare push to trunk. Now working on version 3.24.29. · 75bc1d56

machenbach@chromium.org authored Jan 31, 2014

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/138843008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18991 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

75bc1d56