1. 06 Dec, 2018 1 commit
    • tzik's avatar
      Replace %RunMicrotasks with %PerformMicrotaskCheckpoint · 07011cc4
      tzik authored
      This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
      
      RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
      and may causes nested Microtasks in a problematic way. E.g. that confuses
      v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
      
      OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
      respects the microtask suppressions.
      
      As all existing tests don't call RunMicrotasks() in the suppressed situation
      (like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
      not affect to these tests.
      
      Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
      Reviewed-on: https://chromium-review.googlesource.com/c/1360095Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58068}
      07011cc4
  2. 10 Jan, 2017 1 commit
  3. 08 Nov, 2016 1 commit
  4. 07 Nov, 2016 2 commits
  5. 31 May, 2016 1 commit
    • littledan's avatar
      [esnext] Fix various callsites to use is_resumable, not is_generator · 46253e74
      littledan authored
      Async functions are built out of generators, but the
      SharedFunctionInfo returns false for is_generator. is_resumable is
      the broader query. This patch fixes many parts of V8 to refer
      to is_resumable as appropriate.
      
      One incidental change is to remove a check for generators extending
      classes. This is part of a general check for constructors being the
      only thing which can extend classes, so it is removed here and the
      error message for the general case is made more accurate.
      
      BUG=v8:4483
      
      Review-Url: https://codereview.chromium.org/1996943002
      Cr-Commit-Position: refs/heads/master@{#36621}
      46253e74
  6. 17 May, 2016 1 commit