- 27 May, 2022 11 commits
-
-
Leszek Swirski authored
LoadHandler can also contain Code handlers (for StringLength and FunctionPrototype). Fixed: v8:12911 Change-Id: I2fd2dcb65a3283e9a748a1b1cf382f6eeef1f263 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669253 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80777}
-
Leszek Swirski authored
This reverts commit 5f0e7dd4. Reason for revert: Turns out this isn't true: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/ic/ic.cc;l=946 Original change's description: > [ic] Shadow smi_handler on LoadHandler to always be Smi > > StoreHandlers can store either a Code object or a Smi, so the > smi_handler field on DataHandler is a Code|Smi. But, LoadHandlers can > only store Smis here so add a shadowing smi_handler definition which > only allows / returns Smis. > > Change-Id: Icc1c508db268950990b9c84b9e682b9a9b1f43e5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663745 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80775} Change-Id: Ia2c14141ab5929be3ded883f0cecb40645a72dfd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672419 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80776}
-
Leszek Swirski authored
StoreHandlers can store either a Code object or a Smi, so the smi_handler field on DataHandler is a Code|Smi. But, LoadHandlers can only store Smis here so add a shadowing smi_handler definition which only allows / returns Smis. Change-Id: Icc1c508db268950990b9c84b9e682b9a9b1f43e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663745 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
The cctest test-code-generator/FuzzAssembleMove fuzzes codegen for a random list of sequential moves by simulating the moves on a FixedArray, and comparing the result to the output of the generated code. Add a variant of this test that resolves parallel moves first, to also test integration with the gap resolver. Bug: chromium:1313647 Change-Id: I02f385a957dafc89d91a4ab2216e0ac72147536d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660252Reviewed-by:
Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80774}
-
Leszek Swirski authored
This reverts commit ab76ffc8. Reason for revert: Breaks on UBSan: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/21444/overview Original change's description: > [builtins] use SIMD IndexOf/includes on large arrays > > Change-Id: If751e813c7f45a4d18b84e8c0314a54c84894d61 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639203 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Darius Mercadier <dmercadier@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80771} Change-Id: I62dd4249df122af567680cbaa18deb3c9ed44c90 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672416 Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80773}
-
Alan Zhao authored
Currently, llvm-ml only assembles files that have the .asm extension, so push_registers_masm.S fails to get assembled. This CL changes the extension of the x86 and x64 push_registers_masm.S files to .asm. I'll work on a patch to support assembling files with the .S extension in llvm-ml, but in the meantime, we should probably rename the files as it is customary for Intel syntax assembly files to have the .asm extension[0]. ARM assembly files don't use llvm-ml, so we don't need to rename them. [0]: https://stackoverflow.com/a/34098830 Change-Id: Ie4db42b78dd358c3ec0de83e9518aa5c60f6d175 Bug: chromium:762167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668287 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80772}
-
Darius M authored
Change-Id: If751e813c7f45a4d18b84e8c0314a54c84894d61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639203Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80771}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/1c67b4e..1658259 Cherry-Pick PR2096 to fix TimeZone name (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/1658259 Cherry-pick PR2100 (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/5b063af Cherry-pick PR2086 to fix out-of-bound result from Calendar::get() (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/4c1a868 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I4251dcf0096500302ceaae58feafd44ff32661aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671978 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80770}
-
Frank Tang authored
Refactor ToTemporalTimeRecord to a new routine ToTemporalTimeRecordOrPartialTime to share code with ToPartilTime Change the return type of ToTemporalTimeRecord, RegulateTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.with https://tc39.es/proposal-temporal/#sec-temporal-topartialtime Bug: v8:11544 Change-Id: I214147f497a405ee48e264833c7c0b9401596c01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3665269Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80769}
-
QiuJi authored
Also remove useless comment in test-assembler-riscv64 Change-Id: I28451386449f15542b02383d8bf1aa9c4539469c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669660 Auto-Submit: ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80768}
-
Frank Tang authored
Also add AO: ToPartialDuration Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-topartialduration https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.with Bug: v8:11544 Change-Id: I43282f5285a3c884229445547add6db2cde4fbe4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380102Reviewed-by:
-
- 26 May, 2022 10 commits
-
-
Adam Klein authored
This test had been skipped since it was added in 4a416dbb. Bug: v8:9380 Change-Id: I700f83fa4242baf44dd260fbc74520abf05101dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3670052 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80766}
-
Milad Fa authored
This CL adds a check to all integer/and fp load/store operations, if the offset fits in an `is_int16` and if alignment requirements are met (specific to lwa, ld and std) then a non prefixed load/store instruction will be used. Note that operation mode (MRI vs MRR) gets set during instruction selection. Change-Id: I68e2aa1d559c7ff058d715e6e577a14b590b632b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669186Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80765}
-
Frank Tang authored
Also add AO: ConsolidateCalendars Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaindate https://tc39.es/proposal-temporal/#sec-temporal-consolidatecalendars Bug: v8:11544 Change-Id: I98084f7cc92a837f6401a88ad10389a7c5df8b3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563541 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit dec192fd. Reason for revert: broke gcc builds because of [[nodiscard]] Original change's description: > Roll inspector_protocol to 87e75896dcfcafda7869b0c9714db9b6cdc4c765 > > This lets us accept spec-compliant CBOR tag for message envelopes. > > This also includes a change in v8-inspector-session-impl.cc that > relaxes an envelope check to allow spec-compliant envelopes. > > Change-Id: Id77c1e0fc4b62d78e8580f81ef38d50e3eb54a1d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662540 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80761} Change-Id: Iaa0cc65510c9af6391a2c7d0ef7baf903335a328 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669468 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#80763}
-
Manos Koukoutos authored
We inline array allocation for wasm-gc in the TF graph by using AllocateRaw nodes. Additionally, we use memset to initialize large, zero-initialized arrays. These changes give measurable speedup in some benchmarks. Bug: v8:7748 Change-Id: Icbd37d0fe673c673379139b96d0e1c175e95e357 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666618Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80762}
-
Andrey Kosyakov authored
This lets us accept spec-compliant CBOR tag for message envelopes. This also includes a change in v8-inspector-session-impl.cc that relaxes an envelope check to allow spec-compliant envelopes. Change-Id: Id77c1e0fc4b62d78e8580f81ef38d50e3eb54a1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662540Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#80761}
-
Rob Paveza authored
Initialization after reset + unnecessary use of handle scope appear to be the culprit here. Most of the other functions in debug::Script do not use HandleScope, so this reconciles these differences. Additionally, the call to obtain and initialize the hash within ActualScript::Initialize was inconsistent: all of the other fields were initialized prior to resetting the script and source. These reconciliations appear to fix this crash. Bug: chromium:1325036 Change-Id: Ia86e83b6c99955a3ac80a4a8845c0df0172e991c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648082 Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Auto-Submit: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80760}
-
Lu Yahan authored
Port commit 22a16bda Change-Id: I1a6815ca22f4b931ffd2468d8aeb82dc7a1e2bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669661 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80759}
-
Jakob Kummerow authored
We can simply trap in the runtime, instead of returning sentinels. Bug: v8:7748, v8:12425 Change-Id: I179c8675fabd3cb730f002ba99ba8cf942a9d4ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669108Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80758}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.toplaindatetime Bug: v8:11544 Change-Id: I95bab9814471bb9347101d654f6dc902159f8fe3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3538670Reviewed-by:
-
- 25 May, 2022 19 commits
-
-
Shu-yu Guo authored
IsCompiledScope retains code to be safe against bytecode flushing, but %PrepareFunctionForOptimization isn't currently initializing it with the function's current compiled state. IOW, it's only retaining freshly compiled code and is causing flakes for already-compiled functions. Bug: v8:12697 Change-Id: Ie82a4adb8a136da708b3ae0ce27a42f5c277d324 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668318Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-date.prototype.totemporalinstant Bug: v8:11544 Change-Id: I65315152333291f76edc05cc41a528912a185d02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3609214 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.startofday Bug: v8:11544 Change-Id: I475e03fa9ba43290896a906524414cfbddd1f7bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3385610 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Milad Fa authored
ip holds the jump table slot. Change-Id: Ia56bf62835155d58ef10e57d761088d0b9a9710d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668285Reviewed-by:
-
Milad Fa authored
Port 22a16bda Original Commit Message: The Runtime_WasmCompileLazy function was returning a ptr-sized address, wrapped in an Object. This worked because no GC is triggered between the return from the runtime function and the point where we jump to the returned address. In a pointer-compressed world though, generated code assumes that all objects live in the same 4GB heap, so comparisons only compare the lower 32 bit. On a 64-bit system, this can lead to collisions where a comparison determines that the returned address equals a heap object, even though the upper 32-bit differ. This happens occasionally in the wild, where the returned function entry pointer has the same lower half than the exception sentinel value. This leads to triggering stack unwinding (by the CEntry stub), which then fails (with a CHECK) because there is no pending exception. This CL fixes that by returning a Smi instead which is the offset in the jump table where the kWasmCompileLazy builtin should jump to. The builtin then gets the jump table start address from the instance object, adds the offset that the runtime function returned, and performs the jump. We do not include a regression test because this failure is very spurious and hard to reproduce. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I92907b97a9d44d8cf42bb356ef350a22f7c5d5e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666249 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:12907 Change-Id: I8a6da86b4c88b5cfcc9bbb349841c422ac81b64e No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667082 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Andy Wingo authored
Bug: v8:12868 Also adds the equivalent of Utf8Decoder, but for WTF-8. Change-Id: I1548a44b0aea912cdd429eb85be4dfc606355cad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660257Reviewed-by:
-
Dominik Inführ authored
The fast path of all write barriers already got mostly unified in https://crrev.com/c/3644964. However, the shared heap write barrier still added a new branch in the fast path of the full write barrier. This CL unifies the branch for the generational and the shared heap write barrier in the fast path at the cost of an additional branch in the slow path. This should hopefully the rest of the regressions caused by introducing the shared heap write barrier. Bug: chromium:1326446, v8:11708 Change-Id: Id5a8334c50a7455e53caf65891d4304d9d2e7702 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663091 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80749}
-
Maya Lekova authored
The generated code checks if the receiver is a JS_API_OBJECT and if the receiver requires an access check, and if not it lowers the call to an API call. We also add compilation dependencies on the protector cell to deopt if our invariants change. (Note - the actual invalidation of these cells will be implemented in a follow up CL) Bug: v8:11321 Change-Id: I15722f1e5fac7176e292da4a35186e4609636aba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719563 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Anton Bikineev authored
Due to collections with inlined storage, Oilpan still supports on-stack Members, which are always compressed if pointer compression is enabled. This CL scans halfwords (together with full words) on stack to find potential pointers. Since on-heap pointers can only be compressed and in-construction objects always reside on heap, only halfwords need to be scanned for them. The alternative potential followup approaches: 1) Use a separate uncompressed type for pointer in inlined collections; 2) Dynamically register regions of stack containing compressed pointers. Bug: chromium:1325007 Change-Id: Ia706fd8e7383d30aff11f4014faa9edd3d289a55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644959Reviewed-by:
-
Manos Koukoutos authored
We introduce wasm-gc specific nodes into the Turbofan IR, corresponding to the wasm opcodes: ref.as_non_null, ref.is_null, ref.null, rtt.canon, ref.test, ref.cast. We define them as simplified operators. These are lowered by a dedicated phase in the wasm pipeline. Optimizations based on these nodes will be introduced later. Note: We rename ObjectReferenceKnowledge to WasmTypeCheckConfig and move it to a separate file, as it is now used in simplified-operator as well. Bug: v8:7748 Change-Id: Iceaf04eca089b08bad794f567359196e8ba78d93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3654102Reviewed-by:
-
Dominik Inführ authored
There is now only one invocation left of MemoryAllocator::Unmapper::FreeQueuedChunks in the GC epilogue. Bug: chromium:1329064, chromium:1327132 Change-Id: Icc21ada4c5a8a9505ed6435ef1f62fe48b2dbb52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667079 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Seth Brenith authored
This change reverts the following: 400b2cc2 Don't rescue old top-level SharedFunctionInfos Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3657472 16a7150b Reland "Disable recompilation of existing Scripts from Isolate compilation cache" Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3655011 2df4d58a Fix rehashing of script compilation cache Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3654413 c8848cf4 Refactor CompilationSubCache Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3629603 25072178 Improve Script reuse in isolate compilation cache, part 1 Reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/3597106 Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601, chromium:1328671, chromium:1328672, chromium:1328678, chromium:1328811, chromium:1328810 Change-Id: I1d318dc172e5214166d3b15f19903186f4fe6024 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3664023Reviewed-by:
-
Milad Fa authored
GN is not available as a cipd package for ppc/s390 and needs to be built from source. Change-Id: I5f6eda13cd6227d20fc800cab7f54496a2d33f68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663154Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Igor Sheludko authored
When a callback does not intercept the request 1) it should not call info.GetReturnValue().Set(), 2) it must not produce side effects. Bug: v8:12873, chromium:1310062 Change-Id: If02994f24f1a68eb96c1af7cdd6dd7109f0617c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652786Reviewed-by:
-
Simon Zünd authored
This CL fixes an issue with async stacks. The async task stack is not torn down between page navigations or reloads. The result is that any new async tasks are stacked on top of the old pages async task stack. This was not prominent until now for two reasons: 1) Async tasks created in blink are always finished as long as destructors have time to run. 2) When V8 is terminated while running the micro task queue also all async tasks created for Promises (including `await`) are cleaned up properly. Introducing the stack tagging API made it more common for having unfinished async tasks open outside the MTQ, which left the async task stack non-empty during navigation. This CL fixes this problem by clearing out all the async task and async stack data structures for a context group when that context group is reset. R=bmeurer@chromium.org, victorporof@chromium.org Fixed: chromium:1328785 Change-Id: Iee0c3c4a55f66e643829dae3726dc03c735da1dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666620Reviewed-by: -
Darius M authored
Bug: v8:12865 Change-Id: I539a5b0a9c3c78ef9a767de75b71dd06de337d9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647351Reviewed-by:
-
Samuel Groß authored
V8_SANDBOX has been renamed to V8_ENABLE_SANDBOX in crrev.com/c/3647355 and its remaining uses in Chromium have now been renamed as well. Bug: v8:10391 Change-Id: Ibb23ecab6687438b462685ef7fa044c0024dd098 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660251Reviewed-by:
-
Clemens Backes authored
There were multiple fields missing from the output. R=jkummerow@chromium.org Change-Id: Ie4c3171339943414c58c2fe6f0e507cdd531dd8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3664497Reviewed-by:
-
