1. 30 May, 2018 1 commit
    • Leszek Swirski's avatar
      [sfi] Compress function arg counts to 16 bit · 53d4dfc3
      Leszek Swirski authored
      Compress the parameter count (and function length) stored in
      SharedFunctionInfo to a uint16_t. This limits us to 2^16 - 1 parameters
      per function, minus one for the "don't adapt arguments" sentinel value,
      which is one fewer than Code::kMaxArguments was already. Anyway, 65534
      arguments should be enough for anyone!
      
      This drops SFI size by 4 bytes.
      
      Bug: chromium:818642
      Change-Id: I126bfb24453dcdc5087a104d3a12cf195a56fa9f
      Reviewed-on: https://chromium-review.googlesource.com/1076627
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53447}
      53d4dfc3
  2. 20 Oct, 2017 1 commit
  3. 16 Aug, 2017 1 commit
  4. 03 Aug, 2017 1 commit
  5. 19 Jul, 2017 1 commit
  6. 07 Jun, 2017 1 commit
  7. 20 Apr, 2017 1 commit
  8. 27 Jan, 2017 1 commit
    • yangguo's avatar
      [liveedit] reimplement frame restarting. · 3f47c63d
      yangguo authored
      Previously, when restarting a frame, we would rewrite all frames
      between the debugger activation and the frame to restart to squash
      them, and replace the return address with that of a builtin to
      leave that rewritten frame, and restart the function by calling it.
      
      We now simply remember the frame to drop to, and upon returning
      from the debugger, we check whether to drop the frame, load the
      new FP, and restart the function.
      
      R=jgruber@chromium.org, mstarzinger@chromium.org
      BUG=v8:5587
      
      Review-Url: https://codereview.chromium.org/2636913002
      Cr-Commit-Position: refs/heads/master@{#42725}
      3f47c63d
  9. 12 Jan, 2017 1 commit
  10. 06 Sep, 2016 1 commit
    • marja's avatar
      Include only stuff you need, part 8: Fix debug.h -> liveedit.h. · 51a3ffd9
      marja authored
      Rebuilding (after touching certain files) is crazy slow because
      includes are out of control.
      
      The (last remaining) offending include path is: ast.h <- liveedit.h <-
      debug.h <- src/x64/assembler-whatever-port-inl.h <-
      src/macro-assembler.h <- everything possible
      
      With this CL, the rebuild steps needed when touching ast-value-factory.h
      drops from 365 to 181.
      
      BUG=v8:5294
      TBR=bmeurer@chromium.org
      
      Review-Url: https://codereview.chromium.org/2316443002
      Cr-Commit-Position: refs/heads/master@{#39195}
      51a3ffd9
  11. 09 Jun, 2016 1 commit
    • ishell's avatar
      [ic] [stubs] Remove InlineCacheState field from the code flags. · 9dc62d27
      ishell authored
      There are no ICs left that store their state in this field: vector based
      ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
      ToBooleanIC) reconstruct their state from the ExtraICState field.
      
      This CL also removes unused InlineCacheState::DEBUG_STUB which was used
      mostly in Code::is_debug_stub(). The latter now checks if the code is one
      of the debug builtins instead.
      
      BUG=chromium:618701
      LOG=Y
      
      Review-Url: https://codereview.chromium.org/2052763003
      Cr-Commit-Position: refs/heads/master@{#36871}
      9dc62d27
  12. 30 Mar, 2016 1 commit
    • mythria's avatar
      [Interpreter] Adds support to fetch return value on break at return. · b82720df
      mythria authored
      Debugger fetches the return value of a function when we break at return.
      Interpreter holds the return value in accumulator. This is not stored in a
      specified location on stack and hence it is not possible to look it up from
      stack similar to full-codegen or optimized frames. This cl adds support to
      store the value of accumulator on debug breaks. The value of accumulator is
      passed to the runtime function and is then stored in thread local data.
      
      Also changes full-codegen implementation to match that of ignition.
      The return value from full-codegen is also stored in thread local data.
      The return value is fetched directly thread local data instead of
      finding it by iterating over frames.
      
      BUG=v8:4280, v8:4690
      LOG=N
      
      Review URL: https://codereview.chromium.org/1842683002
      
      Cr-Commit-Position: refs/heads/master@{#35127}
      b82720df
  13. 24 Mar, 2016 2 commits
    • machenbach's avatar
      Revert of [Interpreter] Adds support to fetch return value on break at return.... · 25d2b247
      machenbach authored
      Revert of [Interpreter] Adds support to fetch return value on break at return. (patchset #9 id:160001 of https://codereview.chromium.org/1818873003/ )
      
      Reason for revert:
      [Sheriff] Seems to break nosnap debug:
      https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6019
      
      Original issue's description:
      > [Interpreter] Adds support to fetch return value on break at return.
      >
      > Debugger fetches the return value of a function when we break at return.
      > Interpreter holds the return value in accumulator. This is not stored in a
      > specified location on stack and hence it is not possible to look it up from
      > stack similar to full-codegen or optimized frames. This cl adds support to
      > store the value of accumulator on debug breaks. The value of accumulator is
      > passed to the runtime function and is then stored in thread local data.
      >
      > Also changes full-codegen implementation to match that of ignition.
      > The return value from full-codegen is also stored in thread local data.
      > The return value is fetched directly thread local data instead of
      > finding it by iterating over frames.
      >
      > BUG=v8:4280, v8:4690
      > LOG=N
      >
      > Committed: https://crrev.com/fb65527b75754bcf3b173f16f5d0b04a1c6d9b99
      > Cr-Commit-Position: refs/heads/master@{#35060}
      
      TBR=rmcilroy@chromium.org,yangguo@chromium.org,weiliang.lin@intel.com,balazs.kilvady@imgtec.com,jyan@ca.ibm.com,mythria@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:4280, v8:4690
      
      Review URL: https://codereview.chromium.org/1834733002
      
      Cr-Commit-Position: refs/heads/master@{#35065}
      25d2b247
    • mythria's avatar
      [Interpreter] Adds support to fetch return value on break at return. · fb65527b
      mythria authored
      Debugger fetches the return value of a function when we break at return.
      Interpreter holds the return value in accumulator. This is not stored in a
      specified location on stack and hence it is not possible to look it up from
      stack similar to full-codegen or optimized frames. This cl adds support to
      store the value of accumulator on debug breaks. The value of accumulator is
      passed to the runtime function and is then stored in thread local data.
      
      Also changes full-codegen implementation to match that of ignition.
      The return value from full-codegen is also stored in thread local data.
      The return value is fetched directly thread local data instead of
      finding it by iterating over frames.
      
      BUG=v8:4280, v8:4690
      LOG=N
      
      Review URL: https://codereview.chromium.org/1818873003
      
      Cr-Commit-Position: refs/heads/master@{#35060}
      fb65527b
  14. 08 Mar, 2016 1 commit
    • danno's avatar
      [runtime] Unify and simplify how frames are marked · 9dcd0857
      danno authored
      Before this CL, various code stubs used different techniques
      for marking their frames to enable stack-crawling and other
      access to data in the frame. All of them were based on a abuse
      of the "standard" frame representation, e.g. storing the a
      context pointer immediately below the frame's fp, and a
      function pointer after that. Although functional, this approach
      tends to make stubs and builtins do an awkward, unnecessary
      dance to appear like standard frames, even if they have
      nothing to do with JavaScript execution.
      
      This CL attempts to improve this by:
      
      * Ensuring that there are only two fundamentally different
        types of frames, a "standard" frame and a "typed" frame.
        Standard frames, as before, contain both a context and
        function pointer. Typed frames contain only a minimum
        of a smi marker in the position immediately below the fp
        where the context is in standard frames.
      * Only interpreted, full codegen, and optimized Crankshaft and
        TurboFan JavaScript frames use the "standard" format. All
        other frames use the type frame format with an explicit
        marker.
      * Typed frames can contain one or more values below the
        type marker. There is new magic macro machinery in
        frames.h that simplifies defining the offsets of these fields
        in typed frames.
      * A new flag in the CallDescriptor enables specifying whether
        a frame is a standard frame or a typed frame. Secondary
        register location spilling is now only enabled for standard
        frames.
      * A zillion places in the code have been updated to deal with
        the fact that most code stubs and internal frames use the
        typed frame format. This includes changes in the
        deoptimizer, debugger, and liveedit.
      * StandardFrameConstants::kMarkerOffset is deprecated,
        (CommonFrameConstants::kContextOrFrameTypeOffset
        and StandardFrameConstants::kFrameOffset are now used
        in its stead).
      
      LOG=N
      
      Review URL: https://codereview.chromium.org/1696043002
      
      Cr-Commit-Position: refs/heads/master@{#34571}
      9dcd0857
  15. 10 Feb, 2016 1 commit
  16. 04 Dec, 2015 3 commits
  17. 03 Dec, 2015 5 commits
  18. 02 Dec, 2015 1 commit
  19. 27 Nov, 2015 1 commit
  20. 12 Aug, 2015 1 commit
  21. 31 Jul, 2015 1 commit
  22. 23 Jul, 2015 1 commit
    • danno's avatar
      Unify "runtime-style" IC functions with Runtime intrinsics · bc8041dc
      danno authored
      Previous to this CL, ICs used a slightly different code idiom
      to get to C++ code from generated code than runtime intrinsics,
      using an IC_Utility class that in essence provided exactly
      the same functionality as Runtime::FunctionForId, but in its
      own quirky way.
      
      This CL unifies the two mechanisms, folding IC_Utility
      away by making all IC entry points in C++ code, e.g. IC
      miss handlers, full-fledged runtime intrinsics. This makes
      it possible to eliminate a bunch of ad-hoc declarations and
      adapters that the IC system had to needlessly re-invent.
      
      As a bonus and the original reason for this yak-shave:
      IC-related C++ runtime functions are now callable from
      TurboFan.
      
      Review URL: https://codereview.chromium.org/1248303002
      
      Cr-Commit-Position: refs/heads/master@{#29811}
      bc8041dc
  23. 15 Jul, 2015 1 commit
  24. 10 Jul, 2015 2 commits
  25. 06 Jul, 2015 1 commit
  26. 08 Jun, 2015 1 commit
  27. 01 Jun, 2015 1 commit
  28. 20 May, 2015 1 commit
  29. 15 May, 2015 1 commit
  30. 04 Mar, 2015 1 commit
    • yangguo's avatar
      Refactor BreakLocationIterator. · 1a608493
      yangguo authored
      We now have BreakLocation::Iterator to iterate via RelocIterator, and
      create a BreakLocation when we are done iterating. The reloc info is
      stored in BreakLocation in a GC-safe way and instantiated on demand.
      
      R=ulan@chromium.org
      BUG=v8:3924
      LOG=N
      
      Review URL: https://codereview.chromium.org/967323002
      
      Cr-Commit-Position: refs/heads/master@{#26983}
      1a608493
  31. 08 Oct, 2014 1 commit
  32. 03 Sep, 2014 1 commit