1. 21 May, 2019 1 commit
    • Simon Zünd's avatar
      Reland "[stack-trace] Include API functions in Error.stack stack trace" · 193a2617
      Simon Zünd authored
      This is a reland of 3dd56612
      
      The reland introduces a new flag "--experimental-stack-trace-frames".
      The flag is disabled by default, but enabled for relevant tests.
      The flag stays disabled by default until API frames are eagerly
      symbolized to prevent leaks in blink web tests.
      
      Original change's description:
      > [stack-trace] Include API functions in Error.stack stack trace
      >
      > This CL extends Error.stack to include frames of functions declared
      > with the C++ FunctionTemplate API. For example, "print" in d8.
      >
      > Two changes are necessary:
      >   - HandleApiCall and friends need to go through an BUILTIN_EXIT frame
      >     instead of an EXIT frame. The existing stack-trace machinery will
      >     then pick up FunctionTemplate frames without additional changes.
      >   - Turbofan doesn't go through HandleApiCall, but instead uses an
      >     ASM builtin to enter FunctionTemplate functions. A "marker"
      >     frame state is needed to include these frames in the stack trace.
      >
      > Note: This CL only includes these frames in Error.stack,
      > but not (yet) in the stack-trace API (v8.h).
      >
      > Bug: v8:8742,v8:6802
      > Change-Id: Ic0631af883cf56e0d0122a2e0c54e36fed324d91
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609835
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61602}
      
      Bug: v8:8742, v8:6802
      Change-Id: I1d3b79cdf0b2edcbaeff1ec15e10deeca725f017
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621925Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61683}
      193a2617
  2. 20 May, 2019 1 commit
    • Yang Guo's avatar
      Revert "[stack-trace] Include API functions in Error.stack stack trace" · 5cc9f9bc
      Yang Guo authored
      This reverts commit 3dd56612.
      
      Reason for revert: causes leak tests in blink layout tests to fail: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34295
      
      Steps to reproduce:
      - Build blink_tests with following GN args
      is_component_build = false
      is_debug = false
      strip_absolute_paths_from_debug_symbols = true
      - Run
      third_party/blink/tools/run_web_tests.py --additional-expectations third_party/blink/web_tests/LeakExpectations --time-out-ms 48000 --enable-leak-detection external/wpt/wasm/webapi/body.any.html
      
      Original change's description:
      > [stack-trace] Include API functions in Error.stack stack trace
      > 
      > This CL extends Error.stack to include frames of functions declared
      > with the C++ FunctionTemplate API. For example, "print" in d8.
      > 
      > Two changes are necessary:
      >   - HandleApiCall and friends need to go through an BUILTIN_EXIT frame
      >     instead of an EXIT frame. The existing stack-trace machinery will
      >     then pick up FunctionTemplate frames without additional changes.
      >   - Turbofan doesn't go through HandleApiCall, but instead uses an
      >     ASM builtin to enter FunctionTemplate functions. A "marker"
      >     frame state is needed to include these frames in the stack trace.
      > 
      > Note: This CL only includes these frames in Error.stack,
      > but not (yet) in the stack-trace API (v8.h).
      > 
      > Bug: v8:8742,v8:6802
      > Change-Id: Ic0631af883cf56e0d0122a2e0c54e36fed324d91
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609835
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61602}
      
      TBR=yangguo@chromium.org,sigurds@chromium.org,jgruber@chromium.org,bmeurer@chromium.org,szuend@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:8742, v8:6802
      Change-Id: I4942cd32c6ee5e249dae046eea6b9b2f7120b8ba
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617933Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61639}
      5cc9f9bc
  3. 17 May, 2019 1 commit
  4. 12 Jan, 2017 1 commit
  5. 20 Jul, 2016 2 commits
  6. 19 Jul, 2016 1 commit
  7. 18 Jul, 2016 1 commit
    • jochen's avatar
      Reland^2 "Don't compile functions in a context the caller doesn't have access to" · 02ba2441
      jochen authored
      Original issue's description:
      > Don't compile functions in a context the caller doesn't have access to
      >
      > Instead just return undefined
      >
      > A side effect of this is that it's no longer possible to compile
      > functions in a detached context.
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org,bmeurer@chromium.org
      
      BUG=chromium:541703
      R=verwaest@chromium.org
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
      
      Review-Url: https://codereview.chromium.org/2155503004
      Cr-Commit-Position: refs/heads/master@{#37842}
      02ba2441
  8. 14 Jul, 2016 3 commits
    • jochen's avatar
      Revert of Reland "Don't compile functions in a context the caller doesn't have... · 63449d21
      jochen authored
      Revert of Reland "Don't compile functions in a context the caller doesn't have access to" (patchset #4 id:60001 of https://codereview.chromium.org/2143893005/ )
      
      Reason for revert:
      blink is unhappy about the microtask change
      
      Original issue's description:
      > Reland "Don't compile functions in a context the caller doesn't have access to"
      >
      > Original issue's description:
      > > Don't compile functions in a context the caller doesn't have access to
      > >
      > > Instead just return undefined
      > >
      > > A side effect of this is that it's no longer possible to compile
      > > functions in a detached context.
      > >
      > > BUG=chromium:541703
      > > R=verwaest@chromium.org,bmeurer@chromium.org
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org
      >
      > Committed: https://crrev.com/6bceabac5b705b2ce1f52d34650cea1ae3b8c617
      > Cr-Commit-Position: refs/heads/master@{#37756}
      
      TBR=verwaest@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=chromium:541703
      
      Review-Url: https://codereview.chromium.org/2151843002
      Cr-Commit-Position: refs/heads/master@{#37760}
      63449d21
    • jochen's avatar
      Reland "Don't compile functions in a context the caller doesn't have access to" · 6bceabac
      jochen authored
      Original issue's description:
      > Don't compile functions in a context the caller doesn't have access to
      >
      > Instead just return undefined
      >
      > A side effect of this is that it's no longer possible to compile
      > functions in a detached context.
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org,bmeurer@chromium.org
      
      BUG=chromium:541703
      R=verwaest@chromium.org
      
      Review-Url: https://codereview.chromium.org/2143893005
      Cr-Commit-Position: refs/heads/master@{#37756}
      6bceabac
    • adamk's avatar
      Revert of Don't compile functions in a context the caller doesn't have access... · 68f205b2
      adamk authored
      Revert of Don't compile functions in a context the caller doesn't have access to (patchset #9 id:160001 of https://codereview.chromium.org/2034083002/ )
      
      Reason for revert:
      Causes crashes on Canary
      
      Original issue's description:
      > Don't compile functions in a context the caller doesn't have access to
      >
      > Instead just return undefined
      >
      > A side effect of this is that it's no longer possible to compile
      > functions in a detached context.
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org,bmeurer@chromium.org
      > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
      >
      > Committed: https://crrev.com/992e34c21635b179a993b82ac1d81753e7a6a57a
      > Cr-Commit-Position: refs/heads/master@{#37657}
      
      TBR=bmeurer@chromium.org,verwaest@chromium.org,jochen@chromium.org
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=chromium:541703, chromium:628053
      
      Review-Url: https://codereview.chromium.org/2148163002
      Cr-Commit-Position: refs/heads/master@{#37736}
      68f205b2
  9. 11 Jul, 2016 1 commit
  10. 12 Oct, 2015 2 commits
  11. 02 Oct, 2015 1 commit
  12. 18 Sep, 2014 1 commit
  13. 12 Jun, 2014 1 commit
  14. 19 May, 2014 1 commit