- 11 Jul, 2016 32 commits
-
-
bmeurer authored
This is follow-up cleanup for the flags that are no longer used inside SimplifiedLowering. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2132403002 Cr-Commit-Position: refs/heads/master@{#37652}
-
ishell authored
[runtime] Follow-up fix for "Better encapsulation of dictionary objects handling in lookup iterator." BUG=chromium:626715 Review-Url: https://codereview.chromium.org/2135253002 Cr-Commit-Position: refs/heads/master@{#37651}
-
bbudge authored
Clean up call sites. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2124983004 Cr-Commit-Position: refs/heads/master@{#37650}
-
bbudge authored
All architectures return false for now. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2135573003 Cr-Commit-Position: refs/heads/master@{#37649}
-
hpayer authored
BUG= Review-Url: https://codereview.chromium.org/2138783002 Cr-Commit-Position: refs/heads/master@{#37648}
-
jochen authored
R=verwaest@chromium.org,dcheng@chromium.org BUG= Review-Url: https://codereview.chromium.org/2137943003 Cr-Commit-Position: refs/heads/master@{#37647}
-
mstarzinger authored
This removes the frame state input representing the before-state from nodes having any comparison operator. Lowering that inserts number conversions of the inputs has to be disabled when deoptimization is enabled, because the frame state layout is no longer known. R=jarin@chromium.org BUG=v8:5021 Review-Url: https://codereview.chromium.org/2134173002 Cr-Commit-Position: refs/heads/master@{#37646}
-
mstarzinger authored
This extends pretenuring decisions based on allocation sites to heap numbers that are allocated as part of object literals. It ensures memory locality of a bigger enclosure of the deep copy of an object literal. R=bmeurer@chromium.org TEST=cctest/test-heap/OptimizedPretenuringMixedInObjectProperties Review-Url: https://codereview.chromium.org/2135933002 Cr-Commit-Position: refs/heads/master@{#37645}
-
jgruber authored
Builtin frames can simply use the existing JavaScriptFrame::Print method. Builtin exit frames need their own implementation which can print the function name, receiver and parameters. R=bmeurer@chromium.org, yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2134093002 Cr-Commit-Position: refs/heads/master@{#37644}
-
bmeurer authored
If the first input to CheckBounds is already an Unsigned32, then we can just truncate both inputs to word32 and lower the bounds check. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2138753002 Cr-Commit-Position: refs/heads/master@{#37643}
-
titzer authored
R=ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2135693002 Cr-Commit-Position: refs/heads/master@{#37642}
-
titzer authored
R=jarin@chromium.org, mstarzinger@chromium.org BUG= Review-Url: https://codereview.chromium.org/2132393002 Cr-Commit-Position: refs/heads/master@{#37641}
-
peterssen authored
BUG=chromium:508898 Review-Url: https://codereview.chromium.org/2135153002 Cr-Commit-Position: refs/heads/master@{#37640}
-
bmeurer authored
This unifies phases in SimplifiedLowering, and will enable more optimizations, i.e. we can do the output representation during typing then, which in turn should allow us to use the feedback type even in unchecked operators (i.e. NumberAbs). R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2137003002 Cr-Commit-Position: refs/heads/master@{#37639}
-
bmeurer authored
We can just do the Int32Abs lowering always for Signed32 inputs. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2134143002 Cr-Commit-Position: refs/heads/master@{#37638}
-
rmcilroy authored
BUG=v8:4280 Review-Url: https://codereview.chromium.org/2128233002 Cr-Commit-Position: refs/heads/master@{#37637}
-
neis authored
R=mstarzinger@chromium.org BUG= Review-Url: https://codereview.chromium.org/2134163002 Cr-Commit-Position: refs/heads/master@{#37636}
-
mstarzinger authored
R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2132373002 Cr-Commit-Position: refs/heads/master@{#37635}
-
caitp authored
BUG=v8:5174, v8:1543 R=cbruni@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2129193003 Cr-Commit-Position: refs/heads/master@{#37634}
-
danno authored
By adding MachineType to LinkageLocation, it is possible not only to reason about the location of a LinkageLocation on the stack, but also about it's size. This will be useful in follow-on CLs that attempt to merge some of the parameter passing logic of tail calls and normal (non-tail) calls. As a nice side-effect, it is no longer necessary to separately keep a MachineSignature in a CallDescriptor, because the MachineTypes contianed in LinkageLocation for all of the Descriptor's parameters and return types are sufficient. This CL therefore removes the MachineSignature from the CallDescriptor and adjusts all the calling code accordingly, simplifying and de-duplicating code in a bunch of places. R=titzer@chromium.org, bmeurer@chromium.org LOG=N Review-Url: https://codereview.chromium.org/2124023003 Cr-Commit-Position: refs/heads/master@{#37633}
-
jkummerow authored
Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #2 id:20001 of https://codereview.chromium.org/2131483002/ ) Reason for revert: crashes: crbug.com/626719 Original issue's description: > Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context > > A bit of browsing around indicates that the new fast-path is taken most of the time: > 3496 Entering new > 152295 Reentering same > > BUG= > > Committed: https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490 > Cr-Commit-Position: refs/heads/master@{#37570} TBR=jochen@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2140563002 Cr-Commit-Position: refs/heads/master@{#37632}
-
jgruber authored
CallSite::IsConstructor() was unable to recognize builtin construct stubs (NumberConstructor_ConstructStub and StringConstructor_ConstructStub) as constructors, and thus these frames were not formatted correctly in stack traces. Fix this by explicitly marking their Code objects as construct stubs and passing along a special receiver value when we encounter such cases in CaptureSimpleStackTrace. R=mstarzinger@chromium.org, yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2125163004 Cr-Commit-Position: refs/heads/master@{#37631}
-
bmeurer authored
If a Smi field load is truncated to Word32, we can just load the upper 32 bits on 64-bit architectures (with 32-bit Smis), which avoids the nasty shift right that we'd have to perform otherwise to untag it. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2140553002 Cr-Commit-Position: refs/heads/master@{#37630}
-
bmeurer authored
Usually loops run from 0 to some array length l, which means the induction variable i will probably have type Unsigned32, just like the length l. The CheckBounds operation lowers to an Uint32LessThan comparison, so if we also lower the user level i < l comparison to Uint32LessThan (whenever possible), we get some bounds check elimination for free (via value numbering plus branch condition elimination). This merges the branch condition elimination phase with the late optimization phase to make this magic happen. R=jarin@chromium.org BUG=v8:4930,v8:5141 Review-Url: https://codereview.chromium.org/2135123002 Cr-Commit-Position: refs/heads/master@{#37629}
-
mstarzinger authored
This enables tests which verify allocation site feedback is used and influences pretenuring decisions. By now TurboFan is respecting such feedback. Ignition however doesn't provide such feedback yet. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2135563003 Cr-Commit-Position: refs/heads/master@{#37628}
-
Alexander.Gilday2 authored
This change analyzes and links the output of --code-comments in the disassembly view within turbolizer with the other views, such that selecting these comments will also select the respective blocks/lines/nodes within the other views. The block start comments (e.g. -- B4 start --) are linked with the blocks in the schedule phase view and vice versa. The source position comments (e.g. -- primes.js:3:10 --) select the respective spans, lines, and nodes in the JavaScript code view, the schedule phase view, and the other compilation phase views respectively, and vice versa. It also modifies the display of the line and column numbers in the source position comments to be offset from 1 instead of 0 and ignore the initial source position of the first line of code (from removal of the function name in the compiler). Also fixed the bug where previous selections weren't being cleared properly across multiple views, adding appropriate clear calls when using the selection broker. Review-Url: https://codereview.chromium.org/2133663002 Cr-Commit-Position: refs/heads/master@{#37627}
-
machenbach authored
Revert "Move SimulatorHelper into V8 out of profiler clients." This reverts commit b8372411. Revert "Make use of v8::TickSample instead of v8::internal::TickSample in logger." This reverts commit c3a16f0a. Revert "Clean up SimulatorHelper code." This reverts commit 8ee236e1. BUG=v8:5193 TBR=alph@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2138643003 Cr-Commit-Position: refs/heads/master@{#37626}
-
jgruber authored
Enable the same checks for builtin exit frames as are used for all other standard (i.e. non-wasm) types, and refactor them into a single helper class. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2135593002 Cr-Commit-Position: refs/heads/master@{#37625}
-
machenbach authored
Reland of [gn] Switch gcc bots to gn (patchset #1 id:1 of https://codereview.chromium.org/2130303002/ ) Reason for revert: Relanding as the goma problem is due to an upgrade of the binutils version we use. Original issue's description: > Revert of [gn] Switch gcc bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2124263002/ ) > > Reason for revert: > There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL. > > https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068 > > Original issue's description: > > [gn] Switch gcc bots to gn > > > > BUG=chromium:474921 > > > > Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 > > Cr-Commit-Position: refs/heads/master@{#37580} > > TBR=vogelheim@chromium.org,jochen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:474921 > > Committed: https://crrev.com/980d0d6e227f8de3cc0b71a0d3f492908adcf138 > Cr-Commit-Position: refs/heads/master@{#37603} TBR=vogelheim@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2132333002 Cr-Commit-Position: refs/heads/master@{#37624}
-
yangguo authored
R=bmeurer@chromium.org, littledan@chromium.org BUG=v8:5167 Review-Url: https://codereview.chromium.org/2124813002 Cr-Commit-Position: refs/heads/master@{#37623}
-
zhengxing.li authored
port d49d3864 (r37598) original commit message: BUG= Review-Url: https://codereview.chromium.org/2132303002 Cr-Commit-Position: refs/heads/master@{#37622}
-
bmeurer authored
Consume Smi/Signed32 feedback for division and modulus and introduce appropriate checked operators. This is especially important for modulus where the Float64Mod operator is significantly slower than Int32Mod on most platforms. For division it's mostly important to propagate integerness, i.e. to avoid follow-up conversions between float and int32. Drive-by-fix: Use Int32Mod for the ModulusStub (and the bytecode handler) when the inputs are both Smi. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2138633002 Cr-Commit-Position: refs/heads/master@{#37621}
-
- 09 Jul, 2016 3 commits
-
-
v8-autoroll authored
Rolling v8/build to 766297ee7fd0da3d95276a02ff11089ec3aced9b Rolling v8/tools/clang to 29e654f4a3d0fa9c7c69f2967d427ccbd6f4d4c8 Rolling v8/tools/mb to c279952c34ea262021767ad1f2087f988d85881c TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2136463003 Cr-Commit-Position: refs/heads/master@{#37620}
-
alph authored
Review-Url: https://codereview.chromium.org/2131643003 Cr-Commit-Position: refs/heads/master@{#37619}
-
alph authored
BUG=v8:4789 Review-Url: https://codereview.chromium.org/2133533002 Cr-Commit-Position: refs/heads/master@{#37618}
-
- 08 Jul, 2016 5 commits
-
-
alph authored
Clients should not know about the simulator. BUG=v8:4789 Review-Url: https://codereview.chromium.org/2128613004 Cr-Commit-Position: refs/heads/master@{#37617}
-
jbudorick authored
BUG=chromium:617761 NOTRY=true Review-Url: https://codereview.chromium.org/2113453007 Cr-Commit-Position: refs/heads/master@{#37616}
-
littledan authored
The Intl code previously called the initial value of String.prototype.split for some internal operations. However, this did not have the intended effect as Intl only needs to split strings by strings, but String.prototype.split has integration with Symbol.split for RegExps. This patch replaces the calls of StringSplit in the Intl implementation with direct calls to the %StringSplit runtime function to avoid the issue. R=yangguo@chromium.org BUG=v8:5179 Review-Url: https://codereview.chromium.org/2126073002 Cr-Commit-Position: refs/heads/master@{#37615}
-
ssanfilippo authored
Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N Review-Url: https://codereview.chromium.org/2134703002 Cr-Commit-Position: refs/heads/master@{#37614}
-
alph authored
Isolate is not going to retain a CPU profiler. The client will be creating an instance of profiler when needed. Deprectate v8::Isolate::GetCpuProfiler() BUG=v8:4789 Review-Url: https://codereview.chromium.org/2117343006 Cr-Commit-Position: refs/heads/master@{#37613}
-