- 07 Mar, 2019 22 commits
-
-
Clemens Hammacher authored
Emitting bytes to the Uint8Array directly speeds up generation of binaries enormously. On the limits-any.js spec test (which creates huge modules), the execution time of an optdebug build reduces from 286 seconds to 61 seconds. R=titzer@chromium.org CC=ahaas@chromium.org, ssauleau@igalia.com Change-Id: I5b473b7dc7b0853e54d2406f3db3658bb2abed40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508352Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60096}
-
Takuto Ikuta authored
Because string-util.h includes src/base/logging.h Bug: chromium:931596 Change-Id: Ia6f49ec4629471e8a4a20578c6073b47eab8c4df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507000 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60095}
-
Peter Marshall authored
When running mksnapshot standalone, no callback is registered to serialize embedder fields. In this case they are most probably empty as there is no embedder to set them, so provide a default serialization that keeps them as nullptr. Bug: v8:8822 Change-Id: I9219f2755488aa1473959c3ee75e9d4f47202359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507677 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Maciej Goszczycki authored
Most test-log tests create their own isolates, so initializing the cctest isolate is not necessary. Bug: v8:7464 Change-Id: Icc3cd9d5053c4070833709cbe28e5bde2cee9708 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507719Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#60093}
-
Michael Starzinger authored
This makes sure an exception raised while compiling a module via the embedder API is properly returned as a "scheduled exception" and hence propagates to surrounding {v8::TryCatch} scopes. R=clemensh@chromium.org TEST=cctest/test-api/WasmModuleObjectCompileFailure BUG=v8:8908 Change-Id: I52b21fbe5a4548aa346fd6c9b5bac061613db487 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507673 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60092}
-
Ujjwal Sharma authored
Add a fast path for String.p.startsWith(str) when length of str is 1. Bug: v8:8400 Change-Id: I65e657549902dc3ad064a213d815dd098ce6455f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491872 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60091}
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I0e1b0d6751efdb468e603df21af4d36972b8b90b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505455 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60090}
-
Ulan Degenbaev authored
Change-Id: Ic11e2c6a7b08b7f470f8f1649f37c48cc53eeee6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507675Reviewed-by:
-
Michael Hablich authored
NOTRY=true TBR=machenbach@chromium.org Change-Id: I0b8b93276e7724ef103924d17646599aef7b2ab4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508212Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#60088}
-
Michael Achenbach authored
This umblocks switching this builder to Xenial. The corresponding gcc version is not yet supported by goma. NOTRY=true Bug: chromium:933093 Change-Id: Ib00d191c229bb598b209dcaf447321b874571e62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505577Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60087}
-
Dan Elphick authored
Updates a bunch of links from https://github.com/v8/v8/wiki pages to the appropriate v8.dev page that it redirected to anyway. Bug: v8:8834 Change-Id: I5b37996900eb779753d97e487d16e1489f54d391 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503473 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Vadim Gorbachev (bmsdave) authored
These changes fix Python 3 compatibility errors in third-party libraries I'm not sure if these problems can be fixed this way. But! (1) In deps/inspector_protocol no file roll.py it looks like the repository v8 it shouldn't be, either. (2) I have not found a separate repository for binutils. Bug: chromium:935197 Change-Id: Ied2bb83e0539aa392f8fc7c3aeef662612f37d06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1484302Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:8959 Change-Id: I3493487268aa945aab690ee4561678e61b09aace Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507676Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..37fdf54 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/3e50219..a9db5de Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/22d3f6d..9ae8fb4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..ffb1ffb Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/257c91c..8d60039 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I3fd7ecfbcb998097e5cfe062e4f20933244da918 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507793Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60083}
-
Clemens Hammacher authored
Execute foreground tasks triggered by the {CompilationStateCallback} via the {CompileStep} mechanism of {AsyncCompileJob} such that they get cancelled when the AsyncCompileJob dies. R=ahaas@chromium.org Bug: chromium:938311 Change-Id: I2082f93f47988c014c8dee3ddf3e9b2940f6f531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507674Reviewed-by: -
Michael Achenbach authored
TBR=yangguo@chromium.org Change-Id: Ieb6f9da0cd15c65ed0537ecbc3a3c032ac6bbbf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507672Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60081}
-
Michael Starzinger authored
R=jkummerow@chromium.org TEST=mjsunit/asm/regress-937650 BUG=chromium:937650 Change-Id: I9a46fcce68cf1b5c424539aad2f78fbcd30cf9b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505458Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60080}
-
Michael Achenbach authored
Bug: v8:8889 Change-Id: If0a8e71dca2ae5660481ba78bf79eb311d60c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495557 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Simon Zünd authored
This reverts commit 0738c63a. Reason for revert: Closes tree Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..2cef311 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/3e50219..a9db5de > > Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/22d3f6d..9ae8fb4 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..48f640f > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: Ibe4c24ac7d8a576c21306a915b0d68222eb4477b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507318 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60077} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I84832aa42e94f79b6c55f083d574e15c8c2d9353 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505583Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60078}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..2cef311 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/3e50219..a9db5de Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/22d3f6d..9ae8fb4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..48f640f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ibe4c24ac7d8a576c21306a915b0d68222eb4477b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507318Reviewed-by:
-
tzik authored
This adds the entrypoint to MicrotaskQueue, which used to miss the implementation. Bug: v8:8124 Change-Id: I114fb69d975ee75c86b19349ca76789e425ea910 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505232Reviewed-by:
-
Jakob Kummerow authored
Fixing a few float and int overflows. Drive-by fix: with --experimental-wasm-bigint, Number values may not be used to initialize i64-typed globals. The existing code for doing that relied on UB; since it's a spec violation the fix is to throw instead. No regression test for 933103 because it will OOM anyway. No regression test for 932896 because it would be extremely slow. Bug: chromium:927894, chromium:927996, chromium:930086, chromium:932679, chromium:932896, chromium:933103, chromium:933134 Change-Id: Iae1c1ff1038af4512a52d3e56b8c4b75f2233314 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495911 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#60075}
-
- 06 Mar, 2019 18 commits
-
-
Igor Sheludko authored
... and fix header includes to please the respective bot. Drive-by-fix: decompression implementation is now MSVC friendly. Bug: v8:7703, v8:8834 Change-Id: Iaf589138e5bafb32b0d9feab5cf074b71f241a3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505579 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Matt Gardner authored
ReduceJSHasProperty was always passing STANDARD_LOAD instead of using the load mode from the feedback verctor. This was causing deopt loops when checking for out-of-bounds indices. chromium: 937734 Change-Id: I6de29f2c6a80bcc171cf027d47a2d1af1414b76c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501975Reviewed-by:
-
Georg Neis authored
...mainly by giving a more precise type to global_proxy getters. Change-Id: If4aef6b25baa2c641a45b177c59690e3ebfc3985 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505578 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
This is a reland of 80f06d6f Original change's description: > [wasm] Lazy update instances on a shared Memory.Grow > > - Introduce a GROW_SHARED_MEMORY interrupt, and handler > - Memory objects for isolates are updated on a stack check, add > tracking for isolates that hit the stack check > - When enough memory is not reserved ahead of time, fail to grow > - Add tracking for externalized buffers in the MemoryTracker so > that the MemoryTracker will know when backing_stores can be freed. > - For shared buffer, do not always allocate a new buffer when > growing an externalized buffer > > > Change-Id: I9cf1be19f2f165fa6ea4096869f7d6365304c8c4 > Bug: v8:8564 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1472430 > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Reviewed-by: Ben Smith <binji@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60064} Bug: v8:8564 Change-Id: Id0cf8e42a9d54ac702dba351e248a1b92713c98a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506357Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60071}
-
Irina Yatsenko authored
JSRegExp, JSRegExpResult, JSRegExpStringIterator, AccessorInfo, AccessorPair, BreakPoint, BreakPointInfo Change-Id: I51c557af543d2169dfc5da8bf5105a9eb03ff711 Bug: v8:8952 Change-Id: I51c557af543d2169dfc5da8bf5105a9eb03ff711 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499696 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60070}
-
Ulan Degenbaev authored
This fixes a corner case during young generation evacuation: 1) Sweeping is in progress, but all pages are swept. 2) The main thread has acquired all swept pages. 3) A compaction space cannot get any swept page and has to allocate a new page. This reduces memory usage of ArrayLiteralInitialSpreadLargeDoubleHoley microbenchmark by 2x. Bug: chromium:934453 Change-Id: I146d22a408910ae89adbfbac5822448952f5f0c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505798Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60069}
-
Bill Budge authored
This reverts commit 80f06d6f. Reason for revert: failing grow-memory tests Original change's description: > [wasm] Lazy update instances on a shared Memory.Grow > > - Introduce a GROW_SHARED_MEMORY interrupt, and handler > - Memory objects for isolates are updated on a stack check, add > tracking for isolates that hit the stack check > - When enough memory is not reserved ahead of time, fail to grow > - Add tracking for externalized buffers in the MemoryTracker so > that the MemoryTracker will know when backing_stores can be freed. > - For shared buffer, do not always allocate a new buffer when > growing an externalized buffer > > > Change-Id: I9cf1be19f2f165fa6ea4096869f7d6365304c8c4 > Bug: v8:8564 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1472430 > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Reviewed-by: Ben Smith <binji@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60064} TBR=binji@chromium.org,titzer@chromium.org,gdeepti@chromium.org,ahaas@chromium.org Change-Id: I2ed0b59bcbb285b701172b401d606963261d375c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506355Reviewed-by:
-
Clemens Hammacher authored
This fixes a bug in the offset computation when instantiating the decoder to decode a VarInt32. It also extends the streaming decoder test to check the error location. R=ahaas@chromium.org Bug: v8:8814 Change-Id: Id8ce31ce7e494cce14231febbb5b0c7d91a26e01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505453Reviewed-by:
-
Sergiy Belozorov authored
R=ulan@chromium.org Bug: chromium:936713 Change-Id: If3361023fa6fecfc070028ef505ca1ab1ec1d568 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505800Reviewed-by:
-
Clemens Hammacher authored
Callbacks can be called and deleted from any thread, so they need to be protected by a mutex. The deleted comment in {NotifyOnEvent} is outdated. Use a separate mutex such that callbacks can call back into the NativeModule or CompilationState without deadlocking. R=ahaas@chromium.org Bug: v8:8904, v8:8689 Change-Id: If28a1f5682894518453b216c3ea152e5d6d8afdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505457Reviewed-by: -
Deepti Gandluri authored
- Introduce a GROW_SHARED_MEMORY interrupt, and handler - Memory objects for isolates are updated on a stack check, add tracking for isolates that hit the stack check - When enough memory is not reserved ahead of time, fail to grow - Add tracking for externalized buffers in the MemoryTracker so that the MemoryTracker will know when backing_stores can be freed. - For shared buffer, do not always allocate a new buffer when growing an externalized buffer Change-Id: I9cf1be19f2f165fa6ea4096869f7d6365304c8c4 Bug: v8:8564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1472430 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
Georg Neis authored
Followup to https://chromium-review.googlesource.com/c/v8/v8/+/1487491. Change-Id: I44deb28ef5c8638236b04849921359cc7285c10f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505576Reviewed-by:
-
Ross McIlroy authored
Causes flakyness in TSAN runs when flag is written by EnforceFlagImplications and read by ConcurrentMarking. BUG=v8:8924 Change-Id: I2b0bf0fbb678e03492d7ed13e48657de9316b700 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505796 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60062}
-
Georg Neis authored
This CL builds on top of feedback preprocessing. It brokerizes all parts of element access reduction and disallows heap access there (except for debug tracing). To make this work without breaking tests (when concurrent inlining is enabled): - We don't inline functions that weren't serialized for compilation. - We don't optimize for constant typed-array receivers when the typed array wasn't serialized. This means that from now on --concurrent-inlining (and thus --future) may result in less optimization than the default configuration. Bug: v8:7790 Change-Id: I22685258b7d841fc9183bf99775d3f09cd272927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495556 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
zhiguo authored
When VTune JIT support is enabled, the WasmEngine of an Isolate tries to enable code logging by EnableCodeLogging() method. This multithreaded method requires a Mutex for safety. However, as the WasmEngine is not created, the Mutex of it is not initialized. An attempt of acquiring this Mutex results in an error. The bug is fixed by creating WasmEngine before it enables code logging. Change-Id: I59e749190288ec412f6661233e8f62b0dff3cd7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1337376Reviewed-by:
-
Igor Sheludko authored
... when the latter is not already available. Bug: v8:8834 Change-Id: Ib45b0e04c35a797e2d36a96b891ff1f82d4de02c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505574Reviewed-by:
-
andrew-cc-chen authored
Change-Id: I8e353e6ae46b16abfe2812af88b6718250854e29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503562Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Jakob Gruber authored
This piggy-backs off similar support for lite mode, which silently skips tests that require optimization in lite (and now jitless) modes. Bug: v8:7777,v8:8778, v8:8885 Change-Id: I666d92685ca71682224028743f02d0cce3723135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503758 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#60057}
-
