- 19 Oct, 2016 22 commits
-
-
titzer authored
This CL refactors the handling of metadata associated with WebAssembly modules to reduce the duplicate marshalling of data from the C++ world to the JavaScript world. It does this by wrapping the C++ WasmModule* object in a Foreign that is rooted from the on-heap WasmCompiledModule (which is itself just a FixedArray). Upon serialization, the C++ object is ignored and the original WASM wire bytes are serialized. Upon deserialization, the C++ object is reconstituted by reparsing the bytes. This is motivated by increasing complications in implementing the JS API, in particular WebAssembly.Table, which must perform signature canonicalization across instances. Additionally, this CL implements the proper base + offset initialization behavior for tables. R=rossberg@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org,yangguo@chromium.org BUG=v8:5507, chromium:575167, chromium:657316 Review-Url: https://chromiumcodereview.appspot.com/2424623002 Cr-Commit-Position: refs/heads/master@{#40434}
-
franzih authored
Add legend that explains the abbreviations for different IC states to IC explorer. Copied from ic.cc. BUG= Review-Url: https://chromiumcodereview.appspot.com/2431183004 Cr-Commit-Position: refs/heads/master@{#40433}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5510 Review-Url: https://chromiumcodereview.appspot.com/2430673002 Cr-Commit-Position: refs/heads/master@{#40432}
-
machenbach authored
NOTRY=true NOPRESUBMIT=true TBR=tandrii@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2437723002 Cr-Commit-Position: refs/heads/master@{#40431}
-
jarin authored
No machine constants should reach the representation selector. Review-Url: https://chromiumcodereview.appspot.com/2431693002 Cr-Commit-Position: refs/heads/master@{#40430}
-
cbruni authored
BUG= Review-Url: https://chromiumcodereview.appspot.com/2385423005 Cr-Commit-Position: refs/heads/master@{#40429}
-
bmeurer authored
For binary operations that collect feedback (in Ignition), don't canonicalize when the operation itself is already performed in Float64. This is the first step to fix the performance difference we still see between TurboFan and TurboFan+Ignition. R=mythria@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2431363002 Cr-Commit-Position: refs/heads/master@{#40428}
-
Benedikt Meurer authored
During JSTypedLowering we can decide to insert PlainPrimitiveToNumber operators on the inputs to still utilize pure Number operators, when the type feedback on the numeric binary operation is NumberOrOddball. However that is not beneficial if the inputs can be Strings, that is we cannot statically rule out String based on input type, as that inserts a ToNumber stub call into the hot code path. This repairs the NavierStokes regression with Ignition on Octane. R=jarin@chromium.org Review URL: https://codereview.chromium.org/2432143003 . Cr-Commit-Position: refs/heads/master@{#40427}
-
titzer authored
R=clemensh@chromium.org,ahaas@chromium.org BUG= Review-Url: https://chromiumcodereview.appspot.com/2428343005 Cr-Commit-Position: refs/heads/master@{#40426}
-
jgruber authored
BUG=v8:5530 Review-Url: https://chromiumcodereview.appspot.com/2436613002 Cr-Commit-Position: refs/heads/master@{#40425}
-
machenbach authored
This makes auto-detect-build-configs work on bots (i.e. if --buildbot was passed). BUG=v8:5533 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel,v8_linux64_tsan_rel,v8_linux_arm64_dbg,v8_linux_gc_stress_dbg,v8_linux_noi18n_rel_ng,v8_linux_nosnap_rel Review-Url: https://chromiumcodereview.appspot.com/2431653002 Cr-Commit-Position: refs/heads/master@{#40424}
-
jkummerow authored
BUG= Review-Url: https://chromiumcodereview.appspot.com/2403483002 Cr-Commit-Position: refs/heads/master@{#40423}
-
machenbach authored
Revert of [inspector] Turn on inspector by default (patchset #1 id:1 of https://codereview.chromium.org/2395763002/ ) Reason for revert: Has test failures on windows and blocks landing a test driver fix. Original issue's description: > [inspector] Turn on inspector by default > > BUG=chromium:635948 > > Committed: https://crrev.com/8146402c69044affff0e95f9641eee532fb70312 > Cr-Commit-Position: refs/heads/master@{#40380} TBR=kozyatinskiy@chromium.org,dgozman@chromium.org,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:635948 Review-Url: https://chromiumcodereview.appspot.com/2430223003 Cr-Commit-Position: refs/heads/master@{#40422}
-
Benedikt Meurer authored
Similar to http://crrev.com/2410883003 we don't need to do a minus zero check for the right hand side of CheckedInt32Add, because we already know that the left hand side cannot be minus zero, and the only way that addition can yield -0 is (-0) + (-0). R=jarin@chromium.org Review URL: https://codereview.chromium.org/2431233003 . Cr-Commit-Position: refs/heads/master@{#40421}
-
ahaas authored
Using uint32 to store the the number of control outputs allows WebAssembly switches to have more than 2^16 case. BUG=v8:5531 TEST=mjsunit/regress/wasm/regression-5531 R=titzer@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2425983002 Cr-Commit-Position: refs/heads/master@{#40420}
-
bmeurer authored
When the input to Number.parseInt is a HeapNumber in Signed32 range, we can just return the (truncated) input value (i.e. we need to map -0 to 0 due to the ToString conversion). R=jarin@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2432923002 Cr-Commit-Position: refs/heads/master@{#40419}
-
bmeurer authored
The inlined version of Number.parseInt did a ToInt32 truncation, which is not what the EcmaScript specification says. R=jarin@chromium.org BUG=v8:5538 Review-Url: https://chromiumcodereview.appspot.com/2432143002 Cr-Commit-Position: refs/heads/master@{#40418}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eb8eb7a..e54cf97 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapul/+log/9a96d45..ae987bf TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2432033002 Cr-Commit-Position: refs/heads/master@{#40417}
-
zhengxing.li authored
port 308788b3 (r40397) original commit message: Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). BUG= Review-Url: https://chromiumcodereview.appspot.com/2429623005 Cr-Commit-Position: refs/heads/master@{#40416}
-
kozyatinskiy authored
.. to make windows bot happy. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428213002 Cr-Commit-Position: refs/heads/master@{#40415}
-
kozyatinskiy authored
console should be non enumerable. BUG=chromium:656826 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428473003 Cr-Commit-Position: refs/heads/master@{#40414}
-
kozyatinskiy authored
* introduced v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState); * migrated inspector to new API; * added cctest for new API; * added inspector test for setPauseOnExceptionState. BUG=chromium:652939,v8:5510 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2396193002 Cr-Commit-Position: refs/heads/master@{#40413}
-
- 18 Oct, 2016 18 commits
-
-
bjaideep authored
Port 308788b3 Original commit message: Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2425243003 Cr-Commit-Position: refs/heads/master@{#40412}
-
gdeepti authored
BUG= Review-Url: https://codereview.chromium.org/2410763002 Cr-Commit-Position: refs/heads/master@{#40411}
-
jochen authored
R=jgruber@chromium.org,machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2421303002 Cr-Commit-Position: refs/heads/master@{#40410}
-
bmeurer authored
http://crrev.com/2424403002 contained a typo comparing the input map against the undefined constant rather than the HeapNumber map, which tanks the case where Number.parseInt is used instead of Math.floor. TBR=epertoso@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2425703007 Cr-Commit-Position: refs/heads/master@{#40409}
-
jpp authored
Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 Review-Url: https://chromiumcodereview.appspot.com/2426473007 Cr-Commit-Position: refs/heads/master@{#40408}
-
mythria authored
Add support to collect feedback about oddballs in Add, Mul, Div and Modulus stubs. Turbofan uses NumberOrOddball feedback to reduce the number of deoptimizations. BUG=v8:4280, v8:5400 LOG=N Review-Url: https://codereview.chromium.org/2406263002 Cr-Commit-Position: refs/heads/master@{#40407}
-
jwolfe authored
BUG=v8:5388 Review-Url: https://codereview.chromium.org/2422383002 Cr-Commit-Position: refs/heads/master@{#40406}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2425553003 Cr-Commit-Position: refs/heads/master@{#40405}
-
kozyatinskiy authored
debug-interface.h contains part of v8-debug.h that is used by src/inspector. BUG=v8:5510 R=dgozman@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2423713003 Cr-Commit-Position: refs/heads/master@{#40404}
-
titzer authored
R=ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2429833002 Cr-Commit-Position: refs/heads/master@{#40403}
-
epertoso authored
BranchIf and helpers were introduced when exporting the schedule from the RawMachineAssembler was not ensuring that the CFG was well-form. These methods, that were used to introduce blocks to ensure edge-split form, are now unnecessary. BUG= Review-Url: https://codereview.chromium.org/2426923002 Cr-Commit-Position: refs/heads/master@{#40402}
-
bmeurer authored
These intrinsics are unused now, and so we can drop all the code in fullcodegen and Crankshaft that deals with those. TurboFan and Ignition never tried to optimize those. R=mstarzinger@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2427673004 Cr-Commit-Position: refs/heads/master@{#40401}
-
ahaas authored
R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2413343002 Cr-Commit-Position: refs/heads/master@{#40400}
-
bmeurer authored
R=epertoso@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2424403002 Cr-Commit-Position: refs/heads/master@{#40399}
-
ivica.bogosavljevic authored
MIPS64: Fix Word32Compare turbofan operator implementation when comparing signed with unsigned operand MIPS64 doesn't support Word32 compare instructions. Instead it relies that the values in registers are correctly sign-extended and uses Word64 comparison instead. This behavior is correct in most cases, but doesn't work when comparing signed with unsigned operands. The solution proposed here tries to match a comparison of signed with unsigned operand, and perform Word32Compare simulation only in those cases. Unfortunately, the solution is not complete because it might skip cases where Word32 compare simulation is needed, so basically it is a hack. BUG= TEST=mjsunit/compiler/uint32 Review-Url: https://codereview.chromium.org/2391393003 Cr-Commit-Position: refs/heads/master@{#40398}
-
bmeurer authored
Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). R=mvstanton@chromium.org, mythria@chromium.org BUG=v8:2206,v8:4280,v8:5267 Review-Url: https://codereview.chromium.org/2426693002 Cr-Commit-Position: refs/heads/master@{#40397}
-
mythria authored
When inlining JSCallConstruct in turbofan, receiver is initialized to model the behaviour of constructor. When an implicit receiver is not required the receiver value should be set to the hole value instead of undefined value. When initializing the receiver via super calls, we check that the receiver is the hole value. BUG=chromium:653407 Review-Url: https://codereview.chromium.org/2424123002 Cr-Commit-Position: refs/heads/master@{#40396}
-
yangguo authored
TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2426913002 Cr-Commit-Position: refs/heads/master@{#40395}
-