1. 26 Oct, 2017 1 commit
  2. 17 Jul, 2017 1 commit
    • Sathya Gunasekaran's avatar
      Fix error message while array destructuring undefined · 94ce16b7
      Sathya Gunasekaran authored
      Previously,
        ➜  v8 (master) :heavy_check_mark: ./out.gn/x64.optdebug/d8
        V8 version 6.1.0 (candidate)
        d8> var x = undefined
        undefined
        d8> var [a] = x
        (d8):1: TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
        var [a] = x
                  ^
        TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
            at (d8):1:11
      
      Now,
        ➜  v8 (fix-iterator) :heavy_check_mark: ./out.gn/x64.optdebug/d8
        V8 version 6.1.0 (candidate)
        d8> var x = undefined
        undefined
        d8> var [a] = x
        (d8):1: TypeError: x is not iterable
        var [a] = x
                  ^
        TypeError: x is not iterable
            at (d8):1:11
      
      
      Bug: v8:6599, v8:6513
      Change-Id: I71287a19166af0289e8f7708b8f41ad003ae87ae
      Reviewed-on: https://chromium-review.googlesource.com/571175
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46723}
      94ce16b7
  3. 04 May, 2017 1 commit
  4. 02 May, 2017 1 commit
  5. 11 Apr, 2017 1 commit
    • gsathya's avatar
      [ESNext] Implement DynamicImportCall · 94283dcf
      gsathya authored
      This patch implements the runtime semantics of dynamic import.
      
      We create a new ASTNode so that we can pass the JSFunction closure() to
      the runtime function from which we get the script_url.
      
      d8 implements the embedder logic required to load and evaluate the modules.
      
      The API is mostly implemented as specified.
      
      BUG=8:5785
      
      Review-Url: https://codereview.chromium.org/2703563002
      Cr-Commit-Position: refs/heads/master@{#44551}
      94283dcf
  6. 17 Feb, 2017 1 commit
    • vabr's avatar
      Report unexpected lexical decl also without destructuring · 454816f0
      vabr authored
      https://codereview.chromium.org/2694003002/ introduced
      "SyntaxError: Lexical declaration cannot appear in a single-statement context"
      for the case when let + desctructuring from a list happen.
      
      As was pointed out in https://codereview.chromium.org/2694003002/#msg18, the
      case without destructuring would also benefit from a better message: if a
      single statement is expected and "let identifier = ..." is seen, the error is
      indeed again that the lexical declaration is not a statement. However, the current
      error is "Unexpected identifier", because the parser tries to accept "let" as
      an identifier in an expression statement, and then gives up seeing the other
      identifier after "let".
      
      This CL ensures that the parser recognises the error properly and reports
      accordingly. It also renames the existing test, which contains destructuring,
      and adds the one with a non-destructuring lexical declaration.
      
      BUG=v8:5686
      
      Review-Url: https://codereview.chromium.org/2697193007
      Cr-Commit-Position: refs/heads/master@{#43275}
      454816f0
  7. 16 Feb, 2017 1 commit
  8. 16 Jan, 2017 1 commit
  9. 12 Jan, 2017 1 commit
  10. 04 Jan, 2017 1 commit