- 21 Dec, 2017 20 commits
-
-
Andreas Haas authored
This is the implementation of crrev.com/c/766371 for mips. Original description: Add the ability to return (multiple) return values on the stack: - Extend stack frames with a new buffer region for return slots. This region is located at the end of a caller's frame such that its slots can be indexed as caller frame slots in a callee (located beyond its parameters) and assigned return values. - Adjust stack frame constructon and deconstruction accordingly. - Extend linkage computation to support register plus stack returns. - Reserve return slots in caller frame when respective calls occur. - Introduce and generate architecture instructions ('peek') for reading back results from return slots in the caller. - Aggressive tests. - Some minor clean-up. R=v8-mips-ports@googlegroups.com Change-Id: I2f30cc297771ec74b0b935b6ea28d3d61a986d5c Reviewed-on: https://chromium-review.googlesource.com/839660Reviewed-by:Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50272}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:788104 Change-Id: I3f47332a0f0df7a5a016afcb7d0904142176bea3 Reviewed-on: https://chromium-review.googlesource.com/839775Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50271}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: Idfce9232829581155c0abfda844b14fa6abbd7fb Reviewed-on: https://chromium-review.googlesource.com/839772Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50270}
-
Mike Stanton authored
Bug: Change-Id: I3185f0e88f0eef3d5a9b58a28cb6d103851da473 Reviewed-on: https://chromium-review.googlesource.com/839763 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#50269}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I51ec0be7ea961d3c81e03675cc65d03ecf526c3d Reviewed-on: https://chromium-review.googlesource.com/836988 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Clemens Hammacher authored
Adds support for emitting the drop opcode in the wasm compile fuzzer. R=ahaas@chromium.org CC=eholk@chromium.org Change-Id: Idb6f07f3f50ffda472107bd6276221e803c37152 Reviewed-on: https://chromium-review.googlesource.com/839760 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50267}
-
Clemens Hammacher authored
Refactor out-of-line code to represent either traps or stack checks, and add function-entry stack checks. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I467ccc2016f67da5562a576aeaeceba002cd04ca Reviewed-on: https://chromium-review.googlesource.com/834208 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
peterwmwong authored
Fixes a regression causing a seg fault instead of the expected stack overflow. Bug: chromium:796427, v8:6005 Change-Id: Ifc752a4009a25f447f5e87745dcc1bb83722c34e Reviewed-on: https://chromium-review.googlesource.com/838854 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#50265}
-
Stephan Herhut authored
Bug: Change-Id: I785dd2fb839f8388e7389f4fe935cb983f6e81eb Reviewed-on: https://chromium-review.googlesource.com/803435Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Stephan Herhut <herhut@google.com> Cr-Commit-Position: refs/heads/master@{#50264}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I81bff2190766b3ccbc5da43ff2f3105c6c95da67 Reviewed-on: https://chromium-review.googlesource.com/836557 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:747960 Change-Id: I832c1a438330c0a44dd876ef35eb422fdacca895 Reviewed-on: https://chromium-review.googlesource.com/839445 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Daniel Clifford authored
Bug: v8:1956,v8:4869 Change-Id: Id5822319c14142be2dd984c922b2b65717b96dee Reviewed-on: https://chromium-review.googlesource.com/803974 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50261}
-
Timothy Gu authored
Also fix GetPropertyDescriptorWithInterceptor so that it only calls the interceptor once. R=ahaas@chromium.org, franzih@chromium.org Bug: node:17480, node:17481 Change-Id: I2c3813f80df2962ec909bae7267884ce0b8ccbef Reviewed-on: https://chromium-review.googlesource.com/816515 Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#50260}
-
Georgia Kouveli authored
This patch updates the instruction selector and code generator to pad arguments for arm64 and drop an even number of slots when dropping the arguments. It also updates the builtins that handle arguments. These changes need to be made at the same time. It also adds some tests for forwarding varargs, as this was affected by the builtin changes and the existing tests did not catch all issues. Bug: v8:6644 Change-Id: I81318d1d1c9ab2568f84f2bb868d2a2d4cb56053 Reviewed-on: https://chromium-review.googlesource.com/829933 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:747960 Change-Id: I0af128fd5195b602b7cb302d38722ed86e123060 Reviewed-on: https://chromium-review.googlesource.com/839360Reviewed-by:
-
Igor Sheludko authored
... to ease its inlining to the bytecode handlers. The new code organisation still don't produce unwanted frame creation code on a fast path. Bug: v8:7206, chromium:576312 Change-Id: Ib516ae0795ff1788b3a7e0bb521f72dfa68444f0 Reviewed-on: https://chromium-review.googlesource.com/833869 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50257}
-
Sergiy Byelozyorov authored
Also disable all but one mac experiment. Having too many experiments causes large pending queues to be generated and the builds fail to apply the patch since they run after the CL has landed. TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: I1cd21798a17c857d4275d0f15a2b98e13fe9c367 Reviewed-on: https://chromium-review.googlesource.com/839141 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
When shared memory is defined in the module bytes, and not imported/exported underlying memory should be a SharedArrayBuffer. This was missing in the allocate flow during instantiation. Fixed to use a SharedArrayBuffer. BUG=v8:6532 Change-Id: Ic62ed3fd578a0e03124ee40b273e6a4ea474bba4 Reviewed-on: https://chromium-review.googlesource.com/835348Reviewed-by:
Eric Holk <eholk@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#50255}
-
Brad Nelson authored
R=eholk@chromium.org,mlippautz@chromium.org B=https://bugs.chromium.org/p/chromium/issues/detail?id=775047 Change-Id: Ia3b2f51d6cb4dabbf0f1f9ec78ecb8935775f53a Reviewed-on: https://chromium-review.googlesource.com/809165 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
Mircea Trofin authored
Bug: v8:7232 Change-Id: I1eed337749686ec749b970b4af56413c5614b980 Reviewed-on: https://chromium-review.googlesource.com/837646 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#50253}
-
- 20 Dec, 2017 20 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@google.com Bug: chromium:747960 Change-Id: I9846b955d34d2bbdf28f0d0903ef3fef5d9ba524 Reviewed-on: https://chromium-review.googlesource.com/837980 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:747960 Change-Id: Id191feb257f1e1154cce2f76427b4ddb4d0883fb Reviewed-on: https://chromium-review.googlesource.com/837760Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: I69363b9e636fee99c6a602b3dfe73d0dd2ee903b Reviewed-on: https://chromium-review.googlesource.com/836711 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This is safe to enable multiple mac/win builders because we've migrated all non-experimental builders to LUCI, hence pending queues won't affect CQ. TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: I561c97ac52db0de042fb196f4430b65de562c0de Reviewed-on: https://chromium-review.googlesource.com/836710 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Eugene Ostroukhov authored
Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I8ca7bf33fb848caedce101876316832a1e9cf58f Reviewed-on: https://chromium-review.googlesource.com/836735Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#50248}
-
Ali Ijaz Sheikh authored
* NewSpace::UpdateInlineAllocationInfo and PagedSpace::ComputeLimit were closely related methods. Refactor these into a shared method in the super class. * refactor UpdateInlineAllocationInfo into SpaceWithLinearArea * refactor StartNextInlineAllocationStep * refactor PauseAllocationObservers Bug: Change-Id: I898906d6228ff48e427367ef74e6dc77fb7a1837 Reviewed-on: https://chromium-review.googlesource.com/825591 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50247}
-
Clemens Hammacher authored
And add a helper method to convert an uint32 value to uintptr (e.g. a noop on 32 bit and Uint32ToUint64 conversion on 64 bit). R=ahaas@chromium.org Change-Id: Ibc6731bc7ddaf8ceaa27e9e8fbec916d184d9ad4 Reviewed-on: https://chromium-review.googlesource.com/836618 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:747960 Change-Id: I6718ef1a53439d4d443156c3ec7c269b72a39c36 Reviewed-on: https://chromium-review.googlesource.com/836870 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Mircea Trofin authored
Bug: chromium:796584 Change-Id: Ib6a62d616d36344f35cad0b0a177f8f07c7fd2ac Reviewed-on: https://chromium-review.googlesource.com/836849Reviewed-by:
-
Sergiy Byelozyorov authored
This is now ready to proceed since we've got additional 6 Windows and 24 Linux bots in our luci.v8.try pool. TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: Ib718599e5657fcb709acd563f7eaa9bbd2790fbb Reviewed-on: https://chromium-review.googlesource.com/836898 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I36ab28500742ae1b906f806e0afb477059eb0380 Reviewed-on: https://chromium-review.googlesource.com/836548 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I8783192268cc0860b553af418d56f1117817d747 Reviewed-on: https://chromium-review.googlesource.com/836609 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Georg Neis authored
In a benchmark that I'm looking at, the numbers quickly overflow our current limit. This patch increases kMaxLength to the greatest value that's possible without requiring further code changes. Bug: v8:6791 Change-Id: I7a0d126dcd566d536375a294fa4dcf10b8823ed7 Reviewed-on: https://chromium-review.googlesource.com/833876 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#50240}
-
Ali Ijaz Sheikh authored
Doing an allocation step before the limit is picked is more correct, but it causes the idle scavenger and incremental marking to run more frequently, which causes a regression on certain thread_time benchmarks. This CL fixes the regression by reverting the behaviour. A proper fix can be implemented in a follow-on. Bug: chromium:795323 Change-Id: Ic62eab1ddfd1da4c5904e11eba7d5d71cee38f12 Reviewed-on: https://chromium-review.googlesource.com/835287 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
-
Georgia Kouveli authored
This is a reland of bcf11729 The test was timing out in no snapshot builds, as each CodeAssemblerTester creates a new Context. Reduced the random iterations significantly. Original change's description: > [arm64] Preparation for padding of arguments > > As part of JSSP removal, we need to align the arguments passed to functions > on the stack, by adding a padding slot when the total number of arguments > is odd. > > This patch introduces the kPadArguments flag (which is currently set to > false for all architectures), which will control padding of arguments in > architecture-independent parts of the code (deoptimizer, instruction > selector). > > It also adds some executable tests for tail calls with various stack > parameter counts on the caller and callee sides. > > This will be turned on for arm64 together with arm64-specific changes to > the code generator, the MacroAsembler and the builtins, in a later patch. > > Bug: v8:6644 > Change-Id: I79a5c149123fe8130cedd1ccffec3d9b50361e08 > Reviewed-on: https://chromium-review.googlesource.com/806554 > Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50134} TBR=jarin@chromium.org Bug: v8:6644 Change-Id: I795877ed9791e126ffac6841dbbb65189e95d207 Reviewed-on: https://chromium-review.googlesource.com/833046 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
-
Andreas Haas authored
This is the implementation of crrev.com/c/766371 for arm. Original description: Add the ability to return (multiple) return values on the stack: - Extend stack frames with a new buffer region for return slots. This region is located at the end of a caller's frame such that its slots can be indexed as caller frame slots in a callee (located beyond its parameters) and assigned return values. - Adjust stack frame constructon and deconstruction accordingly. - Extend linkage computation to support register plus stack returns. - Reserve return slots in caller frame when respective calls occur. - Introduce and generate architecture instructions ('peek') for reading back results from return slots in the caller. - Aggressive tests. - Some minor clean-up. R=v8-arm-ports@googlegroups.com Change-Id: I7d61424a184d5778baf1d1270013f4e0c7ec68b4 Reviewed-on: https://chromium-review.googlesource.com/836608Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50237}
-
Camillo Bruni authored
- Make sure scripts have line end data - Make sure initial class maps are logged - Log map creation independently from details - Properly escape commas in the v8 logger Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I583c784cf75e884673e46bfb263da3bc20e6ac41 Reviewed-on: https://chromium-review.googlesource.com/822333Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50236}
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I8920ed24699ab5e6e4ed82f38bd7c8d8548fddfe Reviewed-on: https://chromium-review.googlesource.com/834131 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Camillo Bruni authored
From the log data generated with --log-function-events we can create a detailed model of a function's lifetime. The parse processor displays several stats at a given time (percent and count) on a per function or byte basis: - preparsing - parsing - eager/lazy compiling - execution Bug: chromium:757467 Change-Id: I0ad5c9369c6a0628704e3caffb3920444ea603a9 Reviewed-on: https://chromium-review.googlesource.com/758641 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#50234}
-
Hannes Payer authored
Bug: Change-Id: I53b68e8a4200a87d9f14b9540b52cab316678b2d Reviewed-on: https://chromium-review.googlesource.com/836593 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50233}
-
