- 17 Feb, 2022 23 commits
-
-
Camillo Bruni authored
- Remove debug printing in callstats.py - Handle non-version nested JSON files better in callstats.html - Harden RCS extraction from telemetry JSON files Change-Id: Ied921e54e6281a456c0a6369d797c21785080036 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471856Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79155}
-
Milad Fa authored
https://crrev.com/c/3471558 is causing the following compilation error on gcc: ``` error: suggest explicit braces to avoid ambiguous 'else' ``` Bug: chromium:1298417 Change-Id: I84a34603664c5ee148cc9ea282c0f8c53319b6d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472403Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79154}
-
Dominik Inführ authored
Shared references can also be stored in WeakMaps and during marking we need to be able to deal with such references. In a client GC shared objects are treated as live, so we don't need to update or check mark bits for such objects. Bug: v8:11708 Change-Id: I0dbf797472c4779f462750dab63cc9b012aad091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447365Reviewed-by:
-
Milad Fa authored
Change-Id: Id5295f5afe3bc850f2e8726d696f42fd26f07a51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470565Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79152}
-
Benoît Lizé authored
Guard pages are 4k areas at the beginning and end of each oilpan page (128kiB) which are meant to be inaccessible. However on ARM64 macOS, the OS page size is 16kiB, meaning that these are not inaccessible. But we do pay for these, as they are part of the first and last OS page. Meaning that we effectively waste 2 * 4kiB = 6.25% of each Oilpan page. Since these are not serving their purpose, disable them on this platform. Another fix could be to make the guard page 16kiB, but given that the entire oilpan page is 128kiB, this may have adverse effects on e.g. fragmentation. Note that this doesn't regress security, as the regions were never protected to begin with on this platform. Bug: chromium:1298417 Change-Id: Iad5d05670962780e6d1eeab2bb8a331deb7aa1f3 Cq-Include-Trybots: luci.v8.try:v8_linux_arm64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471558Reviewed-by:
-
Nico Hartmann authored
Tests are flaky on arm64 sim and arm64 sim - msan bots. Bug: v8:12637 Change-Id: If9570ceb8af375d12ddd375274aea1ebc0078e63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471634 Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#79150}
-
Nico Hartmann authored
Bug: chromium:1298421 Change-Id: I3489b2ce8b11052cdf7c23d89255b30258cc9157 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471555Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#79149}
-
Thibaud Michaud authored
Use the existing generic js-to-wasm wrapper to handle arguments in the stack-switching export wrapper, by combining them into a single helper function parameterized by a boolean. If the stack_switch parameter is false, the generated js-to-wasm wrapper is the same as before. If the stack_switch parameter is true, we allocate and switch to the new stack before starting to process the parameters. To load the parameters, we also keep a pointer to the old stack. After the call, we convert the return value according to the return type as usual, and then switch back to the parent stack (which may be different than the original stack, but has a compatible stack frame layout). If the stack suspends during the call, control-flow jumps right before we deconstruct and leave the frame, and returns the Promise as an externref in the return register. R=ahaas@chromium.org,jkummerow@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: If3f8eaba8edebe6e98d4738f79f895fdb5322adc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460410Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#79148}
-
Junliang Yan authored
Change-Id: I08f3ad3987f633de5073c7f44ebb7a71de2425e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470564Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79147}
-
Samuel Groß authored
Using shm_open with a constant name can lead to race conditions with other V8 instances using (and unlinking) the same shared memory object. Bug: v8:12636 Change-Id: Ic2d2317f99c1df7aedec2dc52b187c64eea11d2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468899Reviewed-by:
-
Junliang Yan authored
Change-Id: If34e7927b8d243a22cbcc0e717541c237993ef4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470563Reviewed-by:
-
Clemens Backes authored
For large modules, the current limit of 100k bytes create a large amount of batches to be processed by the concurrent tasks. Choosing the batch size larger removes communication overhead. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: Ia03f42895cb0e6bab8fdc52b82ff2ed59869b749 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468904Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79144}
-
Michael Lippautz authored
There's only a single callsite that performs retries after allocations which already can determine the proper GC to invoke without requiring threading the space backwards. Bug: v8:12615 Change-Id: I5d5d886162b3eca33eb2fe7bde1e113cd08a094c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468905Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79143}
-
Camillo Bruni authored
Avoiding handles in tight loops and setup code improves performance and reduces code size. This CL also makes more non-allocating mode more explicit by adding more DisallowGarbageCollection scopes. Change-Id: I95b5b1a29204c27a23c42ccd67fff150b3fa4a3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460740Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79142}
-
Omer Katz authored
Outside of unittests, if someone tried to delete a GCed object manually they would get a silent crash without a stacktrace or any error messages. This CL replaces the silent crash with an informative message. Change-Id: Ied8895dab43ce7e3a9bf778b13e77d377d269fce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468346 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
which the "no-wasm" build refactoring had accidentally disabled. Bug: v8:11238 Change-Id: Ia2a4be89024f0bc22a1548dcef21e065e4bb5268 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468341Reviewed-by:
-
Clemens Backes authored
In order to create less tasks that each need to swap permissions for writing to the code space, merge the two {CopyAndRelocTask} and {PublishTask} into a single {DeserializeCodeTask}. This also makes the code a lot shorter, and removes stress from the scheduler. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: I8866bf7225b0bc2dd4caef79e64cacca9de15519 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468902Reviewed-by: -
Michael Lippautz authored
Avoid the lookup via heap()->incremental_marking() and instead cache the marking state on GlobalHandles itself. Change-Id: I2665681ad38983bf16d22e0a82dd10743877e520 Bug: chromium:1294661 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468903Reviewed-by:
-
Manos Koukoutos authored
Changes: - Simplify GetRefTypeName. - Simplify WasmModuleDebug::GetWasmValue. - Fix some signature issues in tests. Change-Id: I61b9a48c0fbce0bc9cc74771412bdb8977880697 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468344Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79137}
-
V8 Autoroll authored
Change-Id: I2c4bcabe00d85188675441dc242cd2efc90c5fca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470561Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#79136}
-
Clemens Backes authored
Publishing Wasm code often happens in a loop (in particular for deserialization), so hold the {CodeSpaceWriteScope} outside that loop to avoid repeated switching between writable and executable. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: Ic4bf859685e66c4ba297fed968d0df6ae7d24cba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468896Reviewed-by: -
Camillo Bruni authored
Historically the tool only combined files where the run number was separate by a hash: domain#1.txt , domain#2.txt... Fix this to allow for underscores and/or abitrary number suffixes. Change-Id: I85253a1b871eb75fce60fef9a61b7d50afe72abd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468900Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/62a6377..996f747 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/169eef5..f413334 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/b323ac8..1e0047c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6fbe580..7504934 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d6a3040..e293d3d Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/9538f41..901a5d9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/62e2cd9..0a9dd77 Rolling v8/tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858 Rolling v8/tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Icd4bf05c19d156a1266ce51b4b8ab9af0d4782ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468735 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79133}
-
- 16 Feb, 2022 17 commits
-
-
Milad Fa authored
Change-Id: I45f3379b3656ee2bc939c97c37d3f15bd730de5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3469177Reviewed-by:
-
Samuel Groß authored
The new shared memory API should only be used on macOS, but platform-macos.cc was also included on iOS, causing build failures. This CL splits platform-macos.cc into platform-xnu.cc (common code for macOS and iOS) and platform-macos.cc (the macOS specific parts) Bug: chromium:1218005 Change-Id: Iab332865ffd8990ddd246bb9c08802909464d7e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468895Reviewed-by:
-
Camillo Bruni authored
Don't print command line invocations by default. Change-Id: Ie67c883c92557a645fc8a681722f49a2c7c4bd17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468901Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79130}
-
Nico Hartmann authored
Bug: v8:12633 Change-Id: I4bb98b9f93f7c4a13f7374c732f47aaffedd4a14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468897 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#79129}
-
Milad Fa authored
Change-Id: I0d6258cae0e75b6bd4916cb4c559161f7eac2170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3465739Reviewed-by:
-
Camillo Bruni authored
This is a reland of 9ae463bc - Don't run the heap stats during bootstrapping Original change's description: > [heap-stats] Fix heap-stats with ptr-cage > > - Heap-stats was trying to load the map without explicitly passing in > the PtrComprBase causing failures with Code objects in external code > space > - Extend the debugPrint.js tests to run with some more debugging and > testing flags to prevent future regressions > > Change-Id: I1f0d03cb31480f316fe533b507ff98fe3befbe8e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3432386 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Auto-Submit: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78919} Bug: chromium:1297436 Change-Id: Ib42ae7b8c5f4a427abbce633a1b3ac36ad32994b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437046Reviewed-by:
-
Michael Lippautz authored
The flag is required to allow passing in more debug information when necessary. Change-Id: I34e407ba57786c242aac8b6f6af258969de43efd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468894Reviewed-by:
-
Paolo Severini authored
Allow Wasm to generate calls directly to Fast API C functions. Also fixes a problem when calling a Fast Api C function with no FastApiCallbackOptions from JS. This is a rebase of https://chromium-review.googlesource.com/c/v8/v8/+/3364356, which was a rebase of the work originally done by devsnek in: https://chromium-review.googlesource.com/c/v8/v8/+/2718666. Bug: chromium:1052746, chromium:1292333 Change-Id: Ic56268e7723f80f7ea9e6799e777786d3a50222f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440694Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79125}
-
Camillo Bruni authored
- Add build flag and disable runtime-call-stats by default - Partially fix trap-handler includes for 64-bit android Change-Id: I1c22dbb2a30b7d11ae332ee5b7964a6119ab1188 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3461933Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79124}
-
Samuel Groß authored
This API allows allocating shared memory mappings inside a virtual address space from a platform-specific handle to a shared memory object. This will make it possible to allocate shared memory inside the sandbox, for example as backing memory for ArrayBuffers. Bug: chromium:1218005 Change-Id: I4f1f50baec50734e846496cff78046e4fffe75c5 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3383777Reviewed-by:
-
Michael Lippautz authored
The information was previously kept heap-global but is really only used by spaces when refilling their LABs. Bug: v8:12615 Change-Id: Iee256d35ffa0112c93ec721bc3afdc2881c4743b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3465898Reviewed-by:
-
Camillo Bruni authored
Change-Id: Icb77604d55353064cb793224b3f9c5b691503852 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3466794Reviewed-by:
-
Michael Lippautz authored
Drive-by: Simplify pause logic. Bug: v8:12615 Change-Id: I64e44bff1de1419f1290c9f79cf5bdfe65d8903f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3466796Reviewed-by:
-
Samuel Groß authored
These should not be allowed inside the sandbox as they could be corrupted by an attacker, thus posing a security risk. Furthermore, executable pages require MAP_JIT on macOS, which causes fork() to become excessively slow, in turn causing tests to time out. Due to this, the sandbox now requires the external code space. In addition, this CL adds a max_page_permissions member to the VirtualAddressSpace API to make it possible to verify the maximum permissions of a subspace. Bug: v8:10391 Change-Id: Ib9562ecff6f018696bfa25143113d8583d1ec6cd Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460406Reviewed-by:
-
Manos Koukoutos authored
The reason mentioned for requiring python2 is no longer valid. Bug: chromium:1292013, chromium:1292016 Change-Id: Id8fc938d32c8e967fff74239ccba8ad79e517c57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3464034Reviewed-by:
-
Jakob Gruber authored
Now that different tiers use dedicated interrupt_budgets (which determine how often the runtime profiler (now tiering manager) is called), I don't see a meaningful way to use results from this counter. Bug: v8:7700 Change-Id: I2ec2242d3c7f6c2b9deab075a6f0500cc1350e96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3467595Reviewed-by:
-
Jakob Gruber authored
TierUpCheck and UpdateInterruptBudget were only used by Turboprop (likewise feedback_cell_node). Bug: v8:12552 Change-Id: Ic73d44a5734e183bc1a2eda58cdf85163220e4d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3463954 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
