- 25 Apr, 2018 6 commits
-
-
Simon Zünd authored
This CL implements TypedArray.p.sort in Torque. The Torque version works basically the same as the existing JS builtin: When no comparison function is provided, the C++ fast path builtin is used. Otherwise a quicksort written in Torque is used, with a InsertionSort fallback for smaller arrays. The JS quicksort implementation also containes a more elaborate third pivot calculation for larger arrays. This is currently not done. Reported benchmark results are only for those, where a custom comparison function is provided. The numbers for the C++ path stayed the same. Benchmark Current (JS) Torque Speedup IntTypes 83.9 263.7 3.1 BigIntTypes 32.1 54.6 1.7 FloatTypes 99.3 138.7 1.4 R=danno@chromium.org, jgruber@chromium.org Bug: v8:7382 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7abe7ceff525bab24f302d2f06b5961cca770d24 Reviewed-on: https://chromium-review.googlesource.com/1021691 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52776}
-
Predrag Rudic authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3fc1b53c43e53e12e041178912f372f33068d67c Reviewed-on: https://chromium-review.googlesource.com/1023418 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#52775}
-
Georg Neis authored
Bug: chromium:836124 Change-Id: I82d29408476c9c5b2c62a6368f32575e33932ef3 Reviewed-on: https://chromium-review.googlesource.com/1025890Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#52774}
-
Simon Zünd authored
This CL changes the DECIMAL_LITERAL lexer rule to allow negative decimal literals as well. This could also be achieved by using the unary minus operation, which would occur an runtime overhead and feel counter-intuitive for literals (imho). R=tebbi@chromium.org Change-Id: Ib01aa1930254bcd85a161de385b0fd4f176feb46 Reviewed-on: https://chromium-review.googlesource.com/1027473Reviewed-by:
-
Jaroslav Sevcik authored
This is just code reshuffling to enable changing Type* to Type. Bug: v8:3770 Change-Id: I8ed4ff41b480cab377d115c57c49d6f6c0c46d6d Reviewed-on: https://chromium-review.googlesource.com/1025897Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52772}
-
jing.bao authored
I16x8SConvertI32x4, I16x8UConvertI32x4, I8x16SConvertI16x8, I8x16UConvertI16x8 Change-Id: Iab462c3fb6c60de7b54a925e438862362605fe8d Reviewed-on: https://chromium-review.googlesource.com/1016178Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#52771}
-
- 24 Apr, 2018 23 commits
-
-
Erik Luo authored
This expands the SideEffectType flag to cover whitelisting embedder callbacks that are setup with Template accessors. - v8::ObjectTemplate::SetNativeDataProperty - v8::ObjectTemplate::SetLazyDataProperty - v8::ObjectTemplate::SetAccessor Bug: v8:7515 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ieda6c793141ab249c4f41d00e6572fe2a29ac629 Reviewed-on: https://chromium-review.googlesource.com/1015896Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#52770}
-
Andreas Haas authored
This reverts commit 44ea425a. Reason for revert: https://ci.chromium.org/buildbot/client.v8.ports/V8%20Arm%20-%20debug%20builder/13575 Original change's description: > [refactoring] Remove the isolate from signatures of ExternalReferences > > In this CL I remove the isolate from signatures of ExternalReference > accessor functions where the isolate is not used. The uses of the > isolate were already removed in previous CLs. > > Changes: > * I split the ExternalReference list in external-reference.h into > those which need the isolate for initialization and those which do not. > > * I removed the public constructors and replaced them by > ExternalReference::Create(). The reason is to separate external > creation more clearly from internal creation, because externally > created ExternalReferences sometimes need redirection, whereas > internally created ExternalReferences are just stored as they are. > In addition, by removing the isolate from the signature of the > public constructors, they suddenly exactly matched the interal > constructor. > > * Replace all uses of the public constructors with > ExternalReference::Create(). > > * Remove the isolate from all call sites where necessary. > > > This is a step towards making WebAssembly compilation independent of > the isolate. > > Bug: v8:7570 > R=mstarzinger@chromium.org > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I14f511fc6acc50ab2d6a6641299f5ddbeabef0da > Reviewed-on: https://chromium-review.googlesource.com/1018982 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52768} TBR=mstarzinger@chromium.org,ahaas@chromium.org Change-Id: I7c0d8d420f815cede23d550dee8942ac4d7791cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7570 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1026570Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52769}
-
Andreas Haas authored
In this CL I remove the isolate from signatures of ExternalReference accessor functions where the isolate is not used. The uses of the isolate were already removed in previous CLs. Changes: * I split the ExternalReference list in external-reference.h into those which need the isolate for initialization and those which do not. * I removed the public constructors and replaced them by ExternalReference::Create(). The reason is to separate external creation more clearly from internal creation, because externally created ExternalReferences sometimes need redirection, whereas internally created ExternalReferences are just stored as they are. In addition, by removing the isolate from the signature of the public constructors, they suddenly exactly matched the interal constructor. * Replace all uses of the public constructors with ExternalReference::Create(). * Remove the isolate from all call sites where necessary. This is a step towards making WebAssembly compilation independent of the isolate. Bug: v8:7570 R=mstarzinger@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I14f511fc6acc50ab2d6a6641299f5ddbeabef0da Reviewed-on: https://chromium-review.googlesource.com/1018982 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Eric Holk authored
This adds two new UMA histograms to give us more insight into Wasm memory allocation. The first records the result of every attempt to to allocate a Wasm backing store. This will let us know things like how often we explicitly trigger a GC, or how often we hit our address space limit. The second records how many megabytes of address space Wasm reserves. A sample is added every time the number either increases or decreases. This metric will give us a sense of how many outstanding Wasm memories there are in typical usage. Change-Id: I38c1bc1ad915c26b6cda3c373ededdd395193a4c Reviewed-on: https://chromium-review.googlesource.com/1024646 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#52767}
-
Sathya Gunasekaran authored
... from BaseCollectionsAssembler Bug: v8:7569 Change-Id: I938257b18372bbe8a43af3f25c85d192950be8fa Reviewed-on: https://chromium-review.googlesource.com/1026053 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#52766}
-
Sathya Gunasekaran authored
.. from BaseCollectionsAssembler Bug: v8:7569 Change-Id: I87fd35dbd82ad5752c857f35b63403ca348bf305 Reviewed-on: https://chromium-review.googlesource.com/1024700Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#52765}
-
Clemens Hammacher authored
This adds support for i32.rem_u and i32.rem_s, implemented on ia32 and x64. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Id08a51f7a0dcb7a1ed43c5a97be7a7dafff85397 Reviewed-on: https://chromium-review.googlesource.com/1023932Reviewed-by:
-
Dan Elphick authored
Use StringConstant instead of NewStringFromAsciiChecked so strings are deduplicated. Change-Id: I0c5395be6d06caacd7d257b61bd2372da2fce427 Reviewed-on: https://chromium-review.googlesource.com/1025815Reviewed-by:
-
Clemens Hammacher authored
This avoids some code duplication. R=mstarzinger@chromium.org Bug: v8:7570 Change-Id: Ib8f9095945e688e24351529f8e782614453f2161 Reviewed-on: https://chromium-review.googlesource.com/1023416Reviewed-by:
-
Andrew Grieve authored
Makes builds go faster by not having to re-run "gn gen" unnecessarily Also adds a bunch of flags that configure uses. --max-load --max-jobs --extra-gn-args --depot-tools --bundled-win-toolchain NOTRY=true NOTREECHECKS=true Change-Id: I6555623468d2b11d188ca29563586f5ea9b4dda9 Reviewed-on: https://chromium-review.googlesource.com/1016582 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Andrew Grieve authored
NOTRY=true NOTREECHECKS=true Change-Id: I6a9f671a9c3db4fb2eb346ccdf80a10d3e7a5040 Reviewed-on: https://chromium-review.googlesource.com/1025952Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#52760}
-
Kim-Anh Tran authored
Wasm tier-up first compiles the whole module using Liftoff, and then using Turbofan. The idea is to achieve fast start-up times by first running Liftoff-compiled code. In the meantime we finish compilation with Turbofan, and replace the Liftoff-compiled code as soon as Turbofan finished compilation, thus achieving high performance. Tier-up is enabled through the flag FLAG_wasm_tier_up. Bug: v8:6600 Change-Id: I70552969c53d909a591666a1e7ce1ee1419b2f34 Reviewed-on: https://chromium-review.googlesource.com/1010422 Commit-Queue: Kim-Anh Tran <kimanh@google.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52759}
-
Andreas Haas authored
This CL splits the definition of ValueType and its helper functions into its own header file. R=clemensh@chromium.org Bug: v8:7570 Change-Id: I3aa776edb45839d7d38836e131df45732c685310 Reviewed-on: https://chromium-review.googlesource.com/1021810 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL introduces a JSOperator for Array.isArray and moves the corresponding lowering to JSCallReducer and JSTypedLowering. Bug: v8:7340, v8:7250 Change-Id: Iaa7ced2ad34bec8cccc9da1041007261168cf4b3 Reviewed-on: https://chromium-review.googlesource.com/1025092 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52757}
-
Sigurd Schneider authored
Bug: v8:7679 Change-Id: If8b6d9ad4f93eb2b98878c916625b7a344e5900c Reviewed-on: https://chromium-review.googlesource.com/1021532Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52756}
-
Andreas Haas authored
WebAssembly.instantiate is polymorphic, it can either take a module object as parameter, or a buffer source which should be compiled first. To share code between the two implementations, the module object was first passed to a promise (i.e. which is the result of compilation). However, passing the module object to a promise has a side effect if the module object has a then function. To avoid this side effect I remove this code sharing and call AsyncInstantiate directly in case the parameter is a module object. R=mstarzinger@chromium.org Bug: chromium:836141 Change-Id: I67b76d0d7761c5aeb2cf1deda45b6842e494eed4 Reviewed-on: https://chromium-review.googlesource.com/1025774Reviewed-by:
-
Clemens Hammacher authored
Passing a pointer of the needed type, and then reading using ReadUnalignedValue is pointless, since the compiler can assume alignment of the pointer value. This CL fixes the remaining external refs of wasm to take an Address to a single buffer. R=ahaas@chromium.org Bug: v8:7570, v8:3770 Change-Id: If8a7324a4703e1e900cb3c5644baef207e6a371d Reviewed-on: https://chromium-review.googlesource.com/1023406 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Kenton Varda authored
For use cases with a large number of threads or a large number of isolates (or both), ThreadDataTable can be a major performance bottleneck due to O(n) lookup time of the linked list. Switching to a hash map reduces this to O(1). Example 1: Sandstorm.io, a Node.js app that utilizes "fibers", was observed spending the majority of CPU time iterating over the ThreadDataTable. See: https://sandstorm.io/news/2016-09-30-fiber-bomb-debugging-story Example 2: Cloudflare's Workers engine, a high-multi-tenancy web server framework built on V8 (but not Node), creates large numbers of threads and isolates per-process. It saw a 34x improvement in throughput when we applied this patch. Cloudflare has been using a patch in production since the Workers launch which replaces the linked list with a hash map -- but still global. This commit builds on that but goes further and creates a separate hash map and mutex for each isolate, with the table being a member of the Isolate class. This avoids any globals and should reduce lock contention. Bug: v8:5338 Change-Id: If0d11509afb2e043b888c376e36d3463db931b47 Reviewed-on: https://chromium-review.googlesource.com/1014407Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7490 Change-Id: I03421657d4abc3cd6e27ffafa6b922ea0e83b2b4 Reviewed-on: https://chromium-review.googlesource.com/1016381 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Daniel Clifford authored
Bug: v8:7666 Change-Id: Ida9b6f964261bad75a4eb5d567ad37ec82569bcc Reviewed-on: https://chromium-review.googlesource.com/1023061 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#52751}
-
Marja Hölttä authored
LoadMaybeWeakField returns a TNode<MaybeObject>, and the only way to extract values from it is through explicit functions. Previous version: https://chromium-review.googlesource.com/1014106 BUG=v8:7308 Change-Id: I73bf3a007733ed84937e45336ac142011adc5151 Reviewed-on: https://chromium-review.googlesource.com/1023935Reviewed-by:
-
Ingvar Stepanyan authored
NewFunctionFromSharedFunctionInfo is not called with `undefined` anymore, and so can be changed to just accept `Handle<Context>`. Additionally, reporting script compilation to the debugger can now be moved into `Compiler::PostInstantiation`. R=yangguo@chromium.org Change-Id: I0a9b3fa51f87f41b4fc97a29f79c110c6246f273 Reviewed-on: https://chromium-review.googlesource.com/1024832Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52749}
-
Benedikt Meurer authored
Bug: chromium:830565 Change-Id: I1adab76e790a81f51f7b03165962992f5afecc99 Reviewed-on: https://chromium-review.googlesource.com/1023400 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
- 23 Apr, 2018 11 commits
-
-
Erik Luo authored
This CL whitelists Console Command Line API callbacks on the V8 side. Bug: chromium:810176 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7afdd6bd4263cb4cb18bdf02b37ab3e822ae5c96 Reviewed-on: https://chromium-review.googlesource.com/1016094 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52747}
-
Vincent Belliard authored
On AArch64, we can't push arguments one by one because sp must always be 16 byte aligned. This patch adds a LiftoffStackSlots class which holds everything which has to be pushed. This way, on AArch64, we will be able to reserve the needed space and eventually add some padding. Then, all pushes will be converted to stores into this reserved space. Bug: v8:6600 Change-Id: I17480fb841f16e07356b35326c59e3c7f03ed012 Reviewed-on: https://chromium-review.googlesource.com/1023977 Commit-Queue: Vincent Belliard <vincent.belliard@arm.com> Reviewed-by:
-
Alexey Kozyatinskiy authored
This function can be used to set breakpoint on any function call, including native functions without source code, for them new method is only one way to set breakpoint. R=dgozman@chromium.org Bug: chromium:828076 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iae8f4805b6e860a7ca008041fdfbe75e43a1959c Reviewed-on: https://chromium-review.googlesource.com/1023128 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#52745}
-
Eric Holk authored
Bug: chromium:834693, chromium:834955 Change-Id: I243521f45c2b7e2457a37d34ab3629670d8fa39b Reviewed-on: https://chromium-review.googlesource.com/1020361 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
This CL introduced SafeForInterruptsScope. This scope overrides outer PostponeInterruptsScopes: - reschedule postponed interrupts if needed, - allow requesting new interrupts. As soon as scope removed interrupts are posponed if needed. This scope will be: - used to allow inspector to interrupt and terminate DebugeEvaluate::Local, - exposed with new flag on Isolate to implement SafeForTerminationScope in blink. R=yangguo@chromium.org Bug: chromium:820640 Change-Id: I15befc10c2cee393d1e3be48cecb31ee14dae638 Reviewed-on: https://chromium-review.googlesource.com/1022969 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of 5728b3fb Original change's description: > [builtins] Separate species protectors for Array, TypedArray, Promise > > Previously, there was one species protector for Array, TypedArray and > Promise. This CL splits the protector in three separate ones. This means > that invalidating one of them does not have negative performance > implications for the other ones. > > Bug: chromium:835347, v8:7340 > Change-Id: Id84aa0071f17096192965264eb60ddadd1e8e73f > Reviewed-on: https://chromium-review.googlesource.com/1023408 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52733} Bug: chromium:835347, v8:7340 Change-Id: I0c0188a0723e206ddb362834bcf872b23cd7666d Reviewed-on: https://chromium-review.googlesource.com/1023811 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
Embedder may implement any non trivial logic using embedder fields, e.g. creates wrappers lazily and store native pointer to native object inside embedder fields. R=yangguo@chromium.org Bug: v8:7588 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id14eb6e686f8945cb350cfe77e8a4b3c52c5ec5b Reviewed-on: https://chromium-review.googlesource.com/1013404Reviewed-by:
-
Aleksey Kozyatinskiy authored
This reverts commit bd7f5cf0. Reason for revert: does not work well. Original change's description: > Roll third_party/inspector_protocol to 59ca26e > > This roll includes: > - [inspector_protocol] first class citizien .pdl support > - [inspector_protocol] node uses script names inside own repository > > + removed .json file > > R=pfeldman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Idd87e80a3ce42198858ade4bcf6e6fec4b2f0731 > Reviewed-on: https://chromium-review.googlesource.com/804635 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52734} TBR=pfeldman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I64cfa2740c03a2c15db1eb483212adec8f5f6a76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1024350Reviewed-by:
-
Sigurd Schneider authored
This manages input_index directly in TranslatedFrame::iterator. I think the overhead is low enough, expecially since all uses of the iterator, except one, compute input_index anyway. Bug: v8:7679 Change-Id: I7e5fc08ff23a49415265afd617248c55f4d95e19 Reviewed-on: https://chromium-review.googlesource.com/1021711 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Pierre Langlois authored
The movw/movt instructions are only available since Armv7. One of the disassembly tests was expecting these instructions when, on Armv6, we generate a load literal. Change-Id: I2b11894b5de748fc185f341b0cd49fa518d005e5 Reviewed-on: https://chromium-review.googlesource.com/978143 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
-
Clemens Hammacher authored
This adds support for i32.div_u and i32.div_s, implemented on ia32 and x64. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I920fb0613ecba0021dab0936690415be88d666e9 Reviewed-on: https://chromium-review.googlesource.com/1021890 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
