- 01 Dec, 2015 30 commits
-
-
mstarzinger authored
Revert of [turbofan] Ship TurboFan with new.target references. (patchset #1 id:1 of https://codereview.chromium.org/1482733002/ ) Reason for revert: Tanks sunspider/date-format-tofte because of the Date constructor being turbofanned. Original issue's description: > [turbofan] Ship TurboFan with new.target references. > > This correctly marks functions containing a new.target reference as > being disabled with Crankshaft, which would have bailed out anyways. > Also note that this will trigger TurboFan for such functions and hence > widens the TurboFan intake valve. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/2ec6fcd1520bb8a09c9924ac5498eb9b437670b0 > Cr-Commit-Position: refs/heads/master@{#32444} TBR=bmeurer@chromium.org,rossberg@chromium.org,hablich@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1489833002 Cr-Commit-Position: refs/heads/master@{#32455}
-
jkummerow authored
The fix is to bail out of compilation in that case. BUG=chromium:551287 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1483373002 Cr-Commit-Position: refs/heads/master@{#32454}
-
machenbach authored
Depends on https://chromereviews.googleplex.com/319777013/ BUG=chromium:561530 LOG=n TBR=sergiyb@chromium.org, tandrii@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1486963002 Cr-Commit-Position: refs/heads/master@{#32453}
-
mvstanton authored
CallIC and CallConstructStub look so alike, at least in the feedback they gather even if the implementation differs...and CallIC has such a nice way of surfacing the feedback (CallICNexus), that there is a request to make CallConstructStub look analogous. Enter ConstructICStub. BUG= Review URL: https://codereview.chromium.org/1476413003 Cr-Commit-Position: refs/heads/master@{#32452}
-
jochen authored
BUG=none R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1488563002 Cr-Commit-Position: refs/heads/master@{#32451}
-
yangguo authored
R=hablich@chromium.org Review URL: https://codereview.chromium.org/1486003003 Cr-Commit-Position: refs/heads/master@{#32450}
-
yangguo authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1474293002 Cr-Commit-Position: refs/heads/master@{#32449}
-
bradnelson authored
This greens the wasm travis build. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=asm-wasm tests TBR=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1490673002 Cr-Commit-Position: refs/heads/master@{#32448}
-
mstarzinger authored
This switches all remaining builtin methods to use the ES6 new.target value when determined whether being called as a constructor or not. This is prepatory work for fully deprecating the aforementioned intrinsic. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1474343002 Cr-Commit-Position: refs/heads/master@{#32447}
-
mstarzinger authored
This moves the decision whether code flushing is active into the setup phase of the GC. Components are no longer allowed to dynamically switch the code flushing mode on demand. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1487743002 Cr-Commit-Position: refs/heads/master@{#32446}
-
machenbach authored
Removes the triggered builder temporarily. In a follow up, it'll be added with the new syntax from: https://chromereviews.googleplex.com/319777013/ BUG=chromium:561530 LOG=n TBR=sergiyb@chromium.org, tandrii@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1483063005 Cr-Commit-Position: refs/heads/master@{#32445}
-
mstarzinger authored
This correctly marks functions containing a new.target reference as being disabled with Crankshaft, which would have bailed out anyways. Also note that this will trigger TurboFan for such functions and hence widens the TurboFan intake valve. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1482733002 Cr-Commit-Position: refs/heads/master@{#32444}
-
bmeurer authored
This is the initial support for binary operation hints on javascript binary operators, i.e. JSAdd, JSSubtract and so on. The hints are extracted from the fullcodegen code object before graph building and the AstGraphBuilder puts those hints on the operators if available. R=jarin@chromium.org BUG=v8:4583 LOG=n Review URL: https://codereview.chromium.org/1487973002 Cr-Commit-Position: refs/heads/master@{#32443}
-
zhengxing.li authored
X87 port already implemented Float64RoundDown and Float64RoundTruncate operators, not enabled yet. This CL would enable them. BUG= Review URL: https://codereview.chromium.org/1486483003 Cr-Commit-Position: refs/heads/master@{#32442}
-
zhengxing.li authored
port 9e644881 (r32407) original commit message: This way we avoid the %_IsSmi magic that is required in TurboFan to (efficiently) check abitrary context slots for smi 0. Checking against "the hole" is common in the AstGraphBuilder and "the hole" is also used to mark other context slots as not initialized. BUG= Review URL: https://codereview.chromium.org/1486913002 Cr-Commit-Position: refs/heads/master@{#32441}
-
zhengxing.li authored
port 51e992f1 (r32410) original commit message: Restore frame pointer directly from stack rather than copying it and restoring. Also restore return address register directly on platforms that support it. BUG= Review URL: https://codereview.chromium.org/1483063004 Cr-Commit-Position: refs/heads/master@{#32440}
-
mtrofin authored
Node has an operator<<, however, constructing an ostream in a debugger session is non-trivial, hence this method. BUG= Review URL: https://codereview.chromium.org/1488953003 Cr-Commit-Position: refs/heads/master@{#32439}
-
mbrandy authored
Port 9e644881 Original commit message: This way we avoid the %_IsSmi magic that is required in TurboFan to (efficiently) check abitrary context slots for smi 0. Checking against "the hole" is common in the AstGraphBuilder and "the hole" is also used to mark other context slots as not initialized. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1491453002 Cr-Commit-Position: refs/heads/master@{#32438}
-
v8-autoroll authored
Rolling v8/build/gyp to f4d65e35719cfe02257ece126c109cfc053ca35c Rolling v8/tools/clang to 3bd755f93254f9c21a323a5cfd28dacbe02e53e4 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1486733003 Cr-Commit-Position: refs/heads/master@{#32437}
-
mbrandy authored
R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1487873002 Cr-Commit-Position: refs/heads/master@{#32436}
-
mbrandy authored
Port 47502a23 Original commit message: Previously all contexts had a link to the global object, but what is required in most cases (except for the global load, store and delete case) is the native context. This also removes the second dummy global object that was still linked to every native context. We will add a different mechanism to ensure that builtins do not pollute the actual global object during bootstrapping. Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1491433002 Cr-Commit-Position: refs/heads/master@{#32435}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1480243003 Cr-Commit-Position: refs/heads/master@{#32434}
-
mbrandy authored
Port 7ceaf727 R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:1543, v8:3330, v8:3931 LOG=n Review URL: https://codereview.chromium.org/1480423002 Cr-Commit-Position: refs/heads/master@{#32433}
-
mbrandy authored
Port 81e131ce R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1482153005 Cr-Commit-Position: refs/heads/master@{#32432}
-
bradnelson authored
SIMD.js potentially adds to the standard library passed into asm.js modules. Splitting off the point where the SIMD object would be referenced to allow work on SIMD typing to occur orthogonally. Adding VariableInfo to allow tracking of simd constructors / check functions. Using this for fround. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Looking at simd.js Review URL: https://codereview.chromium.org/1473513004 Cr-Commit-Position: refs/heads/master@{#32431}
-
mbrandy authored
Port d3e5db04 Original commit message: Up until now we sometimes pass Smi 0 around as closure and expect the runtime to translate that appropriately. But we need to be careful in some places to not confuse the Smi 0 with a real closure. However, we could instead just pass the correct closure extracted from the native context. This addresses three long-standing TODOs in the JSTypedLowering pass. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1490553002 Cr-Commit-Position: refs/heads/master@{#32430}
-
adamk authored
This fixes a corner-case in redeclaration handling, where the ES2015 early error case got mixed up with legacy const handling in the parser. Redeclaration using ES2015 'let' and 'const' should be early errors, but legacy 'const' redeclaration has historically been a runtime error, and should stay that way until legacy 'const' is gone. The fix here is uglier than it might be due to https://code.google.com/p/v8/issues/detail?id=4577, which keeps us from simplifying the mess of if/else-if in the current code. BUG=v8:4576 LOG=n Review URL: https://codereview.chromium.org/1485943002 Cr-Commit-Position: refs/heads/master@{#32429}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1490513004 Cr-Commit-Position: refs/heads/master@{#32428}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1480213003 Cr-Commit-Position: refs/heads/master@{#32427}
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1484143002 Cr-Commit-Position: refs/heads/master@{#32426}
-
- 30 Nov, 2015 10 commits
-
-
mbrandy authored
Port 3d004eea Original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. The interpreter entry trampoline stores this value in a bytecode register so that it can be accessed directly by the interpreter. The size of the interpreter stack frame hence grows by one slot. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4544 LOG=n Review URL: https://codereview.chromium.org/1487863002 Cr-Commit-Position: refs/heads/master@{#32425}
-
bradnelson authored
The Type::Print method requires an explict zone, even for basic types on arm debug. This change introduced debug mode printing when types don't match: https://codereview.chromium.org/1471073003/ Adding the zone parameter to make the arm build go green. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=local arm build TBR=bbudge@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1490593002 Cr-Commit-Position: refs/heads/master@{#32424}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1488563003 Cr-Commit-Position: refs/heads/master@{#32423}
-
mbrandy authored
Port 51e992f1 Original commit message: Restore frame pointer directly from stack rather than copying it and restoring. Also restore return address register directly on platforms that support it. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4076 LOG=n Review URL: https://codereview.chromium.org/1490563002 Cr-Commit-Position: refs/heads/master@{#32422}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1485653003 Cr-Commit-Position: refs/heads/master@{#32421}
-
mbrandy authored
Port 51669873 Original commit message: Some highlights of this CL: * Refactor the mutable state out of Frame into FrameAccessState, which is maintained and updated during code generation to record whether sp- or fp-based frame access is currently active and how deep the stack on top of the frame is. * The operand resultion in linkage.cc now uses FrameAccessState to determine how to generate frame-accessing operands. * Update all platforms to accurately track additionally pushed stack slots (e.g. arguments for calls) in the FrameAccessState. * Add a flag, --turbo_sp_frame_access, which forces all frame access to be sp-based whenever possible. This will likely never be used in production, but for testing it's useful in verifying that the stack-tracking of each platform maintained in the FrameAccessState is correct. * Use sp-based frame access for gap resolving before tail calls. This will allow for slightly more efficient restoration of the frame pointer in the tail call in a later CL. * Remove most ad hoc groping into CallDescriptors to determine if a frame is needed, instead consistently use predicates like needs_frame(), IsCFunctionCall() and IsJSFunctionCall(). R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4076 LOG=n Review URL: https://codereview.chromium.org/1484913003 Cr-Commit-Position: refs/heads/master@{#32420}
-
bradnelson authored
Shifts of integer values are in some contexts collapsed by the parser into single literal AST nodes, rather than a direct representation of the parse tree. Confirming this behavior in tests. Integer TypedArrays are assumed to load and store "intish" values rather than more fine-grained type information. Reducing the precision of the typing information to match the spec and simplify the wasm generator. The asm spec requires load and store values of various "float?", "floatish", "double?" and "intish" types to ensure undefined values are not visible and that float32 rounding occurs at the right time. More closely matching this. Adding additional testing around unsigned / signed comparisons, loads and stores. Adding addition debug mode printing when asserting about types fail. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator, wasm side tests R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1471073003 Cr-Commit-Position: refs/heads/master@{#32419}
-
alan.li authored
BUG= Review URL: https://codereview.chromium.org/1453373002 Cr-Commit-Position: refs/heads/master@{#32418}
-
alan.li authored
BUG= Review URL: https://codereview.chromium.org/1481493002 Cr-Commit-Position: refs/heads/master@{#32417}
-
mstarzinger authored
Revert of [heap] Aggressive code flushing in GC stress mode. (patchset #1 id:1 of https://codereview.chromium.org/1483993002/ ) Reason for revert: This breaks (surprise) GC stress with custom snapshot, cannot reproduce, will need to investigate further. https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/2909/steps/Mjsunit/logs/deopt-inlined-from-call Original issue's description: > [heap] Aggressive code flushing in GC stress mode. > > This disregards the code age heuristic when deciding whether to flush > code so that GC stress mode is more likely to flush out potential races > between our various "invariants". > > R=hpayer@chromium.org > > Committed: https://crrev.com/28a3f23e50f1847dd1152e6bb4aa0579acbdaaab > Cr-Commit-Position: refs/heads/master@{#32414} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1485823002 Cr-Commit-Position: refs/heads/master@{#32416}
-