- 18 Dec, 2018 11 commits
-
-
Michael Achenbach authored
NOTRY=true Bug: v8:8421 Change-Id: I00d3a478a876b5ab542c73accd426695308f0e82 Reviewed-on: https://chromium-review.googlesource.com/c/1375915 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58309}
-
Jakob Gruber authored
This is a reland of 1efe6259 Original change's description: > [snapshot] Clear irregexp code prior to serialization > > Compiled irregexp code should be cleared unless > FunctionCodeHandling::kKeep is passed. > > Bug: v8:8572 > Change-Id: Icb74cc6e0f39a69f8383b05f1638cf0e3be1807c > Reviewed-on: https://chromium-review.googlesource.com/c/1373773 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58272} Bug: v8:8572 Change-Id: I2dfe0c1b4419c47fe2a1916c3bc16800a30309c5 Reviewed-on: https://chromium-review.googlesource.com/c/1379937 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58308}
-
Toon Verwaest authored
Since it's explicit what we're tracking, we can immediately throw errors in certain cases, and ignore irrelevant errors. We don't need to use the classifier itself to track "let let", since we know whether we're parsing a "let". Errors that were previously (almost) always accumulated are now immediately pushed to the scopes that care (parameter initialization errors). This CL drops avoiding allocation of classified errors, at least for now, but that doesn't affect performance anymore since we don't aggressively blacklist anymore. Classified errors are even less likely with the more precise approach. ParseAssignmentExpression doesn't introduce its own scope immediately, but reuses the outer scope. Rather than using full ExpressionClassifiers + Accumulate to separate expressions/patterns from each other while keeping track of the overall error state, this now uses an explicit AccumulationScope. When we parse (async) arrow functions we introduce new scopes that track that they may be (async) arrow functions. We track StrictModeFormal parameters in 2 different ways if it isn't immediately certain that it is a strict-mode formal error: Either directly on the (Pre)ParserFormalParameters, or on the NextArrowFunctionInfo in the case we're not yet certain that we'll have an arrow function. In the latter case we don't have a FormalParameter object yet, and we'll copy it over once we know we're parsing an arrow function. The latter works because it's not allowed to change strictness of a function with non-simple parameters. Design doc: https://docs.google.com/document/d/1FAvEp9EUK-G8kHfDIEo_385Hs2SUBCYbJ5H-NnLvq8M/ Change-Id: If4ecd717c9780095c7ddc859c8945b3d7d268a9d Reviewed-on: https://chromium-review.googlesource.com/c/1367809 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#58307}
-
Mike West authored
Bug: chromium:915620 Change-Id: I75579080098632639b125b2252b3ab9615c7ea95 Reviewed-on: https://chromium-review.googlesource.com/c/1379876Reviewed-by:
-
Marja Hölttä authored
This makes it less likely to break layout tests (and block rolling V8 to Chromium) by accident. BUG=v8:8595 NOTRY=true Change-Id: Ie5d2fad72b5b6dc4e3101114068ad134add2e475 Reviewed-on: https://chromium-review.googlesource.com/c/1379882 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58305}
-
Marja Hölttä authored
BUG=v8:8179 Change-Id: I8ef7d3b576db9e872ab527895f5ba3be4ba3f6ce Reviewed-on: https://chromium-review.googlesource.com/c/1379881Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#58304}
-
Maxim Mazurok authored
- Changed "Formating" to "Formatting" in comment - Added Maxim Mazurok <maxim@mazurok.com> to AUTHORS file as required by https://www.chromium.org/developers/contributing-code#TOC-Legal-stuff Change-Id: I48633694975879013c983580fa9b8c71dcb2e8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1379231 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Tamer Tas authored
See errors like: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Fuzzer/28117 The logs only shows the tail of the stderr, in order to get information, huge logs need to be downloaded. Instead of using the tail end of the stderr logs, we get the head of the stderr logs, which is the important part for us. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org gclient sync cd v8 tools/jsfunfuzz/fuzz-harness.sh out/x64.debug/d8 fuzz-results.tar.bz2 ``` Test: ``` Bug: v8:8493 Change-Id: Ia87c52f5b08ff9748cf2a81c9ca983d22fda650d Reviewed-on: https://chromium-review.googlesource.com/c/1378177 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Frank Tang authored
Sync with https://github.com/tc39/proposal-intl-segmenter/pull/55 and https://github.com/tc39/test262/pull/1994 Bug: v8:8588 Change-Id: Ifc46779f156ea986e3dbe6a632a781bb7134112b Reviewed-on: https://chromium-review.googlesource.com/c/1374997Reviewed-by:
-
tzik authored
This updates node typings in MicrotaskQueue builtins including: - Use RawPtrT instead of IntPtrT for pointers. - Prefer CAST instead of UncheckedCast where possible. - Fix MachineType / MachineRepresentation values there. Bug: v8:8124 Change-Id: Idb02ac3ae51d2e9d45920115955afb68c81c7794 Reviewed-on: https://chromium-review.googlesource.com/c/1375510 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58300}
-
tzik authored
This adds a MicrotaskQueue parameter to Execution::RunMicrotasks, and propagate it to Invoke(). Also, reorganizes the existing and newly added parameters into a struct. Change-Id: Ib98009b97681fdb554c0a8d469be962aea4138bd Reviewed-on: https://chromium-review.googlesource.com/c/1373210 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
- 17 Dec, 2018 29 commits
-
-
Frank Tang authored
Change the initial value of breakType to undefined Store break type into bits Change the algorithm Bug: v8:6891 Change-Id: Id2cc1e90c28d92364318928fc8a377f172ebb339 Reviewed-on: https://chromium-review.googlesource.com/c/1374996Reviewed-by:
-
Frank Tang authored
This is a reland of 7b744e3a I cannot reproduce the problem in this reland CL. I think the origin breakage is just due to test flakiness. Try to reland it without changes TBR=jshin@chromium.org Original change's description: > [Intl] Replace uloc_(to|for)Language w/ Locale API > > Bug: v8:8468 > Change-Id: Id2f8d165e5f29f429821b44def2512fe760c0a51 > Reviewed-on: https://chromium-review.googlesource.com/c/1377989 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58260} Bug: v8:8468 Change-Id: I5f34d061d630d07f5c9da07f9adb1efa040d66d5 Reviewed-on: https://chromium-review.googlesource.com/c/1378658Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58297}
-
Frank Tang authored
Bug: v8:7834 Change-Id: Id8018c01e757741aad9ecbdf331bfb1a4b050d81 Reviewed-on: https://chromium-review.googlesource.com/c/1379570 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I968bcf38bfbf3672181ac4ad6b787c0b77a89cfd Reviewed-on: https://chromium-review.googlesource.com/c/1380911 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Ie80ce957ff1d2bcd3596491066f6562ce0ad129a Reviewed-on: https://chromium-review.googlesource.com/c/1380114 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Along with HeapNumberBase and MutableHeapNumber, of course. Bug: v8:5402 Change-Id: I14a7f8052de3839cad36bb7e4ebb6da38b2ac096 Reviewed-on: https://chromium-review.googlesource.com/c/1379884 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58293}
-
Clemens Hammacher authored
C++ introduces the {alignof} keyword, which evaluates to an integral constant defining the alignment of the given type. This makes {V8_ALIGNOF} redundant. R=ulan@chromium.org Bug: v8:8562 Change-Id: I15a4022c2c396afba96360f218d8a04b17a9a448 Reviewed-on: https://chromium-review.googlesource.com/c/1379938 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Jakob Gruber authored
The kCallOnHeapBuiltin name has gotten very confusing now that builtins are actually off the heap (and the generated code will directly call off-heap). Bug: v8:7777 Change-Id: Ie14069eee2fc11ef9aec64868c50832f6138ae8f Reviewed-on: https://chromium-review.googlesource.com/c/1379883Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58291}
-
Clemens Hammacher authored
C++ introduces the {alignas} keyword, which can be used with types or integral constant expressions. Use this instead of the V8_ALIGNAS (for types) or V8_ALIGNED (for integral constants) macros. R=ulan@chromium.org Bug: v8:8562 Change-Id: I54999b56a5715237f88c63d8543ef728a5b2eff5 Reviewed-on: https://chromium-review.googlesource.com/c/1379935Reviewed-by: -
Jakob Kummerow authored
Bug: v8:5402 Change-Id: I07f276dc6a06a2850aaae0a5ee4cbbfd27d8aa81 Reviewed-on: https://chromium-review.googlesource.com/c/1379875 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Parser::MaybeResetCharacterStream calls Scope::ContainsAsmModule which recursively checks whether a Scope is an asm module or any of its sub-scopes. This is sub-optimal for deeply nested scopes and many functions which do not contain any asm modules. Drive-by-fix: - rename Scope::asm_module to Scope::is_asm_module Change-Id: I922270c608b54c6525f0672ead4aca90f57a6551 Reviewed-on: https://chromium-review.googlesource.com/c/1360636Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58288}
-
Jakob Kummerow authored
Tuple2 and subclasses: EnumCache, SourcePositionTableWithFrameCache, TemplateObjectDescription Bug: v8:3770 Change-Id: Icff0860a04445dda542119834ef9866167ba2263 Reviewed-on: https://chromium-review.googlesource.com/c/1377772 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#58287}
-
Jakob Gruber authored
This changes Torque's builtin pointers to use a Smi representation underneath instead of storing the Code target object. Callsites look up the target entry point through IsolateData::builtin_entry_table. The notable effect of this CL is that builtin pointer calls no longer call any on-heap Code. Bug: v8:7777 Change-Id: Ibf6c749dd46cae7aba51494b09921229dd436f63 Reviewed-on: https://chromium-review.googlesource.com/c/1379880 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7490,v8:8562 Change-Id: Ie3e277fef97900dbefbf08cb02f6c03e8dd408b7 Reviewed-on: https://chromium-review.googlesource.com/c/1379877Reviewed-by:
-
Jakob Kummerow authored
CallbackInfo, InterceptorInfo, Tuple3 Bug: v8:3770 Change-Id: I47a380949c031ed9eba0e5a7d752669efc0af76c Reviewed-on: https://chromium-review.googlesource.com/c/1377771 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:5402 Change-Id: Ifdbc61eb401160d03b98336292f1725d604e7f51 Reviewed-on: https://chromium-review.googlesource.com/c/1379936 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Either Address* or Handle<Object> or ObjectSlot, depending on circumstances. Bug: v8:3770 Change-Id: Id00dfede6eb92ec30b658c0090b5310548ba5162 Reviewed-on: https://chromium-review.googlesource.com/c/1379228 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58282}
-
Jakob Gruber authored
Currently, Torque's builtin pointers store a Code target underneath and callsites generate a kArchCallCodeObject opcode. When embedded builtins are enabled, the call thus first calls the on-heap trampoline, which finally jumps to the target off-heap builtin code. This will no longer be possible in jitless mode, since on-heap code must not be executable. As a step towards changing the way builtin pointers are called (function pointers will hold the builtin index as a Smi, and callsites look up the off-heap target address and jump there), this CL adds a dedicated opcode for builtin pointer calls to the compiler pipeline. The calling mechanism itself is unchanged, changes there will happen in a follow-up. Drive-by: rename 'FunctionPointer' in torque/ to 'BuiltinPointer'. Bug: v8:7777 Change-Id: Ic999a1cd7c3172425dd4a1513ae2f50c774faddb Reviewed-on: https://chromium-review.googlesource.com/c/1378175Reviewed-by:
-
Clemens Hammacher authored
R=mmoroz@chromium.org Bug: chromium:911644 Change-Id: Icc42e5ace80ea816925c95e2ea330b484b68e7cf Reviewed-on: https://chromium-review.googlesource.com/c/1379878Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Id7a05e5687d36c9347f35f6f3276af2a4b6115fd Reviewed-on: https://chromium-review.googlesource.com/c/1377770 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of 3ad101f5 Original change's description: > [assembler] Split out CPUFeatures into its own file > > This reduces the preprocessor expanded source size by 84,675 LoC: > > gen ( 20 files): 71,349 to 1,523,934 ( 21x) > src ( 624 files): 367,410 to 53,253,894 ( 145x) > test ( 392 files): 490,503 to 37,436,176 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,031 to 102,736,424 ( 87x) > > to > > gen ( 20 files): 71,349 to 1,523,794 ( 21x) > src ( 624 files): 367,411 to 53,186,896 ( 145x) > test ( 392 files): 490,504 to 37,418,639 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,033 to 102,651,749 ( 87x) > > > Change-Id: Ia8a79092051a42815b65e86a0784297915368c9b > Reviewed-on: https://chromium-review.googlesource.com/c/1291471 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58266} TBR=marja@chromium.org,clemensh@chromium.org,ulan@chromium.org Change-Id: I5b857666508b1c80dcadd0b470aada37dd49077e Reviewed-on: https://chromium-review.googlesource.com/c/1379872Reviewed-by:
-
Jakob Kummerow authored
Microtask, CallableTask, CallbackTask, PromiseReactionJobTask, PromiseFulfillReactionJobTask, PromiseRejectReactionJobTask, PromiseResolveThenableJobTask, WeakFactoryCleanupJobTask Bug: v8:3770 Change-Id: I778a807394acddbbee74f626dcfee211b0bcbe6a Reviewed-on: https://chromium-review.googlesource.com/c/1377769 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58277}
-
Tamer Tas authored
The purpose of this is to simplify tools tests imports. For example, with this commit, 'from ..v8_presubmit import TestClass' is possible in 'tools/unittests/v8_presubmit_test.py'. R=machenbach@chromium.org,sergiyb@chromium.org Change-Id: Ib19a6e3af4027095c72d4c87a9d759ac85a2e1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1379934Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:5402 Change-Id: Ibaf91722165df830fd14b3b4a659802bce809bf1 Reviewed-on: https://chromium-review.googlesource.com/c/1379873Reviewed-by:
-
Jakob Kummerow authored
FeedbackCell, FunctionTemplateRareData, TemplateInfo, FunctionTemplateInfo, ObjectTemplateInfo Bug: v8:3770 Change-Id: Ic30ff2563fe30088b7740d5e98ade03cdae7fdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1377459 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 1efe6259. Reason for revert: Broken V8 Linux - arm - sim - lite build - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/1259 Original change's description: > [snapshot] Clear irregexp code prior to serialization > > Compiled irregexp code should be cleared unless > FunctionCodeHandling::kKeep is passed. > > Bug: v8:8572 > Change-Id: Icb74cc6e0f39a69f8383b05f1638cf0e3be1807c > Reviewed-on: https://chromium-review.googlesource.com/c/1373773 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58272} TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: I7a8c7f5c1500714bccee5c11224fbdf0132c6d78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8572 Reviewed-on: https://chromium-review.googlesource.com/c/1379874Reviewed-by:
-
Jakob Gruber authored
Compiled irregexp code should be cleared unless FunctionCodeHandling::kKeep is passed. Bug: v8:8572 Change-Id: Icb74cc6e0f39a69f8383b05f1638cf0e3be1807c Reviewed-on: https://chromium-review.googlesource.com/c/1373773 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mythri authored
Bug: v8:8394 Change-Id: I3db77f090249251b9765ce869fd8268d43d8347c Reviewed-on: https://chromium-review.googlesource.com/c/1375663Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#58271}
-
Yang Guo authored
R=jgruber@chromium.org Bug: chromium:915435 Change-Id: Ic5535adb2aa09ffc72bf4e50ff8ec624dea1909e Reviewed-on: https://chromium-review.googlesource.com/c/1379932Reviewed-by:
-
