- 17 Apr, 2020 16 commits
-
-
Yang Guo authored
Fixed: chromium:986051 Change-Id: I01ef94fe43ac5c8734890706a6dccd01e008bfec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153215Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67204}
-
Michael Lippautz authored
Supported HW architectures: ia32, x64, arm, arm64, ppc64, s390, mips, mips64 Compiler support: - clang/gcc: all - msvc tools: ia32, x64, arm64 Thanks all for porting! Bug: chromium:1056170 Change-Id: I26ea7d727dc6d90929941668b8f115bdbaf226ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153210 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67203}
-
Clemens Backes authored
Stepping only happens in one frame at a time, so we don't need to rewrite the whole stack. This allows us to remove the {flooded_function_index_}, since no function is globally flooded any more. A follow-up CL will ensure that the code will also not be installed in the code table and jump table any more, to fix issues with non-local control flow (i.e. catching a trap and reentering wasm), where we could currently accidentally execute flooded code. It will also speed up stepping over recursive calls enormously, since the recursive calls don't run into the flooded breakpoints any more. R=thibaudm@chromium.org Bug: v8:10235 Change-Id: Ifae5e35c3242c95e1fe1a89a169ce874b818a288 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2152646Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67202}
-
Adam Kallai authored
NEONFormatDecoder::Substitute function utilizes snprintf() to substitute arrangement specifier into a format string. Some instruction format strings (e.i. ld4r) are specified with '%n$' positional parameter fields, but on Windows snprintf function doesn't support these parameters. NEONFormatDecoder logic is extended to handle four parameters in order to avoid using positional parameters. Bug: v8:10365 Change-Id: I79d4014c6b45d698ca47090a74c30e4eae856334 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2148776Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67201}
-
Paolo Severini authored
This changelist adds to the GDB stub (in class wasm::gdb_server::Target) the logic to decode and execute GDB-remote commands and to format response packets to be sent back to the debugger. Here most of the commands still act as a NOOP; the actual implementation requires interactions with the Wasm engine and will be implemented in the next CL of this series. Build with: v8_enable_wasm_gdb_remote_debugging = true Run with: --wasm-gdb-remote Bug: chromium:1010467 Change-Id: Icfa63be9e1eaa657c05876d0d4e86927e0885b90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1938466 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port 8ef2f799 https://crrev.com/c/2150157 Change-Id: I70ffb8e0c669398339eb6e794bef2b7920b58cd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153194Reviewed-by:
-
Jiaxun Yang authored
GAS have a auto-align function which will align all the directive data into it's nature boundary. And we're using .octa to present data in embedded.S, which will be auto-aligned into 128-bit boundary. It can break relatve offset in generated binary. So we workaround it by forcing generate .long DataDirective on MIPS. Also I rewoked WriteByteChunk so it can accept any kind of directive now. Further more, implementation of HexLiteral is indentical on generic, aix and mac so I merged them into base. Bug: v8:10420 Change-Id: I0ff791412360769510735659f909524c5f96d3e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153187Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#67198}
-
Liviu Rau authored
No-Tree-Checks: true No-Try: true Bug: v8:10302 Change-Id: Ic6cf0fdf2151e0ea3cb6d42789f5499b5b70bd4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150591Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67197}
-
Paolo Severini authored
This changelist adds the logic to format, decode, sends and receive packets in the format specified by the GDB-remote protocol (https://sourceware.org/gdb/onlinedocs/gdb/Overview.html#Overview). Build with: v8_enable_wasm_gdb_remote_debugging = true Run with: --wasm-gdb-remote Bug: chromium:1010467 Change-Id: Ibc9c6713c561d06847b472fab591c208c193199f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1929409 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by:
-
Mythri A authored
Check that the argument passed to %OptimizeOsr is smi before accessing it. If it isn't an Smi we crash unless we are fuzzing. When fuzzing, this returns early (turns into a Nop) if the argument isn't an Smi. Bug: chromium:1071045 Change-Id: Iff1ee3e368dfffdbbbab4107dc355d5460b996e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150602 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67195}
-
Liviu Rau authored
This reverts commit 128368c3. Reason for revert: Just to trigger builders Original change's description: > Whitespace to trigger builders > > TBR: machecnbach@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I208d974b1da1983a8fa5996e6819779bd35d8710 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153216 > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67193} TBR=machenbach@chromium.org,liviurau@chromium.org Change-Id: I87aa28cd4c50d2c63f17e7ccc50425bf05faa39f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153218Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#67194}
-
Liviu Rau authored
TBR: machecnbach@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I208d974b1da1983a8fa5996e6819779bd35d8710 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153216 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port fc29c453 https://crrev.com/c/2148640 Change-Id: I75092072ac6961c26559bd69d6a8413d2e9d2689 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153189Reviewed-by:
-
Kong, Fanchen authored
Bug: v8:9909 Change-Id: Ic71a2a012cbd538d65afb047fe73e98be6454aed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150157 Commit-Queue: Fanchen Kong <fanchen.kong@intel.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67191}
-
Ng Zhi An authored
Instead of putting the 16 immediate bytes on the stack, we move them into a temporary register. The instruction-selector then has to change, to ensure that the operands are distinct from the temporary. Tested on the two workloads given in https://github.com/zeux/wasm-simd/issues/2#issuecomment-614399004 For slow, the row "filter:" oct12 goes from ~50ms to ~27ms, the rest of the figures look about the same or slightly faster. For optimal, the same figure goes from ~25ms to ~24ms, the rest of the figures look slightly faster. Raw outputs are uploaded to bug. Bug: v8:10117 Change-Id: I7f77a3066b5e24584f1c01574aa9311f56bd7fb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2152853 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67190}
-
Zhou, Zhiguo authored
Bug: v8:9909 Change-Id: I1ec888ce0b3389afcb0edd1033bef179327e140c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2148640Reviewed-by:
-
- 16 Apr, 2020 24 commits
-
-
Michael Lippautz authored
.type directive is required on arm to enable ARM/Thumb interworking. Bug: chromium:1071168 Change-Id: I2ff5046719b9c8f611e81970bfa61c68ed850362 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153207Reviewed-by:
-
Michael Achenbach authored
A new realm doesn't contain the mocks and suppressions on the global object for correctness fuzzing. We replace Realm.eval with eval to keep exercising the code. Bug: chromium:1071133 Change-Id: Iffe82d37bf08829fc5937c17c2089277403e71dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153206Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67187}
-
Ng Zhi An authored
SIMD opcodes consist of the prefix byte, then an LEB128 encoded int. We were decoding this incorrectly as a fixed uint8. This fixes the decoder to properly handle multi bytes. In some cases, the multi byte logic is applied to all prefixed opcodes. This is not a problem, since for values < 0x80, the LEB encoding is a single byte, and decodes to the same int. If the prefix opcode has instructions with index >= 0x80, it would be required to be LEB128 encoded anyway. There are a bunch of trivial changes to test-run-wasm-simd, to change the macro from BUILD to BUILD_V, the former only works for single byte opcodes, the latter is a new template-based macro that correct handles multi-byte opcodes. The only unchanged test is the shuffle fuzzer test, which builds its own sequence of bytes without using the BUILD macro. Bug: v8:10258 Change-Id: Ie7377e899a7eab97ecf28176fd908babc08d0f19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2118476 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: Ia5038fccb756d79b08b10a5fd0664b0da8b6a8ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151172Reviewed-by:
-
Yury Semikhatsky authored
This is a follow-up fix for https://crrev.com/c/v8/v8/+/1491608 Bug: chromium:1051186 Change-Id: Ia76ad0e7665fe17013b45816350238c35e7199f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049899Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
-
Bill Budge authored
- Adds kFPReturnRegister0 for all platforms. - Reworks linkage.cc to assign return registers to the proper register type, using the new FP return register. Bug: v8:10070 Change-Id: I5c876d248de9b825a1c80847ab134881dcda6f04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2107510Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#67183}
-
Clemens Backes authored
These tests were skipped three years ago because of flakes. I cannot reproduce the flakes any more, so reenabling the tests. R=petermarshall@chromium.org Bug: chromium:772010 Change-Id: I4dc2d890b20e642f8d9351676aecab965d2b4b63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151357 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: Ib94db390f70ddaa7eafb5af77023b1024c2b96b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151168Reviewed-by:
-
Mythri A authored
When we create a new elements array we should initialize it with holes. The capacity of the newly created elements array could be greater than the actual length of the array and we expect the unused slots to be filled with holes. Bug: chromium:1070560 Change-Id: Ia365eed59859e36a9c8b9e27be34f93ab88942bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150599 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67180}
-
Liviu Rau authored
No-Try: true Bug: v8:10423 Change-Id: Ic75147496bb544871b8add5034409b8c7acfbcfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151364 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Philip Pfaffe authored
This CL relands the implementation of the __getLocal and __sbrk APIs of the evaluator interface reverted in efea7407. Update the original commit to account for a changes to the import function name tracking and defaulting to debugging with liftoff. Change-Id: I9674aad419fb1dab0a9ecbb5d3fd4c33186b127a Bug: chromium:1020120 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151353 Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67178}
-
Richard Townsend authored
Adds an pure (not inline) assembly version of PushAllRegistersAndIterateStack for the Microsoft Arm Assembler, which uses slightly different syntax. Bug: v8:10407 Change-Id: I539e2021bd86e17a2d023c061c9753b4bd96ce2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150600 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67177}
-
Clemens Backes authored
The failure was probably the same as in https://crbug.com/v8/10410. Thus reenable the test also in the stress_incremental_marking variant on windows. R=thibaudm@chromium.org Bug: chromium:772010, v8:10410 Change-Id: Iad0b9b60408e08c5f2202462f6eeba3067525ae5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151356Reviewed-by:
-
Clemens Backes authored
This cleans up several parts of the tiering logic. 1) Instead of using the {ExecutionTier} to specify whether we do tier up or down, we introduce a new {TieringState} enum and use that consistently (also where a {bool} was used before). 2) When tiering up or tiering down, always recompile all functions. It's very unlikely that we can reuse previous code anyway (tiering down is cheap enough to just always do it, and when tiering up we need to recompile everything anyway). 3) Remove the {WasmEngine::RecompileAllFunctions} method and inline the implementation into callers. 4) Drive-by: Remove some obsolete comments and fix or extend others. R=thibaudm@chromium.org Bug: v8:10410 Change-Id: Ic765c6760dd97473ccfd469f22a2514695075587 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151355Reviewed-by: -
Ulan Degenbaev authored
On-heap TypedArrays have empty ArrayBuffers that are not supposed to be accessed directly. Such ArrayBuffers materialize properly when accessed via their TypedArrays. The queryObjects() sidesteps the bottleneck and finds empty ArrayBuffers by iterating the heap. When preview TypedArrays are constructed for the found ArrayBuffers, they get nullptr data pointers. This CL converts all on-heap TypedArrays into off-heap TypedArrays in queryObjects to make sure that all found ArrayBuffers are valid. Bug: chromium:992442 Change-Id: Ie77d1e75aa2007b4a976c72206b9a4e215c9ef53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150601 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#67174}
-
Andreas Haas authored
The existing interface assumed that for atomic binop instructions, the value register and the result register are the same. However, for x64, this assumption is not always useful, and for platforms like arm, this assumption is even negative. The existing interface was originally introduced because ia32 lacks registers, and we wanted to avoid platform-specific code in liftoff-compiler.cc. However, by now the lack of registers on ia32 required us to use platform-specific code also in other places, so we can also use it for atomic binops and thereby enable a better code generation. R=clemensb@chromium.org Bug: v8:10108 Change-Id: If39cc5f49934422b632bb2a5793c7f5d5d2b65c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150585Reviewed-by:
-
Georg Neis authored
Change-Id: Ic5dbf4c3330c71cbae73aa07b2adb1c8ac087182 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151348 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Yuki Shiino authored
JSObject::SetImmutableProto is called from InstantiateObject in api/api-natives.cc: https://source.chromium.org/chromium/chromium/src/+/master:v8/src/api/api-natives.cc;drc=98497572964c764de5dc32a54a62c66943ed8499;l=369 https://source.chromium.org/chromium/chromium/src/+/master:v8/src/api/api-natives.cc;drc=98497572964c764de5dc32a54a62c66943ed8499;l=423 So, non JS code will hit the DCHECK being removed in this patch. Actually, Blink hits this DCHECK when implementing Location object's [[SetPrototypeOf]] as SetImmutablePrototype. c.f. https://crrev.com/c/2145516 Change-Id: I88b2715d645f5ea792ef33cb67a6990c762ad338 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143982Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit 52412058. Reason for revert: Use counters are not the right approach, we need histograms instead. Original change's description: > [protectors] Add use counters to track invalidations > > ... to make real world protector invalidations measurable. > > Chromium CL: https://crrev.com/c/2149324 > > Drive-by: Add missing newline in protector tracing. > Drive-by: Consistent naming for the regexp species protector. > > Bug: v8:9496 > Change-Id: I3c7238aa8024e03ea9e89daf83345b8ec4f0d768 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2149428 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67149} TBR=ulan@chromium.org,jgruber@chromium.org Change-Id: Ia36b598844fbad2166772298c2e2ec8f6b4f92b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9496 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151358Reviewed-by:
-
Yang Guo authored
R=verwaest@chromium.org Fixed: v8:7463 Change-Id: I3d0127865ad0430d38124c3ad8ed3bc63ba4e6d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2149421 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Philip Pfaffe authored
Trying to write an empty byte array currently invokes undefined behavior if the byte array is null. That's the case when trying to write an empty vector for example. Copying zero bytes from nullptr is defined as UB for memcpy. Change-Id: I6f7e920c1e19e8b2e3779bbc1c0ad79fc8bd6e98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2148789 Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This adds support for custom weak callbacks through static callbacks and instance methods. Bug: chromium:1056170 Change-Id: Ie4bd32539e0d933b192f07edb2d45e0070c2128d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2148784 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit https://crrev.com/c/2144966, which was merged to v8.1 in https://crrev.com/c/2151345. R=thibaudm@chromium.org Bug: chromium:1070199 Change-Id: Idb25cfaa52f7f7aa07353cf0372e6758adb58d78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151346Reviewed-by:
-
Zhao Jiazhong authored
Port ad55fa63 https://crrev.com/c/2147148 Change-Id: I5375ae4bddb2221c6f7860e55111c95beeed757d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2152069Reviewed-by:
-
