- 26 Nov, 2019 15 commits
-
-
Jakob Kummerow authored
(1) One more place in ic.cc must guard against "lookup->name()" calls when the LookupIterator might be in indexed mode. (2) Rather than burdening LookupIterator users with specifying "kGuaranteedNoTypedArray", we can do the corresponding calculation in the LookupIterator itself, which makes it robust towards any callers that haven't been updated (specifically, in Object.values). Bug: chromium:1027461,chromium:1028213 Change-Id: I76b5d08e309fc2a694955b537adbeb5a30e681f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1936474Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65177}
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Iceeb7e274c0cc9fd7066fa538818aebf23ce2678 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925566 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65176}
-
Joshua Litt authored
This reverts commit 825f65d3. Reason for revert: Clusterfuzzed Bug: chromium:1028475 Original change's description: > [replaceAll] Stage String.prototype.replaceAll. > > Intent to ship thread: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/raep1X9R_SE > > Bug: v8:9801 > Change-Id: I61c559b82b4119084420ffb0a14a27774e37c760 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930608 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65161} TBR=adamk@chromium.org,joshualitt@chromium.org Change-Id: I7fa44eda475b8f421f74491e60a3131d381eb789 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1935024Reviewed-by:
Joshua Litt <joshualitt@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65175}
-
Maya Lekova authored
This CL ensures we care only about our internal pointer types and not about raw C++ pointers, because normally special care is taken when storing raw pointers to the managed heap. Furthermore, checking for raw pointers produces too many false positives in the dead variable analysis. Bug: v8:9680, chromium:1000635 Change-Id: Ica9ea1fe09b7456c011910a6886149b6dfdda1f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924357 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65174}
-
Nico Hartmann authored
Bug: chromium:1028191 Change-Id: Idfcd678b3826fb6238d10f1e4195b02be35c3010 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1936468 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65173}
-
Georg Neis authored
This flag has had no effect since mid 2017 when its use-site was accidentally removed (in https://codereview.chromium.org/2902533003). Change-Id: I81436b064c2664deff781ad6d75ad47937e3fdc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934333 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65172}
-
Toon Verwaest authored
Bug: chromium:1018611 Change-Id: I2d48673aa5a05e67a6b253415e66af975b693af5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1936470 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65171}
-
Jakob Kummerow authored
after c968607e aka r65078. CheckedTaggedToArrayIndex is the function that's in sync with the ICs. It does both more (string-to-index conversion) and less (limit to kMaxSafeInteger) than CheckedTaggedToInt64. Bug: chromium:1028021 Change-Id: I992b11b8d4c58b4d3f5385b21998f53dd4b235d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934338Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:1025468, chromium:1028396 Change-Id: I76f75b4137e2c166a1f89fd9f2e88330281c7625 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1936467Reviewed-by:
-
Santiago Aboy Solanes authored
In both ChangeIntPtrToSmi and ChangeInt32ToSmi we can use bitcasts instead of change nodes for Smi Tagging, when we are using 31 bit smis in 64 bit architectures with pointer compression enabled. In ChangeIntPtrToSmi we can ignore the truncation as well. Updated DecompressionOptimizer to match the new pattern. Change-Id: I4487ba40ba9fda7b1ab31da95ff7bd144407d02d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924355 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Mike Stanton authored
When running with --deopt-every-n-times, it's possible to hit the deopt point in reduceRight where we fail to find an initial element. There was a bug in this code: the deopt point failed to begin walking the array at {length - 1} in search of the first non-holey element. With the flag, incorrect results would be produced. Without the flag, it's not possible to get an incorrect result because normally the deopt point fires only when the array (of whatever length) contains only holes. Bug: v8:9984 Change-Id: I654c702fca67c0f9a982f5bb8a5d9569e907ccf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934328Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65167}
-
Santiago Aboy Solanes authored
... after executing their action. This allows to search for a regex, click "hide unselected nodes", and then immediately using graph view's keyboard shortcuts (e.g i, o, r). Bug: v8:7327 Change-Id: Ieb7dbb3f1e32a78131500f8fb8b7805417c60e4e Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930906Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65166}
-
Clemens Backes authored
This adds the data structure and a builder for it, without ever using it yet. Users and tests will be added in a follow-up CL. R=mstarzinger@chromium.org Bug: v8:10019 Change-Id: I5c332c8b3a499d3844113fbd4108a9138eef01f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932365 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:4153 Change-Id: I036b3f464a635414e050972cee2dffbf3b44cafd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918250 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#65164}
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7875528..e2349a5 Rolling v8/third_party/android_sdk/public: n5NRtk1IRM87UHkSNPKGfMf6VL_BfjEOBXhD9uqynhIC..Jxtur3_L9RzY4q79K-AwIahwFW4oi5uYVD5URx9h62wC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5459c38..bee6bf4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8001297..83aafc9 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e5c4d8c..7c4128a TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8f6f28d37cf97bea0d64ec13f6d64b4e8697478d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1935351 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65163}
-
- 25 Nov, 2019 25 commits
-
-
Jakob Kummerow authored
This is a reland of e1ad9b89 Original change's description: > Fixes for size_t LookupIterator > > Fixing some fallout from c968607e > aka r65078 > > Bug: chromium:1026729,chromium:1026856,chromium:1026909,chromium:1026974 > Change-Id: I98a4466595fbf1635af403ab58842977882c0453 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930907 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65158} Tbr: verwaest@chromium.org,mstarzinger@chromium.org Bug: chromium:1026729, chromium:1026856, chromium:1026909, chromium:1026974 Change-Id: I66695f05c4910c46f3c75209e14135075721f2cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932839Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65162}
-
Joshua Litt authored
Intent to ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/raep1X9R_SE Bug: v8:9801 Change-Id: I61c559b82b4119084420ffb0a14a27774e37c760 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930608Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65161}
-
Sam Maier authored
adler32 is strictly faster than the old checksum - see this doc: https://docs.google.com/document/d/1fFhuShavlUwf0FqTc-6L3XLYbAVe0DhpmHSv4oenZL8/edit?pli=1#heading=h.ojvfq6akbz5f adler32 also no longer requires alignment to be maintained. Bug: chromium:833361 Change-Id: I3dbfa699b712aa908c87e6f8261756a4a1209df4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925562 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
This reverts commit e1ad9b89. Reason for revert: Landed test that fails with GC stress Original change's description: > Fixes for size_t LookupIterator > > Fixing some fallout from c968607e > aka r65078 > > Bug: chromium:1026729,chromium:1026856,chromium:1026909,chromium:1026974 > Change-Id: I98a4466595fbf1635af403ab58842977882c0453 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930907 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65158} TBR=jkummerow@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org Change-Id: I1f1e95d37b033e53330adae08071cbe34e1d9488 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1026729, chromium:1026856, chromium:1026909, chromium:1026974 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1933599Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#65159}
-
Jakob Kummerow authored
Fixing some fallout from c968607e aka r65078 Bug: chromium:1026729,chromium:1026856,chromium:1026909,chromium:1026974 Change-Id: I98a4466595fbf1635af403ab58842977882c0453 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930907 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Mythri A authored
TurboFan serializes the callee functions when concurrent inlining is turned on. However, if inlining itself is turned off (for ex: TurboProp) we don't need to serialize these functions reducing time spent on main thread. Bug: v8:9684 Change-Id: If4aba1deb64188e411d4f82b27c475ea93a15344 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932375Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#65157}
-
Joshua Litt authored
Bug: v8:9548 Change-Id: I0842ca8ce49ea3a831ae4f168c6dfa7d65dfe063 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930173Reviewed-by:
-
Clemens Backes authored
Also, fix the implementation of {operator==} and add {operator!=}. {operator==} could not be instantiated on a {Vector<T>} where T is not const, as it would access the fields of another instantiation of Vector ({T} vs {const T}). R=jkummerow@chromium.org Bug: v8:9810 Change-Id: I65c2d3071a781f6fe7a624b727d2770b43b7f7a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932363 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Dan Elphick authored
Removes job queue flushing in OptimizingCompileDispatcher::Stop when FLAG_concurrent_recompilation_delay is set. Before this explicit flushing was run, there was already a wait-loop which ensured the queue was always empty. Bug: v8:9810 Change-Id: I620bac9c9d73aead671b178c9450bdd25e6761b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934332 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65154}
-
Igor Sheludko authored
... and remove too restrictive checks. Bug: chromium:1025468, chromium:1027498 Change-Id: I1558d66ef88d1481530479969c0fb81fb6ff808c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932373Reviewed-by:
-
Georg Neis authored
This brings the number of optimization misses (with concurrent inlining) in Octane's typescript from 179 down to 3 (the actual score doesn't seem to change but it's already on par with the default configuration). Bug: v8:7790 Change-Id: Ia4ade2eafc035491d3eac9081383c72b435e8df6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924441 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This makes sure that the return type of the aforementioned heap views is always {float?} and {double?} respectively, independent of the type of the value passed to the store. It fixes validation failures due to bogus (and redundant) conversion expressions being emitted. R=clemensb@chromium.org TEST=mjsunit/asm/regress-1027595 BUG=chromium:1027595 Change-Id: I037613afc643ac1b04ae4a943e42dc1823ad5bdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932374Reviewed-by: -
Maya Lekova authored
This CL moves the DisallowHeapAllocation scopes closer to the callsites that get detected as GC causes by GCMole. Bug: v8:9992 Change-Id: I3148f088ff40cee877683f214f85d745ed685a25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928865Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65150}
-
Georg Neis authored
Change-Id: Iaa3abd6584adf6c844d09a6341bd7fb80fb3d24d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932372Reviewed-by:
-
Maya Lekova authored
Subsequently LookupHolderOfExpectedType should be called only when we have installed handler code. Bug: chromium:1024936, v8:7790 Change-Id: I33a0a7232afaba8455a0cec1fdc56251947419d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930905 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Mythri A authored
Adds RuntimeStats counters for HeapBrokerInitialization, Serialize, SerializeMetadata and Finalization phases. These happen only on main thread. In a followup cl we will also add counters for other phases that could happen on main thread or background thread. Earlier RecompileSynchronous was used to measure the time spent in Concurrent, non Concurrent and Concurrent finalize phases. This cl replaces them with OptimizeConcurrent, OptimizeNonConcurrent and OptimizeConcurrentFinalize counters. This cl also renames RecompileConcurrent to OptimizeBackground to make it clear this measures the background component of optimization. This also updates names of trace events to be in-sync with RuntimeStat counters. Bug: v8:9684 Change-Id: Ifda81ce7ab1c659c2df53bab924c51c46f46939b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924439Reviewed-by:
-
Michael Achenbach authored
TBR=tmrts@chromium.org,ishell@chromium.org,liviurau@chromium.org NOTRY=true Change-Id: I7f345ce40b7906a71f960c3e8f3ab11974d9ac80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932370Reviewed-by:
-
Clemens Backes authored
This saves some bytes here and there. Whenever the label is bound just a few instructions after, we can use a near jump. R=ahaas@chromium.org Bug: v8:10005 Change-Id: If2ec596575e1bd88d09fde3fa96ffa8187de542f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930898Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Backes authored
This looks like an oversight. If we know that near jumps can be used, we should pass that information on to the {jmp} method. R=ahaas@chromium.org Change-Id: I839a7a7b66f0e9d535a7cece283750f5c45a44c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930618Reviewed-by: -
Leszek Swirski authored
Change-Id: I5db858ea02d145aa8e934ee20f3a7fae78e39828 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1932364 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Backes authored
In the declaration, callers, and in the {ConvertFloatToUint64} helper, the parameter is called "fail". In the definition, it's wrongly called "success". R=ahaas@chromium.org Change-Id: Iec861f182e54165e609c6e61d399ceb87512054f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930900Reviewed-by: -
Dan Elphick authored
Converts and uses of RuntimeCallTimerScopes that switch the counter based on the thread, to use kThreadSpecific and remove the counter selection. Also moves RuntimeCallTimerScope::CounterMode to RuntimeCallStats, since now CorrectCurrentCounterId also takes it as a parameter. Bug: v8:10006 Change-Id: I14a503e0b83bb69c071f9665956de094bb33c0ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928864Reviewed-by:
-
Michael Achenbach authored
This adds a regresson test case for the revert reason of: https://crrev.com/c/1906378 The test data is tidied up by keeping the different fake d8s in separate build directories like it would be in production. A new test simulates an architecture difference and ensures we pass the architecture mocks in all runs. No-Try: true Bug: chromium:1023091 Change-Id: Ic33c426ba8eb9c4b6b0fbb66d43c0859dc2edfcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918248 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#65140}
-
Georg Neis authored
Allow sharing of hints and modification of shared hints such that feedback can be propagated to the hints for the corresponding register, AND all alias registers. Even propagation from an inlined callee back to the caller is possible. Bug: v8:7790 Change-Id: I96b3c5e41613efa5711ab758db1c3ef7f7ae6418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914560 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Leszek Swirski authored
During conflict lookup (for lexical variables and sloppy block function hoisting), we cache the looked-up variable on the current scope if the lookup goes through a ScopeInfo. However, for variable lookup during scope analysis, we use the "entry point" as the cache. Since both lookups can create Variables, this can cause us to create duplicate variables, e.g. a duplicate function name variable in the attached test. Instead, for ScopeInfo conflict lookups we can cache the result on the function's outer scope, which shoud be equivalent to the entry point. As a (necessary) drive-by, we can terminate the lookup early if we find a VAR with the same name, as we can safely assume that its existence means that it doesn't conflict, which means that our variable can't conflict either. Bug: chromium:1026603 Change-Id: I19f80f65597ba6573ebe0b48aa5698f55e5c3ea1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928861 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
