- 03 Sep, 2019 12 commits
-
-
Martyn Capewell authored
This reverts commit 2869d9de. Reason for revert: Failing on V8 Arm - debug Original change's description: > [turbofan,arm64] Add float loads poisoning. > > Also extend load poisoning testing for arm and arm64. > > This is a port of I1ef202296744a39054366f2bc424d6952c3bbe9d, > originally introduced for arm. > > Change-Id: I7d317bba6be633dd1e563daa7231d3c5e930f8e4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691032 > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63519} TBR=rmcilroy@chromium.org,mvstanton@chromium.org,neis@chromium.org,tebbi@chromium.org,martyn.capewell@arm.com,artem.serov@arm.com Change-Id: I60ae552f98ae843d4fecbe163d60580a9f1a7068 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782163Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#63523}
-
Santiago Aboy Solanes authored
The important bit is using MachineType::TaggedSigned instead of AnyTagged in CSA. Everything else, it's just the result of adding types to variables. SloppyTNode-ify LoadAndUntagToWord32ObjectField. Both LoadAndUntagSmi and StoreAndTagSmi were only used once, and their names were not clear. Inline those where they were used. TNodify: * ReloadBytecodeOffset * LoadAndUntagRegister * GetInterpretedFramePointer * Advance (the three variants) * SaveBytecodeOffset * BytecodeOffset Type variables: * interpreted_frame_pointer_ * bytecode_offset_ Create macros: * TYPED_VARIABLE_CONSTRUCTOR * TVARIABLE_CONSTRUCTOR which are similar to their non-typed counterparts. Bug: v8:7703, v8:6949 Change-Id: I776e3fe16ca642f868bb635b8bcd5b8b78ca6fea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1758308Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#63522}
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=mjsunit/wasm/asm-wasm-math-intrinsic BUG=v8:8505 Change-Id: I883c9ad174f7fda5ec5dd24e71ca674de51239b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782160Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63521}
-
Jakob Gruber authored
The regexp species protector was recently moved from the isolate onto the native context to avoid cross-context pollution of the regexp fast path state. The implementation was incomplete. We unconditionally used the isolate's current native context, but it is possible for the object we are looking at to come from a different context (= its creation context). The fix is two-fold. 1. when speed is not too important (e.g. when invalidating the protector), grab the creation context off the object. 2. in the regexp fast path check, just document how our current solution is sufficient: although we may initially look at the wrong protector cell, we'd later bail out when comparing the object's map against the initial regexp map (stored on the current native context). Bug: v8:9463 Change-Id: I653732b573f2dd456b3c6b723653dcacf9ead591 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776078 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#63520}
-
Artem Serov authored
Also extend load poisoning testing for arm and arm64. This is a port of I1ef202296744a39054366f2bc424d6952c3bbe9d, originally introduced for arm. Change-Id: I7d317bba6be633dd1e563daa7231d3c5e930f8e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691032 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#63519}
-
Pierre Langlois authored
The `Instruction::IsValidImmPCOffset()` method was taking an `offset` argument in numbers of *instructions* while we were passing it numbers of *bytes*. See `Instruction::IsTargetInImmPCOffsetRange()` and `MacroAssembler::NeedExtraInstructionsOrRegisterBranch()`. As a result, we were 4 times too conservative when computing branch ranges going backwards, forcing us to generate the following sequence for TBZ more often than needed: ``` TBNZ <skip> B <target> skip: ``` This happened rarely for loops, but a lot when doing an early return from out-of-line calls to write barriers. Since out-of-line code is easily out of range of 8K, although the real range of TBZ is 32K. This fixes it by changing this method to take a byte offset instead of instructions, as this is more intuitive and in line with similar methods. For instance, `Instruction::ImmPcOffset()` returns an offset in bytes. The tests are adapted so that they would have caught such a bug: * TEST(far_branch_backward): This test used to only check the code worked if the branch was very far away, but it didn't test the range was correct. So this test was changed to check each branch type separately, and test in-range and out-of-range cases separately too. * TEST(far_branch_veneer_broken_link_chain): Because of the backwards range bug, this test wasn't actually testing what it should. The idea of the test is to make sure the MacroAssembler can still cope when the chain of links is broken after a veneer was emitted. But no veneers were ever emitted. Change-Id: Iddb5c683a71147455175f38fa7ae57da0a3e7337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781058Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63518}
-
Leszek Swirski authored
This reverts commit ab089c78. Reason for revert: Breaking GC stress (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/27523) Original change's description: > [turbofan] Prepare for moving part of CreateGraph into the background > > - Pass Refs, not Handles, to graph builder, and drop bytecode array argument > (get it from SFI instead). > - Add some fields to FeedbackVectorRef that are needed to avoid heap access > in BytecodeGraphBuilderPhase. > - Rename FeedbackVectorRef's SerializeSlots to Serialize, since it's more > than just the feedback slots. > - Rearrange the last steps in PipelineCompilationJob::PrepareJobImpl such > that CreateGraph is last. > > Bug: v8:7790 > Change-Id: I4b17790d1d74da41ba63ee68e3a33968662fc398 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781682 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63515} TBR=neis@chromium.org,mslekova@chromium.org Change-Id: I4dc95907657597d12cbe1ce6a8ebb694ef44e915 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781687Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#63517}
-
Andreas Haas authored
In https://crrev.com/c/1768581 I only enabled the --wasm-staging flag, but that is useless without the implications defined in flag-definitions.h. With this CL I now just set each flag one by one. R=clemensh@chromium.org Bug: v8:9601 Change-Id: Ie0e16f9516aa32b8c958cf58c8c9d4d6cb6f3b22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781060Reviewed-by:
-
Georg Neis authored
- Pass Refs, not Handles, to graph builder, and drop bytecode array argument (get it from SFI instead). - Add some fields to FeedbackVectorRef that are needed to avoid heap access in BytecodeGraphBuilderPhase. - Rename FeedbackVectorRef's SerializeSlots to Serialize, since it's more than just the feedback slots. - Rearrange the last steps in PipelineCompilationJob::PrepareJobImpl such that CreateGraph is last. Bug: v8:7790 Change-Id: I4b17790d1d74da41ba63ee68e3a33968662fc398 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781682Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63515}
-
Maya Lekova authored
This reverts commit d82600ec. Reason for revert: Blocking the roll, see https://ci.chromium.org/p/chromium/builders/try/linux-rel/181725 Original change's description: > [turbofan] Serialize missing objects > > Added a few objects to the standard objects list, as well as specific > builtins when the corresponding runtime calls are detected in the > serializer. Now JSHeapCopyReducer is needed only when concurrent > inlining is disabled. > > Bug: v8:7790 > Change-Id: I91d933611b0352df8ede4fded665f13669591fef > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781053 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63509} TBR=neis@chromium.org,mslekova@chromium.org Change-Id: I5eb8a8371994822debb852fc2a090ba585826d4a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782157Reviewed-by:
-
Simon Zünd authored
"--print-scopes" uses the {function_} variable to print the function name and locals of a function scope. In case of a pre-parsed function, the function variable of the scope lives in a zone which is nuked after pre-parsing, while the scope lives on. This leaves the {function_} variable pointer in the scope in a state where it points to invalid memory, causing "--print-scopes" to crash. This CL fixes the crash by properly resetting the {function_} pointer. TBR=verwaest@chromium.org Change-Id: Id24dbb605bec883317f676265a920fe0ca662301 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776094Reviewed-by:Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#63513}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5dd1782..4fa36b1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9f64c5c..5198ea1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6783233..2fef805 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I2357d1ea3e6b28825b4b952ad6bc5db852bdfb18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1780230Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63512}
-
- 02 Sep, 2019 23 commits
-
-
Michael Lippautz authored
Those object types can carry embedder fields as they are generated from embedder-provided function templates. Bug: v8:9672 Change-Id: Iaea794ba8bea2ffec3559131eecfe1941479759a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781048Reviewed-by:
-
Dominik Inführ authored
Slots are always valid inside an invalidated area when outside the respective object's current size. This allows us to remove the size from the InvalidatedSlots data structure. This change was enabled by https://crrev.com/c/1771793. Bug: v8:9454 Change-Id: I2b5a7234d47227cb6ad8d67de20e9b5a2028ae83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1773242Reviewed-by:
-
Maya Lekova authored
Added a few objects to the standard objects list, as well as specific builtins when the corresponding runtime calls are detected in the serializer. Now JSHeapCopyReducer is needed only when concurrent inlining is disabled. Bug: v8:7790 Change-Id: I91d933611b0352df8ede4fded665f13669591fef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781053Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#63509}
-
Jakob Gruber authored
.. and use it for generating faster loads of external references. This changes the stack check instruction sequence from mov ecx,0x567651dc // The address of the stack limit. cmp esp,[ecx] to cmp esp,[ebx+0x3c] This addressing mode was likely forgotten when we recently added root register support on ia32. Bug: chromium:998751,v8:9534 Change-Id: I3521519da1e9d373dfcd83831b3e399e0e9c895b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781056Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:9601 Change-Id: I0406326dab681843ef8accadefa10a9e85593fb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781055Reviewed-by:
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I79b81d66751707756139db50720080a144bdcd38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781045 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Yang Guo authored
R=sigurds@chromium.org Bug: chromium:956475 Change-Id: Ie4ccd84e1c239d771fd9238599c687782ddb1356 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776097Reviewed-by:
-
Leszek Swirski authored
Similar to https://crrev.com/c/1781047, WordEqual already does the right truncation in the instruction selector. Bug: v8:8948 Change-Id: I92e74bafab6a467aeca1570494e9044f9cf18c46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781049 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#63504}
-
Ana Peško authored
This CL adds initial tests for the tier-up logic. Change-Id: I6e6ff69604b14387e81b08d178f98d2227b4f496 Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776080 Commit-Queue: Ana Pesko <anapesko@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63503}
-
Thibaud Michaud authored
Allow the backward spilling heuristic to look and spill before the start of the current range. This solves a common scenario where control-flow aware allocation cannot apply the heuristic as efficiently as splintering because it creates smaller live ranges. Bug: v8:9088 Change-Id: I7f8af8bb9c82849fbae0c652baa5011fd890690e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776085 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... which already does good the right job of generating 32-bit comparisons while Word32Equal() seems to break some optimizations in TurboFan and produce a little bit slower code. Bug: v8:8948 Change-Id: I288656479fa32c34a7253c4879cb3566d7470a6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781047 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Dan Elphick authored
If a bytecode mismatch occurs, the original and new bytecode are now printed along with the position of the bytecode mismatch. Bug: v8:8510 Change-Id: Ia3b016fb4e0edde46944533a6a768499b20678d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1774722 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This is a reland of 0736599a. This is a reland of 7e1fbe8f. Original change description: > [ic] In-place Double -> Tagged transitions > > With no more MutableHeapNumber, we can make Double -> Tagged transitions > in-place, at the cost of an extra map check when accessing double fields > to make sure they are still doubles. > > Bug: v8:9606 > Change-Id: I74ff39ed6fba62ee223cd37dfe761f7d73020e1c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1743973 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63374} TBR=verwaest@chromium.org, tebbi@chromium.org Bug: v8:9606 Change-Id: I2d1b7416064d743582f4983fb868316b7e8a4cf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1777661Reviewed-by:
-
Georg Neis authored
Print the file name instead of the function name, as the function name can be ambiguous. Bug: v8:7790 Change-Id: I079eb0e5a0012aff1d241618d132ecd2d3d93c8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781043Reviewed-by:
-
Georg Neis authored
- Add serialization for CallNoFeedback, which was missing. - Extend serialization for CallJSRuntime. - Serialize for calls to higher-order Array builtins. - Serialize for calls to Function#apply and Function#call. - Serialize for calls to Reflect.apply and Reflect.construct. - Serialize for calls to Promise constructor. - Fix ConvertReceiverMode in serialization for CallProperty. Bug: v8:7790 Change-Id: I4bba6f45f9b7948ed2ba9c70bd423a23ec29ecf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1763530Reviewed-by:
-
Peter Marshall authored
When creating a new JSRegExp for a literal, we sometimes create a boilerplate and store it in the feedback vector. Then for future creations, we can copy the boilerplate instead of re-creating the regexp from scratch. When we don't have a feedback vector, we currently create a boilerplate, copy it and return the copy, and then throw out the boilerplate, which is unnecessary. We can just return the first JSRegExp we create. Change-Id: I98b4e3a3082654ea989e0e6ba1524ce080b0125c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776086Reviewed-by:
-
Michael Achenbach authored
The sanity checks never really worked since the file was missing in the output dir. Runs bailed out with "Error loading file". As both configurations bailed out in the same way, the correctness fuzzer treated it as pass. NOTRY=true Bug: chromium:933076 Change-Id: Id3a2f7e8e3fa8c6654e3e08654d2e9e6b7010484 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1778289Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63495}
-
Michael Achenbach authored
This also ignores the line number for type errors. NOTRY=true Bug: chromium:995075 Change-Id: I9d9a91842383eba60db858c2c2e02df7dda1a9e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1778287Reviewed-by:
-
Georg Neis authored
Now it's easy to find the bytecode corresponding to a given SFI in logging output. Change-Id: I32100d54830c2dae3cef838f09582e8d023b5ecb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781044 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: chromium:998802 Change-Id: I243c00b367ffd1c5c54ca6930681b1b1d3317b26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1773273 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Mu Tao authored
Port 2e0bc516 Original Commit Message: Similar to CheckNotAtStart, one can now apply an offset to the CheckAtStart operation. Due to a recent change, all callsites of CheckNotAtStart now need to pass an offset, whereas previously the offset was just assumed to be zero. Change-Id: I8201ae7620809be3767ad32feab069074b3cbf86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1775983 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mu Tao authored
Port 213504b9 Original Commit Message: The code fields in a JSRegExp object now either contain irregexp compiled code or a trampoline to the interpreter. This way the code can be executed without explicitly checking if the regexp shall be interpreted or executed natively. In case of interpreted regexp the generated bytecode is now stored in its own fields instead of the code fields for Latin1 and UC16 respectively. The signatures of the jitted irregexp match and the regexp interpreter have been equalized. Change-Id: I843b11cfdd9ecbb38f03706bcb86a5cfcbf69050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1778083 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b99a3be..5dd1782 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3d3532b..6783233 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I4872aa1ed13a08e257d7f722c8f0348df943b9c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1779633Reviewed-by:
-
- 01 Sep, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5f1456d..b99a3be Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/354c81a..9f64c5c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5aeddeb..355e97e TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ib817bc78402251bc181b2f5429b9cd335836d935 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1779631Reviewed-by:
-
- 31 Aug, 2019 2 commits
-
-
John Budorick authored
This should allow us to add other Windows-10 versions to pool:Chrome without adversely affecting the V8 bots. Bug: chromium:990885 Change-Id: I760eb6b1fc6f9fb91c9bacce692b21cbc044b261 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1778916 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d2d4319..5f1456d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8fe3e6a..354c81a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ee8d9ce..5aeddeb Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/952ccb9..53f6b23 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I0d9c69c1253243928b40aeed62769299f09d50ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1779628Reviewed-by:
-
- 30 Aug, 2019 2 commits
-
-
Seth Brenith authored
This change provides a quick way to see string contents in postmortem debugging sessions, without digging through a (possibly very large, in the case of ConsString) tree of properties. As well as being convenient for inspecting String objects, this functionality will also be necessary for displaying property names on JSReceiver objects. In order to support custom behaviors for specific classes, this change extends the existing generated debug reader classes with a visitor pattern. Bug: v8:9376 Change-Id: I70eab9ea4e74ca0fab39bf5998d6a602716a4202 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771939Reviewed-by:
-
Dan Elphick authored
When changing the code coverage or type profiler modes, first ensure there are source positions for all BytecodeArrays as regenerating the source positions after toggling the mode will result in a bytecode mismatch. Bug: v8:9656, v8:8510 Change-Id: Ic6cf3afec1588f11e5ce5fcbea2fd13e4452e15f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1774721 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
