- 12 May, 2015 15 commits
-
-
yangguo authored
Revert of Provide accessor for object internal properties that doesn't require debugger to be active (patchset #3 id:40001 of https://codereview.chromium.org/1126103006/) Reason for revert: GC mole issues: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1950/steps/GCMole%20ia32/logs/stdio Original issue's description: > Provide accessor for object internal properties that doesn't require debugger to be active > > Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. > > Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. > > BUG=chromium:481845 > LOG=Y > > Committed: https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d > Cr-Commit-Position: refs/heads/master@{#28362} TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481845 Review URL: https://codereview.chromium.org/1133243002 Cr-Commit-Position: refs/heads/master@{#28365}
-
titzer authored
Handle missing or improper FrameStates more gracefully. Uses the operator properties to determine if the node contains a FrameState before, then checks if a valid bailout id exists. R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1135243002 Cr-Commit-Position: refs/heads/master@{#28364}
-
titzer authored
[turbofan] Add AdvancedReducer::ReplaceWithValue() method and convert JSInlining to an AdvancedReducer. Note that this is just a duplication for now. We'll want to get rid of the NodeProperties::ReplaceWithValue() method in the long run. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1135483004 Cr-Commit-Position: refs/heads/master@{#28363}
-
yurys authored
Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. BUG=chromium:481845 LOG=Y Review URL: https://codereview.chromium.org/1126103006 Cr-Commit-Position: refs/heads/master@{#28362}
-
titzer authored
[turbofan] Use FrameStatesBeforeAndAfter to simplify handling of before/after frame states in AstGraphBuilder. R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1128193005 Cr-Commit-Position: refs/heads/master@{#28361}
-
hpayer authored
In follow-up CLs the scavenger and the MC collector should also respect the unalignment of heap numbers. BUG= Review URL: https://codereview.chromium.org/1141523002 Cr-Commit-Position: refs/heads/master@{#28360}
-
mvstanton authored
HMaybeGrowElements moves the situation where you actually have to grow into deferred code. This means crankshaft doesn't have to spill registers just to make the bounds comparison to see if it'll need to grow or not. It makes the growing case a bit more expensive, but reduces the cost of the general case. BUG=chromium:484025 LOG=N Review URL: https://codereview.chromium.org/1124443004 Cr-Commit-Position: refs/heads/master@{#28359}
-
yangguo authored
Revert of Migrate error messages, part 10. (patchset #2 id:20001 of https://codereview.chromium.org/1126043004/) Reason for revert: patch didn't apply correctly. Original issue's description: > Migrate error messages, part 10. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f > Cr-Commit-Position: refs/heads/master@{#28357} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1130073005 Cr-Commit-Position: refs/heads/master@{#28358}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1126043004 Cr-Commit-Position: refs/heads/master@{#28357}
-
yurys authored
If there had been no debug listener v8::Debug::GetDebugContext would have created new context and wouln't have kept reference to it. This way we may well end up with several debug contexts and disabled debugger. As a side effect this change allows to efficiently distinguish debug context from blink contexts by simply comparing handles. BUG=chromium:482290 LOG=Y Review URL: https://codereview.chromium.org/1136733002 Cr-Commit-Position: refs/heads/master@{#28356}
-
yangguo authored
Revert of Use function wrapper argument to expose internal arrays to native scripts. (patchset #2 id:20001 of https://codereview.chromium.org/1127983003/) Reason for revert: custom snapshot builder failing. Original issue's description: > Use function wrapper argument to expose internal arrays to native scripts. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/a9b5a1795449d94387218d25baed2c2b3c4fbadc > Cr-Commit-Position: refs/heads/master@{#28354} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1123353008 Cr-Commit-Position: refs/heads/master@{#28355}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1127983003 Cr-Commit-Position: refs/heads/master@{#28354}
-
jochen authored
Embedders need to always pass CreateParams now BUG=none LOG=y R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1133723004 Cr-Commit-Position: refs/heads/master@{#28353}
-
v8-autoroll authored
Rolling v8/buildtools to b73e5f70d7ac6be98fb2555461f631afc90216ce Rolling v8/third_party/icu to ce41627e388fb46ab49671bd16a5db81dcd75a71 Rolling v8/tools/clang to 6e259b4afbbd784a775e47f37379e57f002bf0c2 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1124083005 Cr-Commit-Position: refs/heads/master@{#28352}
-
dehrenberg authored
The idea is to make this the model for future TypedArray methods. A possible downside could be lower array method performance if everything gets polymorhpic (but if enough inlining happens, it should still be fast), but on the upside, this change means that the TypedArray methods won't create as much code size bloat. BUG=v8:3578 LOG=Y R=adamk@chromium.org CC=arv@chromium.org, caitpotter88@gmail.com Review URL: https://codereview.chromium.org/1133503003 Cr-Commit-Position: refs/heads/master@{#28351}
-
- 11 May, 2015 22 commits
-
-
akos.palfi authored
Port 3226e980 BUG= Review URL: https://codereview.chromium.org/1129323007 Cr-Commit-Position: refs/heads/master@{#28350}
-
caitpotter88 authored
BUG=v8:4007 LOG=N R= Review URL: https://codereview.chromium.org/1128873006 Cr-Commit-Position: refs/heads/master@{#28349}
-
mbrandy authored
Port 3226e980 Original commit message: In strong mode it is an error to call a function with too few arguments. This is enforced inside the ArgumentsAdaptorTrampoline. This does not yet handle rest parameters R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1132153003 Cr-Commit-Position: refs/heads/master@{#28348}
-
paul.lind authored
Port abc35080 BUG= Review URL: https://codereview.chromium.org/1133103003 Cr-Commit-Position: refs/heads/master@{#28347}
-
arv authored
In strong mode it is an error to call a function with too few arguments. This is enforced inside the ArgumentsAdaptorTrampoline. This does not yet handle rest parameters BUG=v8:3956 LOG=N R=rossberg@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/1115263004 Cr-Commit-Position: refs/heads/master@{#28346}
-
dslomov authored
This patch: - Refactors Parser::ParseVariableDeclarations - Introduces Parser::PatternMatcher class - Implements matching a single variable pattern - Implements rudimentary matching against object literal pattern as a proof of concept R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1130623004 Cr-Commit-Position: refs/heads/master@{#28345}
-
titzer authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1139733002 Cr-Commit-Position: refs/heads/master@{#28344}
-
wingo authored
R=rossberg@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1128963005 Cr-Commit-Position: refs/heads/master@{#28343}
-
mbrandy authored
Port bd56d279 Original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>. This is a reapplication of https://codereview.chromium.org/1130733003. R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1134073003 Cr-Commit-Position: refs/heads/master@{#28342}
-
mbrandy authored
Port abc35080 Original commit message: This stub will be used as the basis of a Math.floor-specific CallIC to detect and track calls to floor that return -0. Along the way: - Create a TurboFanCodeStub super class from which the StringLength and MathRound TF stubs derive. - Fix the ugly hack that passes the first stub parameter as the "this" pointer in the the TF-compiled JS function. - Fix bugs in the ia32/x64 disassembler. R=danno@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1137033002 Cr-Commit-Position: refs/heads/master@{#28341}
-
wingo authored
Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>. This is a reapplication of https://codereview.chromium.org/1130733003. R=rossberg@chromium.org BUG=v8:2700 LOG=N Review URL: https://codereview.chromium.org/1136073002 Cr-Commit-Position: refs/heads/master@{#28340}
-
danno authored
This stub will be used as the basis of a Math.floor-specific CallIC to detect and track calls to floor that return -0. Along the way: - Create a TurboFanCodeStub super class from which the StringLength and MathRound TF stubs derive. - Fix the ugly hack that passes the first stub parameter as the "this" pointer in the the TF-compiled JS function. - Fix bugs in the ia32/x64 disassembler. Review URL: https://codereview.chromium.org/1137703002 Cr-Commit-Position: refs/heads/master@{#28339}
-
titzer authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/1132303003 Cr-Commit-Position: refs/heads/master@{#28338}
-
wingo authored
R=svenpanne@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1128043002 Cr-Commit-Position: refs/heads/master@{#28337}
-
machenbach authored
Also make the expectation lint check happy. TBR=jochen@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1137993003 Cr-Commit-Position: refs/heads/master@{#28336}
-
erikcorry authored
R=jkummerow@chromium.org,hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1125383007 Cr-Commit-Position: refs/heads/master@{#28335}
-
machenbach authored
BUG=chromium:485932 LOG=n Review URL: https://codereview.chromium.org/1134703002 Cr-Commit-Position: refs/heads/master@{#28334}
-
yangguo authored
TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1130253006 Cr-Commit-Position: refs/heads/master@{#28333}
-
machenbach authored
Revert of Add the concept of a V8 extras exports object (patchset #5 id:80001 of https://codereview.chromium.org/1128113006/) Reason for revert: [Sheriff] Causes gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/2167 Original issue's description: > Add the concept of a V8 extras exports object > > Exposed to the extras as extrasExports (on the builtins object), on > which they can put things that should be accessible from C++. Exposed > to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). > > Adding a test (in test-api.cc) required adding a simple extra, > test-extra.js, which we build into the standalone builds. > > R=yangguo@chromium.org, jochen@chromium.org > BUG= > > Committed: https://crrev.com/ad547cea05f3e02c67243b682e933fc53ac763d9 > Cr-Commit-Position: refs/heads/master@{#28317} TBR=jochen@chromium.org,yangguo@chromium.org,domenic@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1127313005 Cr-Commit-Position: refs/heads/master@{#28332}
-
yangguo authored
For the moment, we only pass the global object (the one we are setting up). A few smaller changes were necessary to avoid failures in test-object-observe/DontLeakContextOnObserve. Otherwise the global object would be retained by being context allocated, leading to test failure. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1132513003 Cr-Commit-Position: refs/heads/master@{#28331}
-
titzer authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1131853002 Cr-Commit-Position: refs/heads/master@{#28330}
-
v8-autoroll authored
Rolling v8/tools/clang to 5bab78c6ced45a71a8e095a09697ca80492e57e1 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1136043002 Cr-Commit-Position: refs/heads/master@{#28329}
-
- 10 May, 2015 1 commit
-
-
v8-autoroll authored
Rolling v8/tools/clang to 72b418e60c4529a7b160cead01b099de6ea8445f TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1132473006 Cr-Commit-Position: refs/heads/master@{#28328}
-
- 09 May, 2015 2 commits
-
-
jkummerow authored
BUG=chromium:485410 LOG=y R=mvstanton@chromium.org,danno@chromium.org Review URL: https://codereview.chromium.org/1132113004 Cr-Commit-Position: refs/heads/master@{#28327}
-
hpayer authored
BUG=chromium:486003 LOG=n Review URL: https://codereview.chromium.org/1136783002 Cr-Commit-Position: refs/heads/master@{#28326}
-