- 27 Feb, 2015 21 commits
-
-
adamk authored
BUG=v8:1569 LOG=n Review URL: https://codereview.chromium.org/958213006 Cr-Commit-Position: refs/heads/master@{#26921}
-
adamk authored
This required fixing the exports_ hash map to use the appropriate comparison function instead of pointer comparison. BUG=v8:1569 LOG=n Review URL: https://codereview.chromium.org/960793003 Cr-Commit-Position: refs/heads/master@{#26920}
-
bratell authored
InstallBuiltinFunctionIds stood out when looking at code that grew strangely when compiled with default optimizations. This change from repeated code to a loop saves 6-7 KB of machine code. I suspect it's faster but I also suspect it's fast enough either way so that is not really a factor. Machine code reduction seen below. Code formatted with git cl format. clang x64: Total change: -5985 bytes ------------------------------------------- +517 - Source: ?? - (gained 744, lost 227) ------------------------------------------- New symbols: +744: v8::internal::Genesis::InstallBuiltinFunctionIds()::builtins type=d, size=744 bytes Removed symbols: -4: .L.str98 type=r, size=4 bytes ... [stripped 30 similar lines] -19: .L.str100 type=r, size=19 bytes ---------------------------------------------------------------------------------------------- -6502 - Source: /home/bratell/src/chromium/src/v8/src/bootstrapper.cc - (gained 0, lost 6502) ---------------------------------------------------------------------------------------------- Removed symbols: -1135: v8::internal::ResolveBuiltinIdHolder(v8::internal::Handle<v8::internal::Context>, char const*) type=t, size=1135 bytes Shrunk symbols: -5367: v8::internal::Genesis::InstallBuiltinFunctionIds() type=t, (was 7105 bytes, now 1738 bytes) BUG= Review URL: https://codereview.chromium.org/918303005 Cr-Commit-Position: refs/heads/master@{#26919}
-
machenbach authored
Rolling v8/buildtools to 93b3d0af1b30db55ee42bd2e983f7753153217db Rolling v8/tools/clang to eb87c73202018d13f2f713e1304ab4edf9a6f49f TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/962223002 Cr-Commit-Position: refs/heads/master@{#26918}
-
loislo authored
BUG= TBR=svenpanne Review URL: https://codereview.chromium.org/960903005 Cr-Commit-Position: refs/heads/master@{#26917}
-
loislo authored
Save Unknown position as zero in RelocInfo. Remove copy constructor of SourcePosition because it is trivial. Mechanical replace int raw_position with SourcePosition position. BUG=452067 LOG=n Review URL: https://codereview.chromium.org/959203002 Cr-Commit-Position: refs/heads/master@{#26916}
-
dcarney authored
BUG= Committed: https://crrev.com/56039af476797accc238dcb24c7ab926899287a0 Cr-Commit-Position: refs/heads/master@{#26881} Review URL: https://codereview.chromium.org/955393002 Cr-Commit-Position: refs/heads/master@{#26915}
-
dcarney authored
BUG=v8:3929 LOG=Y Review URL: https://codereview.chromium.org/959223002 Cr-Commit-Position: refs/heads/master@{#26914}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/967483003 Cr-Commit-Position: refs/heads/master@{#26913}
-
dcarney authored
BUG=v8:3929 LOG=y Review URL: https://codereview.chromium.org/962983002 Cr-Commit-Position: refs/heads/master@{#26912}
-
bmeurer authored
Without this shortcut we generate one BooleanNot per JSUnaryNot with number input, which is quite common in asm.js. These dead nodes then survive until the late control reducer runs, and may prevent optimizations in the mean time. R=dcarney@chromium.org Review URL: https://codereview.chromium.org/963713002 Cr-Commit-Position: refs/heads/master@{#26911}
-
bmeurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/964843002 Cr-Commit-Position: refs/heads/master@{#26910}
-
balazs.kilvady authored
MIPS: Skip the mapcheck on the global object since the global proxy and cell are already checked (or the global object map for contextual global loads). Port 6af7ca6b BUG= Review URL: https://codereview.chromium.org/957393002 Cr-Commit-Position: refs/heads/master@{#26909}
-
chunyang.dai authored
port 6af7ca6b (r26886) original commit message: Skip the mapcheck on the global object since the global proxy and cell are already checked (or the global object map for contextual global loads). BUG= Review URL: https://codereview.chromium.org/965693002 Cr-Commit-Position: refs/heads/master@{#26908}
-
bmeurer authored
Review URL: https://codereview.chromium.org/926553004 Cr-Commit-Position: refs/heads/master@{#26907}
-
chunyang.dai authored
this is introduced by 88c4f52c (r26783) BUG= Review URL: https://codereview.chromium.org/958243004 Cr-Commit-Position: refs/heads/master@{#26906}
-
cdai2 authored
port e9cdcb71 (r26875) original commit message: Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. Proxies up the chain are guaranteed to provide access if we had access to the receiver, since otherwise we wouldn't have been able to compile the stub in the first place. If the security check would change, the window navigates, changing the map of the JSGlobalProxy. BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/964813002 Cr-Commit-Position: refs/heads/master@{#26905}
-
cdai2 authored
port affcfaf4 (r26835). original commit message: Move Maps' back pointers from "transitions" to "constructor" field BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/964783002 Cr-Commit-Position: refs/heads/master@{#26904}
-
cdai2 authored
port 119cb566 (r26696). original commit message: Stop using HeapType in IC and Crankshaft BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/958283002 Cr-Commit-Position: refs/heads/master@{#26903}
-
svenpanne authored
For now we just use the RawMachineAssembler, this will be changed later to use the whole TurboFan pipeline. Review URL: https://codereview.chromium.org/925373002 Cr-Commit-Position: refs/heads/master@{#26902}
-
chunyang.dai authored
This is introduced by acd9c46c (r26691). BUG= Review URL: https://codereview.chromium.org/965673002 Cr-Commit-Position: refs/heads/master@{#26901}
-
- 26 Feb, 2015 19 commits
-
-
machenbach authored
Revert of Also skip when the target is the global object (patchset #1 id:1 of https://codereview.chromium.org/961723002/) Reason for revert: Breaks unscopables and fix attempt needed to be reverted too. Original issue's description: > Also skip when the target is the global object > > BUG= > > Committed: https://crrev.com/cc918d30b9d586ce974b71232473f2ae3c5e7847 > Cr-Commit-Position: refs/heads/master@{#26887} TBR=jkummerow@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/960363002 Cr-Commit-Position: refs/heads/master@{#26900}
-
machenbach authored
Revert of Invalidate the global property cell when converting from data to accessor. (patchset #1 id:1 of https://codereview.chromium.org/961003002/) Reason for revert: Breaks gc stress, e.g.: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/builds/2322 Original issue's description: > Invalidate the global property cell when converting from data to accessor. > > BUG= > TBR=jkummerow@chromium.org, > > Committed: https://crrev.com/6a12dc240b1faffa500ff269077d832ecc74239d > Cr-Commit-Position: refs/heads/master@{#26896} TBR=jkummerow@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/958113004 Cr-Commit-Position: refs/heads/master@{#26899}
-
machenbach authored
Revert of MIPS: Also skip when the target is the global object. (patchset #1 id:1 of https://codereview.chromium.org/957413002/) Reason for revert: Need to revert the ported CL. Original issue's description: > MIPS: Also skip when the target is the global object. > > Port cc918d30 > > BUG= > > Committed: https://crrev.com/b24a0efa447235e11b9ff9d1eeaada06131b2e04 > Cr-Commit-Position: refs/heads/master@{#26897} TBR=danno@chromium.org,verwaest@chromium.org,paul.lind@imgtec.com,gergely.kis@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,balazs.kilvady@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/963603002 Cr-Commit-Position: refs/heads/master@{#26898}
-
balazs.kilvady authored
Port cc918d30 BUG= Review URL: https://codereview.chromium.org/957413002 Cr-Commit-Position: refs/heads/master@{#26897}
-
verwaest authored
BUG= TBR=jkummerow@chromium.org, Review URL: https://codereview.chromium.org/961003002 Cr-Commit-Position: refs/heads/master@{#26896}
-
adamk authored
This also adds a new VariableMode, IMPORT, which will be used to do appropriate binding for Import-declared Variables. Only named imports are handled for now. "import *" and default import syntaxes have had their TODOs adjusted to match the new code structure. BUG=v8:1569 LOG=n Review URL: https://codereview.chromium.org/948303004 Cr-Commit-Position: refs/heads/master@{#26895}
-
balazs.kilvady authored
Port e9cdcb71 Original commit message: Proxies up the chain are guaranteed to provide access if we had access to the receiver, since otherwise we wouldn't have been able to compile the stub in the first place. If the security check would change, the window navigates, changing the map of the JSGlobalProxy. BUG= Review URL: https://codereview.chromium.org/958923002 Cr-Commit-Position: refs/heads/master@{#26894}
-
ulan authored
This reverts commit b57be748 and disables the test/mjsunit/debug-clearbreakpointgroup.js because BreakLocationIterator::ClearBreakPoint is already broken for unrelated reasons (see v8:3924). BUG=v8:3877 LOG=N TEST=cctest/test-heap/Regress3877 Review URL: https://codereview.chromium.org/957373002 Cr-Commit-Position: refs/heads/master@{#26893}
-
arv authored
BUG=v8:3923 LOG=N R=marja,rossberg Review URL: https://codereview.chromium.org/961823002 Cr-Commit-Position: refs/heads/master@{#26892}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/958023002 Cr-Commit-Position: refs/heads/master@{#26891}
-
titzer authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/955243002 Cr-Commit-Position: refs/heads/master@{#26890}
-
vogelheim authored
(Discovered when landing crrev.com/959693002) R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/960883003 Cr-Commit-Position: refs/heads/master@{#26889}
-
dusan.milosavljevic authored
Reuse optimization introduced in 6dee8884. TEST= BUG= Review URL: https://codereview.chromium.org/960963002 Cr-Commit-Position: refs/heads/master@{#26888}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/961723002 Cr-Commit-Position: refs/heads/master@{#26887}
-
verwaest authored
Skip the mapcheck on the global object since the global proxy and cell are already checked (or the global object map for contextual global loads). BUG= Review URL: https://codereview.chromium.org/961693002 Cr-Commit-Position: refs/heads/master@{#26886}
-
vogelheim authored
Revert of Default-enable external startup data for Linux for stand-alone builds. (patchset #1 id:1 of https://codereview.chromium.org/959693002/) Reason for revert: Breaks "Simple Leaks Check" Original issue's description: > Default-enable external startup data for Linux for stand-alone builds. > > Notes: > - Other platforms to follow later. > - This follows Chromium practice, that mostly uses this feature these days. > - The statically linked-in startup data will stay. So whoever prefers > the old way just needs to set the flag differently. > > BUG= > > Committed: https://crrev.com/6d0dcaabe55ca3556bebfd771fbc7fd560fdd4e0 > Cr-Commit-Position: refs/heads/master@{#26884} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/962593003 Cr-Commit-Position: refs/heads/master@{#26885}
-
vogelheim authored
Notes: - Other platforms to follow later. - This follows Chromium practice, that mostly uses this feature these days. - The statically linked-in startup data will stay. So whoever prefers the old way just needs to set the flag differently. BUG= Review URL: https://codereview.chromium.org/959693002 Cr-Commit-Position: refs/heads/master@{#26884}
-
marja authored
Revert of Fix memory leak caused by field type in descriptor array. (patchset #3 id:40001 of https://codereview.chromium.org/955063002/) Reason for revert: Breaks test/mjsunit/debug-clearbreakpointgroup.js on arm64.debug. Original issue's description: > Fix memory leak caused by field type in descriptor array. > > When a field type is a map, it is wrapped in a weak cell upon storing to the descriptor array. > > Map::GetFieldType(i) does the unwrapping. > > BUG=v8:3877 > LOG=N > TEST=cctest/test-heap/Regress3877 > > Committed: https://crrev.com/77d3ae0e119893ac8d34ea6ca090cddd5bbf987e > Cr-Commit-Position: refs/heads/master@{#26879} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3877 Review URL: https://codereview.chromium.org/960103003 Cr-Commit-Position: refs/heads/master@{#26883}
-
dcarney authored
Revert of ensure host compiler is always clang when cross compiling from linux (patchset #6 id:100001 of https://codereview.chromium.org/955393002/) Reason for revert: broke some things Original issue's description: > ensure host compiler is always clang when cross compiling from linux > > BUG= > > Committed: https://crrev.com/56039af476797accc238dcb24c7ab926899287a0 > Cr-Commit-Position: refs/heads/master@{#26881} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/964483002 Cr-Commit-Position: refs/heads/master@{#26882}
-