- 02 Jan, 2020 7 commits
-
-
Peter Marshall authored
This was needed for Perfetto at one point but now this is all handled internally by the Perfetto Client API. The implementation was potentially wrong as on some platforms we truncate the the thread ID https://chromium-review.googlesource.com/c/v8/v8/+/1720821/1/src/base/platform/platform-posix.cc#528 Change-Id: I5124f4fb0df4d29ff78ab6c7a2c2b0c9a66a2af3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981508Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65576}
-
Peter Marshall authored
This improves runtime and guarantees a number of samples, reducing the chance of flakes and simplfying the code as well. Change-Id: Ife559475240670e40e194285ba73853d18672e97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981506Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65575}
-
Peter Marshall authored
This test tried to get enough samples by varying the amount of work done based on simulator vs. non-simulator builds. This didn't take into account other things like release vs. debug, and some bots took a very long time to run this test. This CL uses the existing ProfilerHelper and sets a minimum number of samples so that we can actually run the minimum amount of work for any platform without manual tweaking. This decreases runtime on x64.optdebug from 18.5 to 1.08s, and from 10+ min on x64.debug to 1.8s. arm.debug is ~4s now. Bug: v8:10013 Change-Id: Ibdbdec00a300683554e3c67013e56d27dc7e6257 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981504 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Peter Marshall authored
This reverts commit 6ce3046e. Reason for revert: Flaky test failures, see flako run: https://ci.chromium.org/p/v8/builders/try.triggered/v8_flako/b8893085619399726256 Original change's description: > [wasm] Add support to tier down/up Wasm NativeModule > > This is the first part of switching between Liftoff and Turbofan in > debugging Wasm. In this CL, we implemented the logic to tier down/up all > functions in module. > > Bug: v8:9654 > Change-Id: Ia25103ca29963afa103c124ff5f159f197c2b2b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970470 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65529} TBR=clemensb@chromium.org,bmeurer@chromium.org,duongn@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9654, v8:10086 Change-Id: I44a4c2bde87ba5e4e83859e3e3c96103249b585f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981501 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65573}
-
Michael Achenbach authored
Also mark a slow test for better throughput. No-Try: true Change-Id: Ib8520ba3d00328cc27f330aff594b57d33ebe88d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981502Reviewed-by:
-
Peter Marshall authored
Just a cleanup, should not change behavior, although we will allocate more handles in some cases. Also re-orders some of the implementations of the interface to try and keep things consistent. Included cleanup: Change CodeEventDispatcher so that it now implements CodeEventListener, given that it had that exact interface already. Also remove the macro dispatch to try and make things a bit easier to read. Bug: chromium:1033407 Change-Id: Id943b10c49f102d9783d8f4cf3a8c43e04364c77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1976390Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1255ede..19d4aa5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b3788f2..7c4300c TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I47bac7d2b1a6856fbb1fdc46b4e1cc63f24cd49d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1984842Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65570}
-
- 01 Jan, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cac0fb4..1255ede Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/fa02977..8d21328 Rolling v8/buildtools/linux64: git_revision:6feb55993083dfd27b93da195c8a82a3a9529848..git_revision:a5bcbd726ac7bd342ca6ee3e3a006478fd1f00b5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c9e75ab..b3788f2 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I0ea7db7fbc1c79303a7524c432f8464dfe75391e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1984841Reviewed-by:
-
- 31 Dec, 2019 2 commits
-
-
Mike Stanton authored
This limit hangs TypeScript and needs further investigation. Bug: chromium:1038292 Change-Id: I5270052cb2b357f9f872d6de42a8122cee81b13e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981499Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65568}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/54b7873..cac0fb4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f77838c..c9e75ab TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I4eed13bc79f1f2a80f5d3050e24a1c1c011a669a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1984839Reviewed-by:
-
- 30 Dec, 2019 1 commit
-
-
Jakob Gruber authored
Bug: v8:9972 Change-Id: Ieed4ba6648a20a9b372888d75e8eb7617acdf562 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981490 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65566}
-
- 28 Dec, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/69e421a..54b7873 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1890745..f77838c TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ic07b7b0b1ca3de37e18e39775d0f233ada3731ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1983482Reviewed-by:
-
- 27 Dec, 2019 6 commits
-
-
Mike Stanton authored
Renderer hangs are possible with current limit (25). I'd like to know what a limit of 15 does to benchmark performance, and see it's effect on hangs. Bug: chromium:1034768 Change-Id: Ie7fae638972816f547e6ca7a9d7f199cbcf6b2cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981492Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65564}
-
Clemens Backes authored
This adds a {wasm::DebugInfo} struct which will hold the {wasm::DebugSideTable}s for individual Liftoff functions, and will use them to construct local scope information. R=jkummerow@chromium.org, bmeurer@chromium.org Bug: v8:10019 Change-Id: I7869cec5000e9b126c891a242fcccfc53c67662e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975758 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65563}
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Iee3bcaa3a7149309c01d16be67d189ccc56bd0e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965919 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Daniel Clifford authored
In the process: * Rework the Torque definition of ScopeInfo to enable direct field-style access of ScopeFlags, removing some dead code in the process. * Allow implicit FromConstexpr conversion from subtypes of 'constexpr A' to other types. This makes it possible/easy to convert constexpr versions of enums to other types, since the constexpr version of the enum isn't addressable. It's namespace isn't a valid namespace and is an implementation detail anyway. * Cleanup LanguageMode: Language mode is now an enum and directly mirrors the C++-side definition rather than being a Smi. With the changes above, a new type LanguageModeSmi is introduced that is the Smi representation of LanguageMode that can be implicitly casted from constexpr LanguageMode values. Change-Id: I190412f95e02905f445d149883fbf1f2b8ed757b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977159 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
When opening DevTools, make sure that Wasm modules properly show up, aka are reported via "Debugger.scriptParsed" events. Previously these scripts corresponding to Wasm modules had been filtered out explicitly (accidentally). Bug: chromium:1032042 Tbr: clemensb@chromium.org Change-Id: Id5e49616a4959c9ca611dbae6f1a4e9a47413ea6 Doc: https://bit.ly/wasm-dbg-stories-2019#bookmark=id.drrsobk5mo0p Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980588 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/01e7f30..69e421a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fe10b5c..1890745 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ccefaab..86eb804 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ib5230e27e0d5e7670977d8583fa77bd05dbf4c43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1982899Reviewed-by:
-
- 26 Dec, 2019 2 commits
-
-
Joshua Litt authored
Fixes a potential overflow when using the runtime's StringCompareSequence by checking the string length first. Bug: chromium:1032906 Change-Id: I7cb94473ae8331dd2ecf1fa98034829bebf8a9ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973936 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/45aab2c..01e7f30 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bdfd74a..fe10b5c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1d36586..ccefaab TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I0074734ddfadead62c449b4bc2cfccd79e5f578e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1982251Reviewed-by:
-
- 25 Dec, 2019 2 commits
-
-
Jakob Gruber authored
Tbr: mvstanton@chromium.org Bug: v8:9972 Change-Id: If491e37e43e2a639b452b7d5558baca75bca1791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973737 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:9972 Change-Id: I94a6a1a520de9da76a5de7bdcc19bd1b71b303cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973736 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
- 24 Dec, 2019 1 commit
-
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3682ddd7..31f1bb5a 31f1bb5 Remove date related types for Intl.DisplayNames (#2448) by Frank Yung-Fong Tang · 61 minutes ago 502cc20 fix delete test, add error tests, fix lint (#2453) by Gus Caplan · 2 days ago 19fd4be Improve Object.prototype.isPrototypeOf coverage (#2446) by Alexey Shvayka · 5 days ago 0ea69c7 feat: regression tests for optional call (#2429) by Benjamin E. Coe · 5 days ago a3370bf FinalizationGroup: Improve tests for cleanupSome/unregister interactions (#2440) by Mathieu Hofman · 5 days ago 0ddce19 Adding tests for Array.prototype.copyWithin (#2443) by Natalie Silvanovich · 5 days ago cadd47a Add test for for-in order (#2432) by Kevin Gibbons · 5 days ago f7ad295 Update tests now that FinalizationGroup.prototype.cleanupSome throws if cleanup is currently in progress. (#2434) by Jon Coppeard · 5 days ago 09380a4 Add test verifying that optional call preserves `this`. (#2436) by Ross Kirsling · 3 weeks ago 5c41447 Remove incorrect tests for AggregateError#toString (#2435) by Leo Balter · 3 weeks ago 65e996b Check the step 29 of InitializeDateTimeFormat (#2427) by Frank Yung-Fong Tang · 3 weeks ago 22978d3 add test for typeof proxy (#2438) by Gus Caplan · 3 weeks ago 8ef20fb Merge pull request #2439 from devsnek/engine262 by Leo Balter · 3 weeks ago df8aa61 add engine262 runner by Gus Caplan · 3 weeks ago 2213d13 Merge pull request #2425 from bcoe/optional-chaining-iteration by Leo Balter · 5 weeks ago 5babea2 chore: added a few more examples based on code review by bcoe · 5 weeks ago 3d0c203 feat(optional-chaining): add tests for IterationStatement by bcoe · 5 weeks ago Bug: v8:7834 Change-Id: Id2eac590b65d2070bbd3da905ce71d30fa5197c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980907Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#65554}
-
- 23 Dec, 2019 5 commits
-
-
Dan Elphick authored
Adds --retain option (all, none, json) which controls which files are kept after running the benchmark. No-Try: true Change-Id: I033a8ff7938fd10f8a0fc9425043e24f1229ce0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980575Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#65553}
-
Tobias Tebbi authored
This enables using the GraphAssembler for Wasm. Change-Id: Id1f46db6cc05c9de6e878fb062434211a9c390ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977160 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: v8:10053 Change-Id: I90e0798ce490dea035cf4ecb934a4b8d98c61bc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977859 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2e9f699..45aab2c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/efb804d..bdfd74a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5df4d00..1d36586 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I234983cfbdbfe01fde68606133405f6b1799781b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980076Reviewed-by:
-
Zhang, Shiyu authored
Contributed by fanchen.kong@intel.com Change-Id: I4be08cb8fdbf7e2be3e9694cc0eb94e8128c8f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973541Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Cr-Commit-Position: refs/heads/master@{#65549}
-
- 22 Dec, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/60770dc..2e9f699 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d7f3ca9..814da1f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/13263d5..5df4d00 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I49d10dd90a201942cb9a4a899b6237abf2ea0baf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1979836Reviewed-by:
-
- 21 Dec, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/032b1bd..60770dc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/104d957..efb804d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0593495..4413434 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cd8fb02..13263d5 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I754f7771db2c8defda57f601857757f5596ccdab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1978064Reviewed-by:
-
- 20 Dec, 2019 10 commits
-
-
Ng Zhi An authored
kFpRegPair requires a bit of special case logic in allocation and spill logic, since it requires adjacent fp registers, with the low register being an even-numbered one. We make use of a shift+and trick with the reg list to check this. Given a bit mask of registers available, AND this with a right-shift-by-one version of itself, and then AND it again with with a bit mask of even numbered fp registers, we can get a bit mask where all available even registers are set. For example, given 00011011, where 1 means register is available: 00011011 & 0001101 (right shift by 1) ---------- 00001001 & 01010101 (mask of even registers) ---------- 00000001 We see that only the first fp register is available, based on the adjacency requirement. The mask of even registers is defined to be uint64_t, to workarond shift overflow issues when non-unsigned values are used, and also to make this work on all platforms and compilers without implicit conversion warnings. It is a bit wasteful, since we really only need storage_t, but since it is a constexpr it should be okay. The spilling case tries to be a bit smart, since there are three possible cases (described in the code), two of which we can spill one register, and in the last case we have to spill two registers. We try to distinguish between these cases in order to minimize spills. The dumb thing here is in the last case, we arbitrarily pick the first two registers (d0, d1) to spill. Bug: v8:9909 Change-Id: I408f9f79b1f3c505f2fd73bad15923188ae7aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975033 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Add support for storing values of type kWasmS128 to ia32, x64, arm, arm64. These stores are never hit right now, since Liftoff does not handle any S128 values yet. Bug: v8:9909 Change-Id: Ib74b9db158428186757086711b8249866026dab5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1974834 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Frank Tang authored
I2I https://mail.google.com/mail/u/0/#search/Intl.DisplayNames+Intent/KtbxLwgxBjLmZRWGMwZfjnVwNFvdndwvBq Design Doc: https://shorturl.at/emEHW https://www.chromestatus.com/feature/4965112605573120 Latest spec: https://tc39.es/proposal-intl-displaynames/ Spec Github: https://github.com/tc39/proposal-intl-displaynames Bug: v8:8703 Change-Id: I3757d2131029104984d26cd5f037f90dd7b136e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1976903Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10039 Change-Id: Ic2775bfcae330ff9763bc28a65a806e6a41a5fba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958013Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65543}
-
Ulan Degenbaev authored
These worklists are needed for accounting of objects retained by native contexts for the new memory measurement API. Bug: chromium:973627 Change-Id: I354c5ebbbac11da4d01800164e15b94a93aa654c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943158 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#65542}
-
Tobias Tebbi authored
This reverts commit 91e3243d. Reason for revert: This deopts to the wrong point. Original change's description: > Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]() > > Current GetIterator bytecode loads and calls @@iterator property on a > given object. This change extends the bytecode functionality to check > whether the value returned after calling @@iterator property is a valid > JSReceiver. The bytecode throws SymbolIteratorInvalid exception if the > returned value is not a valid JSReceiver. This change absorbs the > functionality of additional two bytecodes - JumpIfJSReceiver and > CallRuntime, that are part of the iterator protocol in the GetIterator > bytecode. > > Bug: v8:9489 > Change-Id: I9e84cfe85eeb9a1b8a97ca0595375ac26ba1bbfd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792905 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com> > Cr-Commit-Position: refs/heads/master@{#63704} TBR=rmcilroy@chromium.org,leszeks@chromium.org,tebbi@chromium.org,swapnilgaikwad@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9489 Change-Id: I9324b5b01ead29912ad793a1e7b4d009643d7901 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960288Reviewed-by:
-
Clemens Backes authored
This adds a respective test, even though Liftoff frames currently do not show scope information. The output will change with future CLs. R=jkummerow@chromium.org Bug: v8:10019 Change-Id: I015863768c02678e97404f2edb538e3b4320d134 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975754 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
This uses the Smi-fast-path that was added for i32 values also for f32 and f64. The code was generalized to do the smi-to-wasm-type and float64-to-wasm-type conversion dependent on the type, and keep the rest generic. R=jkummerow@chromium.org Bug: v8:10070 Change-Id: I42b021dcc99755883cf003579c730675e6d93ff6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965577Reviewed-by:
-
Tobias Tebbi authored
This allows the definition of classes with several arrays and ports SmallOrderedHashTable subclasses to Torque as an example, including the existing CSA allocation functions for them. Overview of changes: - Introduce ResidueClass to encapsulate the modulo-arithmetic necessary to do alignment checks. - Add MachineOperatorReducer to the CSA pipeline to address now missing CSA ad-hoc constant folding that got blocked by a temporary phi. - Allow assignments to references to structs. This is needed to initialize the data_table part of SmallOrderedHashMap. - Make the NumberLiteralExpression AST-node store a double instead of a string. This is necessary to detect arrays with constant size used for padding. - Turn offsets into base::Optional<size_t> to ensure we don't use an invalid or statically unknown offset. - Remove CreateFieldReferenceInstruction since it doesn't work for complex offset computations and the logic can be expressed better in ImplementationVisitor. - Validate alignment of structs embedded in classes. Bug: v8:10004 v8:7793 Change-Id: Ifa414b42278e572a0c577bf9da3d37f80771a258 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958011 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65538}
-
Tobias Tebbi authored
This is a reland of 53308bf7 Original change's description: > [csa] use JSGraph to create constants in CodeAssembler > > Now that CodeAssembler uses optimizing TurboFan passes, creating > constants without using the caching implemented in JSGraph leads to > problems, since value numbering only works properly if all constants > in the graph were introduced through the cache. > To mitigate this, this CL creates the JSGraph earlier so that > CodeAssembler can already use the same JSGraph used by later TurboFan > optimizations. > For other uses of RawMachineAssembler, everything stays as before. > > This issue is creating bot failures in > https://chromium-review.googlesource.com/c/v8/v8/+/1958011 > > Change-Id: Ife017876b19cb2602694279ef1da75f23e18a031 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967329 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65477} TBR=mslekova@chromium.org Change-Id: I5c8218ce22470b3efa06d872176c910a4c5325a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977858Reviewed-by:
-
