Commits · 37d11fb0f001352ae04fd9db4884a2414b91a5e2 · Linshizhi / V8

22 Apr, 2013 1 commit

Improvements in lithium code generation. Recognizing if some operands are... · 37d11fb0

mvstanton@chromium.org authored Apr 22, 2013

Improvements in lithium code generation. Recognizing if some operands are constants, we can often save on registers and instructions.

BUG=

Review URL: https://codereview.chromium.org/14022011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14364 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

37d11fb0

19 Apr, 2013 18 commits

MIPS: Generator objects can suspend · f51b7642

palfia@homejinni.com authored Apr 19, 2013

Port r14353 (f4bb81d1)

Original commit message:
* src/ast.h:
* src/parser.cc: Differentiate between the different kinds of yields, in
  anticipation of boxing return values.  Parse `return' into `yield' in
  a generator.

* src/runtime.h:
* src/runtime.cc (Runtime_SuspendJSGeneratorObject): New horrible
  runtime function: saves continuation, context, and operands into the
  generator object.

* src/arm/full-codegen-arm.cc (VisitYield):
* src/ia32/full-codegen-ia32.cc (VisitYield):
* src/x64/full-codegen-x64.cc (VisitYield): Arrange to call
  SuspendJSGeneratorObject.  If the call returns the hole, we suspend.
  Otherwise we resume.

BUG=v8:2355
TEST=These codepaths are tested when the generator is first invoked, and so
are covered by mjsunit/harmony/generators-objects.js.

Review URL: https://codereview.chromium.org/14091006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14363 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f51b7642

Refactor HCheckMaps to have a private constructor, removing duplicated code... · 3575f970

titzer@chromium.org authored Apr 19, 2013

Refactor HCheckMaps to have a private constructor, removing duplicated code and simplifying calls in clients.
Ignore bsuite directory.

Review URL: https://codereview.chromium.org/14367023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14362 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3575f970

OS::MemMove/OS::MemCopy: Don't call through to generated code when size == 0... · 7155b96d

jkummerow@chromium.org authored Apr 19, 2013

OS::MemMove/OS::MemCopy: Don't call through to generated code when size == 0 to avoid prefetching invalid memory

BUG=chromium:233500

Review URL: https://codereview.chromium.org/14365011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14361 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7155b96d

Switch elements access to use IfBuilder instead of CheckBuilder. · e288a65e

mstarzinger@chromium.org authored Apr 19, 2013

R=danno@chromium.org

Review URL: https://codereview.chromium.org/14365014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14360 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e288a65e

RecordWriteStubs on ARM need to save FP registers · a8521a9e

mvstanton@chromium.org authored Apr 19, 2013

A previous change erroneously stopped saving fp registers for write stubs in
snapshotted code. This CL restores correct behavior, and makes sure code that
saves fp registers checks at runtime for 16 or 32 fp registers. Also fix a bug
in the arm simulator debugger.

BUG=

Review URL: https://codereview.chromium.org/14246032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14359 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a8521a9e

Propagate OOM exception instead of crashing in CALL_HEAP_FUNCTION_PASS_EXCEPTION macro. · dcb3c630

ulan@chromium.org authored Apr 19, 2013

R=jkummerow@chromium.org
BUG=webkit/fast/js/concat-large-strings-crash.html

Review URL: https://chromiumcodereview.appspot.com/14365017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14358 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dcb3c630

Fix build failures on Win64 since r14354. · d38a463d

mstarzinger@chromium.org authored Apr 19, 2013

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/14246034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14357 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d38a463d

Remove heap snapshot size limit. · 8bbf942d

alph@chromium.org authored Apr 19, 2013

As long as frontend now stores snapshots in external arrays
it doesn't make sense to check the collected snapshot size on the
backend side. In other words if backend has managed to fit the
collected snapshot into its memory, it should also fit into the
frontend's memory.

R=yurys@chromium.org
BUG=chromium:232305

Review URL: https://codereview.chromium.org/14246029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14356 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8bbf942d

Update arm and mips simulator to also use cmath · e457b92a

danno@chromium.org authored Apr 19, 2013

Review URL: https://codereview.chromium.org/14241029

Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14355 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e457b92a

Update tests to use std::isnan instead of isnan · 600ed94a

danno@chromium.org authored Apr 19, 2013

Should fix compilation breakage after r14352

Review URL: https://codereview.chromium.org/14328044

Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14354 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

600ed94a

Generator objects can suspend · 0f348e55

mstarzinger@chromium.org authored Apr 19, 2013

* src/ast.h:
* src/parser.cc: Differentiate between the different kinds of yields, in
  anticipation of boxing return values.  Parse `return' into `yield' in
  a generator.

* src/runtime.h:
* src/runtime.cc (Runtime_SuspendJSGeneratorObject): New horrible
  runtime function: saves continuation, context, and operands into the
  generator object.

* src/arm/full-codegen-arm.cc (VisitYield):
* src/ia32/full-codegen-ia32.cc (VisitYield):
* src/x64/full-codegen-x64.cc (VisitYield): Arrange to call
  SuspendJSGeneratorObject.  If the call returns the hole, we suspend.
  Otherwise we resume.

BUG=v8:2355
TEST=These codepaths are tested when the generator is first invoked, and so
are covered by mjsunit/harmony/generators-objects.js.

Review URL: https://codereview.chromium.org/13704010

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14353 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f348e55

Replace math.h with cmath · bc04544f

danno@chromium.org authored Apr 19, 2013

This will make it easier to use other STL headers in the future

Review URL: https://codereview.chromium.org/14362023

Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14352 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bc04544f

Remove unused member variables in IfBuilder · 0c5c6c50

danno@chromium.org authored Apr 19, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14328042

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14351 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0c5c6c50

Switch GCMole to use GYP build file instead of SCons. · 6654cbeb

mstarzinger@chromium.org authored Apr 19, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14320024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14350 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6654cbeb

Simplified LCodeGen::GetNextEmittedBlock and LCodeGen::EmitGoto a bit. · 0af76e96

svenpanne@chromium.org authored Apr 19, 2013

GetNextEmittedBlock is always called with the same argument (an instance
variable), so let's remove it. In EmitGoto, avoid assignment to an argument.

This CL is split off another CL for easier reviewing.

Review URL: https://codereview.chromium.org/14246031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14349 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0af76e96

Revert r14252 as it broke --prof for some cases · c0fca4e8

yurys@chromium.org authored Apr 19, 2013

R=jkummerow
BUG=v8:2642

Review URL: https://codereview.chromium.org/14367020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14348 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c0fca4e8

Handle retry-after-gc failures within LoadIC::Load and StoreIC::Store. · 1938b1de

ulan@chromium.org authored Apr 19, 2013

Follow-up for r14321, makes the remaining unsafe calls to runtime functions during ic computation safe.

R=verwaest@chromium.org
BUG=222301

Review URL: https://chromiumcodereview.appspot.com/13976015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14347 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1938b1de

Removed redundant instruction in VerifyX87StackDepth() · dfdd17fc

mvstanton@chromium.org authored Apr 19, 2013

BUG=

Review URL: https://codereview.chromium.org/14353004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14346 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dfdd17fc

18 Apr, 2013 21 commits

MIPS: Add infrastructure to automatucally generate IC miss stubs · ab695a2b

palfia@homejinni.com authored Apr 18, 2013

Port r14342 (24df6264)

BUG=

Review URL: https://codereview.chromium.org/13896016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14345 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ab695a2b

MIPS: HArgument instructions currently require a frame. In Lithium we can... · 5197ab05

palfia@homejinni.com authored Apr 18, 2013

MIPS: HArgument instructions currently require a frame. In Lithium we can ensure a frame is created for these instructions via a compile info flag.

Port r14339 (7d544be1)

BUG=

Review URL: https://codereview.chromium.org/14367003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14344 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5197ab05

MIPS: Fix bugs in IfBuilder and improve functionality · bd03455c

palfia@homejinni.com authored Apr 18, 2013

Port r14327 (21310b91)

BUG=

Review URL: https://codereview.chromium.org/14246017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14343 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd03455c

Add infrastructure to automatucally generate IC miss stubs · 80adb589

danno@chromium.org authored Apr 18, 2013

Review URL: https://codereview.chromium.org/13886013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14342 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

80adb589

HArgument instructions currently require a frame. In Lithium we can ensure a frame · bfb3e6ce

mvstanton@chromium.org authored Apr 18, 2013

is created for these instructions via a compile info flag.

BUG=

Review URL: https://codereview.chromium.org/14354003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14339 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bfb3e6ce

Saving Hydrogen code stubs in the snapshot requires us to respect the availability of VFP32DREGS. · ad2c227e

mvstanton@chromium.org authored Apr 18, 2013

BUG=

Review URL: https://codereview.chromium.org/13878011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14338 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ad2c227e

Prepare push to trunk. Now working on version 3.18.2. · ddfa5634

mstarzinger@chromium.org authored Apr 18, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14356002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14335 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ddfa5634

Revert r14310 due to isolate tests failure. · 72a05845

yangguo@chromium.org authored Apr 18, 2013

R=mstarzinger@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14021004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14334 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

72a05845

Do not choose parallel recompilation when bootstrapping. · ecbbf528

yangguo@chromium.org authored Apr 18, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/13878019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14333 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ecbbf528

Fix missing Smi check in grow mode keyed stores. · adf9afc0

mstarzinger@chromium.org authored Apr 18, 2013

R=danno@chromium.org
TEST=mjsunit/regress/regress-grow-store-smi-check

Review URL: https://codereview.chromium.org/14352011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14332 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

adf9afc0

Cleaned up and fixed code comment handling a bit. · 27589107

svenpanne@chromium.org authored Apr 18, 2013

* Let GCC check the arguments of LCodeGen::Coment.
* Fixed a few call sites.
* Made basic blocks a little bit more visible in the code output.
* Sorted #includes.

Review URL: https://codereview.chromium.org/14079007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14331 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

27589107

Fix debug print and wrong handle dereference in es6 typed array. · 373bdbc9

yangguo@chromium.org authored Apr 18, 2013

R=dslomov@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14149009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14330 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

373bdbc9

Inline isUint32() method from HConstant, which was only used in one place. · e210d832

titzer@chromium.org authored Apr 18, 2013

Add utility method for checking whether an HValue is a given int32_t constant.

BUG=

Review URL: https://codereview.chromium.org/14244023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14329 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e210d832

Remove SCons related files · 5eadc1a4

jkummerow@chromium.org authored Apr 18, 2013

Review URL: https://codereview.chromium.org/14348002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14328 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5eadc1a4

Fix bugs in IfBuilder and improve functionality · fded35e0

danno@chromium.org authored Apr 18, 2013

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/14344004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14327 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fded35e0

Remove deprecated test suite configurations. · c47af882

mstarzinger@chromium.org authored Apr 18, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/13878008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14326 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c47af882

ARM: clean up code now that ARMv6 is the baseline. · 76ed72bd

rodolph.perfetta@gmail.com authored Apr 18, 2013

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/14188016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14325 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

76ed72bd

Improve generated code for HDoCompareObjectEqAndBranch on ia32/x64 · f85f1e0d

danno@chromium.org authored Apr 18, 2013

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/14083008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14324 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f85f1e0d

Make it possible to Crankshaft all kinds of stubs. · 244fa50a

danno@chromium.org authored Apr 18, 2013

Review URL: https://codereview.chromium.org/14307006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14323 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

244fa50a

Unify canonicalization of HAdd/HSub/HMul a bit. · 55324693

svenpanne@chromium.org authored Apr 18, 2013

HDiv/HMul are a slightly different story and will be handled in a separate CL.

Review URL: https://codereview.chromium.org/14296013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14322 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55324693

Handle retry-after-gc failures within KeyedLoadIC::Load and KeyedStoreIC::Store. · 5a215129

ulan@chromium.org authored Apr 18, 2013

Returning retry-after-gc failure from these functions causes them to be
re-executed after ic state change, which breaks stub computation assumptions.

R=verwaest@chromium.org
BUG=222301
TEST=mjsunit/array-bounds-check-removal.js --gc_interval=10 in x64.debug

Review URL: https://chromiumcodereview.appspot.com/14251014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5a215129