- 08 Nov, 2018 21 commits
-
-
Leszek Swirski authored
Bug: chromium:902610 Change-Id: I4675e3089a09ee75aa81ba2958f30a17621a537e Reviewed-on: https://chromium-review.googlesource.com/c/1326029Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57358}
-
Toon Verwaest authored
Since we use a ScopedPtrList to track cover grammar expressions we don't know the position of the commas anymore. The position of the commas was used to demark the initializer, which is needed to figure out whether we need hole checks for variable references. (Typically only references within the initializer need hole checks for the initialized variable.) Since we didn't have the comma position, we simply used the position of the first expression as the position of any subsequent comma, which would make it seem as if the initializer body wasn't in the initializer. Now instead we simply use the position of the subsequent parameter as the end of the initializer, which is close enough. Bug: chromium:902810 Change-Id: I8d2bc7a2dc9f59db16ce56ccef01e263a18a3b7a Reviewed-on: https://chromium-review.googlesource.com/c/1326022Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57357}
-
v8-ci-autoroll-builder authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/d9d9839..0475c12 TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I3d996306614cbf80a24c9dfc4f320ad551fd0b84 Reviewed-on: https://chromium-review.googlesource.com/c/1326365Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57356}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I5192891c85da12638e036b605713264d0e59aedc Reviewed-on: https://chromium-review.googlesource.com/c/1324490 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57355}
-
Igor Sheludko authored
Currently, in debug mode the snippets check the result of decompression equals to the full value stored in the field. Bug: v8:7703 Change-Id: I0caa7fdaa7d346612084706ed96a4330fcb0c236 Reviewed-on: https://chromium-review.googlesource.com/c/1319575 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57354}
-
Sigurd Schneider authored
Increase width of resizers and clean up CSS. Drive-by: Add hot recompile watch command. Run npm run-script watch and rollup will recompile on file changes. Notry: true Bug: v8:7327 Change-Id: If24e18049ff565a7584b5cca9c64431e4ac03f77 Reviewed-on: https://chromium-review.googlesource.com/c/1320852Reviewed-by:
-
Clemens Hammacher authored
Introduce a typedef to avoid repeating the function definition multiple times. R=ahaas@chromium.org Change-Id: I9d8a2a9b663f86ce0f6e21edf6d4a6d5ae450efc Reviewed-on: https://chromium-review.googlesource.com/c/1325963Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57352}
-
George Wort authored
Change-Id: I7079a0460fcb8f9b818c97125ab11f6168c3a28d Reviewed-on: https://chromium-review.googlesource.com/c/1323731 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57351}
-
Leszek Swirski authored
The Ignition statement list visitor will skip the rest of the statements in the list if it hits a jump statement (like a return or break), as the rest of the code in the list can be considered dead. return; dead_call(); // skipped However, since this is at an AST node level, it does not take into account condition shortcutting: if(2.2) return; dead_call(); // not skipped There is also a second dead code elimination in Ignition compilation, at the bytecode array writer level, where a bytecodes are not emitted if an "exit" bytecode (Return, Jump, or a few others) has been written, until the next basic block starts (i.e. a Bind). This can cause an issue with statements that resurrect the bytecode array writer part-way through their visit. An example is try-catch statements, which save the context to a register, and then Bind to start the try region. For the case: if (2.2) return; try { // try statement not skipped ... } the bytecode writer is called with OutputReturn() // exit bytecode seen OutputMove(<context>, r1) // not emitted Bind(&try_begin) // starts new basic block // try body So, the try is emitted, but without saving the context to a register. This means that the liveness analysis sees the read of that register (as the output liveness of throwing bytecodes), but does not have a write to the register, which means that the liveness escapes. This patch fixes this by using the bytecode array writer dead-code elimination (i.e. "exit bytecode seen") to inform the statement list visitor, so that in this example the try statement is not visited at all. Bug: chromium:902395 Change-Id: Ieb8e46a4318df3edbac0ae17235e0ce8fba12ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1322951Reviewed-by:Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57350}
-
Jaroslav Sevcik authored
As opposed to the register. For subtle reasons, this fixes a deoptimizer bug with handling return values in lazy deopt. Since the return values can now only overwrite the accumulator, there is no danger of overwriting a captured object that might be later used (since there is no "later"). Bug: chromium:902608 Change-Id: I3a7a10bb1c7a6f4303a01d60f80680afcb7bc942 Reviewed-on: https://chromium-review.googlesource.com/c/1325901Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57349}
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: chromium:901329 Change-Id: Id9bc01e7e49c90ac3b5bca88abba53a38a1b0d80 Reviewed-on: https://chromium-review.googlesource.com/c/1326021Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57348}
-
Marja Hölttä authored
See https://github.com/tc39/proposal-weakrefs/issues/37 Drive-by: fix error messages. BUG=v8:8179 Change-Id: I8608d09ec5a58c8b62eea4580be9415f6bb41586 Reviewed-on: https://chromium-review.googlesource.com/c/1319758 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57347}
-
Ivica Bogosavljevic authored
Fix 4001f86a Change-Id: I8392c1c6c279b51c64d1052992d836939c84ec55 Reviewed-on: https://chromium-review.googlesource.com/c/1325377Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57346}
-
Georg Neis authored
Also brokerize a few things along the way. Bug: v8:7790 Change-Id: I40d8175fd1c86901af3d128f0d0a1e29e56723d9 Reviewed-on: https://chromium-review.googlesource.com/c/1319751Reviewed-by:
-
Jaroslav Sevcik authored
This is a hacky approach to make constant field tracking somewhat friendly to class boilerplates - if the class boilerplate has an on-descriptor-data field, we change the field to be an on-instance-const-field and store it on the instance. Bug: v8:8361 Change-Id: I5152041363bcd26568669fee93c91ff362ba8de9 Reviewed-on: https://chromium-review.googlesource.com/c/1319869 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Georg Neis authored
Installation of the PrototypePropertyDependency, as well as GC, can invalidate dependencies. Bug: chromium:902552 Change-Id: Iabcce026c7475c722d19ac0b80758b22d9fbcfda Reviewed-on: https://chromium-review.googlesource.com/c/1322450Reviewed-by:
-
Jakob Gruber authored
This fixes an issue introduced in https://crrev.com/c/1301483. The JSArray allocation could trigger GC and thus elements must be fully initialized. Bug: v8:8429,chromium:890599 Change-Id: I7bfa1728c1dde7fc880063e095413163b13be2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1322955Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57342}
-
Frank Tang authored
Requires ICU 63 or above be used when building v8 1. Remove unneeded #include of icu header files 2. Remove code inside "#if U_ICU_VERSION_MAJOR_NUM < x" block where x is 63 or smaller. Bug: v8:8401 v8:5751 Change-Id: I908b0d7d174df53d4296580fe7150417322b0b21 Reviewed-on: https://chromium-review.googlesource.com/c/1314112Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Yang Guo authored
Previously, we finalize all compile jobs at once. This keeps the zone memory in every compile job alive until the end. This contributes to a high peak memory when many functions are compiled eagerly, for example when producing cache data for the ServiceWorker cache. Memory tracked by the AccountingAllocator in bytes, prior to this change in the test case: peak memory after init: 8192 peak memory after lazy compile: 41200 peak memory after lazy compile: 41200 peak memory after eager compile: 164256 With this change, if we are compiling on the main thread, we finalize every compile job as soon as it is done and dispose the compile job and its zone memory. After this change: peak memory after init: 8192 peak memory after lazy compile: 41200 peak memory after lazy compile: 41200 peak memory after eager compile: 41376 R=leszeks@chromium.org, rmcilroy@chromium.org Bug: chromium:901329 Change-Id: Iae0c89396c89692c4ecdeec3970d3c62031d2bce Reviewed-on: https://chromium-review.googlesource.com/c/1322949 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9f8abf9..cae006c Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/a56cf2e..5aaea96 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2e722b0..1a1b38d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d6e0a8..75fa855 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/29de0c2..ac40df8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifcd163c5757f69ea900548da5e315c07a76e1cb8 Reviewed-on: https://chromium-review.googlesource.com/c/1325372Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:902428 Change-Id: If261edaa4d5ebd2a8635cdc76870c8e4ac4194dd Reviewed-on: https://chromium-review.googlesource.com/c/1325609Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57338}
-
- 07 Nov, 2018 19 commits
-
-
Adam Klein authored
Bug: v8:8413 Change-Id: I8dffebd92b3d2ce85deb31b48cbefb1dd2390481 Reviewed-on: https://chromium-review.googlesource.com/c/1325049Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57337}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:902428 Change-Id: Id9a727d83c2a69e4ffd20e761c274cba2c75404a Reviewed-on: https://chromium-review.googlesource.com/c/1320889Reviewed-by:
-
Adam Klein authored
regress-336820 is testing that joining a very sparse array to create a too-big string results in a RangeError, rather than a crash. Reducing the largest index by two orders of magnitude speeds this up (on x64 debug) by 8x (from 8 seconds down to 1). Given that this test takes nearly 9 minutes on arm64 sim debug, I hope to see big ones there too. Bug: v8:7783, chromium:336820 Change-Id: I74c22cf451a892eb039efc7f1259152921bf8530 Reviewed-on: https://chromium-review.googlesource.com/c/1323915Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57335}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:902428 Change-Id: I0781753b1a9488e091ec70b1f3601d912f3eafa6 Reviewed-on: https://chromium-review.googlesource.com/c/1324489 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port 4f6ba385 Original Commit Message: This is a reland of de88bfb2 Original change's description: > [wasm-simd] Implement remaining I8x16 SIMD ops on x64 > > - Implementation for I8x16 Shifts, and Mul > - Fix convert bug > - Enable all tests except for shuffle tests > > Change-Id: Id1a469d2883c30ea782c51d21dc462d211f94420 > Reviewed-on: https://chromium-review.googlesource.com/c/1318609 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57254} R=gdeepti@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I18980c8844a3e859b4ca3f2181de9f337bfb9698 Reviewed-on: https://chromium-review.googlesource.com/c/1324269Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57333}
-
Mathias Bynens authored
The goal is to roll in my upstream patch [1] which speeds up some of the slowest tests. The impact is especially noticeable on the builder named “V8 Linux - arm64 - sim - debug”. Before [2]: 08:57:047 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-digit-class-escape-flags-u * 08:56:265 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-word-class-escape-flags-u * 08:53:736 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-whitespace-class-escape-flags-u * 08:26:101 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-whitespace-class-escape-flags-u * 06:57:767 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-word-class-escape-flags-u * 05:04:746 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-digit-class-escape-flags-u * 01:46:609 test262/built-ins/Array/prototype/filter/15.4.4.20-9-c-ii-1 * […other unrelated tests…] After [3]: 01:46:630 test262/built-ins/Array/prototype/filter/15.4.4.20-9-c-ii-1 * […other unrelated tests…] That is, tests that previously took almost 9 minutes to run now don’t even show up in the list of slowest tests anymore. [1] https://github.com/tc39/test262/pull/1927 [2] https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8930575270954225344/+/steps/Test262_-_no_variants/0/logs/durations/0 [3] https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8930489323837575408/+/steps/Test262_-_no_variants/0/logs/durations/0 Bug: v8:7834 Change-Id: I1d0cea3b64223f7b0ec89c46235632855b8c7eee Reviewed-on: https://chromium-review.googlesource.com/c/1323733Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#57332}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:902428 Change-Id: I8cc2927a9a55f534753a499e2687e0d35cb21cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1324270Reviewed-by:
-
Adam Klein authored
The set of locales available there seems different from what the tests expect. Tbr: ftang@chromium.org Bug: v8:8413 Change-Id: Icd4a072d1a7199772b7713485a558c5db54fc30d Reviewed-on: https://chromium-review.googlesource.com/c/1323914Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:616879 Change-Id: I78a204d3620a1ea28bfd93f019b122f2186f009b Reviewed-on: https://chromium-review.googlesource.com/c/1323909 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Igor Sheludko authored
which will allow gm to work for more directories than just [<arch>].[<mode>]: gm.py ia32.release-nosnap.check gm.py x64.optdebug-ptr-compr cctest unittests Basically the new usage is: gm.py [<arch>].[<mode>[-<suffix>]].[<target>] [testname...] Once default gn configuration is created based on <arch> and <mode> the script user may change it and then use gm as usual. Bug: v8:8238 Change-Id: I9659b87073e815e0e4754f0a2f1056f3403c149c Reviewed-on: https://chromium-review.googlesource.com/c/1323734Reviewed-by:
-
Adam Klein authored
This test takes nearly 10 minutes to run on arm64, and over 5 on arm. Bug: v8:7783 Change-Id: I6798c001a76c59974729e4b2618167578eb50a1b Reviewed-on: https://chromium-review.googlesource.com/c/1321034 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#57327}
-
Deepti Gandluri authored
This is a reland of de88bfb2 Original change's description: > [wasm-simd] Implement remaining I8x16 SIMD ops on x64 > > - Implementation for I8x16 Shifts, and Mul > - Fix convert bug > - Enable all tests except for shuffle tests > > Change-Id: Id1a469d2883c30ea782c51d21dc462d211f94420 > Reviewed-on: https://chromium-review.googlesource.com/c/1318609 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57254} Change-Id: Id2f6eef3a07e40df37af29456116754e7cf5b901 Reviewed-on: https://chromium-review.googlesource.com/c/1320031Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#57326}
-
Frank Tang authored
Bug: v8:8414 Change-Id: If7fa7aff80066f8f0073f563af4a3b3f60ae3ebf Reviewed-on: https://chromium-review.googlesource.com/c/1317825Reviewed-by:
-
Frank Tang authored
This is a reland of 007c0034 In the original commit below, the permutation of testing combinatino test/intl/regress-8413.js take too long to complete in the TSAN and fail by TIMEOUT. Therefore we fix it by splitting up the test to smaller tests, one for each property type in Table 5 of ECMA402. Original change's description: > [Intl] Handle 'c' pattern for DateTimeFormat > > Handle the pattern 'c' return by ICU in Intl.DateTimeFormat > for weekday standalone form. > Add regression test to ensure all the standalone pattern return > option are in the expected list. > > Bug: v8:8413 > Change-Id: I9ab42383e3882ef1720606830624775e2748fccb > Reviewed-on: https://chromium-review.googlesource.com/c/1318092 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57299} Bug: v8:8413 Change-Id: I7a4bfd0876e4afd3eddaf3cb3d9027db075a1e3c Reviewed-on: https://chromium-review.googlesource.com/c/1321893Reviewed-by:
-
Frank Tang authored
This is a bit of a performance bottleneck currently and we're planning on improving performance by adding caching. These benchmarks will allow us to measure the improvements Add benchmark tests for String.prototype.localeCompare() Date.prototype.toLocaleString() Date.prototype.toLocaleDateString() Date.prototype.toLocaleTimeString() Number.prototype.toLocaleString() Run with python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Strings/StringLocaleCompare" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Dates" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Numbers" \ test/js-perf-test/JSTests.json Before the landing of dffaff77 git reset --hard 474a6d63 got StringLocaleCompare-Strings(Score): 13240000 toLocaleDateString-Dates(Score): 1877000 toLocaleString-Dates(Score): 1197000 toLocaleTimeString-Dates(Score): 2147000 toLocaleDateString-Dates(Score): 1908000 After the landing of dffaff77 git reset --hard dffaff77 got StringLocaleCompare-Strings(Score): 97182 toLocaleDateString-Dates(Score): 10436 toLocaleString-Dates(Score): 10436 toLocaleTimeString-Dates(Score): 10669 toLocaleString-Numbers(Score): 2876 Bug: chromium:901748 Change-Id: Ibfea85fe668f1bfaacb2dfe08368cd920d2bbfc6 Reviewed-on: https://chromium-review.googlesource.com/c/1318099Reviewed-by:
-
Toon Verwaest authored
Instead we can typically check whether the expression or statement we just parsed indicate failure. Bug: v8:8363, v8:7926 Change-Id: I477511f9f2f0e615a07285db858a237af8478edc Reviewed-on: https://chromium-review.googlesource.com/c/1323553Reviewed-by:
-
Dan Elphick authored
Change-Id: I10f64ce7c1692e46b3a4b1511936f3dd4e5b983a Reviewed-on: https://chromium-review.googlesource.com/c/1323554Reviewed-by:
-
Clemens Hammacher authored
Bug: v8:6600 Change-Id: I4982a7bb9f93bd2dced65ef9a7d3aa7711bc93b5 Reviewed-on: https://chromium-review.googlesource.com/c/1323730 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
That allows us to keep on running further without explicit RETURN_IF Bug: v8:8363, v8:7926 Change-Id: If1424a1dae656ac725a8443b09ea1b8cc25dfcb1 Reviewed-on: https://chromium-review.googlesource.com/c/1322953Reviewed-by:
-
