- 10 Nov, 2017 11 commits
-
-
Clemens Hammacher authored
This is a reland of 6c613288 Original change's description: > [Liftoff] Implement parallel register moves > > This was not implemented so far, leading to lots of clusterfuzz issues. > Testing this feature would require complicating the interface a lot and > exposing more implementation details in the header file, hence we just > go with regression tests for now. > > R=ahaas@chromium.org, titzer@chromium.org > > Bug: v8:6600, chromium:782280 > Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee > Reviewed-on: https://chromium-review.googlesource.com/758772 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49286} Bug: v8:6600, chromium:782280 Change-Id: I82a75bfeaf83dc63a2917da3ccdc4721c5d689e7 Reviewed-on: https://chromium-review.googlesource.com/763387Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49292}
-
Igor Sheludko authored
Bug: v8:5799 Change-Id: I782ec131c7194aef20942a19750168a974913c3f Reviewed-on: https://chromium-review.googlesource.com/757337 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49291}
-
Jakob Gruber authored
This reverts commit 9664d017. Reason for revert: Planned revert, this is on Canary 3264 and V8 branch 6.4.245. Original change's description: > [snapshot] Flip --lazy-handler-deserialization > > Flip this for a day or two to gather perf bot results & stability > issues. Results will be collected in https://crbug.com/782637. > > TBR=hablich@chromium.org > > Bug: v8:6624, chromium:782637 > Change-Id: I70eb5d6287d4723f935715ef80d9ba129dc282f0 > Reviewed-on: https://chromium-review.googlesource.com/758375 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49222} TBR=hablich@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6624, chromium:782637 Change-Id: I2a6ee63f7191d186810d7352ee63b6b664e74157 Reviewed-on: https://chromium-review.googlesource.com/763427 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49290}
-
Clemens Hammacher authored
This reverts commit 6c613288. Reason for revert: breaks compilation on win64 bot: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/69 Original change's description: > [Liftoff] Implement parallel register moves > > This was not implemented so far, leading to lots of clusterfuzz issues. > Testing this feature would require complicating the interface a lot and > exposing more implementation details in the header file, hence we just > go with regression tests for now. > > R=ahaas@chromium.org, titzer@chromium.org > > Bug: v8:6600, chromium:782280 > Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee > Reviewed-on: https://chromium-review.googlesource.com/758772 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49286} TBR=titzer@chromium.org,ahaas@chromium.org,clemensh@chromium.org Change-Id: I386983da7f9f03d54cef2190b01fd2cc5785966e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:782280 Reviewed-on: https://chromium-review.googlesource.com/763367Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49289}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1c66ba1..3dd2b5f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I345def7a1ade64accc9570b8c8af6f0514058da1 Reviewed-on: https://chromium-review.googlesource.com/763130Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49288}
-
Michael Starzinger authored
R=hpayer@chromium.org BUG=v8:6792 Change-Id: Iba360a83c8c1d929c29c0a4e0c5f32cef8755c85 Reviewed-on: https://chromium-review.googlesource.com/758650Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49287}
-
Clemens Hammacher authored
This was not implemented so far, leading to lots of clusterfuzz issues. Testing this feature would require complicating the interface a lot and exposing more implementation details in the header file, hence we just go with regression tests for now. R=ahaas@chromium.org, titzer@chromium.org Bug: v8:6600, chromium:782280 Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee Reviewed-on: https://chromium-review.googlesource.com/758772Reviewed-by:
-
Camillo Bruni authored
- Implement exchangeable timer clock for RuntimeCallStats for testing - Rewrite RuntimeCAllStatsTest to overwrite the default RCS timer This gets rid of the previous flakiness for these tests due to using the real platform timer. Bug: v8:5677 Change-Id: Iff312c7f79ab97407ba1c0c2c72fb0b35a5efdf1 Reviewed-on: https://chromium-review.googlesource.com/760416Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49285}
-
Mathias Bynens authored
The DEPS roll in f3a2e34d updated ICU to a version that includes a fix for https://ssl.icu-project.org/trac/ticket/13462. As a result, our Script_Extension data is now correct again. This patch re-enables the Test262 tests that were failing due to this ICU data bug. BUG=v8:4743 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: If0f08693ed0355c59b9c02aa6d941dab1588431c Reviewed-on: https://chromium-review.googlesource.com/761616Reviewed-by:
-
Georg Neis authored
There were some places left where that could happen. Bug: chromium:782754 Change-Id: I1db1f5b361cdf443b730a220c0e569ad48dd298d Reviewed-on: https://chromium-review.googlesource.com/758841Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1cfb9fe..1c66ba1 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/73ddd64..93a751e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I05cc6e607da1ae1f7afbd147735a5ccb83e9d6e6 Reviewed-on: https://chromium-review.googlesource.com/762988Reviewed-by:
-
- 09 Nov, 2017 29 commits
-
-
Sergiy Byelozyorov authored
This came up in https://crrev.com/c/758410 R=machenbach@chromium.org Change-Id: Ia6849a34962628fb17ef61b803f10a1e7c334cd9 Reviewed-on: https://chromium-review.googlesource.com/758852Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49281}
-
Myles Borins authored
Fixes .gyp scaffolding for building on Windows. Patch from Refael Ackermann <refack@gmail.com>. https://github.com/nodejs/node/pull/16848/commits/5528afd073efe3fe4f5019887f30134d649abc16 Bug=v8:7061 Change-Id: I4faaf3f488b6725942746d74838ef7ce73b1e8d0 Reviewed-on: https://chromium-review.googlesource.com/761477Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#49280}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cfed275..1cfb9fe Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/af046c5..f83c79a Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/b318966..5ed2698 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I03094c38301d65ce0795f9fbc0d8660ffce47f49 Reviewed-on: https://chromium-review.googlesource.com/761321Reviewed-by:
-
Michael Starzinger authored
R=mlippautz@chromium.org BUG=v8:6792 Change-Id: I4b148b4bcb6e3cb73bc58eaad61d52a14da19a35 Reviewed-on: https://chromium-review.googlesource.com/760739Reviewed-by:
-
Michael Lippautz authored
Removes the handling of the flag independent. The flag will be removed in a followup. The patch changes handling of V8::PersistentBase that are set to Weak: - The Scavenger ignores the flag independent. - The Scavenger keeps alive anything that is marked as Active. - The Scavenger is free to drop weak handles of non-Active object if they are otherwise dead. Active: - Any JSObject will always be marked Active. - Any JSApiObject will be marked Active if it has been modified (=has elements, properties, etc.) CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: chromium:780749 Change-Id: If1f547f2419930ad9400bd3b11bdbf609cb57649 Reviewed-on: https://chromium-review.googlesource.com/741801 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Converts the ast prettyprinter to printing literals from the raw values rather than internalized on-heap strings. This enables ast printing before internalizing, and means we can avoid use of the isolate in the interpreter's off-thread phase. Also removes --print-builtin-ast and relies on just --print-ast to print everything. Finally, converts FunctionLiteral's debug_name function to return a char[] which is created from the raw name literal where it exists, rather than relying on the value having been internalized. BUG=v8:5203 Change-Id: Ib69f754e254736f415db38713e6209465817e6f1 Reviewed-on: https://chromium-review.googlesource.com/758681Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49276}
-
Martyn Capewell authored
Align the claimed arguments in Generate_JSConstructStubGeneric by pushing an extra copy of the receiver as padding. Bug: v8:6644 Change-Id: I77e92624ff32c21c8f3f310176aa2576c756b56c Reviewed-on: https://chromium-review.googlesource.com/757098 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Id13b0d84ee255d12ecaf4a30479e7c7173462d5c Reviewed-on: https://chromium-review.googlesource.com/760360Reviewed-by:
-
Bill Budge authored
This is a reland of 7e78506f Original change's description: > [Memory] Use OS::Allocate for all OS memory allocations. > > - Eliminates OS::ReserveRegion and OS::ReserveAlignedRegion. > - Changes OS::Allocate to take alignment parameter, reorders parameters > to match page_allocator. > - Since the size of memory allocation can be deduced, don't return the > amount of memory allocated. > - Changes reservation of aligned address space. Before we would reserve > (size + alignment) rounded up to page size. This is too much, because > maximum misalignment is (alignment - page_size). > - On Windows and Cygwin, we release an oversize allocation and > immediately retry at the aligned address in the allocation. If we > lose the address due to a race, we just retry. > - Clean up all the calls to OS::Allocate in codegen and tests by adding > helper AllocateSystemPage function (allocation.h) and > AllocateAssemblerBuffer (cctest.h). > - Changes 'assm' to 'masm' in some targets for consistency when using > a macro-assembler. > > Bug: chromium:756050 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I306dbe042cc867670fdc935abca29db074b0da71 > Reviewed-on: https://chromium-review.googlesource.com/749848 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49235} Bug: chromium:756050 Change-Id: I333f7a6aea0bcb608d01cafb43e94893a4625b15 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/758509Reviewed-by:
-
Ulan Degenbaev authored
Bug: Change-Id: Ice28172e75a9fce1bad199b13e3fc0c123aaf42f Reviewed-on: https://chromium-review.googlesource.com/758588Reviewed-by:
-
Igor Sheludko authored
This is necessary in order to support class literals boilerplates which will contain descriptor arrays not attached to maps. This CL introduces Heap::descriptor_array_map() which will be used only for descriptor arrays templates created as a part of class literal boilerplate. We don't use the new map for all descriptors for now because in order to handle chicken-egg problem in deserializer which can be solved in a clean and readable way only if introduce a DESCRIPTOR_ARRAY_TYPE instance type which we can't currently do because the InstanceType enum is already "full". Bug: v8:5799 Change-Id: I732d236b0dda2c436ab3ce3ac5967f6c66162df3 Reviewed-on: https://chromium-review.googlesource.com/758360 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Eric Holk authored
This was meant to be included in https://crrev.com/c/757129 but got missed somehow. The fuzzer was generating i64.store instructions with an i32 value argument instead of i64 like it should be. Bug: Change-Id: I5b5bcdb22b2ac3abe872e7ff0ab0019b5ecb9c98 Reviewed-on: https://chromium-review.googlesource.com/759148Reviewed-by:
-
Michael Starzinger authored
R=mvstanton@chromium.org Change-Id: Iff5a3741ba93ea2cc9d4b9f9907b22ce768b1cb3 Reviewed-on: https://chromium-review.googlesource.com/758840 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49269}
-
jgruber authored
Move block coverage logic for TryCatchStatement and TryFinallyStatement nodes into builder classes. Bug: v8:6000 Change-Id: I0402ef78a54d6ba1bae62214f16aabfebbd7c581 Reviewed-on: https://chromium-review.googlesource.com/758645 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds test coverage for write-protected code pages by adding the feature to the existing "stress_incremental_marking" variant. Since this is considered a temporary state, the variant has not been renamed. R=machenbach@chromium.org BUG=v8:6792 Change-Id: I62fa5aa15bf5309b12fbc269fcf81069845755f9 Reviewed-on: https://chromium-review.googlesource.com/753388Reviewed-by:
-
Georg Neis authored
I made a mistake in yesterday's cleanup. R=jarin@chromium.org Bug: chromium:783051 Change-Id: Iabd7403096197ce8e54d46e079bc9a70aa98578d Reviewed-on: https://chromium-review.googlesource.com/758765 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Andreas Haas authored
Pending exceptions were not cleared when the TurboFan result was not compared to the Interpreter result, which happens when the result may be affected by potential nondeterminism. With this CL we always clear pending exceptions. R=clemensh@chromium.org Bug: chromium:782267 Change-Id: Ibe9b33c94810cccb6282c6c8dc49748fb79b07e4 Reviewed-on: https://chromium-review.googlesource.com/758272Reviewed-by:
-
Marja Hölttä authored
Bug: Change-Id: I8f82cba33f19c56b169f6bb641bf16301d578a0a Reviewed-on: https://chromium-review.googlesource.com/758368Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#49264}
-
Jaroslav Sevcik authored
Since the deoptimizer generalizes maps for all materialized objects, it must make sure that none of the object's fields contain mutable heap numbers (only double fields are allowed to point to mutable heap numbers). With this CL, we simply change any mutable heap numbers in property arrays to immutable ones. This could be dangerous if some non-materialized object could point to this property array, but this cannot happen because interpreter registers cannot refer to naked property arrays. Bug: chromium:776309 Change-Id: I897b604fa804de673710cfa3ba0595dbd9f80eeb Reviewed-on: https://chromium-review.googlesource.com/759781Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49263}
-
Tobias Tebbi authored
This reverts commit ac0661b3. Reason for revert: Clusterfuzz unhappy: chromium:783019 chromium:783035 Original change's description: > Reland^5 "[turbofan] eagerly prune None types and deadness from the graph" > > This gives up on earlier attempts to interpret DeadValue as a signal of > unreachable code. This does not work because free-floating dead value > nodes, and even pure branch nodes that use them, can get scheduled so > early that they get reachable. Instead, we now eagerly remove branches > that use DeadValue in DeadCodeElimination and replace DeadValue inputs > to value phi nodes with dummy values. > > Reland of https://chromium-review.googlesource.com/715716 > > Bug: chromium:741225 chromium:776256 > Change-Id: I251efd507c967d4a8882ad8fd2fd96c4185781fe > Reviewed-on: https://chromium-review.googlesource.com/727893 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49188} TBR=jarin@chromium.org,tebbi@chromium.org Bug: chromium:741225 chromium:776256 chromium:783019 chromium:783035 Change-Id: I6a8fa3a08ce2824a858ae01817688e63ed1f442e Reviewed-on: https://chromium-review.googlesource.com/758770Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#49262}
-
Michael Starzinger authored
R=machenbach@chromium.org BUG=v8:6792 NOTREECHECKS=true NOTRY=true Change-Id: I878b11c6bddeca59ff49bfa88031a4ce15507e04 Reviewed-on: https://chromium-review.googlesource.com/759039Reviewed-by:
-
Mathias Bynens authored
This is a reland of 0db90bc5 Original change's description: > [regexp] Include unicode/uvernum.h in parser > > This patch explicitly includes unicode/uvernum.h in the regular > expression parser. > > It should be removed once we no longer need to check > `U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js > updates their ICU. This is an ongoing effort: > https://github.com/nodejs/node/pull/16876 > > BUG=v8:4743 > > Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58 > Reviewed-on: https://chromium-review.googlesource.com/758407 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49253} Bug: v8:4743 Change-Id: Id3f375f27fb5eaa4129884f99095d16763bd6e86 Reviewed-on: https://chromium-review.googlesource.com/758861Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Change-Id: I5b82f56e9b9d894455500de693fe6ac6de5205ae Reviewed-on: https://chromium-review.googlesource.com/758764 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Mostyn Bramley-Moore authored
assembler-arm64.h and assembler-arm64-inl.h have a B() function which conflicts with the B macro in bytecode-utils.h. Headers that leak macros can be annoying to deal with, in this case we can't simply undef B at the end of source files that include bytecode-utils.h because the second source file that includes bytecode-utils.h won't see the B macro. Let's just move this macro into the two unittest files that include this header. Bug: chromium:746958 Change-Id: I588b73fe81615f882a0e010c92ba187d3bc2bf25 Reviewed-on: https://chromium-review.googlesource.com/758779 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
-
Michael Starzinger authored
This turns the deoptimization entries from free-floating memory chunks that were not considered part of the heap into true {Code} objects. By marking them as immovable we get the same guarantees without the need for side-stepping heap API methods. R=jarin@chromium.org BUG=v8:6792 Change-Id: I88e1795e52fb586f7ca960d08cd6d9d082f4df9b Reviewed-on: https://chromium-review.googlesource.com/756851Reviewed-by: -
Michal Majewski authored
Bug: v8:6917 Change-Id: I7dae0715264cdf9f963f2454b101f6260d8493ff Reviewed-on: https://chromium-review.googlesource.com/758837Reviewed-by:
-
Yang Guo authored
This reverts commit 0db90bc5. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/17335 You need to also check whether i18n is on, e.g. #ifdef V8_INTL_SUPPORT. Original change's description: > [regexp] Include unicode/uvernum.h in parser > > This patch explicitly includes unicode/uvernum.h in the regular > expression parser. > > It should be removed once we no longer need to check > `U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js > updates their ICU. This is an ongoing effort: > https://github.com/nodejs/node/pull/16876 > > BUG=v8:4743 > > Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58 > Reviewed-on: https://chromium-review.googlesource.com/758407 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49253} TBR=yangguo@chromium.org,jshin@chromium.org,jgruber@chromium.org,mathias@chromium.org Change-Id: I58d6b7a49b707c97153b8b0aec141248f5c669e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:4743 Reviewed-on: https://chromium-review.googlesource.com/759777Reviewed-by:
-
jgruber authored
This was originally introduced to reuse large handlers, but now only LdaContextSlot and LdaCurrentContextSlot remain (both roughly 2-300 bytes in size). Since handler reuse complicates lazy (de)serialization and currently doesn't seem to give us significant advantages, let's remove this. Bug: v8:6624 Change-Id: I6f19952632e10bd67677a825bbcb46d580a9d5c8 Reviewed-on: https://chromium-review.googlesource.com/758642Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49254}
-
Mathias Bynens authored
This patch explicitly includes unicode/uvernum.h in the regular expression parser. It should be removed once we no longer need to check `U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js updates their ICU. This is an ongoing effort: https://github.com/nodejs/node/pull/16876 BUG=v8:4743 Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58 Reviewed-on: https://chromium-review.googlesource.com/758407Reviewed-by:
-
