- 28 Jun, 2016 10 commits
-
-
yangguo authored
Removing a bad test case because: - The test case makes wrong assumptions about compilation. We now may run bytecode with the interpreter. - The test exposes internal implementation details such as pc offset of JIT code. - The test uses a runtime function specially written to cater to, and used only by this test. Being unmaintained, this runtime function is already returning bogus results, making this test useless. R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2101223002 Cr-Commit-Position: refs/heads/master@{#37312}
-
neis authored
R=adamk@chromium.org BUG= Review-Url: https://codereview.chromium.org/2081733004 Cr-Commit-Position: refs/heads/master@{#37311}
-
neis authored
When calling the return method on a generator suspended inside a yield*, yield* in turn calls return on its iterable. If this results in a "done" iterator, yield* must return immediately, thus terminating the generator. For some reason, we didn't terminate the generator but continued right after the yield*. R=adamk@chromium.org BUG=v8:5131 Review-Url: https://codereview.chromium.org/2100093002 Cr-Commit-Position: refs/heads/master@{#37310}
-
yangguo authored
R=bmeurer@chromium.org, jgruber@chromium.org BUG=v8:5117 Review-Url: https://codereview.chromium.org/2095893002 Cr-Commit-Position: refs/heads/master@{#37309}
-
bjaideep authored
variable hz is defined as a macro in AIX system header /usr/include/sys/m_param.h (as "ticks per second of the clock"). The pre-processor replaces hz with the numeric value defined in system header file and therefore emits an error. Re-naming variable name to "iz". R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2104483002 Cr-Commit-Position: refs/heads/master@{#37308}
-
zhengxing.li authored
port c1d01aea (r37086) original commit message: Compilation of wasm functions happens before instantiation. Imports are linked afterwards, at instantiation time. Globals and memory are also allocated and then tied in via relocation at instantiation time. This paves the way for implementing Wasm.compile, a prerequisite to offering the compiled code serialization feature. Currently, the WasmModule::Compile method just returns a fixed array containing the code objects. More appropriate modeling of the compiled module to come. Opportunistically centralized the logic on how to update memory references, size, and globals, since that logic is the exact same on each architecture, except for the actual storing of values back in the instruction stream. BUG= Review-Url: https://codereview.chromium.org/2100393003 Cr-Commit-Position: refs/heads/master@{#37307}
-
bmeurer authored
Add NumberAbs operator to implement an inline version of Math.abs, that can be optimized and eliminated. We don't use any speculation here, but for now stick to the information we can infer (this way we avoid the inherent deopt loops that Crankshaft has around Math.abs). CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel R=jarin@chromium.org BUG=v8:5086 Review-Url: https://codereview.chromium.org/2096403002 Cr-Commit-Position: refs/heads/master@{#37306}
-
v8-autoroll authored
Rolling v8/build to 87e063014aa0f343b15f5de495a28e5f8572bf8d Rolling v8/tools/clang to 2ad431ac7823581e1f39c5b770704e1e1ca6cb32 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2101893002 Cr-Commit-Position: refs/heads/master@{#37305}
-
zhengxing.li authored
port c781e831 (r37072) original commit message: Import base::ieee754::cos() and base::ieee754::sin() from fdlibm and introduce Float64Cos and Float64Sin TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.cos() and Math.sin() as TurboFan builtins and use those operators to also inline Math.cos() and Math.sin() into optimized TurboFan functions. BUG= Review-Url: https://codereview.chromium.org/2105613002 Cr-Commit-Position: refs/heads/master@{#37304}
-
mattloring authored
Reland of Include file names in trace_turbo output (patchset #1 id:1 of https://codereview.chromium.org/2083153004/ ) Reason for revert: Ready to test fix and reland. Original issue's description: > Revert of Include file names in trace_turbo output (patchset #3 id:40001 of https://codereview.chromium.org/2083863004/ ) > > Reason for revert: > Many build bots are failing with a message of the form: > > Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json > > Can be relanded once we understand why these failures are occuring. > > Original issue's description: > > Include file names in trace_turbo output > > > > The trace turbo output will overwrite itself when functions in different > > files share the same name. Output files now have the form > > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`. > > > > R=ofrobots@google.com > > BUG= > > > > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba > > Cr-Commit-Position: refs/heads/master@{#37199} > > TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a > Cr-Commit-Position: refs/heads/master@{#37204} TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org,machenbach@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2081323007 Cr-Commit-Position: refs/heads/master@{#37303}
-
- 27 Jun, 2016 30 commits
-
-
caitpotter88 authored
In addition to recording the BindingPattern error, also record an AsyncArrowFormalParameters error for shorthand property "await" in object literals. BUG=v8:4483, v8:5148 R=littledan@chromium.org, jwolfe@igalia.com, adamk@chromium.org, nikolaos@chromium.org Review-Url: https://codereview.chromium.org/2100623002 Cr-Commit-Position: refs/heads/master@{#37302}
-
ddchen authored
When reading malformed input, the length of variable-length types can be very large. Computing operand length with this and adding it to PC will overflow and screw up decode. This patch switches to unsigned int for arity and lengths, terminates loop analysis on error, adds overflow checking to BranchTableOperand, and adds a unit test. Review-Url: https://codereview.chromium.org/2052623003 Cr-Commit-Position: refs/heads/master@{#37301}
-
bjaideep authored
Constantpool register is being used with no frame, and therefore it points to its parent stub's constantpool causing segfault. Disable constantpool before CallStub if frame not set. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2106493002 Cr-Commit-Position: refs/heads/master@{#37300}
-
machenbach authored
Revert of Refactor CreateApiFunction (patchset #2 id:20001 of https://codereview.chromium.org/2095953002/ ) Reason for revert: [Sheriff] Changes a layout test. Please rebase upstream if intended: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7742 Original issue's description: > Refactor CreateApiFunction > > BUG= > > Committed: https://crrev.com/705574970f3899a6eda0c61130c8c31693df4039 > Cr-Commit-Position: refs/heads/master@{#37290} TBR=jochen@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2099983004 Cr-Commit-Position: refs/heads/master@{#37299}
-
mythria authored
Removes failure expectation for observer-expectations layout test. BUG=v8:4280,v8:5096 LOG=N Review-Url: https://codereview.chromium.org/2094353002 Cr-Commit-Position: refs/heads/master@{#37298}
-
bbudge authored
Replaces ArchDefault method with Crankshaft and Turbofan getters. Eliminates IsAllocated method on Register, FloatRegister, DoubleRegister. Eliminates ToString method too. Changes call sites to access appropriate arch default RegisterConfiguration. LOG=N BUG= Review-Url: https://codereview.chromium.org/2092413002 Cr-Commit-Position: refs/heads/master@{#37297}
-
ssanfilippo authored
the .eh_frame format as part of the jitdump generated when FLAG_perf_prof is enabled. The final goal is allowing precise unwinding of callchains that include JITted code when profiling V8 using perf. Unwinding information is stored in the body of code objects after the code itself, prefixed with its length and aligned to a 8-byte boundary. A boolean flag in the header signals its presence, resulting in zero memory overhead when the generation of unwinding info is disabled or no such information was attached to the code object. A new jitdump record type (with id 4) is introduced for specifying optional unwinding information for code load records. The EhFrameHdr struct is also introduced, together with a constructor to initialise it from the associated code object. At this stage no unwinding information is written to the jitdump, but the infrastructure for doing so is ready in place. BUG=v8:4899 LOG=N Review-Url: https://codereview.chromium.org/1993653003 Cr-Commit-Position: refs/heads/master@{#37296}
-
ivica.bogosavljevic authored
BUG= Review-Url: https://codereview.chromium.org/2069933003 Cr-Commit-Position: refs/heads/master@{#37295}
-
mstarzinger authored
This adds a missing lazy bailout point when defining data properties with computed property names in object literals. The runtime call to Runtime::kDefineDataPropertyInLiteral can trigger deopts. The necessary bailout ID already exists and is now properly used. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-621816 BUG=chromium:621816 Review-Url: https://codereview.chromium.org/2099133003 Cr-Commit-Position: refs/heads/master@{#37294}
-
franzih authored
Instead of a JS implementation that calls C++ runtime functions, migrate String.fromCodePoint() to C++. BUG=v8:5049 Review-Url: https://codereview.chromium.org/2038563003 Cr-Commit-Position: refs/heads/master@{#37293}
-
jochen authored
R=yangguo@chromium.org,danno@chromium.org BUG= Review-Url: https://codereview.chromium.org/2094293002 Cr-Commit-Position: refs/heads/master@{#37292}
-
ishell authored
This is a building block for GetPropertyStub. It supports querying fast, slow and global objects without native accessors and interceptors. BUG=v8:4911 LOG=Y Review-Url: https://codereview.chromium.org/2079823002 Cr-Commit-Position: refs/heads/master@{#37291}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2095953002 Cr-Commit-Position: refs/heads/master@{#37290}
-
franzih authored
Proxy objects need special treatment in toString(). Usually, we use the @@toStringTag, if it is set, otherwise we determine the result of toString() by checking IsArray() and other internal slots. According to ES2017 19.1.3.6, IsArray() and the internal slots must be checked first, then get(@@toStringTag). The result of IsArray() and internal slots is discarded if @@toStringTag is set. For proxy objects, we must obey this order, because get() can have side-effects, i.e., revoke the proxy. For all other objects, we can skip the check of the internal slots, if @@toStringTag is set. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2090773006 Cr-Commit-Position: refs/heads/master@{#37289}
-
bbudge authored
- Add a const bool kSimpleFPAliasing variable for each platform so it's easier for the compiler to eliminate dead code. - Modify RegisterAllocator to use it. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2101473002 Cr-Commit-Position: refs/heads/master@{#37288}
-
machenbach authored
This adds generate-bytecode-expectations and parser_shell. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2102483002 Cr-Commit-Position: refs/heads/master@{#37287}
-
jochen authored
This superseeds all-can-read/all-can-write properties BUG=chromium:618305 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2087823002 Cr-Commit-Position: refs/heads/master@{#37286}
-
bbudge authored
Removes OperandConverter::*Float32* and *Float64* methods. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2091973002 Cr-Commit-Position: refs/heads/master@{#37285}
-
mlippautz authored
BUG=chromium:581412 LOG=N R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2094753002 Cr-Commit-Position: refs/heads/master@{#37284}
-
franzih authored
We can check if the instance type of an object is JS_PROMISE_TYPE to determine if it is a promise rather than test whether the property promise_state_symbol is present. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2091243002 Cr-Commit-Position: refs/heads/master@{#37283}
-
zhengxing.li authored
port f5b83dec (r37061) original commit message: As a first step towards showing builtin frames in stack traces, we will now push target and new target unconditionally. Since the various specializations of BuiltinArguments are made redundant by this change, we can remove them and all related code. BUG= Review-Url: https://codereview.chromium.org/2095323002 Cr-Commit-Position: refs/heads/master@{#37282}
-
neis authored
R=littledan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2088813002 Cr-Commit-Position: refs/heads/master@{#37281}
-
neis authored
R=adamk@chromium.org BUG= Review-Url: https://codereview.chromium.org/2081163002 Cr-Commit-Position: refs/heads/master@{#37280}
-
franzih authored
Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro generated functions Object::IsJSError() and HeapObject::IsJSError(). BUG= Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b Cr-Commit-Position: refs/heads/master@{#37244} CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2090333002 Cr-Commit-Position: refs/heads/master@{#37279}
-
ishell authored
The global object can be loaded from the native context and the name can be loaded in the type feedback metadata. BUG=chromium:576312 Review-Url: https://codereview.chromium.org/2096653003 Cr-Commit-Position: refs/heads/master@{#37278}
-
zhengxing.li authored
port 4d4eb611 (r37058) original commit message: BUG= Review-Url: https://codereview.chromium.org/2097323002 Cr-Commit-Position: refs/heads/master@{#37277}
-
franzih authored
BUG=623021 Review-Url: https://codereview.chromium.org/2099923002 Cr-Commit-Position: refs/heads/master@{#37276}
-
zhengxing.li authored
port 198e09de (r37053) original commit message: Construct a BUILTIN frame before throwing an exception from runtime. BUG= Review-Url: https://codereview.chromium.org/2094223002 Cr-Commit-Position: refs/heads/master@{#37275}
-
machenbach authored
Fix after: https://codereview.chromium.org/2060743002/ https://codereview.chromium.org/2086653003/ BUG=v8:5086, v8:5092, v8:4124 TBR=bmeurer@chromium.org, yangguo@chromium.org, bbudge@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2095313002 Cr-Commit-Position: refs/heads/master@{#37274}
-
bmeurer authored
If we know that a constant can be represented as word32, then we don't need to insert a checked conversion, but just change the constant appropriately. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2100063002 Cr-Commit-Position: refs/heads/master@{#37273}
-