- 14 Sep, 2009 2 commits
-
-
sgjesse@chromium.org authored
The main piece of this change was to add support for break on return for ARM. On ARM the normal js function return consist of the following code sequence. mov sp, fp ldmia sp!, {fp, lr} add sp, sp, #4 bx lr to a call to the debug break return entry code using the following code sequence mov lr, pc ldr pc, [pc, #-4] <debug break return entry code entry point address> bktp 0 The values of Assembler::kPatchReturnSequenceLength and Assembler::kPatchReturnSequenceLength are somewhat misleading, but they fit the current use in the debugger. Also Assembler::kPatchReturnSequenceLength is used in the IC code as well (for something which is not related to return sequences at all). I will change that in a separate changelist. For the debugger to work also added recording of the return sequence in the relocation info and handling of source position recording when a function ends with a return statement. Used the constant kInstrSize instead of sizeof(Instr). Passes all debugger tests on both simulator and hardware (only release mode tested on hardware). Review URL: http://codereview.chromium.org/199075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2879 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
Review URL: http://codereview.chromium.org/194100 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2878 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Sep, 2009 4 commits
-
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/200096 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2877 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/192075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
The SCons build now has the options profilingsupport and debuggersupport for controlling the setting of the defines ENABLE_LOGGIGN_AND_PROFILING and ENABLE_DEBUGGER_SUPPORT. By default both are set to true. The changes to the XCode project have not been tested. Review URL: http://codereview.chromium.org/195061 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2875 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
If there is a local cpplint.py in the tools directory use this instead of any cpplint in the path. This makes it possible to run presubmit checks on Windows by downloading cpplint.py from http://code.google.com/p/google-styleguide/. Review URL: http://codereview.chromium.org/194039 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2874 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Sep, 2009 7 commits
-
-
ager@chromium.org authored
TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/203017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2873 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
TBR=lrn@chromium.org Review URL: http://codereview.chromium.org/201078 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2872 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
This new option is convenient for cross-compilation as actually running the targets build does not make sense. Review URL: http://codereview.chromium.org/200077 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2871 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Use the code patcher for the patching of the JS return sequence used by the debugger. Added explicit instruction cache flushing in a code patching section which did not have it for completeness, even though it is not required on Intel processors. Review URL: http://codereview.chromium.org/203016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2870 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
lrn@chromium.org authored
First step in changing Smi representation. Review URL: http://codereview.chromium.org/196077 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2869 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/197057 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
christian.plesner.hansen@gmail.com authored
Instead of crashing or reporting a fatal v8 error if an error occurs during context initialization we now survive and return an empty handle. Review URL: http://codereview.chromium.org/194070 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2867 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2009 19 commits
-
-
ager@chromium.org authored
TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/201069 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2865 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Removed implementation of function which was no longer member of class Debug. TBR=lrn@chromium.org Review URL: http://codereview.chromium.org/199063 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2864 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Got rid of the debug break on return entry code which did not add anything. It just jumped directly to the debug break on return code. Removed the CodePatcher class on x64 as it was not implemented. Added instruction cache flush to where the return sequence was patched on x64. Added some missing ENABLE_DEBUGGER_SUPPORT #ifdef/#endif. Review URL: http://codereview.chromium.org/193057 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2863 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
The algorithm for finding the inner-most function containing a script break point was not correct when the script only contained one function. In that case the script function and not the actual function in the script could be returned depending on the order of the objects in the heap. TEST=cctest/test-debug/ScriptBreakPointReload BUG=none Review URL: http://codereview.chromium.org/193059 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2862 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
Review URL: http://codereview.chromium.org/200059 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2861 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kasperl@chromium.org authored
TBR=ager@chromium.org Review URL: http://codereview.chromium.org/195038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2860 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
Also: - move constructor name getter near similar class name getter method; - if the constructor is not present, use 'Object', as for class name, this eliminates a special case. Review URL: http://codereview.chromium.org/202018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2859 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
followed by shrinking of new space earlier. Review URL: http://codereview.chromium.org/199057 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2858 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
This reduces the initial V8 memory usage by roughly 2MB. Review URL: http://codereview.chromium.org/194054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2856 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
TBR=ager@chromium.org Review URL: http://codereview.chromium.org/193056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2855 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
TBR=yurys@chromium.org Review URL: http://codereview.chromium.org/197056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2854 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
erik.corry@gmail.com authored
Review URL: http://codereview.chromium.org/199056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2853 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
christian.plesner.hansen@gmail.com authored
Safari. Fixed const error in api. Review URL: http://codereview.chromium.org/200056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2852 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
Doing so makes the max new space size influence the initial total size of the heap. This change reduces the initial memory use of V8 by over 6MB. Review URL: http://codereview.chromium.org/202017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2851 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
Support stepping out for recursive functions.Simply flooding JS function from the calling stack frame with one shot breakpoints is not enough to support step out action in all cases since the function on top of the stack may be turn recursive and we may end up flooding itself. To overcome this a pointer to the stack frame where the debugger should be invoked after stepping out is strored in the debugger.Chromium bug:http://code.google.com/p/chromium/issues/detail?id=17967 Review URL: http://codereview.chromium.org/200041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2850 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
TBR=ager@chromium.org Review URL: http://codereview.chromium.org/201059 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2849 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
memory usage in Chromium 64-bit Linux. Review URL: http://codereview.chromium.org/200055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2848 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Review URL: http://codereview.chromium.org/195024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2847 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Sep, 2009 6 commits
-
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/196042 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2846 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
lrn@chromium.org authored
(Not yet fully functional) Review URL: http://codereview.chromium.org/201042 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2845 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
Removed a false assertion in ScopeIterator that assumed context extension to never be a JSContextExtensionObject. The context extension object in a 'with' context is JSContextExtensionObject iff the 'with' statement is generated from a catch block in order to extend its local scope with a variable holding exception object. This is how we differentiate 'catch' scope from 'with' scope. Chrome bug: http://code.google.com/p/chromium/issues/detail?id=17229 Review URL: http://codereview.chromium.org/202005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2843 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/190004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2842 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kasperl@chromium.org authored
in old space. Before this change we would compute the fragmentation limit before the GC, but that means that we take all the garbage into account - and consequently we almost never hit the limit (because we have a lot of garbage). This change changes the policy to compact on the *next* GC if we determine that we have too much fragmentation after doing a GC. We'll do a GC if we've wasted more than 1MB and more than 15% of the old space size. This can be further improved by computing whether or not to compact during the marking phase. Review URL: http://codereview.chromium.org/202008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
http://crbug.com/18639kasperl@chromium.org authored
was fixed in r2642. Review URL: http://codereview.chromium.org/192037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Sep, 2009 2 commits
-
-
sgjesse@chromium.org authored
This is an attempth to address the flakiness of the test cctest/test-debug/DebuggerAgent on the Mac build-bot. Review URL: http://codereview.chromium.org/200037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
christian.plesner.hansen@gmail.com authored
Author: abdulla <abdulla.kamar@gmail.com> Review URL: http://codereview.chromium.org/173262 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-