Commits · 3419aefe5d36b75281686627d8cea954f0f88f82 · Linshizhi / V8

12 Jun, 2014 13 commits

Do away with variable length memcpy to Set/Get registers in simulator · 3419aefe

svenpanne@chromium.org authored Jun 12, 2014

About a 32% boost.

Before - 5:31

Richards: 84.5
DeltaBlue: 128
Crypto: 65.3
RayTrace: 203
EarleyBoyer: 149
RegExp: 23.4
Splay: 121
NavierStokes: 98.9
----
Score (version 7): 93.8

After - 4:10

Richards: 107
DeltaBlue: 175
Crypto: 93.9
RayTrace: 258
EarleyBoyer: 186
RegExp: 32.7
Splay: 165
NavierStokes: 124
----
Score (version 7): 124

R=jacob.bramley@arm.com, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21448

Review URL: https://codereview.chromium.org/213943002

Patch from Fritz Koenig <frkoenig@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3419aefe

Revert "Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen"" · 634cb5e8

danno@chromium.org authored Jun 12, 2014

This CL tickled an unrelated arm64 bug which was is fixed separately.

The MIPS port (originally landed 21784) is also included.

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/331633002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

634cb5e8

Remove duplicate code in SetPropertyPostInterceptor · 9fa48abd

verwaest@chromium.org authored Jun 12, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/314673002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9fa48abd

Revert "Rename kIs64BitArch with kRequiresCodeRange." · 546b3e55

danno@chromium.org authored Jun 12, 2014

TBR=haitao.feng@intel.com

Review URL: https://codereview.chromium.org/325343003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

546b3e55

Rename kIs64BitArch with kRequiresCodeRange. · 1562d8e3

haitao.feng@intel.com authored Jun 12, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/335473003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1562d8e3

Remove unnecessary HCompareNumericAndBranch when generating HShr instruction. · 4891950b

haitao.feng@intel.com authored Jun 12, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/334573003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21799 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4891950b

Fix register mixup in arm64's Crankshafted typeof() == 'object' · 87323779

danno@chromium.org authored Jun 12, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/330593003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

87323779

Add @@iterator for generator objects · 8e165acb

wingo@igalia.com authored Jun 12, 2014

R=arv@chromium.org, rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/328093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21797 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8e165acb

Revert "MIPS: Reland 21774: Generate KeyedLoadGeneric with Hydrogen" · 07f6d619

machenbach@chromium.org authored Jun 12, 2014

This reverts commit r21784 as the original CL also got reverted.

BUG=
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/329973002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

07f6d619

filter cross context eval · 44b0e211

dcarney@chromium.org authored Jun 12, 2014

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/294073002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21793 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

44b0e211

Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen" · c17e7929

danno@chromium.org authored Jun 12, 2014

Due to lingering arm64 failures in Test262

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/332663003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21790 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c17e7929

Fix detection of VFP3D16 on Galaxy Tab 10.1. · 0d11cb3e

bmeurer@chromium.org authored Jun 12, 2014

BUG=v8:3387
LOG=y
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/329963002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d11cb3e

Drop unused v8threads include from platform files · 8eacf4e7

jochen@chromium.org authored Jun 12, 2014

BUG=none
R=marja@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/323303002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21788 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8eacf4e7

11 Jun, 2014 27 commits

X87: add OWNERS file · 3c4a6d1b

weiliang.lin@intel.com authored Jun 11, 2014

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/323413002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21785 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3c4a6d1b

MIPS: Reland 21774: Generate KeyedLoadGeneric with Hydrogen · 6b318947

palfia@homejinni.com authored Jun 11, 2014

Port r21781 (4869c528)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/327373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21784 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6b318947

Whitespace change to trigger bots. · 6803022a

machenbach@chromium.org authored Jun 11, 2014

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/330573002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6803022a

Whitespace change to trigger bots. · b4226acc

machenbach@chromium.org authored Jun 11, 2014

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/330563002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4226acc

Reland 21774: Generate KeyedLoadGeneric with Hydrogen · 905d777d

danno@chromium.org authored Jun 11, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/57123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21781 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

905d777d

MIPS: Fixed flooring division by a power of 2, once again... · b0b10ec7

plind44@gmail.com authored Jun 11, 2014

Port r21769 (52e191b)

Original commit message:
Avoid right shifts by zero bits: On ARM it actually means shifting by
32 bits (correctness issue) and on other platforms they are useless
(performance issue). This is fix for the fix in r20544.

BUG=v8:3259
LOG=y
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/322403006

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21780 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b0b10ec7

Drop globals.h include from platform.h · 4e336430

jochen@chromium.org authored Jun 11, 2014

Also delete dead cpu-features-implied-by-platform code.

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/326333002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21779 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4e336430

verwaest@chromium.org authored Jun 11, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/324383005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21778 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7bbe963a

MIPS: Revert 21774: "Generate KeyedLoadGeneric with Hydrogen" · ea9c67d6

plind44@gmail.com authored Jun 11, 2014

Port r21776 (10a4872)

Original commit message:
Due to arm64 and GCMole failures

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/329723007

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21777 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea9c67d6

Revert 21774: "Generate KeyedLoadGeneric with Hydrogen" · 006bdafe

danno@chromium.org authored Jun 11, 2014

Due to arm64 and GCMole failures

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/329253003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

006bdafe

MIPS: Generate KeyedLoadGeneric with Hydrogen. · fc620e3d

plind44@gmail.com authored Jun 11, 2014

Port r21774 (f0462b8)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/328173002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21775 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc620e3d

Generate KeyedLoadGeneric with Hydrogen · 3b9039ab

danno@chromium.org authored Jun 11, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/57123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21774 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b9039ab

MIPS: Simplify string copy in SubStringStub. · e832badd

plind44@gmail.com authored Jun 11, 2014

Port r21756 (3d58e58)

Original commit message:
The optimizations are unnecessary since the maximum
string length they operate on is currently 12.

BUG=352155
LOG=N
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/326413002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21773 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e832badd

X87: Simplify string copy in SubStringStub. · 38d1b5c7

weiliang.lin@intel.com authored Jun 11, 2014

port r21756.

original commit message:
  The optimizations are unnecessary since the maximum
  string length they operate on is currently 12.

R=yangguo@chromium.org, bmeurer@chromium.org
  BUG=352155
  LOG=N

Review URL: https://codereview.chromium.org/326353002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21772 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

38d1b5c7

Correctly lookup starting at the holder · 15f719df

verwaest@chromium.org authored Jun 11, 2014

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/329153002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15f719df

Ignore live_edit_ flag when when dealing with LiveEdit in a debug break. · 223e831a

yangguo@chromium.org authored Jun 11, 2014

LiveEdit maybe disabled when we enter the break and again when we
leave it, but enabled in between.

TEST=https://codereview.chromium.org/329533002
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/325183003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

223e831a

Fixed flooring division by a power of 2, once again... · 23fc5b75

svenpanne@chromium.org authored Jun 11, 2014

Avoid right shifts by zero bits: On ARM it actually means shifting by
32 bits (correctness issue) and on other platforms they are useless
(performance issue). This is fix for the fix in r20544.

BUG=v8:3259
LOG=y
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/324403003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

23fc5b75

Whitespace change to trigger bots. · 6c26eb26

machenbach@chromium.org authored Jun 11, 2014

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/324373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c26eb26

Implement LookupIterator designed to replace LookupResult · bb2b08b1

verwaest@chromium.org authored Jun 11, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/314953006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bb2b08b1

Set SAHF flag correctly for ia32 · 99923118

svenpanne@chromium.org authored Jun 11, 2014

sahf flag will not be set for ia32 on some old platform because some old processors does not support CPUID's extended features.
This also avoids redundant cpuid check in ia32 for sahf.

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/298823008

Patch from Weiliang Lin <weiliang.lin@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

99923118

Fix typos in BUILD.gn source lists · ce947a43

mstarzinger@chromium.org authored Jun 11, 2014

"foo,cc" is not the same as "foo.cc"

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/326193002

Patch from James Robinson <jamesr@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21765 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ce947a43

Unbreak build. · b016d748

svenpanne@chromium.org authored Jun 11, 2014

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/329053005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21764 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b016d748

Removed dead API entries. · f67f8fc4

svenpanne@chromium.org authored Jun 11, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/322293003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f67f8fc4

Fix unsigned comparisons. · 2931f091

svenpanne@chromium.org authored Jun 11, 2014

Instead of marking the comparison instruction itself as Uint32, we
look at its arguments. This is more consistent what HChange does.

BUG=v8:3380
TEST=mjsunit/regress/regress-3380
LOG=y
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/325133004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2931f091

Fix GN build. · 05216fdd

mstarzinger@chromium.org authored Jun 11, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/328883005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21759 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

05216fdd

Simplify string copy in SubStringStub. · d5c6e4a9

yangguo@chromium.org authored Jun 11, 2014

The optimizations are unnecessary since the maximum
string length they operate on is currently 12.

R=bmeurer@chromium.org
BUG=352155
LOG=N

Review URL: https://codereview.chromium.org/326943002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21756 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5c6e4a9

V8 can clear exception pending message, when should not do this. · 6cb90020

yurys@chromium.org authored Jun 11, 2014

The case:
v8::TryCatch try_catch;
CompileRun(try { CEvaluate('throw 1;'); } finally {});
CHECK(try_catch.HasCaught());
CHECK(!try_catch.Message().IsEmpty());

CEvaluate is native call. Last check is not passed without patch. Patch contains test TryCatchFinallyStoresMessageUsingTryCatchHandler with more details.

R=yangguo@chromium.org, mstarzinger@chromium.org, vsevik@chromium.org

Review URL: https://codereview.chromium.org/321763002

Patch from Alexey Kozyatinskiy <kozyatinskiy@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6cb90020