- 07 Oct, 2019 24 commits
-
-
Igor Sheludko authored
With the smi-corrupting decompression approach we don't have to sign extend Smis anymore and therefore we can switch to zero extending approach by moving the isolate root to the beginning of the reserved 4Gb region. Bug: v8:9706 Change-Id: Icd6008fa87d0924519b574fdec445976f742e306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835548 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64144}
-
Santiago Aboy Solanes authored
Bug: v8:9684 Change-Id: I6988579693788d5bbc878c63269fe7c1bec65831 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1845223 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64143}
-
Seth Brenith authored
Just mechanical conversion to remove boilerplate code. When .tq and .h files didn't agree on what a field is named, I used the name from the .h file. In a couple of cases the generated accessor became slightly more specific (HeapObject instead of Object), and I had to update the code that uses those accessors accordingly. Change-Id: Ie3af1590e3889887b167c9d045b07860b01f7d15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776479Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#64142}
-
Junliang Yan authored
Disable because it's not yet supported on BE Bug: v8:9330 Change-Id: Ia850801d410d3eeaccf9933dd2669f6077e2919c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834904Reviewed-by:
-
Dominik Inführ authored
TypedSlotSet is only recorded for code pages. Code pages are not swept concurrently to the application, so pre-freeing is not needed for typed slot sets anymore. Also replaces the manually allocated buffer with a regular std::vector. Bug: v8:9454 Change-Id: I901851ad8b525c1653c9818e6599308319aeade2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844773Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#64140}
-
Maya Lekova authored
This reverts commit 9b1e174f. Reason for revert: Breaks arm64 sim debug build - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/17609 Original change's description: > [ptr-compr] Storing a Tagged value stores the lower 32 bits > > This CL changes the Tagged stores when pointer compression is enabled. > It shouldn't affect anything for the time being since if we have pointer > compression enabled, we are going to be storing Compressed values. Later, > we will eliminate the Compressed representation and that it's where it > will come into effect. > > The Arm64 side of the CL looks bigger since we eliminated the opcode in > https://chromium-review.googlesource.com/c/v8/v8/+/1803345. > > Bug: v8:7703 > Change-Id: Ic4afbff9646b5d058adb9619b20ccccb3f5aed45 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822044 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64133} TBR=neis@chromium.org,jgruber@chromium.org,solanes@chromium.org Change-Id: I901f0802b40144492594f293657f7f2b58dc32cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7703 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1845217Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64139}
-
Hans Wennborg authored
It was disabled because it didn't use to work, but it does now, see bugs. Bug: chromium:803591, v8:9736 Change-Id: I53a04199f001b436bd5a247b51cd7c25e3a6e990 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844776 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Backes authored
Some of the methods in {WasmCodeAllocator} can be called either without holding the lock, or while already holding it. In order to support both situations, we used a {RecursiveMutex} so far. This CL refactors this to be a simple {Mutex} again, and passes a {WasmCodeAllocator::OptionalLock} object which stores whether the lock is already held or not. Note that getting the lock twice fails immediately in debug builds, while forgetting to get the lock might only fail on TSan. The alternative would be to duplicate all methods, having one variant that expects that the lock is held and one that assume that it's unlocked. It would be multiple methods though to duplicate across both {NativeModule} and {WasmCodeAllocator}, hence I went for the {OptionalLock} instead. Bug: v8:9477 R=mstarzinger@chromium.org Change-Id: I4e32286cdb93385ac655d408191b330efdd7ad66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825338 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64137}
-
Joey Gouly authored
Found while testing with asan. Change-Id: I82529422770653535aae148a4acc6089c5a4fee7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844786Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#64136}
-
Igor Sheludko authored
So Word32Equal(YYY, CompressedHeapConstant(XXX)) is now generated as cmpl [r13+0xXXX], rYYY instead of movq rXXX,[r13+0xXXX] cmpl rYYY, rXXX Bug: v8:8948 Change-Id: I346c3e9bdb17ae5443e9e488da0eefa07e391b33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841353Reviewed-by:
-
Thibaud Michaud authored
R=mstarzinger@chromium.org Bug: v8:9492 Change-Id: Ie404eb6cb07ea033a10d29dd1b9aba6cb1f03b69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826663 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This CL changes the Tagged stores when pointer compression is enabled. It shouldn't affect anything for the time being since if we have pointer compression enabled, we are going to be storing Compressed values. Later, we will eliminate the Compressed representation and that it's where it will come into effect. The Arm64 side of the CL looks bigger since we eliminated the opcode in https://chromium-review.googlesource.com/c/v8/v8/+/1803345. Bug: v8:7703 Change-Id: Ic4afbff9646b5d058adb9619b20ccccb3f5aed45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822044Reviewed-by:
-
Santiago Aboy Solanes authored
... and make sure that the arm64 ptr-compr bots proceed testing V8 without pointer compression in order to keep testing the other config. Bug: v8:7703 Change-Id: I0017345273d5328d95a338064dd80b44974c1c53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844780Reviewed-by:
-
Clemens Backes authored
This CL fixes the overlap check by using {<=} instead of {<}. This allows us to always use {std::copy_n}, which should fall back to {memcpy} internally (instead of the potentially slower {memmove} we were using before). This might also fix the regressions seen mostly on atom CPUs. R=leszeks@chromium.org Bug: chromium:1006157 Change-Id: Ib61048d65e99a9e7edac5ed894ceaf9e26ad4409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844781Reviewed-by:Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64131}
-
Dan Elphick authored
Removes CodeStubAssembler::GotoIfDebugExecutionModeChecksSideEffects and associated test as well as the PerformSideEffectCheckForObject runtime function. Bug: v8:9396 Change-Id: Id7748be8fbf1d633f759fef8751ddca13a21748c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1824937Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Clemens Backes authored
The {GetNearRuntimeStubEntry} and {GetNearCallTargetForFunction} functions need to find the code space that contains the current function. This lookup requires a lock and is non-trivial. The repeated lookup caused severe regressions. This CL introduces a {JumpTablesRef} struct which holds information about the jump tables to use. It can be looked up once and then used for a whole function or even several functions within the same code space (in {NativeModule::AddCompiledCode} which adds a whole vector of compilation results). This fixes the regressions. R=ahaas@chromium.org Bug: chromium:1004262, v8:9477 Change-Id: I50bd8327a131e3bee79d86b6d7e867a506959312 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1840153 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64129}
-
Joey Gouly authored
Placing these tests in anonymous namespaces, is the suggested fix according to the GCC documentation. The GCC documentation states: "If a type A depends on a type B with no or internal linkage, defining it in multiple translation units would be an ODR violation because the meaning of B is different in each translation unit. If A only appears in a single translation unit, the best way to silence the warning is to give it internal linkage by putting it in an anonymous namespace as well." Change-Id: I69a1e9b5f1789e9a7a62c762cd499809a72e0ea5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1836255 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64128}
-
Clemens Backes authored
Because of a GCC bug we needed to use a functor instead of a constexpr function. Since we do not support gcc before version 5 any more, this can be cleaned up now. R=jkummerow@chromium.org Bug: v8:9396 Change-Id: I848c5a25e1d5fa44a1497b06826f9a59b93ed695 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835543Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64127}
-
Dominik Inführ authored
This CL removes the StoreBuffer and inserts slots into the RememberedSet directly from within the RecordWrite builtin. Only calls into C code when either the SlotSet-array or the bucket is not allocated. This avoids filling the store buffer up with duplicates or due to a write-heavy workload and then blocking the main thread on store buffer processing. The first CL (https://crrev.com/c/1815241) got reverted, because mksnapshot was using a different size for SlotSet than the final binary on ARM. This is fixed now, SlotSet has a standard layout. Bug: v8:9454 Change-Id: I881641f4ee08a8b42c36fdca8733138b908096bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1842452Reviewed-by:
-
Dan Elphick authored
Fixes spurious DCHECK triggering due to bug introduced in https://chromium-review.googlesource.com/c/v8/v8/+/1836258. Bug: chromium:1011596 Change-Id: Ia3b1eb25d326e465b3239f191aad11d90a2e56a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844777Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64125}
-
Mathias Bynens authored
We've gathered sufficient data, so the use counter can now be removed again. The use counter was originally added here: - V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/1718145 - Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1718367 The Chromium plumbing was removed here: https://chromium-review.googlesource.com/c/chromium/src/+/1839851 BUG=v8:9551 Change-Id: I829a0fe34d9ebade1403cb4d1c0b9c997f125074 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844774Reviewed-by:
-
Michael Achenbach authored
This adds a fake toolchain for pointer compression, used for correctness fuzzing. The toolchain enables us to have an extra build with inverse pointer-compression defaults side-by-side. The extra build is used similarly to existing x64/x86 comparisons, except that we now compare builds with different compile-time flags. Change-Id: I75491371262204b86eaa006ca8d04848f49121ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829275Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64123}
-
Michael Achenbach authored
The entries test262_variants and test262 are now equal after previous changes. This switches all to test262 to prepare removing the former. Bug: v8:9791 Change-Id: I677ea36798556e1aeed8bc11c3272804141e1eb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835539Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f60b4e5..359f95f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I89fce2878ea8bfa1fa5803220bc9446e17767f55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64121}
-
- 06 Oct, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cf8d1d9..f60b4e5 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d696f20..c9256e1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8d3ee4364b25a6176865dd8a0d227465a9e6da17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1843093Reviewed-by:
-
- 05 Oct, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/90168ea..cf8d1d9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8305659..ddbd321 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f3c5fef..d696f20 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ibfd3dc3fdeb38aec3ab5bdcad4d58163d2ad66c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1842077Reviewed-by:
-
- 04 Oct, 2019 14 commits
-
-
Ng Zhi An authored
Bug: v8:9728 Change-Id: Ie769ae0431b7924a4b8f8858681d57e92c00f4b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1808400Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64118}
-
Ng Zhi An authored
We reuse PACKED_OP_LIST to generate *pd instructions. Introduce a new pd base method, similar to ps and vps. Bug: v8:9396 Change-Id: Id9d81c22c9110935484fd929ef7bf5cc20e9ae7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834767Reviewed-by:
-
Michael Lippautz authored
Change-Id: I0751c1761a2d07dd89d831ca6370ae01bc569b6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841351 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... in order to improve performance of decompression code on C++ side (because computation of isolate root from isolate pointer becomes a trivial reinterpret cast) and measure the impact separately from other ptr-compr changes. Bug: v8:9353 Change-Id: I36906cef2968355411ee944d97625ecd2652646b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835550Reviewed-by:
-
Dominik Inführ authored
Now that sweeping uses its own RememberedSet, pre-freeing of empty buckets is not necessary anymore. Mutator inserts into a different remembered set, than the sweeper removes slots from. Bug: v8:9454 Change-Id: I65d046926aa82aeb9eca7694e6a7eff1331d7e01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835547 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 7177d87f Original Commit Message: Reorders the Smi check and the empty OptimizationMarker check as the latter implies the first and means there is now just a single comparison on the fast path. R=delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I4129e8d710d25fb1df02742816ab3b56430a7523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841611Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64113}
-
Georg Neis authored
It was on JSGlobalProxyRef but in reality the property cells exist in the global object, not in the global proxy. Bug: v8:7790 Change-Id: Ia7bd5731c730db09602a1aec61b64b1355abf6a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841352 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This is a reland of b271ea3c The failing arm64 disasm poison test was fixed. Original change's description: > [ptr-compr] Disable double fields unboxing > > Double field unboxing optimization is incompatible with pointer compression so > we land this CL before enabling pointer compression in order to separate memory > and performance regressions caused by disabled double field unboxing from > pointer compression change. > > Bug: v8:9799 > Change-Id: Ic8118356496a3f351344215b409f9722de6c9355 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835546 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64089} Tbr: verwaest@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_arm64_dbg Bug: v8:9799 Change-Id: Ib7c126d70859537c3d0bce54a49f23909c14a6ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1840411 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Dan Elphick authored
Reorders the Smi check and the empty OptimizationMarker check as the latter implies the first and means there is now just a single comparison on the fast path. Bug: v8:9771 Change-Id: Ibba1f322944b17186842983e227684b301ed5f31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833683 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64110}
-
Mike Stanton authored
A slow dcheck can verify that hints are equal for the same SharedFunctionInfo+FeedbackVector combo. Bug: v8:7790 Change-Id: I43dcacf19c857770b609d13c310835a873c814fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835952 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#64109}
-
Georg Neis authored
Recursively serialize arguments to higher-order functions if appropriate. This should recover all or most of the Deltablue regression with --concurrent-inlining. It is also a prerequisite to allowing speculation in the call reducer for these situations. Bug: v8:7790, v8:9702 Change-Id: I1ac8ac8b8e4dc0f2e19c89aacfb45d18f2df190f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835541 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... as the smi-corrupting decompression seems to be stable enough. Bug: v8:9706 Change-Id: I404924ec4a12b37d8bc3e521c5563aa7e6357dc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835544Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9799 Change-Id: I402133f6265f4a3129daef45615258d4a9b8f2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1840154 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a reland of 35ca0abd. The last known issue is fixed in https://crrev.com/c/1832178. Original change's description: > [wasm] Ship far jump tables > > This flips the --wasm-far-jump-table flag. It will allow for more than > 128MB of code space per wasm module on arm64, and will increase the > limit on the number of modules per process on x64 (was ~1000 before, > because we reserved 1GB for the code space per module). > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I870ec616f4812e38ef1e3fccf0629854a247bb4f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815247 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Backes [né Hammacher] <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63967} Bug: v8:9477 Change-Id: I6d7de80e874e1d51512148fc3c1f45b0fc1474ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1840151Reviewed-by:
-
