- 30 Aug, 2022 21 commits
-
-
Simon Zünd authored
This CL changes debug breaks that are triggered via interrupts (i.e. via stack check). One client of this behavior is the `Debugger.pause` CDP method. The problem is that when we pause so early, the JSFunction didn't have time yet to create and push it's context. This requires special handling in the ScopeIterator and makes an upcoming change unnecessary complex. Another (minor) problem is that local debug-evaluate can't change context-allocated local variables (see changed regression bug). Since the context is not yet created and pushed, variables are written to the DebugEvaluateContext that goes away after the evaluation. The solution is to mirror what `BreakOnNextFunction` does. Instead of staying paused in the middle of the function entry, we trigger a "step in" and pause at the first valid breakable position instead. This ensures that the function context is already created and pushed. Note that we do this only in case for JSFunctions. In all other cases we keep the existing behavior and stay paused in the entry. R=jgruber@chromium.org Fixed: chromium:1246907 Change-Id: I0cd8ae6e049a3b55bdd44858e769682a1ca47064 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854501Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#82817}
-
Jakob Linke authored
This implementation sticks closely to what Ignition-to-Turbofan (and now Sparkplug-to-TF) does. OSR is detected in the TieringManager by having optimized code available, without having entered it. The osr_urgency is increased to enable OSR for increasing loop depths. When a candidate JumpLoop backedge is reached, we call into runtime to trigger OSR compilation. JumpLoop also detects the availability of cached OSR'd code. When a matching OSR code object is available, Maglev 1) deoptimizes s.t. the unoptimized frame layout is reconstructed, and 2) delegates the actual OSR tierup to the unoptimized tier. For purposes of 1), we add a new DeoptimizeReason that causes a one-time eager deopt without invalidating any code. Drive-by: Annotate OSR for more --trace-opt output. Todo: Refactor non-Sparkplug-specific bits of the BaselineAssembler into a generic spot that both SP and ML can use. Bug: v8:7700 Change-Id: I6ebab2df8b87f9f70ffb78162a3c1226ec545468 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859850Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82816}
-
Jakob Kummerow authored
...to honor the {pinned} list under all circumstances. Drive-by: DEBUG-mode helpers to print FunctionSig and LiftoffRegList objects to stdout. Fixed: chromium:1356718 Change-Id: I487db12294f687790cec1d658d7a7d754f3c2f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859752Reviewed-by: Clemens Backes <clemensb@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82815}
-
Dominik Inführ authored
This class is only used for heap verification and doesn't need to be public. Bug: v8:11708 Change-Id: I9d1750a6f701ed0d9a106f8d93ab3ff82bbf4f3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862208Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82814}
-
Darius M authored
Only Internalized and Thin strings should be accessed from the background. My CL "[compiler] Remove map check in StringRef::length" removed a check, and, while doing so, made it possible to read Cons strings in the background, which is incorrect because such strings can be mutated by the main threads. Fixed: chromium:1357438 Change-Id: I3a5445f91d10e5ceab62ac208a04be5ed71798ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862007 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82813}
-
Camillo authored
If either target or source are shared buffers, use relaxed memmove. Bug: chromium:1353555 Change-Id: Ieaad826c610b0f2f808b4061947372d851f95978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862209Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82812}
-
Simon Zünd authored
Adapted from https://crrev.com/c/3862264. Add a new teardown trampoline for the case where a Sparkplug function is deoptimized during its function entry stack check. In these cases, the stack is in an incomplete setup state, so instead of forwarding to interpreter re-entry, we undo the partial stack setup and forward to the standard interpreter entry. R=leszeks@chromium.org Bug: chromium:1246907, chromium:1357554 Change-Id: I0795b20cdc60d3ba28bc32cd55bdf82d72f83aac Also-by: leszeks@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865144 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#82811}
-
Dominik Inführ authored
Methods are now defined in heap-verifier.h in the HeapVerifier class. Bug: v8:11708 Change-Id: I13e7f1760598f3659ad6aa31082840caf2e44038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857558Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82810}
-
Victor Gomes authored
This CL: - Separates Wasm frame pointer iteration from TypedFrame iteration - Introduces the frame StubWithContext that correspond to a TF-optimized code without JS linkage - Fixes WasmToJsFrame to be a WasmFrame - Fixes the hack with JsToWasmFrame that calls TypedFrame when not the right builtin - Cleans up TypedFrame::Iterate Change-Id: Ie238df5188f2e2f081f5353b4538b75b6e79f64a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859787Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82809}
-
jameslahm authored
... when deserializing. EphemeronHashTables require valid HeapObject keys, however EphemeronHashTables are filled with Smi::uninitialized_deserialization_value when deserializing. We could fill EphemeronHashTable's elements with "the initial filler" which is undefined value to make sure the elements are valid. Bug: v8:13232 Change-Id: I268cdbd4303fbe9afa2f9a5d8aafcace397c8164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3864185 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82808}
-
Vasili Skurydzin authored
Change-Id: Ia0078bed77f5f75eebd837b7ffcc34cfb2c7d305 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863723Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82807}
-
Dominik Inführ authored
Add a flag for disabling FastForwardSchedule() during incremental marking. This CL disables "schedule fast forwarding" by default to experiment with this setup for a few days and to see whether this causes performance regressions. Bug: v8:12775 Change-Id: Id2c0a62f4b67b3a2379816581800cfb62361b40c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865003 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82806}
-
Simon Zünd authored
This CL adjusts a DCHECK that verifies a bytecode offset when looking for the closest breakpoint given that offset. When we pause on function entry via interrupt, then the offset is kFunctionEntryBytecodeOffset (-1), which is still a valid offset. R=jarin@chromium.org Fixed: chromium:1357554 Change-Id: I5b25b58f02be0e605191c38e9d1d93e334664c63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862265 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/main@{#82805}
-
Frank Tang authored
PR https://github.com/tc39/proposal-temporal/pull/2266 Disallow arbitrary integers for the reference ISO year in PlainMonthDay Spec text: https://tc39.es/proposal-temporal/#sec-temporal-createtemporalmonthday Also add missed assertion of calling ISODateTimeWithinLimits Bug: v8:11544 Change-Id: Idd18428f3e6e6af53c2c207652688af269746782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855703Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82804}
-
ishell@chromium.org authored
This is a reland of commit 40901824 The reason for revert was regressions in `blink_gc:effective_size` buckets of `system_health.memory_desktop` benchmarks. See http://crbug/1356329#c51. Memory Perf Sheriffs: This CL shifts GC times which regresses `blink_gc:effective_size` but improves `v8:effective_size` bucket by a similar amount. The `private_footprint_size` metric stays neutral for the majority of the stories and for certain load stories it even improves. Original change's description: > [ext-code-space] Enable Code-less embedded builtins > > Bug: v8:11880, v8:12592 > Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82642} Bug: v8:11880, v8:12592, chromium:1356329, chromium:1356763 Change-Id: Ia9150ecb1f16581e249e4e3e566be20ac4591e78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862503 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82803}
-
Frank Tang authored
Subtract timeZone.[[OffsetNanoseconds]] from epochNanoseconds before calling the IsValidEpochNanoseconds() for the case of 4. If timeZone.[[OffsetNanoseconds]] is not undefined Bug: v8:11544 Change-Id: Icea2d8390a9db01054956f8c57b47dc5a88446d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855980Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82802}
-
Frank Tang authored
Validate fractionalSecondDigits after truncation https://github.com/tc39/proposal-temporal/pull/2297 Spec text: https://tc39.es/proposal-temporal/#sec-temporal-tosecondsstringprecision Bug: v8:11544 Change-Id: I648f087f4fa2cfd6245c7946cfa625a7c5e3b3b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855702 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82801}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7e25322..adc338f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2417ba3..6552f9b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b7ec673..bbb66d7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1eff359..ad4caa4 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ife992f3f909a23faa528e8ee1637b1213cc07fa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863152 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82800}
-
Igor Sheludko authored
Bug: v8:13235 Change-Id: Ic6509a74bb808de320734043a42c2da867c150a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858301Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82799}
-
Frank Tang authored
Disallow negative day lengths as round result PR https://github.com/tc39/proposal-temporal/pull/2261 Also fix the missing extraValues=<"day"> to GetTemporalUnit Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.round Bug: v8:11544 Change-Id: Ibc963d5d93dde30f29df707ef3b3ecea99cd4a60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855704Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82798}
-
Frank Tang authored
https://github.com/tc39/proposal-temporal/pull/2225 Call ToTemporalOverflow in ToTemporalDate and ToTemporalDateTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-totemporaldate https://tc39.es/proposal-temporal/#sec-temporal-totemporaldatetime Bug: v8:11544 Change-Id: I3d2846e2efc214ea5385be58cb49e319369b5900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855705Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82797}
-
- 29 Aug, 2022 19 commits
-
-
Frank Tang authored
This reverts commit 6b682148. Reason for revert: Cause CHECK violation in https://bugs.chromium.org/p/chromium/issues/detail?id=1356838 Original change's description: > [intl] Return "UTC" instead of "Etc/UTC" or "Etc/GMT" as DefaultTimeZone > > Refactoring the code dealing with TimeZone Canonicalization. > Change CanonicalizeTimeZoneName from return MaybeHandle<String> to Handle<String> > Move TimeZoneId from JSDateTimeFormat to Intl and return Handle<String> instead of Handle<Object> > > > Bug: v8:13112 > Change-Id: I678b0e0d407e5e4e9dd8b7120c0e99e7e2d9c5ea > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3833435 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82505} Bug: v8:13112 Change-Id: If4df4bc19b5d1a02c51e2c944abaca8a25b76a1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863883Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82796}
-
Shu-yu Guo authored
Shared values need to be kept alive while being conveyed across threads (i.e. by postMessage). Currently they are meant to be conveyed through the serializer/deserializer by the embedder via API. This both clunky and the embedder has no good choice for what to do, because the most natural choice is v8::Global and it is not designed to be threadsafe. This CL removes the API and transparently handles conveying shared values by using a wrapper around PersistentHandles called SharedValueConveyors. Any isolate can own the conveyor provided it outlives the receipt of the message by the receiving isolate. For simpler lifetime management, the shared isolate currently owns all conveyors. Bug: v8:12547 Change-Id: I8f71b2faa0f8a1973f8b97ffccf4f5ad230f4e16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857453Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82795}
-
Michael Lippautz authored
- Unify AIX and Starboard wrapping code. - Move all wrapping code into `platform/memory.h` Change-Id: I42c04dd1e982edff2db7bbfa9eecdbdd67f40714 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858226Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82794}
-
Milad Fa authored
Port c2d46fe9 Original Commit Message: When a call_indirect fails because of a signature mismatch or a null target, the value stack generated for debug doesn't contain the target index anymore, which makes it hard for users to understand the error. Keep the index on the stack, and ensure that the index is not modified until we generate the debug info. Previously, the index was shifted in-place to compute various offsets. Instead, use scaled loads to compute the offset directly in the load instruction. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I6ab0b5bfcac991f6e26a97bb2513556aa67dcf94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858300Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#82793}
-
Jakob Kummerow authored
The string and view creating instructions string.new*, string.const, string.concat, and string.as_* should all return non-nullable reference types. See https://github.com/WebAssembly/stringref/issues/42 Bug: v8:12868 Change-Id: I2a39aadd339a49b4aa2d145492cba85e6ab14b71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858236 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#82792}
-
Victor Gomes authored
We follow Chromium and only download the image qemu.x64 Change-Id: I13e06c5646e889af2acfac8c8e9cb971a7a36c56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858299 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82791}
-
Milad Fa authored
Port 8a56da44 Original Commit Message: ... so that the offset fits into the maximum offset for load byte instruction for arm/arm64 (Ldrb) in order to produce smaller code. Update code generation so that the loading of the flag value is combined with the comparison operation where possible. Additionally, this CL moves the Isolate::is_profiling flag to the IsolateData so that it can be loaded directly via roots register which removes one indirection. The fields moved in the IsolateData: - is_marking_flag and is_minor_marking_flag (checked by write barriers) - is_profiling (checked on API callbacks/getter calls) - stack_is_iterable (not super hot, checked during deoptimization). the field size expectations clear. R=ishell@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ibafb23e9a035caffe6921a304a3d318b54732167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862227Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82790}
-
Leszek Swirski authored
Accidentally tried to print the colour '-1' if there was no line colour set yet but the current colour had changed. Bug: v8:7700 Change-Id: Iba3cbe51fd0e31e389e614d0a42e59147a51b902 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859355 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82789}
-
Shu-yu Guo authored
Change-Id: I98f9808c139cb0f04efae2d732e9ed60e6d2d78b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3278678 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82788}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220812.1.1..version:9.20220826.3.1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ae771c8..1eff359 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I653b89dccbef92c384cad109aa7e00df9c96c08d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3860485 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82787}
-
Feng Yu authored
Bug: v8:12781 Change-Id: I19de9ab655e3e4b7ad45cde7f9bc659741d856a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858928Reviewed-by: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Feng Yu <f3n67u@gmail.com> Cr-Commit-Position: refs/heads/main@{#82786}
-
Victor Gomes authored
System images are checked-out via the SDK update script, these fixed images are outdated and not used anymore. Change-Id: I4563e04bd252667a01470363f47bbae2ef17d5c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859354Reviewed-by: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82785}
-
Victor Gomes authored
Bug: chromium:1357478 Change-Id: I6c412efa9ecc57fd8fbd47a5753c7731558df3b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859353Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82784}
-
Milad Fa authored
Intermittent issues were fixed here: crrev.com/c/3840820 Change-Id: If0e7acc57053ecfa188ca2c858029da7fdf4ff27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859519 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#82783}
-
Junliang Yan authored
This is a reland of commit c060af4d Use LoadFullTagged function instead to avoid test failing with v8_enable_verify_csa=true. Original change's description: > Fix CSA_CHECK failure on BE > > The load for external reference should be a full pointer load > instead of tagged size. > > Change-Id: I3460a26abea5053ba6daa5c6ed908cb93431654a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3842348 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/main@{#82625} Change-Id: I85817634ce2de099a9fbd350defb57789cce9678 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857442 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82782}
-
Camillo Bruni authored
Change-Id: I8570c748a9e4e509b0f609fcbb6aa37a3a986971 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862267Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82781}
-
Thibaud Michaud authored
When a call_indirect fails because of a signature mismatch or a null target, the value stack generated for debug doesn't contain the target index anymore, which makes it hard for users to understand the error. Keep the index on the stack, and ensure that the index is not modified until we generate the debug info. Previously, the index was shifted in-place to compute various offsets. Instead, use scaled loads to compute the offset directly in the load instruction. R=clemensb@chromium.org Bug: chromium:1350384 Change-Id: Iad5359ec80deef25a69ac119119a0b5ca559a336 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854309Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#82780}
-
Samuel Groß authored
Bug: chromium:1355990 Change-Id: I1a822ce7b476baf5866070b11b65c464800d3b7b Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859849 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#82779}
-
Jakob Linke authored
Bump the limit to give TF enough time to finish compiling. The `keep_going` limit is fairly ugly, but it lets us test the real (=concurrent) pipeline. Bug: v8:7700 Fixed: v8:13176 Change-Id: Iba97111d752c8a4894e99ab57e8f42abcc8c29bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862204 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82778}
-