- 24 Sep, 2021 34 commits
-
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/650e7ad..50dd431 Bug: v8:7834, v8:12240 Change-Id: I017d7a60a38c8935d279040eb5f4bdadda22317e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182892 Commit-Queue: Shu-yu Guo <syg@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77059}
-
Junliang Yan authored
Port a0ace8a8 Original Message: In Liftoff, the result of table.grow was smi-untagged and sign-extended to a ptr-sized value. However the result is typed as i32, so the upper 32 bits should be cleared on 64 bit platforms. In particular this is observable when the value is used as an index for a memory operand, which leads to the repro in the attached issue. Match the TF behavior by untagging the value as a 32-bit int. Change-Id: I73ee1d29b830eae1fd4e680634b78317b04c069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183160Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77058}
-
Clemens Backes authored
Many instructions are declared using DECLARE_INSTRUCTION (via ASSEMBLER_INSTRUCTION_LIST), and each of them currently defined eight templates for different sizes and different number of arguments. This CL reduces this to three variadic templates per instruction. R=zhin@chromium.org Bug: v8:12244 Change-Id: Ibd75c55e757f917eb1e9b54c0a1a79632a1ba6d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181103Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77057}
-
Clemens Backes authored
Some macros are redundant or unused. - WASM_RETURN1 is identical to WASM_RETURN. - WASM_RETURNN has an unused {count} parameter, and is otherwise identical to WASM_RETURN. - WASM_IFB is identical to WASM_IF. - WASM_CASE and WASM_CASE_BR are unused. - WASM_BR_TABLEV is unused. R=thibaudm@chromium.org Bug: v8:12244 Change-Id: Ie7be00351f2dfe38d6e84d80e157a85df37233a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178860Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77056}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:12244 Change-Id: I9d633fd3c79703ee65dc2f57b556fde4853cc35c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181105Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77055}
-
Clemens Backes authored
Instead of hand-coding a loop, use range-based for loops for iterating signatures. Similarly, {std::transform} can replace a hand-coded loop for constructing values from return types. R=thibaudm@chromium.org Bug: v8:12244 Change-Id: I467656650b731cbcb9ea57c54f5311885bb158dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181520Reviewed-by: -
Andreas Haas authored
R=jkummerow@chromium.org Bug: v8:12244 Change-Id: I6264a91caa1f961ea1fa27c372c53240d969e91a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181527 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77053}
-
Dominik Inführ authored
Bug: v8:12244, v8:12245 Change-Id: Ibea600e10d64be5e4da474ae501b88e4f4d9cc51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182228 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77052}
-
Dominik Inführ authored
Bug: v8:12244, v8:12245 Change-Id: Iaa2d8be352bbe03882f531cc66ab36c15b2b2a75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182227 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Andreas Haas authored
Rename the enum value to avoid variable shadowing. R=clemensb@chromium.org Bug: v8:12244 Change-Id: I96a3bee7615b44692bb9edfedf82c6020a803d0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181529Reviewed-by:
-
Andreas Haas authored
NameSectionKindCode::kFunction got shadowed by WasmCompilationResult::Kind::kFunction. NameSectionKindCode is not used often, so this CL just adds "Code" to all fields of this enum. R=clemensb@chromium.org Bug: v8:12244 Change-Id: I87155a43084b868f6c118ddc2e44cb9c35b4249b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181535Reviewed-by:
-
Dominik Inführ authored
Bug: v8:12244, v8:12245 Change-Id: I718c7531a7bec24abbc1c5b23246828261d0b94b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182221Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:12244,v8:12245 Change-Id: I60eaad6a96f227a0c39f2f79806b38a2080296ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182220 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77047}
-
Milad Fa authored
Port e301d71f Original Commit Message: Because these instructions can trap, we don't want them to be reordered as freely as unprotected accesses. As part of this, make explicit which opcodes support a MemoryAccessMode. R=neis@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I122a53a67c9d2b3b99c5c25395064b61969483a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181539Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77046}
-
Michael Lippautz authored
Bug: v8:12244, v8:12245 Change-Id: Id6b9e0a3986fb04c1a949b26ecf20da652ddd097 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181537 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77045}
-
Thibaud Michaud authored
In Liftoff, the result of table.grow was smi-untagged and sign-extended to a ptr-sized value. However the result is typed as i32, so the upper 32 bits should be cleared on 64 bit platforms. In particular this is observable when the value is used as an index for a memory operand, which leads to the repro in the attached issue. Match the TF behavior by untagging the value as a 32-bit int. R=clemensb@chromium.org CC=ahaas@chromium.org Bug: chromium:1251465 Change-Id: Ia57fd8a69ecb2787b42bbf8217e448976aa1dbd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173680Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77044}
-
Milad Fa authored
Port 4bbfc4b7 Original Commit Message: The argument is no longer in use. R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I06095fc237ae19ece4586d60b048785d7efa4ac3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3179268Reviewed-by:
-
Omer Katz authored
Bug: v8:12244,v8:12245 Change-Id: Ic2d324fa5a3bde18b4fdbe7d64e44c7fc9ccd4ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181534Reviewed-by:
-
Samuel Groß authored
Attempts to allocate memory pages inside the virtual memory cage are currently allowed to fall back to allocating them outside of the cage if necessary. When this will be forbidden in the future, these cases will turn into allocation failures. To estimate the frequency of such events, we now record the outcome of allocation attempts for memory inside the cage into UMA. Bug: chromium:1218005 Change-Id: I788fdd968eea10c887eaba1585cd7951823246e0 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178520Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77041}
-
Michael Lippautz authored
Bug: v8:12244,v8:12245 Change-Id: Ic73482248fdf36929f597626db13462401f098e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181530Reviewed-by:
-
Andreas Haas authored
R=thibaudm@chromium.org Bug: v8:12244 Change-Id: I36a44660b8b41a4b9dc44a1143b2cc0c2f88a040 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181523Reviewed-by:
-
Michael Lippautz authored
Introduce IDENTIFIER_WITH_LINE() that can be similarly used in other scope-based macros throughout the codebase. Bug: v8:12244,v8:12245 Change-Id: If9d45b7065d7eb3df0297f35eb9be777b497ea95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181524 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:12244, v8:12245 Change-Id: Ia08a23fe8ff09e3b0da3ae549238f9b017c04219 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181526 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77037}
-
Marja Hölttä authored
Bug: v8:12244, v8:12245 Change-Id: Icd54ac767542ec2344c34b8dde674b41079180af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181525Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77036}
-
Toon Verwaest authored
Bug: v8:12244, v8:12245 Change-Id: I7d9e8c1a8eda63d1e6c66d92d4ed39daad02df44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181522 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77035}
-
Omer Katz authored
This reverts commit 2db50670. Reason for revert: pdfium crashes Original change's description: > Reland "Reland "cppgc: Enable checks for assignments in prefinalizers"" > > This is a reland of adb6276f > > Causes for previous revert was addressed by crbug.com/3140387 and > crbug.com/3163579. > > Original change's description: > > Reland "cppgc: Enable checks for assignments in prefinalizers" > > > > This is a reland of edcc8ff5 > > > > Cause for previous revert was addressed by crbug.com/1241773. > > > > Original change's description: > > > cppgc: Enable checks for assignments in prefinalizers > > > > > > Bug: v8:11749 > > > Change-Id: Ic027f732030fb6a2befeffeca9db2eacfd0830a5 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099953 > > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#76370} > > > > Bug: v8:11749 > > Change-Id: I57fc138ace002d41e54f7f70250e4d19bc9262b0 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122153 > > Auto-Submit: Omer Katz <omerkatz@chromium.org> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#76553} > > Bug: v8:11749 > Change-Id: I138ca374314108f0f23e234a8fd90d15d912120d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168280 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76971} Bug: v8:11749 Change-Id: I01bb9166dbc6444456b44165f1b9f9d90575056a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181101 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77034}
-
Toon Verwaest authored
Bug: v8:12244, v8:12245 Change-Id: Ic6250a62baadfde87bcd05cfd6c891c91af73f87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181104 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:12244, v8:12245 Change-Id: I75d699f7b1707c610a5d335185192089e840e23b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180824 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Georg Neis authored
Because these instructions can trap, we don't want them to be reordered as freely as unprotected accesses. As part of this, make explicit which opcodes support a MemoryAccessMode. Bug: v8:12018 Change-Id: I9db3053d7d62ffce6d3c95d62adce71ae40dae62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172770Reviewed-by:
-
Marja Hölttä authored
Bug: v8:12244 Change-Id: I9ec30012f7238f53448b80cf9d657571a37502a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180822Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77030}
-
Marja Hölttä authored
The tests won't be very interesting, but we should still have basic smoke tests. Bug: v8:11111 Change-Id: I57eadfc090883bc9b84e5b2fb5984b5ed588a69b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3177223Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d7f25a4..c4acc0e Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/7ea3a87..9d33a71 Rolling v8/third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ba539c1..4402489 Rolling v8/third_party/aemu-linux-x64: 93-xiCMBx8NRjVvu1v-vuwCsej5zB1Pj3FEUsphwCeUC..35rwW0ni0eziJ2doq4bSBym86edze8jHjf2fyZhjl8kC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e155ea5..3d49e1c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/04d9c83..a6baf70 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/948efd2..77d41f0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I038172041cffa59b18441fb946f6d02272bc9540 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180522Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77028}
-
Ng Zhi An authored
Bug: v8:12207 Change-Id: Ia553891986f0ef3fe6fb1c4350c3accc0e7bfc84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180243Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77027}
-
Ng Zhi An authored
Bug: v8:12244 Change-Id: I5a85e109316b349545d2699a59200c167d261842 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180244Reviewed-by:
-
- 23 Sep, 2021 6 commits
-
-
Ng Zhi An authored
Change-Id: Iba7d3f528262b3979d3bfe83784c3cfe050cd6e6 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180241 Auto-Submit: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I71505f29cd1dba04f0e8cc14d33067a766495921 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3179719Reviewed-by:
-
Milad Fa authored
Port: bba7c09a Original Commit Message: .. by reusing the regexp stack from potentially multiple nested irregexp activations. To do this, we now maintain a stack pointer in RegExpStack. This stack pointer is synchronized at all boundaries between generated irregexp code and the outside world, i.e. when entering or returning from irregexp code, and when calling into C functions such as GrowStack. Fixed: v8:11382 Change-Id: I0f97363a069c65f4fbe081b2f9fa796f9d950f43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3179030Reviewed-by:
-
Ng Zhi An authored
Scalar lowering pass is removed, so if hardware does not support SIMD, compilation should fail. Bug: chromium:1202671,v8:11613 Change-Id: I4cafd244d066121dc716ea880529603d9013a05d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3179762Reviewed-by:
-
Ng Zhi An authored
- create a helper class to set up Disassembler for testing - add a helper macro to only compare disassembled instruction (ignore the hex bytes), this is useful for comparing SSE instructions, whose opcodes are defined in sse-instr.h, and use uppercase letters, but the disassembly always uses lowercase - emit and compare SSE instructions using macro list Bug: v8:12207 Change-Id: I3580f5d756736cada4f7260efc4d90e2c894f43c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173906Reviewed-by:
-
Shu-yu Guo authored
'#x in expr' currently parses incorrectly and associates #x as an operand of an existing binary expression continuation if the previous operator was of higher precedence. For example, 0 << #x in foo gets incorrectly parsed as (0 << #x) in foo. Bug: v8:12259, v8:12086 Change-Id: Ie37ff49ff6e63b3ea91fd0fba6bc73ec839c580b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3176506Reviewed-by:
-
