- 05 Apr, 2019 2 commits
-
-
Georg Neis authored
Bug: v8:9087 Change-Id: Ia806686b47f0e6ddc89f6b043df65ab8a931bbf8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552798Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60644}
-
Sigurd Schneider authored
This is a test to see how much and where we regress. We have seen some quirks of our current allocator that do not show up in this new approach, so we need to decide whether to stabilize the new allocation scheme. Performance numbers are a key indicator for that decision. This patch is intended to be reverted after stability and performance numbers are in (i.e. after a few days). Change-Id: I8df8ff7de8efa82a8abbdfa1d21d7877756f129e Bug: v8:9088 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552786Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60643}
-
- 04 Apr, 2019 24 commits
-
-
Deepti Gandluri authored
Change-Id: I453c356a6d9098739e7bf32d3c7a75c8afb7cab2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554106Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60642}
-
Deepti Gandluri authored
Some state related to WasmMemories is cached on the JSArrayBuffer object (is_growable, is_wasm_memory). The problem with this is in some PostMessage flows, this information can get lost depending on how JSArrayBuffers are deserialized. In this particular case when the WasmMemory is postMessaged, it goes through the Blink DedicatedWorkerMessagingProxy::PostMessageToWorkerGlobalScope flow, which reconstructs the ArrayBuffer from the backing store, and size, and loses the is_growable flag, leading to a failure to grow memory. Moving the is_growable flag so that AllocationData can be the source of truth for all wasm memory state, and is consistently preserved across PostMessage. Change-Id: I775f66ddeff68b8cafc18b75ca5460dfb0343c8b Bug: v8:9065 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549789 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#60641}
-
Jaroslav Sevcik authored
This makes the DCHECK consistent with the map updater. See https://cs.chromium.org/chromium/src/v8/src/map-updater.cc?l=330&rcl=5671f8b940b0fcdb550e318e449ded0f866e935a Bug: chromium:949435 Change-Id: Id4fef60cdca094e638a1db38878953ecb2422c4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552797Reviewed-by:
-
Daniel Clifford authored
Indexed fields in classes can now be initialized using iterators and a spread syntax, e.g.: class Foo { length: Smi; elements[length]: Object; } new Foo{length: 5, elements: ...iter}; where iter implements Torque's iterator protocol. This protocol requires the definition of a method with the following signature: Next(): <type> labels NoMore; Where <type> is the Torque type of the values to be iterated. In the case of indexed field initialization, the type must be the field's type or a subtype thereof. Field initialization with spread is desugared into a loop that calls the spread iterator's Next method and assigns each returned value in order to the corresponding indexed field element. The general machinery for the spread syntax has been added to the ast and parser, however, it can currently only be used in the specific context of indexed field initialization. Spread operators used in any other context will cause an error. Bug: v8:7793 Change-Id: If071e61db8166573c28d13318879c88ba96f6d98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550407 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60639}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I1b9f3c0c805709c6570785ec9f1045f21c9d03e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541048Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60638}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:933093 Change-Id: Iaf703f9f9743c508c1f63301a74a1076286fab79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552792Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60637}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:933093 Change-Id: Idff6d4bdee2192eea895ca044c5a529e3638e908 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552789Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I91534149f6a1d4cb4bf2beccc7ab53d75e677024 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552780 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit c652b5a1. Reason for revert: Clang roll detecting this failures was reverted. Original change's description: > [test] Skip tests blocking DEPS roll > > NOTRY=true > > Bug: v8:9086 > Change-Id: I1a430c12d5ddccb17931fa32f45463b7d8992971 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552005 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60624} TBR=machenbach@chromium.org,sigurds@chromium.org,jshin@chromium.org,sergiyb@chromium.org Bug: v8:9086 Change-Id: I083c9b4c037bdae1bc0bfbd872bc73b931fbb853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552785Reviewed-by:
-
Maciej Goszczycki authored
Bug: v8:8834 Change-Id: I763869297e52baf1142f89f0567441c05e00391c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552784Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I643d9a142e55405ec010cfe56915527e3cff2d6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552783 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60632}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6fdec9f..96d2ee3 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/235be3c..218cb3d Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/955113d..fbddc46 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/95a9e86..25ef1f6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifcda76b2b210ba6bfdee10170e042b5dbfff6d01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1551412Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60631}
-
Clemens Hammacher authored
We only use the safe math helpers (CheckedNumeric<T>) in very few places. The headers are huge though, and complex. They are pulled in to 839 of our object files, increasing compilation time. I also find the implicit checks more easy to understand than the complex logic in CheckedNumeric. Thus, this CL removes the safe_math headers and implements bounds checks for the five uses explicitly. R=jkummerow@chromium.org, mlippautz@chromium.org Bug: v8:8834 Change-Id: I2d60f95799ee61cfa161354428605f67829cd736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547651Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60630}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: Ic949775e018d2bad08fc36db8cdf912df3d67e65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552779Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: Ie624a02598f5c3a43e40e03d0337c17ca5cc3769 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541052 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#60628}
-
Georg Neis authored
It's implied by the last clause of the conjunction. Change-Id: I78a810a259888eda696c77cd6c117b35ef9e861a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549171Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60627}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c2f2e5a..6fdec9f Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/459baaf..235be3c Rolling v8/buildtools/linux64:gn/gn/linux-amd64: https://chrome-infra-packages.appspot.com/gn/gn/linux-amd64/+log/git_rev..git_rev Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e1fc0b0..63e0762 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/865445e..b8268ca Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b823d94..95a9e86 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie516f9c71b9709b86def577369702ae149744091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552157Reviewed-by:
-
Frank Tang authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/324f291..6119191 Bug: v8:7834 Change-Id: I2ff745e709727d80ad6be6e910b1896adf78d3db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1551406Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60625}
-
Michael Achenbach authored
NOTRY=true Bug: v8:9086 Change-Id: I1a430c12d5ddccb17931fa32f45463b7d8992971 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552005 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60624}
-
tzik authored
Context::microtask_context can be null after v8::Context::DetachGlobal is called, and that should cancel microtasks that are associated to the detached context. However, there are several callers left without the null check to the microtask queue, and that causes crashes. This CL adds the null check and cancellation as the crash fix. Bug: chromium:937784 Change-Id: Ie8d107f28f200cee6e75798e3f72c5ed7a2a461c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545139 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This changes the syntax for constructing structs and classes to explicitly mention the fieldnames, similar to JavaScript object literals. The fields still have to be listed in the same order as in the struct/class declaration. As in Javascript, {foo: foo} can be abbreviated as {foo}. Example: macro NewJSArray(implicit context: Context)( map: Map, elements: FixedArrayBase): JSArray { return new JSArray{ map, properties_or_hash: kEmptyFixedArray, elements, length: elements.length }; } Drive-by cleanup: Make struct and class constructors follow the same pattern in the parser and the AST. Bug: v8:9018 v8:7793 Change-Id: I22ff7f68270e4f406aa80731a709d41ea52f52bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1551999Reviewed-by:Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60622}
-
Benedikt Meurer authored
Don't record samples from machines without high-resolution timers, as that can cause serious reporting issues. See the thread at http://g/chrome-metrics-team/NwwJEyL8odU/discussion for more details. Bug: v8:9074 Change-Id: I8f9b588b249f944c4bc95feedf56960b28db9ddc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552001 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/8059cd6..2a28a92 [test] Add dedicated test for memory.size (#997) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/2a28a92 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Idcb9a6f8f57d0e9d3f673d5575e663d729a50366 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1551405Reviewed-by:
-
Yu Yin authored
This is port for https://crrev.com/c/1524482 Original commit message: This allows immediates to be encoded directly into instructions, rather than mov-ing constants to registers first. This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once this approach has been approved. Bug: v8:9038 Change-Id: I96929f870e54b24403a32428f3db31b42f41087a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545148Reviewed-by:
-
- 03 Apr, 2019 14 commits
-
-
Adithya Srinivasan authored
This reverts commit 42beed97. Reason for revert: This commit seems to cause consistent failures in some ProcessMemoryMetricsEmitterTest tests on Mac and ChromeOS. I'm not sure what the exact reasoning behind this is. See https://crbug.com/949157. Original change's description: > Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64" > > This is a reland of 4f051fd5 > > Relanding after fixing Chromium issues. > > Original change's description: > > [ptr-compr][x64] Temporarily enable pointer compression on x64 > > > > ... and make sure that the x64 ptr-compr bots proceed testing V8 without > > pointer compression in order to keep testing the full pointer mode. > > > > Bug: v8:7703 > > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > > Change-Id: Iee725deda813425a6f0722948b54976154f50909 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139 > > Reviewed-by: Michael Hablich <hablich@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#60230} > > Bug: v8:7703 > Change-Id: Ic2d1c2ae41ec645f34963f5f561c33199c72ef4b > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535819 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60582} TBR=machenbach@chromium.org,hablich@chromium.org,leszeks@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: Ib9737081e90dddcfe44af9da1275a610da209323 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7703 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550709 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60618}
-
Dave Tapuska authored
Just rely on calling toString. This matches other vendor's implementations. BUG=chromium:948257 R=dgozman@chromium.org Change-Id: I325a12dd47712263a1ef4deee0bb2de9c4a1c656 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545124Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#60617}
-
Frank Tang authored
Making 43K of room for landing ICU64. Size Change (on x64.release) D8 before 23,683,192 D8 after 23,639,296 Reduce 43,896 bytes Bugs: v8:8348 Change-Id: I057f7d59e955a2e5e017873e5b3b5daf5b142ae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1478710 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60616}
-
Sathya Gunasekaran authored
These tests make sure the ticks are correct when resolving against a Promise. Without the optimization, the result is: "start,tick 1,tick 2,tick 3,tick 4,done,tick 5" With the optimization, the result is: "start,tick 1,tick 2,done,tick 3,tick 4,tick 5" Bug: v8:8267 Change-Id: I6c6499c7c256927531a99bab4ae1c5bd5069ef7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534884Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60615}
-
Frank Tang authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/de567d3..324f291 Bug: v8:7834 Change-Id: I31d3ea423078bc14df7cf131f373ba7b661938c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1544904Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
This is a part of porting Proxy-related builtins to Torque. Spec: https://tc39.github.io/ecma262/#sec-proxy.revocable Bug: v8:6664 Change-Id: I5f53eb4dff8ff9d3156b601652f3f86ede25fc1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529261 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60613}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I45f85807132fc9278e90b4cfc7f0dc8326870dfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541046 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: I7d51a49dfbf2e5a1fa2675fe0d70bb4091a4db78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1544274Reviewed-by:
-
Frederik Gossen authored
Merged WasmCode::Tier into Execution Tier. Bug: v8:9003 Change-Id: I0ad439b8bc060f73e71d60ab9c93dd6bc18d05fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547852 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in interpreter code to 'using' declarations. R=leszeks@chromium.org Bug: v8:8834 Change-Id: Ide1e8a35a56a840b36b3ceab1307df1bcab94acd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545900Reviewed-by:
-
Clemens Hammacher authored
This CL enables adding code to the top-most {WasmCodeRefScope} when either adding code to the {NativeModule} (we have a nice choke point for that in {PublishCodeLocked}), or when looking up existing code from a {NativeModule}. It also enables the DCHECK that for each such operation, there must be an enclosing {WasmCodeRefScope}. R=titzer@chromium.org Bug: v8:8217 Change-Id: Ie93ca0b31b1577bef074923b3d228a9f214a909c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533861 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Benedikt Meurer authored
When TurboFan optimizes field access, we need to check first that the runtime already determined the correct field representation properly. If the field representation is still None, we cannot optimize this in TurboFan straight away but we have to call the IC to let the runtime do the magic. Bug: chromium:944865 Change-Id: I032a48824e83806e1be7670346f518b258a9dd65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549167Reviewed-by:
-
Simon Zünd authored
The native flag is a left-over from self-hosted JavaScript. Currently only the empty function and empty script are marked native. This CL removes the native flag from the ParseInfo, UnoptimizedCompilationInfo and its handling in the bytecode generator. R=leszeks@chromium.org Bug: v8:8834,v8:9043 Change-Id: I60726e28ce83cc84249e9c49bdc88d81f0a695c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545079Reviewed-by:
-
Clemens Hammacher authored
Using the Isolate's allocator when creating the WasmModule can lead to use-after-free situations when the NativeModule is shared across Isolates. R=mstarzinger@chromium.org Bug: v8:9079 Change-Id: I5a564852179cc5b9d4cbad2a002d3b6e14b01968 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550404Reviewed-by:
-
