- 14 Nov, 2019 13 commits
-
-
Liviu Rau authored
We mirror the Android deps changes that were operated on Chromium and seem to break the auto-roller for V8. Here: https://chromium-review.googlesource.com/c/chromium/src/+/1824130/9/DEPS Bug: chromium:1024152 Change-Id: Iefc109fb59247ddb5963cd0dafea4263c383a4e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916200Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64957}
-
Clemens Backes authored
This removes {CPURegister::Is} and {CPURegister::is}, and just uses {CPURegister::operator==} instead. Drive-by: Use DCHECK_EQ and DCHECK_NE where possible. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I03aad8b4223bd4ae37d468326a734f7a5c3c8061 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916202Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64956}
-
Andrew Grieve authored
Bug: chromium:747064 Change-Id: I1ae943785fc8048a0affd9eec9f0966056d43bee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1915660 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64955}
-
Dan Elphick authored
Removes the include/v8.h from utils.h since it doesn't seem to need it. To make this work, add v8.h to a couple of files that really do need it. Bug: v8:9810 Change-Id: I9640a0df45cd7192f59d1fd8a722234f0d501a08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916601Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64954}
-
Clemens Backes authored
Register currently has several methods twice: Once for regular {Register} objects, once for constexpr registers or register codes. It was implemented this way so that the non-constexpr code can include DCHECKs. With C++14, we can add these DCHECKs also in the constexpr methods. Thus the redundant implementation can be skipped. R=tebbi@chromium.org Bug: v8:9810 Change-Id: Ifc6253d4cd04b19be9bca47495186849118ad6b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910958Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64953}
-
Clemens Backes authored
Just use the default {is_valid} method provided by RegisterBase. Drive-by: Also rename {CPURegList::IsValid} to {CPURegList::is_valid}. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: Ia3bc3c477e6329d63ffd00bca59762d9a6cf2fcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916201 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Michael Starzinger authored
This is a reland of 837556be Original change's description: > [wasm] Improve test coverage of s128 exception handling. > > This adds test coverage for the encoding and decoding of s128 values as > part of an exception package. The encoding within an exception package > is not specified (and not observable), but the full bit-pattern needs to > survive an encoding/decoding round trip. > > R=clemensb@chromium.org > TEST=mjsunit/wasm/exceptions-simd > BUG=v8:8091 > > Change-Id: I4cf6c1f00c64757512f66d068640a7e772eb0127 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905769 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64932} Bug: v8:8091,v8:9973 Change-Id: I7daf17a0cbc6904e7130ec4e50b12a829b1b1d34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916203 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64951}
-
Jakob Gruber authored
This is a reland of b3d748a2 Original change's description: > [regalloc] Use an adaptive data structure for live sets > > Live sets represent sets of live virtual registers at block entry and > exit points. They are usually sparsely populated; for example, a sample > taken from Octane2 shows 80% of sampled live sets with a fill ratio of > 10% or less. > > Prior to this CL, live sets were implemented as a statically-sized bit > vector. This is fine for low-ish virtual register counts, but becomes > wasteful at higher numbers. > > This CL attempts to address this issue through an adaptive > implementation. Small live sets remain bit vectors, while larger sets > switch to a PersistentMap-based implementation. PersistentMap has very > memory-efficient add/remove/copy operations. > > Of course, with adaptive data structures we enter the territory of > parameter fiddling. In this case, two parameters are used: > kMaxSmallSetSize controls when to switch implementations, and > kMaxDeletionsBeforePrune controls when pruning (= managing the # of > deleted entries in the map) sets in. > > On the (degenerate) test case from the linked bug, the register > allocation zone shrinks from 1008MB to 475MB. For more realistic cases > I expect savings on the order of 10s of KB. > > Bug: v8:9574 > Change-Id: Id903bbe23f030b418e8d887ef4839c8d65126c52 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1891693 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64872} Bug: v8:9574 Change-Id: I5a95d56c33a98cc5c6c58ff9308314e2eefa462c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910953Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64950}
-
Santiago Aboy Solanes authored
Bug: v8:9810 Change-Id: I7bf617680e2e4029553d44ae4d11990ffd7a8a7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914212Reviewed-by:
-
Clemens Backes authored
With C++14, we can make {ElementSizeLog2Of} constexpr and use it to compute the loaded or stored memory size instead of duplicating that information. The code does not get shorter this way, but more robust. R=ahaas@chromium.org Bug: v8:9810 Change-Id: Idb7e861f833798e181694cda0db21ef57804d3a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914215Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64948}
-
Santiago Aboy Solanes authored
Allows the use of PageUp and PageDown in sequence and schedule phases. Since graphmultiview had a tabindex of 0, it was sitting on top of sequence and schedule. This blocked the use of PageUp and PageDown to scroll in these phases. Bug: v8:7327 Change-Id: I4fc129cd9d5ea82e469cd4b67c12a455ec920317 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914207Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64947}
-
Clemens Backes authored
If streaming compilation has been triggered on a worker, it can be problematic to schedule a foreground task for the callback, since workers might never return to the event queue. Hence, deliver the callback in background. This is possible after this blink-side change: https://crrev.com/c/1901592 R=ahaas@chromium.org CC=bbudge@chromium.org Bug: chromium:1018029 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Change-Id: I568c39cf97e94f6d1cec01090ece81e4521fa47c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914199Reviewed-by:
-
Michael Achenbach authored
This reverts commit 6dad771a. Reason for revert: Possible cause for purple Android builders. Original change's description: > [deps] Realign dependencies manually after auto-roller failure > > Auto-roller fails to update the depency changes that were operated here: > https://crrev.com/c/1824130/9/DEPS#717 > > Bug: chromium:1024152 > Change-Id: I9c0bdb5cc53b3faf18ef4ba8b262afaa20d6d0af > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914200 > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64936} TBR=machenbach@chromium.org,hpayer@chromium.org,liviurau@chromium.org Change-Id: I47fd9b0c75022e790745110bd8c0ce6ea73f084b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1024152 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916199Reviewed-by:
-
- 13 Nov, 2019 18 commits
-
-
Ng Zhi An authored
SIMD shifts was changed to use register in https://crrev.com/c/1722198 so all this code to deal with shift immediates can be removed. SimdOp was also removed from the interface, so now Liftoff does not need to implement it. Bug: v8:9810 Change-Id: I845e28b4f5712ff188d68beea7121eebddebdd9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1913506Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64944}
-
Mike Stanton authored
This is part of a general move of math builtins away from builtins-math-gen.cc. Change-Id: Ifb6e5d4779bb9e6f69ff7c58d09ca8fc94f4cc66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914210 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Dan Elphick authored
Bug: v8:9810 Change-Id: I5bf191a77c79c96f25eb97d0fbbc05d967af17fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906572Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64942}
-
Ng Zhi An authored
This is in preparation for having unfixed slot sizes, where each push operation will need to record the slot offset of the value. Bug: v8:9909 Change-Id: I04734d4e67bbae70bdf4351f3afe9d0cc5f3f532 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1913500Reviewed-by:
-
Zhao Jiazhong authored
Change-Id: Ie2c7462e336de22aa1b91019a4e06bd44475b95c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914003Reviewed-by:
-
Clemens Backes authored
The gap is chosen unneccessarily large, leading to too early growing of the assembler buffer. R=mstarzinger@chromium.org Change-Id: I9ddbe1d59929f2a76511cbc2d18c054fb8eafa74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914213Reviewed-by:
-
Clemens Backes authored
Instead of always using {AssemblerBase::kMinimalBufferSize}, this CL computes the expected code size per function compiled with Liftoff, and uses that size to allocate the initial assembler buffer. This saves reallocations especially for big functions. R=jkummerow@chromium.org Change-Id: I0031033c6be986f9d0d7bb10db0d213669044603 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910951Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64938}
-
Michael Starzinger authored
R=jkummerow@chromium.org TEST=mjsunit/object-is Change-Id: Ic933c71d8d7baa252644a69cd7816a8fc0ac85ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914206Reviewed-by:
-
Liviu Rau authored
Auto-roller fails to update the depency changes that were operated here: https://crrev.com/c/1824130/9/DEPS#717 Bug: chromium:1024152 Change-Id: I9c0bdb5cc53b3faf18ef4ba8b262afaa20d6d0af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914200 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 837556be. Reason for revert: Breaks V8 Linux https://cr-buildbucket.appspot.com/build/8896896548394462912 Original change's description: > [wasm] Improve test coverage of s128 exception handling. > > This adds test coverage for the encoding and decoding of s128 values as > part of an exception package. The encoding within an exception package > is not specified (and not observable), but the full bit-pattern needs to > survive an encoding/decoding round trip. > > R=clemensb@chromium.org > TEST=mjsunit/wasm/exceptions-simd > BUG=v8:8091 > > Change-Id: I4cf6c1f00c64757512f66d068640a7e772eb0127 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905769 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64932} TBR=mstarzinger@chromium.org,clemensb@chromium.org Change-Id: I9276c6f6600a0f4e8a06dd1a7907cac25c761577 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914211Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64935}
-
Mythri A authored
Bug: v8:9810 Change-Id: I30c6265904c43ec86abc91a28d789fe5bfb22694 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910106 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 1d493d31. Reason for revert: Fails on clusterfuzz: https://crbug.com/1024241 Original change's description: > [foozzie] Refactor command abstraction > > This moves code for running d8 into its own class. No functional > changes intended. > > No-Try: true > Bug: chromium:1023091 > Change-Id: I7cbfeebd2911dc758322f89cf93666550f2956d9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906378 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64928} TBR=machenbach@chromium.org,tmrts@chromium.org,almuthanna@google.com,liviurau@chromium.org Change-Id: I22aede0d2c8bd3cde48c45f4663b43caa4d60b65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1023091,chromium:1024241 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914208Reviewed-by:
-
Michael Starzinger authored
This adds test coverage for the encoding and decoding of s128 values as part of an exception package. The encoding within an exception package is not specified (and not observable), but the full bit-pattern needs to survive an encoding/decoding round trip. R=clemensb@chromium.org TEST=mjsunit/wasm/exceptions-simd BUG=v8:8091 Change-Id: I4cf6c1f00c64757512f66d068640a7e772eb0127 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905769 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I88adc527fea64c8ab6e9b32cfd8d40927e78da9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874087Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64931}
-
Santiago Aboy Solanes authored
This reverts commit 4d1b7af7. Reason for revert: Broke clusterfuzz asan build Original change's description: > [turbofan][64] Remove Smi Untagging extra nodes for 31 bit smis > > There are some cases where we can ignore some truncations or > change nodes for Smi Untagging, when we are using 31 bit smis > in 64 bit architectures. > > Updated DecompressionOptimizer to match the new pattern. > > Change-Id: I89d34407e6f780ec0399cd427cf9d3e24ee5669a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889877 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64909} TBR=jgruber@chromium.org,tebbi@chromium.org,solanes@chromium.org Bug: chromium:1023972 Change-Id: I7773455a970a11c345a020c1421c961314c8eb5c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914202 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Mike Stanton authored
When simulating bytecode, we store the current environment at the site of the appropriate catch handler when entering a try range. If the start of the try range is dead, we don't bother to store an environment. However, generators can create alive regions inside the try range. At such moments, we should recognize we're in a try range and store the environment for the handler. Bug: chromium:1017159 Change-Id: Icccc2ccf530895099bc62b97d9aaec8b97d5f4e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879247Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This moves code for running d8 into its own class. No functional changes intended. No-Try: true Bug: chromium:1023091 Change-Id: I7cbfeebd2911dc758322f89cf93666550f2956d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906378 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#64928}
-
Zhao Jiazhong authored
Patch af608d4b https://crrev.com/c/1903969 removed some functions used on mips platform. Original Commit Message: [utils] Remove unused classes and functions This removes dead classes and functions from utils.h. Change-Id: I558de38370b51a3f7dd0ea9712d9c9dc47fa05a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1909747 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
- 12 Nov, 2019 9 commits
-
-
Leszek Swirski authored
After allocation of an object, we need to initialize it to make it safe for the GC to see it. For complex objects like SharedFunctionInfo, this initialization code is long and requires understanding of the object. So, it makes sense for the initialization to live in the SharedFunctionInfo code itself (as an Init method) rather than in the factory. Aside from being a neat cleanup, this will allow us to share this initialization logic between different allocation methods, as part of the off-thread allocation project: https://docs.google.com/document/d/1-_96kok0AcavkbcdqqZvpqt_2q-_XWAsAJwbRXlfwCo/ Bug: chromium:1011762 Change-Id: Ie276eb711423272f85abfeb3d88df1826a77b984 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872402 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64926}
-
Zhao Jiazhong authored
port 80dc6a33 https://crrev.com/c/1903445 Original Commit Message: [ptr-compr] Remove CompressedSigned MachineRepresentation Since smi-corrputing, TaggedSigned (aka known smis) only have the lower bits used. This renders CompressedSigned useless. Change-Id: I3d656752bb81a09bd3985bd39ab9f656504f4da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1911268 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Ross McIlroy authored
Change-Id: I2b1cf44670e12b22bbf5115742e1d62dafec7304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1912220 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64924}
-
Joshua Litt authored
Bug: v8:9838 Change-Id: I8f1ca56517c4de097cab7e5fbd63ef3fe56d8f8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1904120Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#64923}
-
Joshua Litt authored
This reverts commit d46bd852. Reason for revert: I suspect this breaks the 'V8 Linux - predictable' bot. Specifically, 'typedarray-copywithin' has been failing since this landed. I am not exactly sure what is wrong from the tests error message, but see this link for more information: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8896980452133814304/+/steps/Check_-_d8__flakes_/0/logs/typedarray-copywithin/0 Original change's description: > [ic] Migrate Code-based handlers to use data driven handler. > > All usage of KeyedLoadIC_Slow, HasIC_Slow, StoreInArrayLiteralIC_Slow > and KeyedStoreIC_Slow now use data driven handlers > > Bug: v8:9779 > Change-Id: Idd888c5c10b462a5fe155ba0add36f95169bd76d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895988 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#64918} TBR=rmcilroy@chromium.org,verwaest@chromium.org,surshar@microsoft.com Change-Id: Id7c2b553f85b46048bed2c633b8bd24098f67147 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1912092Reviewed-by:
Joshua Litt <joshualitt@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#64922}
-
Clemens Backes authored
This allows us to use them in constexpr contexts, just as DCHECK. There were some "constexpr" keywords missing, and we cannot have explicit template instantiations for constexpr. R=jkummerow@chromium.org Bug: v8:9810 Change-Id: Iba7c6ed4a16ea5077324880f59f7f0e17d1757a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910956Reviewed-by:
-
Ross McIlroy authored
Optimizes BitVector::Iterator::Advance by using base::bits::CountTrailingZeros to skip through bitvector. Also inlines Advance in the header. This reduces the LiveRangeAnalysis phase of TurboFan/Prop by about 2-5% on Octane. BUG=v8:9684 Change-Id: I3954d50d8ae9bd062a153e1fa2cb0abfd43d73eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910948 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit f616b372. Reason for revert: Might break incremental build: https://crbug.com/v8/9966 Original change's description: > [build] Simplify snapshot target > > Drops unnecessary visibility exception and uses minimum deps required > for snapshot target. > > Change-Id: I4098a443e9df31c25551540a0b6edfe9500f7bcd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910943 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64907} TBR=machenbach@chromium.org,jgruber@chromium.org Change-Id: I01b087406e913faca42e21572d2fb62116c8c222 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9966 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1912219Reviewed-by:
-
Suraj Sharma authored
All usage of KeyedLoadIC_Slow, HasIC_Slow, StoreInArrayLiteralIC_Slow and KeyedStoreIC_Slow now use data driven handlers Bug: v8:9779 Change-Id: Idd888c5c10b462a5fe155ba0add36f95169bd76d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895988Reviewed-by:
-
